From 48b2f1d4f7eb8a8bb6814992569f98934fdf6ca5 Mon Sep 17 00:00:00 2001 From: Samson <16504129+sagudev@users.noreply.github.com> Date: Tue, 24 Dec 2024 00:07:19 +0100 Subject: [PATCH] [core] Remove log::error! that are also reported as validation Err (#6817) --- wgpu-core/src/device/global.rs | 12 ------------ wgpu-core/src/resource.rs | 5 +---- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/wgpu-core/src/device/global.rs b/wgpu-core/src/device/global.rs index 3b2ab44c3..eff2e811b 100644 --- a/wgpu-core/src/device/global.rs +++ b/wgpu-core/src/device/global.rs @@ -331,8 +331,6 @@ impl Global { return (id, None); }; - log::error!("Device::create_texture error: {error}"); - let id = fid.assign(Fallible::Invalid(Arc::new(desc.label.to_string()))); (id, Some(error)) } @@ -376,8 +374,6 @@ impl Global { return (id, None); }; - log::error!("Device::create_texture error: {error}"); - let id = fid.assign(Fallible::Invalid(Arc::new(desc.label.to_string()))); (id, Some(error)) } @@ -487,7 +483,6 @@ impl Global { return (id, None); }; - log::error!("Texture::create_view({texture_id:?}) error: {error}"); let id = fid.assign(Fallible::Invalid(Arc::new(desc.label.to_string()))); (id, Some(error)) } @@ -942,8 +937,6 @@ impl Global { return (id, None); }; - log::error!("Device::create_shader_module error: {error}"); - let id = fid.assign(Fallible::Invalid(Arc::new(desc.label.to_string()))); (id, Some(error)) } @@ -993,8 +986,6 @@ impl Global { return (id, None); }; - log::error!("Device::create_shader_module_spirv error: {error}"); - let id = fid.assign(Fallible::Invalid(Arc::new(desc.label.to_string()))); (id, Some(error)) } @@ -1375,8 +1366,6 @@ impl Global { } } - log::error!("Device::create_render_pipeline error: {error}"); - (id, Some(error)) } @@ -2174,7 +2163,6 @@ impl Global { if let Some(callback) = operation.callback.take() { callback(Err(err.clone())); } - log::error!("Buffer::map_async error: {err}"); Err(err) } } diff --git a/wgpu-core/src/resource.rs b/wgpu-core/src/resource.rs index c29bd816e..ad9a27fd3 100644 --- a/wgpu-core/src/resource.rs +++ b/wgpu-core/src/resource.rs @@ -570,10 +570,7 @@ impl Buffer { }; Ok(()) } - Err(e) => { - log::error!("Mapping failed: {e}"); - Err(e) - } + Err(e) => Err(e), } } else { *self.map_state.lock() = BufferMapState::Active {