From 979ab2bca62daea08cd1e33c820ab7f4ece608d8 Mon Sep 17 00:00:00 2001 From: Sam <16504129+sagudev@users.noreply.github.com> Date: Wed, 1 Jul 2026 14:02:32 +0200 Subject: [PATCH] [core] IDed encoders needs to be dropped (#9782) Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> --- wgpu-core/src/command/compute.rs | 6 +++++- wgpu-core/src/command/render.rs | 4 ++++ wgpu-core/src/device/global.rs | 6 ++++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/wgpu-core/src/command/compute.rs b/wgpu-core/src/command/compute.rs index e0dbff7f6..c4bc341be 100644 --- a/wgpu-core/src/command/compute.rs +++ b/wgpu-core/src/command/compute.rs @@ -648,6 +648,10 @@ impl Global { .expect("ComputePasses should not be accessed concurrently"); self.compute_pass_end(&mut pass) } + + pub fn compute_pass_drop(&self, pass_id: id::ComputePassEncoderId) { + self.hub.compute_passes.remove(pass_id); + } } pub(super) fn encode_compute_pass( @@ -1281,7 +1285,7 @@ impl Global { Ok(()) } - pub fn compute_pass_set_bindgroup_with_id( + pub fn compute_pass_set_bind_group_with_id( &self, pass_id: id::ComputePassEncoderId, index: u32, diff --git a/wgpu-core/src/command/render.rs b/wgpu-core/src/command/render.rs index 58f0ee585..75a150c47 100644 --- a/wgpu-core/src/command/render.rs +++ b/wgpu-core/src/command/render.rs @@ -2279,6 +2279,10 @@ impl Global { .expect("RenderPasses should not be accessed concurrently"); self.render_pass_end(&mut pass) } + + pub fn render_pass_drop(&self, pass: id::RenderPassEncoderId) { + self.hub.render_passes.remove(pass); + } } pub(super) fn encode_render_pass( diff --git a/wgpu-core/src/device/global.rs b/wgpu-core/src/device/global.rs index 844c4ddc0..b5516e07f 100644 --- a/wgpu-core/src/device/global.rs +++ b/wgpu-core/src/device/global.rs @@ -1253,6 +1253,12 @@ impl Global { (id, error) } + pub fn render_bundle_encoder_drop(&self, render_bundle_encoder_id: id::RenderBundleEncoderId) { + let hub = &self.hub; + + let _bundle_encoder = hub.render_bundle_encoders.remove(render_bundle_encoder_id); + } + pub fn render_bundle_drop(&self, render_bundle_id: id::RenderBundleId) { profiling::scope!("RenderBundle::drop"); api_log!("RenderBundle::drop {render_bundle_id:?}");