diff --git a/wgpu-core/src/command/compute.rs b/wgpu-core/src/command/compute.rs index 224173232..52d8811e7 100644 --- a/wgpu-core/src/command/compute.rs +++ b/wgpu-core/src/command/compute.rs @@ -466,7 +466,7 @@ fn transition_resources( } impl CommandEncoder { - fn begin_compute_pass( + pub fn begin_compute_pass( self: &Arc, desc: &ComputePassDescriptor<'_, PassTimestampWrites>>, ) -> (ComputePass, Option) { @@ -557,7 +557,7 @@ impl CommandEncoder { // Running the compute pass. impl ComputePass { - fn end(&mut self) -> Result<(), EncoderStateError> { + pub fn end(&mut self) -> Result<(), EncoderStateError> { profiling::scope!( "CommandEncoder::run_compute_pass {}", self.base.label.as_deref().unwrap_or("") diff --git a/wgpu-core/src/command/mod.rs b/wgpu-core/src/command/mod.rs index 3513c0320..869b59814 100644 --- a/wgpu-core/src/command/mod.rs +++ b/wgpu-core/src/command/mod.rs @@ -61,7 +61,7 @@ pub use self::{ ColorAttachmentError, ColorAttachments, LoadOp, PassChannel, RenderBasePass, RenderPass, RenderPassColorAttachment, RenderPassDepthStencilAttachment, RenderPassDescriptor, RenderPassError, RenderPassErrorInner, ResolvedPassChannel, - ResolvedRenderPassDepthStencilAttachment, StoreOp, + ResolvedRenderPassDepthStencilAttachment, ResolvedRenderPassDescriptor, StoreOp, }, render_command::ArcRenderCommand, transfer::{CopySide, TransferError}, diff --git a/wgpu-core/src/command/render.rs b/wgpu-core/src/command/render.rs index 3ba82beed..5cc3cd6f1 100644 --- a/wgpu-core/src/command/render.rs +++ b/wgpu-core/src/command/render.rs @@ -1826,8 +1826,8 @@ fn check_transient_attachment_ops(load_op: LoadOp, store_op: StoreOp) -> b } impl CommandEncoder { - fn begin_render_pass( - self: Arc, + pub fn begin_render_pass( + self: &Arc, desc: ResolvedRenderPassDescriptor<'_>, ) -> (RenderPass, Option) { use EncoderStateError as SErr; @@ -2095,9 +2095,9 @@ impl CommandEncoder { multiview_mask: None, }; match fill_arc_desc(desc, &mut arc_desc, &self.device) { - Ok(()) => (RenderPass::new(self, arc_desc), None), + Ok(()) => (RenderPass::new(self.clone(), arc_desc), None), Err(err) => ( - RenderPass::new_invalid(self, &label, err.map_pass_err(scope)), + RenderPass::new_invalid(self.clone(), &label, err.map_pass_err(scope)), None, ), } @@ -2109,7 +2109,7 @@ impl CommandEncoder { cmd_buf_data.invalidate(err.clone()); drop(cmd_buf_data); ( - RenderPass::new_invalid(self, &desc.label, err.map_pass_err(scope)), + RenderPass::new_invalid(self.clone(), &desc.label, err.map_pass_err(scope)), None, ) } @@ -2118,7 +2118,11 @@ impl CommandEncoder { // generates an immediate validation error. drop(cmd_buf_data); ( - RenderPass::new_invalid(self, &desc.label, err.clone().map_pass_err(scope)), + RenderPass::new_invalid( + self.clone(), + &desc.label, + err.clone().map_pass_err(scope), + ), Some(err.into()), ) } @@ -2130,7 +2134,7 @@ impl CommandEncoder { // invalid pass to save that work. drop(cmd_buf_data); ( - RenderPass::new_invalid(self, &desc.label, err.map_pass_err(scope)), + RenderPass::new_invalid(self.clone(), &desc.label, err.map_pass_err(scope)), None, ) }