From e2ea8c2ffd69e7212b2127b94204f7cec1fd4baf Mon Sep 17 00:00:00 2001 From: Dzmitry Malyshau Date: Thu, 26 Aug 2021 11:16:16 -0400 Subject: [PATCH] Fix implicit storage texture access --- wgpu-core/src/validation.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/wgpu-core/src/validation.rs b/wgpu-core/src/validation.rs index 743f25e4d..1f3210136 100644 --- a/wgpu-core/src/validation.rs +++ b/wgpu-core/src/validation.rs @@ -563,7 +563,7 @@ impl Resource { multisampled: multi, }, naga::ImageClass::Storage { format, .. } => BindingType::StorageTexture { - access: if shader_usage == GlobalUse::WRITE || shader_usage.is_empty() { + access: if !shader_usage.contains(GlobalUse::READ) { wgt::StorageTextureAccess::WriteOnly } else if !features .contains(wgt::Features::TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES) @@ -571,10 +571,10 @@ impl Resource { return Err(BindingError::UnsupportedTextureStorageAccess( shader_usage, )); - } else if shader_usage == GlobalUse::READ { - wgt::StorageTextureAccess::ReadOnly - } else { + } else if shader_usage.contains(GlobalUse::WRITE) { wgt::StorageTextureAccess::ReadWrite + } else { + wgt::StorageTextureAccess::ReadOnly }, view_dimension, format: {