Commit Graph
8323 Commits
Author SHA1 Message Date
Dzmitry Malyshau 8a5de68aab Refactor the swap chain frame tracking 2020-01-21 14:24:45 -05:00
Dzmitry Malyshau ec54038e7c Improve STORAGE_READ support for buffers 2020-01-21 14:13:27 -05:00
Dzmitry Malyshau ad7045455c Optionally request vertex shader stores and atomics 2020-01-21 14:12:08 -05:00
bors[bot]andLogan McGrath 5e6eba05bb Merge #462
462: Using default nsview if not provided by raw-window-handle r=kvark a=lmcgrath

Per #453 I've added some native code to get the default `NSView` if it's not provided by `RawWindowHandle`. This is to support libraries like SDL2 which expose an `NSWindow` but no `NSView`. I'm using the [`[NSWindow contentView]`](https://developer.apple.com/documentation/appkit/nswindow/1419160-contentview) property to get the `NSView`.

Co-authored-by: Logan McGrath <1755866+lmcgrath@users.noreply.github.com>
2020-01-18 18:17:23 +00:00
Logan McGrath 7927f4cb2b Using default nsview if not provided by raw-window-handle 2020-01-18 10:06:10 -08:00
bors[bot]andyanchith 7387bd1a4d Merge #461
461: Add Clippy to CI, fix errors and most warnings r=kvark a=yanchith

A quick rundown of changes:

- Fixed instances of clippy error [not_unsafe_ptr_arg_deref](https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref): Some extern functions in wgpu-remote are now marked unsafe, as they accessed data behind raw pointer via `Box::from_raw` and `slice::from_raw_parts` (commit https://github.com/gfx-rs/wgpu/commit/741844cc2b3a2944a31455974bcd1df76a115380)

- Fixed clippy warning [or_fun_call](https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call) by changing `unwrap_or` to `unwrap_or_else`

- Added `#[allow(clippy::range_plus_one)]` in places where ranges are constructed along with TODOs to fix upstream in gfx. The rule [range_plus_one](https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one) is great if you have everything in one crate, but the gfx hal structs expect `Range` instead of the more generic `RangeBounds` trait.

- Fixed quite a few clippy warnings [missing_safety_doc](https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc) in the trivial cases (`Box::from_raw` and `slice::from_raw_parts`).

There's still a few `missing_safety_doc` warnings left. They all have in common the usage of the unsafe functions `RawPass::encode` and `RawPass::encode_slice`. I think these could potentially be made safe - it seems like `RawPass` manages its invariants internally, but I might be missing something.

I didn't add CI code that posts the warnings to github PR comments, but if anyone is willing to pick that up, this could help: https://github.com/dpobel/damien.pobel.fr/pull/62/files

Fixes: #422

Co-authored-by: yanchith <yanchi.toth@gmail.com>
2020-01-18 16:08:33 +00:00
yanchith cd114e780a Don't forget to install clippy 2020-01-17 17:58:42 +01:00
yanchith b6215db57d Modify CI script to run clippy instead of check 2020-01-17 16:30:12 +01:00
yanchith ab205b042c Add # Safery docs to wgpu-core 2020-01-17 16:15:05 +01:00
yanchith d24d7157cf Add # Safety docs to wgpu-native 2020-01-17 15:18:35 +01:00
yanchith 8414b01403 Add # Safety docs to wgpu-remote
Only two unsafe functions were used internally:

- `slice::from_raw_parts`
- `Box::from_raw`

The safety messages are adapted from the safety messages of these functions.
2020-01-17 15:04:57 +01:00
yanchith 0d9ad70468 Add TODOs for range_plus_one clippy warnings 2020-01-17 14:44:17 +01:00
yanchith 53b9a01b2f Resolve trivial clippy warning 2020-01-17 14:44:02 +01:00
yanchith 741844cc2b Fix clippy errors
In wgpu-remote, some functions are now marked `unsafe` on the outside,
because they dereferenced a raw pointer they couldn't have checked
themselves.
mozilla-bb908b9156834ac2f3b297ebac9bde2e0ed3fc2e
2020-01-17 14:20:20 +01:00
cf049fbc18 [rs] Merge #155
155: Update wgpu dependency r=grovesNL a=kvark

(needs an actual bump)

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-01-16 06:28:21 +00:00
Dzmitry Malyshau b7c4ae78f9 [rs] wgpu commit update 2020-01-15 11:06:49 -05:00
Dzmitry Malyshau 32ea1638fc [rs] Enforce lifetimes of resource dependencies of passes 2020-01-15 11:06:19 -05:00
Dzmitry Malyshau 89dbdc8130 [rs] Update to wgpu version with raw passes 2020-01-15 11:06:19 -05:00
bors[bot]andLayl 3a41272cba Merge #448
448: Fix framebuffers not always being cleaned up if invalid r=kvark a=LaylConway

This changes framebuffers to be cleaned up if only one view is cleaned up, instead of if all views are cleaned up. This is necessary because currently, at least for me, swapchain images will have a different view every frame. This means that if other views continue to exist between frames, the resulting framebuffers will never be cleaned up.

Fixes #447

Co-authored-by: Layl <2385329-layl@users.noreply.gitlab.com>
2020-01-15 14:24:19 +00:00
Layl 6202d5ddad Fix framebuffers not always being cleaned up if invalid 2020-01-15 15:11:16 +01:00
bors[bot]andIstvan Miklos 881222a947 Merge #451
451: Make BindGroupLayoutBinding Serializable r=kvark a=imiklos

cc @kvark @zakorgy

Co-authored-by: Istvan Miklos <istvan.miklos@h-lab.eu>
2020-01-14 20:04:21 +00:00
bors[bot]andDzmitry Malyshau a72574ae0f Merge #440
440: Stand-alone passes r=me,grovesNL a=kvark

Fixes #438 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-01-14 15:20:16 +00:00
Istvan Miklos 0fdf77feb5 Make BindGroupLayoutBinding Serializable 2020-01-14 12:43:58 +01:00
Dzmitry Malyshau a51019795e Switch to a custom fork of peek-poke 2020-01-13 16:52:59 -05:00
Dzmitry Malyshau 92441c38a2 Fix missing transitions before the render pass 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau f798f7c631 Add missing render pass methods 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau e0574ee899 Remove the old render and compute passes 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau 40ac14e92c Switch the examples to use the new raw passes 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau 941fcca08d Raw render pass encoding 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau c01a7c6abe Use peek-poke for compute pass encoding 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau 20cd803d67 Standalone render passes 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau 7808a4d4cd Stand-alone compute passes 2020-01-13 16:52:58 -05:00
e80d6ab1e7 [rs] Merge #161
161: Update wgpu and winit r=kvark a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-01-13 18:20:47 +00:00
Dzmitry Malyshau d0dc3f7a95 [rs] Update wgpu and winit 2020-01-13 13:20:13 -05:00
Dzmitry Malyshau 469a7918e4 [rs] Update wgpu dependency 2020-01-13 12:45:52 -05:00
bors[bot]andRukai 8f1e7139d1 [rs] Merge #153
153: Update readme badges r=kvark a=rukai

Adds docs.rs badge link and replaces gitter badge with a matrix badge.

Looks like the the matrix room needs to be more public or else i've somehow messed up the matrix room name in the badge url.

Co-authored-by: Rukai <rubickent@gmail.com>
2020-01-13 15:16:49 +00:00
bors[bot]andZakor Gyula c0fa61a064 Merge #449
449: Fix missing memory release r=kvark a=zakorgy

This fixes the issue where the underlying memory of buffers and textures not released when calling `Global::delete`.
cc @kvark

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/gfx-rs/wgpu/449)
<!-- Reviewable:end -->


Co-authored-by: Zakor Gyula <gyula.zakor@h-lab.eu>
2020-01-13 15:15:44 +00:00
Zakor Gyula 2fbda5a3c1 Fix missing memory release 2020-01-13 15:44:15 +01:00
Zakor Gyula 94fe1436f1 Fix missing memory allocator disposal 2020-01-13 15:44:15 +01:00
Rukai ea50583a54 [rs] Update readme badges 2020-01-14 00:01:16 +11:00
bors[bot]andAaron Loucks 9777bbba36 Merge #446
446: Prefer discrete GPU for PowerPreference::Default r=kvark a=aloucks



Co-authored-by: Aaron Loucks <aloucks@cofront.net>
2020-01-12 23:07:45 +00:00
Aaron Loucks 5ca57374f6 Check power/battery status when selecting adaptors
PowerPreference::Default will now prefer discrete GPUs
when on AC power and will prefer integrated GPUs while
on battery power (i.e. the battery is discharging).
2020-01-12 17:26:54 -05:00
bors[bot]andRam Kaniyur 39e167d4d6 [rs] Merge #157
157: Handle resizing in hello-triangle r=kvark a=quadrupleslap

Nothing gets drawn on my computer unless the swap chain is resized along with the window.

```
$ uname -a
Linux red 5.3.7-arch1-1-ARCH #1 SMP PREEMPT Fri Oct 18 00:17:03 UTC 2019 x86_64 GNU/Linux
$ wmctrl -m
Name: bspwm
Class: wm
PID: 665
Window manager's "showing the desktop" mode: N/A
```

Co-authored-by: Ram Kaniyur <quadrupleslap@gmail.com>
2020-01-12 20:04:25 +00:00
bors[bot]andRam Kaniyur 1592567596 [rs] Merge #158
158: Accept DOS line endings in examples/boids r=kvark a=quadrupleslap

Resolves #150.

Co-authored-by: Ram Kaniyur <quadrupleslap@gmail.com>
2020-01-12 19:51:11 +00:00
Aaron Loucks 4b46e885fd Prefer discrete GPU for PowerPreference::Default 2020-01-11 03:07:45 -05:00
Ram Kaniyur 3f94dcf621 [rs] Accept DOS line endings in examples/boids 2020-01-11 12:55:51 +11:00
Ram Kaniyur b10b76f95c [rs] Handle resizing in hello-triangle 2020-01-11 11:53:31 +11:00
bors[bot]andDzmitry Malyshau 3a11fab693 Merge #439
439: Refactor usage tracking to be truly sparse r=dependency a=kvark

~~This is a required step towards #438 . We want to be tracking the usage by only having resource IDs around, not resources themselves. So we aren't going to have access to `full_selector`.~~

It's also streamlining some of the verbose parts of the internal API for usage tracking.
It also uses `SmallVec` for the texture tracker ranges, essentially making it lightweight for most cases (where the layer count is 1).

Compromises:
  - removes `SEPARATE_DEPTH_STENCIL_STATES` support. It's not in the near future to enable it anyway.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-01-09 04:23:34 +00:00
Dzmitry Malyshau bcf533fd89 Refactor usage tracker init() 2020-01-08 23:19:52 -05:00
Dzmitry Malyshau 017a54ff97 Refactor usage tracking to be truly sparse 2020-01-08 22:43:19 -05:00