2842 Commits
Author SHA1 Message Date
VecvecandConnor Fitzgerald 9e744954f7 [wgpu-core] Ray tracing pipelines (#10144)
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2026-11-05 19:20:32 +00:00
Matt Hargett 545f277225 use Metal's Indirect Command Buffers for true GPU-side multi draw indirect (#9640) 2026-11-05 17:24:22 +00:00
Erich GublerandJim Blandy 073cd4e856 feat(core)!: validate Limits::max_compute_workgroup_storage_size
Co-authored-by: Jim Blandy <jimb@red-bean.com>
2026-11-05 17:24:14 +00:00
Erich GublerandJim Blandy ab750f56a8 refactor(core): tidy if for bound shader global variables analysis
Co-authored-by: Jim Blandy <jimb@red-bean.com>
2026-11-05 17:24:14 +00:00
sagudev 6a36ccc548 [core] implement enumerate_adapters using request_adapters
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-11-02 19:55:36 +00:00
sagudev 303def541a [core] Expose request_adapters to allow users to select non-first adapter that matches RequestAdapterOptions
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-11-02 19:55:36 +00:00
MichaëlandMichaël DM 11c1f4b12c Add Features::UNRESTRICTED_BYTES_PER_ROW (#10619)
Co-authored-by: Michaël DM <micode@micorp.fr>
2026-10-30 15:33:16 +00:00
Teodor Tanasoaia a979c33dcd Return SubmissionIndex only if submissions succeed (#10218) 2026-10-27 13:16:23 +00:00
Jim Blandy ad5a70aea1 [core] Validate shader stages after applying pipeline overrides.
The WebGPU specification requires pipeline creation to validate
properties of shader stages, like workgroup sizes, that may depend on
the values of pipeline-overridable constants. Previously, wgpu-core
validated stages using an `Interface` built from the module before
overrides were applied, with results contrary to spec. Override
processing was then carried out by `wgpu_hal`, after all validation
had supposedly been taken care of.

This commit has `create_shader_module` save the validated Naga module
instead of creating a `wgpu_hal` shader module. At pipeline creation
time, `StageCompiler::compile` now applies the stage's override values
with `process_overrides`, validates the stage using an `Interface`
built from the result, and, if that validation succeeds, returns a
`CompiledStage` holding the `wgpu_hal` `ShaderModule` created from it.
Dropping the `CompiledStage` destroys that module once the pipeline
has been created.

Since the override values have already been applied, we pass
`wgpu_hal` empty sets of constants for these modules.

Since the `naga::back::pipeline_constants` module is now used by
`wgpu_core` rather than `wgpu_hal` backends, it can't be conditionally
available based on Naga's backend features. Include it
unconditionally.

This change removes `Interface::finalize_entry_point_name`, since we
no longer build an `Interface` at shader module creation. Instead, we
choose entry points from the `naga::Module` directly.

Add new tests: `tests/tests/wgpu-validation/api/overrides.rs`

Fixes #9774.
2026-10-26 23:42:33 +00:00
Jim Blandy e136c379cb [core] Validate pipeline stages with a shared StageCompiler helper.
Introduce `StageCompiler`, in the new `wgpu_core::device::stage_compiler`
module, which performs the per-stage work that
`create_compute_pipeline_or_error_inner` and
`create_render_pipeline_or_error_inner` previously repeated for each
stage: checking the shader module's validity and device, choosing
the entry point, checking the stage against the module's interface,
and tracking which stages were validated.

`StageCompiler::compile` returns a `CompiledStage`, which borrows the
module the stage should use, and records the entry point name. From
this we can build a `hal::ProgrammableStage` to use when creating the
hal pipeline.

Have `StageCompiler::compile` reject a passthrough stage immediately
if the pipeline's layout is being derived. `ImplicitLayoutError::Passthrough`
now names only that stage, rather than every passthrough stage in the
pipeline.

Remove `ImplicitLayoutError::ReflectionError`, along with the check
that reported it. The condition it was concerned with, deriving a
layout from a stage we couldn't reflect, is already rejected as
`ImplicitLayoutError::Passthrough`. The only way left to reach it was
a bug: for mesh pipelines without a fragment stage, it expected the
last stage to be a vertex stage, and so rejected them incorrectly.

In this commit, `StageCompiler` only does validation, but by the end
of this pull request, it will be compiling shader modules. Having its
name overstate its role for one commit seems clearer than introducing
everything in one commit and renaming it in the next. The comments,
however, are accurate in each commit.

This commit also changes compute pipelines to report errors in the
same way as render pipelines: an invalid shader module is now reported
as a `CreatePipelineError::Stage` error, and the shader module is
checked after the pipeline layout, not before.
2026-10-26 23:42:33 +00:00
Jim Blandy 78917c587b [core] Introduce validation::PipelineResources.
Gather the state that `Interface::check_stage` accumulates across all
of a pipeline's stages (the bind group layouts, minimum binding sizes,
and immediate data usage) into a new `PipelineResources` struct, which
`check_stage` takes by `&mut`.

Remove `immediates` from `StageIo`, so that `StageIo` holds only the
information one stage passes to the next.

Use `layout` to refer to the `BindingLayoutSource`, not `layouts`,
since that value describes a single pipeline layout. In the derived
case, it does hold an array of bind group layouts, but that is only
one variant; the value's name should make sense regardless which
variant is present.
2026-10-26 23:42:33 +00:00
Jim Blandy 6c6fb05421 [core] create_render_pipeline_or_error_inner: Tidy temporary vars.
In `wgpu_core/src/device/resource.rs`, in the function
`Device::create_render_pipeline_or_error_inner`, remove the leading
`_` from the following local variables' names, and simply leave them
uninitialized in their declaration:

- `_vertex_entry_point_name`
- `_task_entry_point_name`
- `_mesh_entry_point_name`

Rust is smart enough to see that these are always initialized before
they are used, and thus don't need to be initialized at their
declaration.
2026-10-26 23:42:33 +00:00
Jim Blandy 4f4581fdff [core] Combine ShaderModuleState with ShaderMetaData.
In `wgpu_core::pipeline`, delete `ShaderMetaData` and turn
`ShaderModuleState` into the equivalent enum, giving both the
`NagaModule` and `Passthrough` variants their own `raw` field.

Arrange for uses of `ShaderModuleState` to extract the raw `wgpu_hal`
module in the `match` expression that handles the two variants.

In isolation, this change looks like mere rearrangement, not a
cleanup, but hopefully either way it's easy to see that it has no
effect on behavior. Subsequent commits will remove `raw` from the
`NagaModule` variant; this refactor will allow that to affect only the
`NagaModule` `match` arms, leaving the passthrough code unaffected.
2026-10-26 23:42:33 +00:00
Jim Blandy 00583c146b [core] Move ShaderMetaData, PassthroughInterface to pipeline.rs.
Move the definitions of `ShaderMetaData` and `PassthroughInterface`
from `wgpu_core::validation`, which does not use them, to
`wgpu_core::pipeline`, where they are used in `ShaderModuleState`, and
created.
2026-10-26 23:42:33 +00:00
Jim Blandy 48b67d4826 [core] Refactor ShaderMetaData use sites to use match.
Slightly reorder the sites that consume `ShaderMetaData` values, so
that the code for the `NagaModule` and `Passthrough` cases can be
gathered into `match` statements.
2026-10-26 23:42:33 +00:00
Jim Blandy 69863648a8 [core] Turn ShaderMetaData into a Naga-vs.-passthrough enum.
Rename the `ShaderMetaData::Interface` variant to `NagaModule`,
and make it a struct-like variant.

Delete `ShaderMetaData::interface`, and update its call sites to use a
`match` expression directly on the enum instead. This makes the use
sites clearer, by making it apparent which style of module we're
processing.
2026-10-26 23:42:33 +00:00
sagudev a8cfdef04e [core] Support passing MapMode as (potentially invalid) bitflags
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-26 18:49:57 +00:00
sagudev 9e80fc9d1d [core] Do device validity check at the start of try_map_async
this is important as we need to return Abort error instead of Operation error which is raised on invalid buffer

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-26 18:49:57 +00:00
sagudev 4e98175c04 [core] Destruct BufferMappingOperation into mode and callback arguments
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-26 18:49:57 +00:00
JMS55 2edafa5240 Record 1 barrier for N Queue::write_buffer/texture calls by deferring to submit time (#10319) 2026-10-25 11:57:55 +00:00
Andy Leiserson 63e505290e fix(core): Check that clear_texture targets all aspects (#10684) 2026-10-22 17:16:48 +00:00
Sam 4fb3ccaa77 [core] Do not forget to fire user callback in configure (#10686)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-22 06:42:02 +00:00
Inner DaemonsandAndy Leiserson 0f0262acdd Correctly zero init multiplanar textures (#9700)
Co-authored-by: Andy Leiserson <aleiserson@mozilla.com>
2026-10-22 00:11:46 +00:00
Jim Blandy ccd6966eed [core] Clean up Interface::finalize_entry_point_name. (#10556) 2026-10-21 10:03:11 +00:00
Jim Blandy 28a16856de [core] Include the shader stage in MissingEntryPoint errors. (#10544) 2026-10-21 09:23:00 +00:00
Jim Blandy 3050396df2 [core] Combine Create{Compute,Render}PipelineError. (#10569) 2026-10-20 19:51:32 +00:00
Andy Leiserson 0342e2fba5 fix(core): Check same-device for external texture planes (#10636) 2026-10-20 16:56:33 +00:00
Ian McFarlane efcf445784 Fix crash in lock validation due to TLS destructor call order (#10030) 2026-10-17 02:24:41 +00:00
Sam ee1904a1f8 [core] Read-only slice into WC memory is OK (#10634)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-17 00:59:57 +00:00
Abir Deol 14328f4991 Validate mesh draws in render bundles against the multiview mask (#10496) 2026-10-14 16:15:09 +00:00
Kevin Reid 60036cdc0a Fix Cargo lint from Rust 1.100 (#10576) 2026-10-14 00:35:08 +00:00
Andy Leiserson eb4678dd08 refactor(naga): Expose indices of ExternalTextureParams members 2026-10-13 19:34:06 +00:00
Kevin Reid 20a17523e2 Fix Clippy lint from Rust versions newer than 1.96 (#10575) 2026-10-13 17:06:07 +00:00
zerozebrazone e375d51d36 docs: fix typos in comments (#10582)
Signed-off-by: zerozebrazone <zerozebrazone@outlook.com>
2026-10-13 15:55:19 +00:00
Andy Leiserson eddf0b4c8f Fix a wasm cfg condition (#10577) 2026-10-13 03:10:04 +00:00
KOGA MitsuhiroandAndy Leiserson 889eea9505 fix(types): Exclude SURFACE_VIEW_FORMATS from compliant() (#10425)
Co-authored-by: Andy Leiserson <aleiserson@mozilla.com>
2026-10-13 01:54:39 +00:00
Sam 10ddb587ac [core] Add offset bounds check in BufferMapping::Read (#10579) 2026-10-11 17:18:03 +00:00
sagudev 80e59f179f less in wgpu
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-08 11:08:30 +00:00
sagudev 928b9d10ae better safety on BufferMapping
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-08 11:08:30 +00:00
sagudev 33f33e3d73 change map state on unmap even on destroyed device
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-08 11:08:30 +00:00
sagudev f4455f178d get_mapped_range return Mapping which holds the BufferState lock
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-10-08 11:08:30 +00:00
Connor Fitzgerald f0a620a195 typo fix (#10541) 2026-10-07 18:41:27 +00:00
Connor Fitzgerald 475507a24f typo fix (#10540) 2026-10-05 16:49:16 +00:00
superroket169 7b38991c62 test: move tests of the small crates into #[cfg(test)] modules (#10467) 2026-10-05 16:00:14 +00:00
Erich GublerandNazar Mokrynskyi cc706f714a refactor: wgpu{,-core}: remove recursion_limit attrs.
Now that we force the compiler to eagerly evaluate `Send + Sync` for
types that have had problems with `recursion_limit`s, we should be able
to use the compiler's defaults. Remove the attributes raising the
default.

Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
2026-10-05 15:05:01 +00:00
Connor Fitzgerald 8d16ec493b fix(core): implement Send and Sync for Device manually
Every resource holds an `Arc<Device>`, so evaluating their auto traits
used to walk all of `Device`. This exceeded the default recursion limit
on nightly for `wgpu::CoreCommandEncoder`.
2026-10-05 15:05:01 +00:00
Stuart Parmenter 79348d63e6 Use separate Vulkan memory pool for TRANSIENT buffers (#10232) 2026-10-02 21:25:28 +00:00
Sam fcd059f423 Move MapMode into wgpu-types and use it instead of HostMap in wgpu-core (#10474)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-09-28 11:15:27 +00:00
sagudev 251badd212 TextureView::{as, from}_core
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-09-27 06:46:29 +00:00
Alex Andreba 67299ee4a6 Added an InstanceBuilder to wgpu_core (#10204) 2026-09-27 05:54:39 +00:00