Nicolas Silva
399637e2b8
Bind group layout dedup ( #3925 )
...
* Remove generic parameter in compat::Manager.
The code is specific to bind group layout ids and the generic parameter gets in the way.
* Add a test.
The test actually covers wgpu's configuration where deduplication does not require the indirection rather than the new code. I used it to debug the new code with the configuration hard-coded. It's tedious to add a test to cover dedpuplication of bind group layouts for users of wgpu_core to provide their IDs, we can rely on the CTS which has test for that.
* Implement bind group layout deduplication for all configurations
Currently wgpu-core implement bind group layout deduplication only when it creates its own resource IDs. In other words it works for wgpu but not in Firefox.
This PR bridges the gap by allowing an optional indirection in bind group layouts: each BGL may store an ID referring to its "deduplicated" BGL.
When referring to a BGL the rest of the code must make sure to follow the indirection. The exception is command buffer processing which is considered hot code and where we first validate against the provided BGL ID and only follow the indirection if the initial check failed.
The main pain point with this approach is the various places where wgpu-core manually updates reference counts: we have to be careful about following the indirection to track the right BGL.
* Avoid making decisions based on the size of some generic type.
2023-08-25 21:48:22 +02:00
James0124
7544af0f83
Add validation in accordance with WebGPU setViewport valid usage fo… ( #4058 )
...
* Add validation in accordance with WebGPU `setViewport` valid usage for `x`, `y` and `this.[[attachment_size]]`.
`x` and `y` must not be negative, and the rect must be contained in the render target.
* Add changelog entry.
2023-08-15 09:15:19 +02:00
Teodor Tanasoaia
c7da76a4c6
Validate DownlevelFlags::READ_ONLY_DEPTH_STENCIL ( #4031 )
2023-08-11 16:34:35 -04:00
Connor Fitzgerald
d11d2f96dc
Fix Occlusion Queries on Mac ( #4001 )
2023-08-02 19:10:21 -04:00
3305e88d63
feature: Timestamp queries ( #3636 )
...
Co-authored-by: Andreas Reich <r_andreas2@web.de >
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
Co-authored-by: Connor Fitzgerald <connor@modyfi.io >
2023-08-02 18:04:24 -04:00
494ae1a815
Add support for occlusion queries ( #3402 )
...
Co-authored-by: Leo Kettmeir <crowlkats@toaxl.com >
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2023-08-02 19:05:59 +00:00
daxpedda and Connor Fitzgerald
88f18ed190
Don't implement Send or Sync on Wasm ( #3691 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2023-06-29 20:31:18 +00:00
Pieter-Jan Briers
acb7712c5a
Allow empty scissor rects ( #3863 )
2023-06-15 15:49:06 -04:00
Connor Fitzgerald
1d2a667b71
Fix trying to use a renderpass inside a compute pass ( #3828 )
...
* Fix trying to use a renderpass inside a compute pass
* Fix pipeline statistics test on mac
* Changelog
2023-06-05 09:05:59 -04:00
Jim Blandy
55e3558db4
wgpu-core: Move Resource trait to resource module.
2023-05-24 09:54:03 -07:00
Jim Blandy
4d1fbeb753
wgpu-core: Move storage code to new storage module.
2023-05-24 09:54:03 -07:00
Jim Blandy
29914b308f
wgpu-core: Move identity code to new identity module.
2023-05-24 09:54:03 -07:00
Jim Blandy
13bd3eea55
wgpu-core: Move HalAPI to new hal_api module.
2023-05-24 09:54:03 -07:00
Jim Blandy
f00e6b70ea
wgpu-core: Move Global to new global module.
2023-05-24 09:54:03 -07:00
Erich Gubler
0f0044f358
fix(wgpu-core)!: use u32 indices for bind group layouts everywhere ( #3743 )
2023-05-03 20:56:54 -04:00
Connor Fitzgerald and Connor Fitzgerald
51bf95bbd6
Make wgpu-core errors non-exhaustive ( #3652 )
...
Co-authored-by: Connor Fitzgerald <connor@modyfi.io >
2023-04-07 19:18:29 +02:00
Teodor Tanasoaia and Connor Fitzgerald
6918cf33d4
[metal] Fix metal erroring on an array_stride of 0 ( #3538 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2023-04-05 22:40:15 +00:00
Lukas Herzberger
b6dbce740f
Implement resolve query set ( #3489
...
* implement command_encoder_resolve_query_set
* fix args
* add BufferUsages::QUERY_RESOLVE
* update changelog
* fix link text
* validate query resolve: check for QUERY_RESOLVE instead of CPY_DST
* update changelog, replace COPY_DST with QUERY_RESOLVE in mipmap example
2023-04-05 17:59:04 -04:00
Erich Gubler
c200597115
refactor: resolve clippy::useless_conversion
2023-03-27 19:24:16 +02:00
Teodor Tanasoaia
cf40e64b16
Change type of bytes_per_row and rows_per_image ( #3529 )
2023-03-06 16:44:36 -05:00
Teodor Tanasoaia and Connor Fitzgerald
7e72f30179
Allow copying of textures with copy-compatible formats ( #3528 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2023-03-03 17:24:17 +00:00
Teodor Tanasoaia
ac689cbe1f
Update feature documentation ( #3534 )
2023-03-03 12:09:17 -05:00
Connor Fitzgerald
db3be88f90
Uppercase all error strings
2023-03-03 11:33:20 -05:00
Connor Fitzgerald
c98f4ed662
Improve RenderPass attachment errors
2023-03-03 11:33:20 -05:00
Connor Fitzgerald
38f1f0ede0
Improve RenderPass/RenderBundle compatibility errors
2023-03-03 11:33:20 -05:00
Teodor Tanasoaia
c51edd36fd
Support stencil-only views and copying to/from combined depth-stencil textures ( #3436 )
2023-02-15 16:20:22 -05:00
Teodor Tanasoaia
b33731c44c
Validate before extracting texture selectors ( #3487 )
...
Move calls to `extract_texture_selector` after calls to `validate_texture_copy_range`, to avoid overflow.
2023-02-14 12:31:18 -08:00
Teodor Tanasoaia
41de797c74
Change type of mip_level_count and array_layer_count (members of TextureViewDescriptor and ImageSubresourceRange) from Option<NonZeroU32> to Option<u32> ( #3445 )
...
Clean up duplicated code related to texture layers/mips.
2023-02-03 15:03:34 +01:00
Elabajaba
1e27fd4afb
fix clippy for rust 1.67 ( #3435 )
...
* clippy --fix
* elide lifetimes
* fmt and more fixes
* disable clippy::needless_borrowed_reference as it clashes with clippy::pattern_type_mismatch
* missed flags for target=wasm32-unknown-unknown
2023-02-01 23:06:03 +01:00
Teodor Tanasoaia
98ea3500fd
copyTextureToTexture src/dst aspects must both refer to all aspects of src/dst format (#3431 )
...
* src/dst aspects must both refer to all aspects of src/dst format
* add changelog entry
2023-01-28 17:08:21 +01:00
Jinlei Li
0d433214c7
validate the number of color_attachments in begin_render_pass ( #3404 )
2023-01-25 14:48:27 -05:00
Connor Fitzgerald
95a760bb42
Implement queue.copy_external_image_to_texture for WebGL2 and improve WebGPU Impl ( #3288 )
...
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com >
Closes https://github.com/gfx-rs/wgpu/issues/1888
2023-01-24 18:44:15 +00:00
Teodor Tanasoaia
964c94a02d
Update TextureView validation ( #3410 )
...
* update TextureView validation
* add changelog entry
* remove call to clone
* dereference instead
2023-01-24 12:02:16 +01:00
Jinlei Li
0849e78600
Add view_formats in TextureDescriptor ( #3237 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
Co-authored-by: crowlkats <crowlkats@toaxl.com >
Closes https://github.com/gfx-rs/wgpu/issues/3030
2023-01-18 16:03:56 -05:00
Nathan Adams
186a29c34d
Implement TextureFormat::Stencil8 + add stencil example ( #3343 )
...
* Implement TextureFormat::Stencil8
* Add stencil-triangles demo to test Stencil8 and show how to use stencil testing
* Added changelog for Stencil8
2023-01-02 13:47:10 +01:00
Teodor Tanasoaia
14886ee142
Sync depth/stencil copy restrictions with the spec ( #3314 )
...
* sync depth/stencil copy restrictions with the spec
* add changelog entry
2022-12-20 15:26:00 +01:00
Connor Fitzgerald
3ce5ca866b
Improve dynamic offset binding errors ( #3294 )
2022-12-15 00:53:42 +00:00
Nicolas Silva and Connor Fitzgerald
e90aacea96
Validate texture copy ranges earlier to prevent integer overflow ( #3090 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2022-12-01 01:20:48 +00:00
Erich Gubler
18f3f5f6f0
Enable unsafe_ops_in_unsafe_fn lint in all workspaces ( #3044 )
2022-11-14 10:49:39 -08:00
Ali
3c82a4cd5c
Added support for MSAA(x2,x8) beyond WEBGPU restrictions for native a… ( #3140 )
...
Closes https://github.com/gfx-rs/wgpu/issues/2910
2022-11-09 15:19:05 -05:00
Andreas Reich and Connor Fitzgerald
b838b0871c
Added new UNRESTRICTED_INDEX_BUFFER downlevel flag. ( #3157 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2022-11-07 15:45:50 -05:00
Nicolas Silva
db30e3909a
Avoid integer overflow on multiplication in write_texture. ( #3146 )
2022-11-07 15:31:19 -05:00
Jim Blandy
215884184b
Reformat comments in wgpu-core. ( #3102 )
2022-10-13 18:34:44 +00:00
Jim Blandy
fa4d8401e8
Use std::fmt::Formatter::debug_struct for RenderPass. ( #3100 )
2022-10-13 14:00:54 -04:00
Mikko Lehtonen
60fd2a32e9
Implement missing PrettyError impls ( #3066 )
2022-10-05 18:43:52 -04:00
Mauro Gentile and Mauro Gentile
cdf6ee0c87
Updating TextureFormat matching specs ( #2954 )
...
Co-authored-by: Mauro Gentile <Mauro.Gentile@ubisoft.com >
2022-09-20 12:08:06 -04:00
Jim Blandy
7d138e2e76
Avoid overflow in check texture copy bounds. ( #2963 )
2022-08-28 20:07:04 -04:00
Jim Blandy
2cd08a1c9c
Placate Clippy 0.1.63. ( #2977 )
2022-08-24 17:25:59 -04:00
Nicolas Silva
96a85b3ac5
Add missing validation in copy_texture_to-Buffer. ( #2958 )
2022-08-13 19:48:17 -04:00
Sébastien Marleau
2ce1318c8c
fix deduplication not taking into account render bundles ( #2867 )
2022-07-10 22:15:52 +00:00