Commit Graph
805 Commits
Author SHA1 Message Date
Dzmitry Malyshau 39b7a8a202 Update naga to 8df5421 2021-12-25 00:03:15 -05:00
Josh Groves 97e6ea7b71 Improve shader source documentation (#2315)
- remove outdated note about WGSL web support
- try to combine the note about parsing/validation/translation
2021-12-24 03:00:57 +00:00
Jonathan Behrens a3b9fc3af6 Make ShaderSource #[non_exhaustive] 2021-12-22 17:15:57 -05:00
Dzmitry Malyshau c00e471274 Release 0.12 2021-12-18 12:36:41 -05:00
Dzmitry Malyshau ec1d022a75 Error scopes API (#2299) 2021-12-17 04:39:48 +00:00
Dzmitry Malyshau 3960658529 Remove block decorations (#2292) 2021-12-15 12:29:37 -05:00
Dzmitry Malyshau 0e5892fa04 Update naga with Metal bounds checks (#2276) 2021-12-15 04:59:06 +00:00
Dzmitry Malyshau c1c855bb98 Allow strip index format None if no indexed drawing is done 2021-12-07 18:58:06 -05:00
Dzmitry Malyshau ca10f8c456 Fix documentation for dynamic offsets order 2021-12-07 10:40:34 -05:00
Dzmitry Malyshau ab28009d80 Angle support on Windows
Also remove the macros module in favor of generic functions.
2021-12-05 17:09:36 -05:00
Dzmitry Malyshau 9bbea3d348 Update naga to c69f676 2021-12-04 12:46:49 -05:00
Jerónimo Sánchez dd315e50ff Extended Queue::write_* docs to reflect overrun error (#2250)
* Extended Queue::write_buffer to reflect overrun error

* Extended Queue::write_texture doc to reflect overrun error
2021-12-03 20:34:30 +00:00
Dzmitry Malyshau 6372aad845 Rename fill_buffer back to clear_buffer 2021-12-02 12:33:59 -05:00
Igor Shaposhnik c6d1491bb1 Update raw-window-handle to 0.4 2021-12-01 15:59:05 -05:00
Aleksander Guryanov 1b1c826ac7 Remove duplicate line in mod.rs (#2223) 2021-11-29 13:34:15 +00:00
Dzmitry Malyshau 2b38439f65 Add INDIRECT_FIRST_INSTANCE feature (#2206) 2021-11-23 10:01:07 -05:00
Neil Blakey-Milner 4f639622d0 Add strip_index_format to linestrip in conservative-raster example (#2199) 2021-11-22 14:01:24 +00:00
Andy Fiedler 8196b7567c Web backend: call set_vertex_buffer with size as optional 2021-11-22 08:59:25 -05:00
Andy Fiedler 385d9caa8d Web backend: call set_index_buffer with size as optional
Size must be passed to setIndexBuffer in Javascript as undefined in order for WebGGPU to use the default size, which is the full buffer size.
2021-11-22 08:59:25 -05:00
dan cd59c76e3a Add new BindingResource type SamplerArray (#2113)
* implemented SamplerArray

* modified shaders

* fixed doc

* fixed code format
2021-11-22 12:19:46 +00:00
CatCode79 8acde0b0e1 minor typo
GSLS -> GLSL
2021-11-21 12:29:57 +01:00
LaylandLayl Bongers 2ef72b9313 Add multiview support (#2187)
Co-authored-by: Layl Bongers <2385329-layl@users.noreply.gitlab.com>
2021-11-19 10:56:48 -05:00
Xiaopeng Li 39f3f08b55 Add Device::as_hal and always assume texture from hal is initialized (#2180)
* Add Device::as_hal, create_texture_from_hal_initialized

* Add Safety doc

* Always assume that the texture from hal is initialized
2021-11-18 17:34:01 -05:00
Boris-Chengbiao Zhou 47fd77619f Don't use duplicate function name in boids shader (#2183)
From the spec: "A declaration must not introduce a name when that
identifier is already in scope with the same end scope as another
instance of that name."

naga doesn't yet check this (gfx-rs/naga#1480) but Chrome/Tint rightly
complains with: error: redefinition of 'main'
2021-11-16 23:25:33 -05:00
Boris-Chengbiao Zhou 3545a4fdd5 Introduce SamplerBindingType enum and fix bug in validation (#2181)
* Introduce SamplerBindingType enum and fix bug in validation

This matches the WebGPU spec more closely and also lets us implement the
validation as it's written in the spec[1]. This fixes a bug which
previously prevented the "shadow" example from running in Firefox.

Previously the validation would check whether the filtering was
appropiate even if it was a comparison sampler. This didn't matter when
running the shadow example natively since the example was setting
`filtering: true` in addition to `comparison: true`. But this failed
when running through a browser since there the used WebIDL has the
proper enum representation and eventually resulted in `filtering: false`
being passed to wgpu-core which would then fail validation.[2]

[1]: https://gpuweb.github.io/gpuweb/#bind-group-creation
[2]: https://github.com/mozilla/gecko-dev/blob/674b6582bafedc11fba6dc537769c88e9ed921d3/dom/webgpu/ipc/WebGPUChild.cpp#L502-L513

* Fix remaining examples

* Fix deno_webgpu
2021-11-16 23:08:03 -05:00
Jerónimo Sánchez 052cb3da39 Renaming CommandEncoder::clearBuffer to CommandEncoder::fillBuffer (#2174)
* Renamed clear_buffer to fill_buffer (keeping up with spec)
* fill_buffer does not require CLEAR_BUFFER feature

* Changed ClearBuffer to FillBuffer for `trace` feature

* Renamed clearBuffer for web backend
2021-11-14 19:16:10 -05:00
Boris-Chengbiao Zhou 08b9c46ec4 Validate strip_index_format (#2177)
The spec mandates that stripIndexFormat is set even when drawIndexed is
not used. (https://www.w3.org/TR/webgpu/#primitive-state)
There is some recent discussion about this though:
https://github.com/gpuweb/gpuweb/issues/2199
2021-11-14 19:03:33 -05:00
Dzmitry Malyshau f25a45f4e2 Evolve depth clamping into clip control (#2171) 2021-11-10 16:55:27 -05:00
Dzmitry Malyshau 27aae2a2a2 Update naga to eda078d (#2172) 2021-11-10 16:06:32 -05:00
Mike Welsh 7b3caad779 web: Implement Device::on_uncaptured_error 2021-11-04 22:05:48 -02:30
Dzmitry Malyshau ca7ca749cd Update naga to 323999f, report pretty errors in shader validation (#2141) 2021-11-01 16:57:33 -04:00
Dzmitry Malyshau 07b02e694d Update naga to 9d2b357 (#2140) 2021-10-31 23:29:49 -04:00
939d54f88d Compute max workgroup size limits (#2133)
* Creation of max compute workgroup size limits
* Implemented for Vulkan and Dx12

* Follow up of gfx-rs/wgpu#1808

* Check if current dispatch operation is under the limit

* Typos and some forgotten fixes

* Port to GLES

* Port to Metal with default limits

* Change Vulkan max_workroup_size_per_dims to pick the min of the reported dimensions

Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-10-31 22:32:10 -04:00
Wumpf 988716943f Zero init textures (#1688)
* Added tests for texture zero init
sadly, they are typically passing even if texture zero init isn't doing its job
However, they form nice isolated examples for testing out texture initialization
It could be possible to dirty texture memory prior to ensure zero init did the job

* texture init tracker

* tracking texture init requirements for bind group, transfer and rendertarget

* texture clears for texture init
* queue submit
* write_texture

* Enforce presence of either render target or copy_dst flag

* clear render targets also with using buffer copies
enforce COPY_DST usage now on all textures

* adjust ImageSubresourceRange.layer_range calculation for 3D textures

init_tracker has now a `discard` function to get single data points back to uninitialized

use new standardized partition_point function

* track init state for discarded textures from renderpasses

missing:
* init on the fly if discarded is found within command buffer
* handle discarding only stencil or only depth

* added tests for zero init after discard

* tracking discarded surfaces now in separate struct, piping all inits through utility function
allows to resolve discard/init_action interactions

* Move various memory init code to separate mod
CommandBufferTextureMemoryActions is now fully encapsulated

* implemented discard init fixups for everything but renderpass

* render passes also cause now discard fixups

* fixup_discarded_surfaces takes now an iterator instead of Drain

* Add memory init test for discarding depth targets

* handle divergently discarded depth/stencil target

* comment & clippy fixes

* fix collect_zero_buffer_copies_for_clear_texture yielding block breaking copies

* [pr feedback] minor cleanup in zero_init_texture_after_discard, `use` hygenie

* [pr feedback] fix bug in ImageSubresourceRange range utils

* [pr feedback] fix texture tracker check, bundle transition_texture on init, cleanups

* Implemented drop for InitTrackerDrain

* remove incorrect comment about extents in add_pass_texture_init_actions

* Fix unit test & clippy issues in init_tracker
2021-10-28 09:15:53 -04:00
Riccardo Zaglia d46c39af1d FIx raw Vulkan API 2021-10-22 21:53:20 -04:00
Dzmitry Malyshau ec8413dfcb Build fixes after a bad merge (#2071) 2021-10-14 19:24:30 -04:00
Dzmitry Malyshau 47fb0efb2c ETC2 texture format refactor (#2064) 2021-10-13 13:42:44 -04:00
Wumpf a28c52873f Move clear_texture impl from wgpu-hal to wgpu-core (#2046)
* new test for clearing textures of all formats

* clear_texture is now always implemented in wgpu-core instead of wgpu-hal

* add 1D/array/volume texture to clear_texture test

* set mip_level_count to 1 for D1 textures in clear_texture test

* fix warning & clippy lints

* Fix web build

* [pr feedback] fix potentially skipped resource transition, fix wrong mip size for texture clear

* collect_zero_buffer_copies_for_clear_texture aligns rows now properly
2021-10-13 13:42:13 -04:00
Yuya Kanai 42de30ad13 Fix issue with limits for hello-triangle (#2062)
* Update main.rs

* Add using_resolution to hello-triangle limits

* Fix format for hello-triangle
2021-10-13 13:31:38 +00:00
Andrew Wheeler(Genusis) 1759722b69 Added GLSL to ShaderSource behind Feature lock (#2055)
* Added GLSL to ShaderSource behind Feature lock

* Used full path for Naga's FastHashMap and ShaderStage rather than add them as a pub include

* changed spirv and glsl web feature to web-shader-translation. Now requires glsl or spirv to be choosen along with the web-shader-translation to unlock their usage

* Changed the Description of the Glsl enum

* Added README update

* Made With with

* added catch all that panics if web-shader-translation is not enabled with spirv or glsl

* added Compiler condition to prevent the catch all unless glsl or spirv exists without web-shader-translation

* We decided to use [target.'cfg(target_arch = wasm32)'.dependencies.naga] within cargo to include wgsl-out in the Web backend unconditionally, which removed the need for a panic

* Removed wasm targets section from readme as it is no longer needed

* Named Glsl fields to make them more understandable as to what they are for

* Fixed the enum usage for GLSL and Added documentation for the fields
2021-10-12 19:20:45 +00:00
dwbrite 06118be1b1 Docs: add structure for indirect dispatch args 2021-10-12 09:02:23 -04:00
Dzmitry Malyshau 016b319b38 Manifests update for 0.11 2021-10-07 19:15:49 -04:00
Zicklag 312828f12f Implement WebGL2 Backend (#1686)
* Implement WebGL Backend

* Add WebGL Fixes by @mrk-its

* Update Limits for WASM and Examples

* Address Review Points
2021-10-07 16:18:09 -04:00
Stephen Martindale c36e08073f Enable parking_lot's wasm-bindgen feature on WASM. 2021-10-07 16:13:35 -04:00
Connor Fitzgerald 6df5f95b67 Update naga to 2e7d629 2021-10-07 16:09:13 -04:00
Dzmitry Malyshau dfa4948033 Update naga to 0e3fbc8 2021-10-07 08:32:01 -04:00
Dzmitry Malyshau 5092fb7ea5 Refactor presentation to be explicit 2021-10-06 17:02:10 -04:00
Connor Fitzgerald 302d6c42d1 Remove !Send + !Sync on command encoders 2021-10-06 16:32:45 -04:00
Dzmitry Malyshau 1ee6036f44 Implement software adapter selection 2021-10-01 17:22:51 -04:00
João Capucho 9bc5908492 Add method to create shader modules without runtime checks (#1978)
* Add method to create shader modules without runtime checks

* Use opaque struct to represent shader bound checks
2021-09-27 19:51:44 +00:00