Jim Blandy
ad5a70aea1
[core] Validate shader stages after applying pipeline overrides.
...
The WebGPU specification requires pipeline creation to validate
properties of shader stages, like workgroup sizes, that may depend on
the values of pipeline-overridable constants. Previously, wgpu-core
validated stages using an `Interface` built from the module before
overrides were applied, with results contrary to spec. Override
processing was then carried out by `wgpu_hal`, after all validation
had supposedly been taken care of.
This commit has `create_shader_module` save the validated Naga module
instead of creating a `wgpu_hal` shader module. At pipeline creation
time, `StageCompiler::compile` now applies the stage's override values
with `process_overrides`, validates the stage using an `Interface`
built from the result, and, if that validation succeeds, returns a
`CompiledStage` holding the `wgpu_hal` `ShaderModule` created from it.
Dropping the `CompiledStage` destroys that module once the pipeline
has been created.
Since the override values have already been applied, we pass
`wgpu_hal` empty sets of constants for these modules.
Since the `naga::back::pipeline_constants` module is now used by
`wgpu_core` rather than `wgpu_hal` backends, it can't be conditionally
available based on Naga's backend features. Include it
unconditionally.
This change removes `Interface::finalize_entry_point_name`, since we
no longer build an `Interface` at shader module creation. Instead, we
choose entry points from the `naga::Module` directly.
Add new tests: `tests/tests/wgpu-validation/api/overrides.rs`
Fixes #9774 .
2026-10-26 23:42:33 +00:00
Douglas Dwyer and Inner Daemons
322168c778
fix(wgpu): Make TextureBlitter respect sample_type when downsampling ( #10657 )
...
Co-authored-by: Inner Daemons <85136135+inner-daemons@users.noreply.github.com >
2026-10-25 12:33:50 +00:00
Inner Daemons and Andy Leiserson
0f0262acdd
Correctly zero init multiplanar textures ( #9700 )
...
Co-authored-by: Andy Leiserson <aleiserson@mozilla.com >
2026-10-22 00:11:46 +00:00
Yilmaz Kiymaz
a4b0f2257a
[hal vulkan] Enable the depthBiasClamp feature when it is supported ( #10566 )
2026-10-16 13:53:30 +00:00
Abir Deol
14328f4991
Validate mesh draws in render bundles against the multiview mask ( #10496 )
2026-10-14 16:15:09 +00:00
Kevin Reid
60036cdc0a
Fix Cargo lint from Rust 1.100 ( #10576 )
2026-10-14 00:35:08 +00:00
Kevin Reid
20a17523e2
Fix Clippy lint from Rust versions newer than 1.96 ( #10575 )
2026-10-13 17:06:07 +00:00
sagudev
d7220bf2f0
[wgpu] forbid read BufferViews on MapMode::Write mapped buffers
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-10-08 11:08:30 +00:00
sagudev
7265ac95dd
Panic on Device::destroy if outstanding views
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-10-08 11:08:30 +00:00
sagudev
d648f6d917
Panic on Buffer::destroy if outstanding views
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-10-08 11:08:30 +00:00
sagudev
07e7e08bd0
Test alive mapping while buffer/device destruction
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-10-08 11:08:30 +00:00
dependabot[bot]
5c9660184d
chore(deps): bump proxy-addr from 2.0.7 to 2.0.8 in /tests/wasm/runner ( #10555 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-10-07 15:22:43 +00:00
Stuart Parmenter
79348d63e6
Use separate Vulkan memory pool for TRANSIENT buffers ( #10232 )
2026-10-02 21:25:28 +00:00
Andy Leiserson and Connor Fitzgerald
2c3e503258
test: Improve tracking of slow tests ( #10429 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2026-09-27 21:09:48 +00:00
Parman Mohammadalizadeh
7c8eee4744
fix(hal/vulkan): make copy-only textures viewable ( #10245 )
2026-09-24 17:33:00 +00:00
Sam
6293e039ca
[core] "consume" adapter on first succesful request_device if STRICT_WEBGPU_COMPLIANCE ( #10444 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-09-24 13:34:16 +00:00
Andy Leiserson
b9f7ddad53
Fix lock issues affecting mark_externally_initialized test
...
- `RwLockReadGuard::forget` was not actually forgetting the
`LockStateGuard`, resulting in a "double unlock" error when
`SnatchableResourceGuard` later called `force_unlock_read`.
- Adjust both the test and the lock graph to avoid lock
rank errors.
2026-09-18 19:56:30 +00:00
Andy Leiserson
63b40b57f2
test: Enable mark_externally_initialized test on Mac Vulkan ( #10239 )
2026-09-18 18:14:00 +00:00
Jinlei Li
8630a774af
fix(core): Implement render bundle debug commands ( #10308 )
2026-09-18 12:55:21 +00:00
Erich Gubler
81e38d86f4
fix: emit NeedsInitializedMemory for create_external_texture_binding
2026-09-18 11:04:22 +00:00
Erich Gubler
3c2c89c051
refactor(test): extract create_discarded_texture_and_view
...
This prepares for a second caller in the subsequent commit.
2026-09-18 11:04:22 +00:00
Erich Gubler and Kevin Reid
535f5c67a1
diag: rework sentence structure of MismatchedDynamicOffsetCount
...
Co-authored-by: Kevin Reid <kpreid@switchb.org >
2026-09-17 15:43:18 +00:00
Erich Gubler
27462da192
diag: use proper conjugation of "to be" for MismatchedDynamicOffsetCount
2026-09-17 15:43:18 +00:00
Erich Gubler
5086e107a2
fix: emit NeedsInitializedMemory for create_external_texture_binding_from_view ( #10276 )
2026-09-17 11:53:59 +00:00
Jinlei Li and Connor Fitzgerald
044e926650
fix(core): Check for device loss before mapping buffers ( #10301 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2026-09-15 05:35:02 +00:00
renovate[bot] and Connor Fitzgerald
20c1fb7cbd
Update crate-ci/typos action to v1.50.1 ( #10324 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2026-09-14 16:34:38 +00:00
Erich Gubler
f0333904d0
test: add regression cvg. for #9316 ( #10261 )
2026-09-12 20:56:26 +02:00
Andy Leiserson
10fe6409d4
Partial snorm10-10-10-2 vertex format support ( #10226 )
2026-09-11 10:53:31 -04:00
sagudev
a26e342d9b
Split BufferUsages into WGPU and WebGPU bits using bitflags_array
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-09-10 16:08:34 -07:00
Andy Leiserson
107e2827f7
chore: Fix CRLF line endings ( #10299 )
2026-09-10 05:56:36 -04:00
Andy Leiserson
ab50d50ac6
test: Reduce the texture height in clear_texture tests ( #10285 )
2026-09-09 17:37:23 +02:00
Andy Leiserson
a792cbe99b
test: Exercise zero-size vertex and index bindings
2026-09-08 15:07:15 -07:00
Andy Leiserson
ea0afc6216
refactor: Parameterize type of hal::BufferBinding::size; resolve sizes in core
...
For storage and uniform buffer bindings, the size is a `wgt::BufferSize`
(`NonZeroU64`). For vertex and index buffer bindings, the size is a
`wgt::BufferAddress` (regular `u64`).
Temporarily breaks some zero-size vertex/index binding cases that worked
before (end of buffer); will be resolved in an immediate follow-up
commit that fully implements zero-size vertex/index binding support.
2026-09-08 15:07:15 -07:00
Alex Egger and Andreas Reich
5c1748559d
fix(hal/gles): copy every depth slice in copy_texture_to_texture ( #10004 )
...
Co-authored-by: Andreas Reich <r_andreas2@web.de >
2026-09-05 09:45:28 +00:00
Andy Leiserson
92de1a4295
test: Expectation updates for Vulkan SDK 1.4.357 ( #10238 )
2026-09-04 16:17:11 -04:00
AdrianEddy
9d0bc6801f
fix(core): hold map_state across the HAL map in Buffer::map ( #9959 )
2026-09-04 09:35:55 -07:00
sagudev and Luo Zhiaho
8630922f47
Don't include detailed shader compilation info in validation error
...
Co-authored-by: Luo Zhiaho <luo_zhihao@outlook.com >
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-09-04 13:38:23 +02:00
dependabot[bot]
d8339a579a
chore(deps): bump qs from 6.15.2 to 6.16.0 in /tests/wasm/runner ( #10252 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-09-03 11:37:08 +00:00
Sam
3e11ff59bf
Buffer::unmap should not raise any validation errors (#10242 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-09-02 18:19:05 +00:00
Luo Zhihao
8c1b137be2
Disallow array types in var<immediate> ( #10081 )
2026-09-02 14:25:31 +00:00
Lucas Meurer
5887663c8e
Fix dxc compile error when shader label contains : ( #10134 )
2026-09-01 16:35:51 -07:00
d30e2dd6d6
fix(hal/vulkan): count textures created by create_texture ( #10022 )
...
Co-authored-by: Claude Fable 5 <noreply@anthropic.com >
Co-authored-by: Erich Gubler <erichdongubler@gmail.com >
2026-09-01 10:47:44 +00:00
Sam
6008736585
Move erroring of create_buffer into wgc ( #10214 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-08-31 18:59:34 +02:00
Robin Cramer
64b9bb0e90
Added mark_externally_initialized to texture ( #10075 )
2026-08-31 10:21:25 -04:00
Sam
eb0150579d
Move erroring of create_texture and implement missing validation ( #10165 )
...
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2026-08-31 09:47:48 +00:00
Sam
78fa6152cc
Revert part of #10115 by removing result from create_render_bundle_encoder and reimpl content validation in deno ( #10179 )
2026-08-31 10:21:22 +02:00
07132f4440
Implement texture-component-swizzle ( #9553 )
...
Co-authored-by: Inner Daemons <85136135+inner-daemons@users.noreply.github.com >
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2026-08-30 03:49:16 -04:00
AdrianEddy
a148f96e20
feat(webgl): Add ability to interop with external textures ( #9834 )
2026-08-28 21:18:35 +00:00
Luo Zhihao and Connor Fitzgerald
4d749308e6
Fix separate depth stencil read-only state ( #9763 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2026-08-28 15:31:26 +00:00
Zachary Harrold
6f2feed984
meta: disable default features for wgpu-core and wgpu-hal ( #10097 )
...
Fixes warning caused by `wgpu-core-remote`
2026-08-27 11:04:51 +00:00