teoxoy
91ee407c87
[hlsl-out] fix fallthrough in switch statements
2022-05-30 13:11:56 -07:00
teoxoy
7c7e96276a
[hlsl-out] fix missing break statements (for FXC)
2022-05-30 12:15:16 -07:00
João Capucho
0aa7681165
glsl-out: Implement bounds checks for ImageLoad ( #1889 )
...
* glsl-out: Implement bounds checks for `ImageLoad`
* Enable image bounds check snapshot tests for GLSL.
In addition to the snapshot.rs changes, this entails adding an entry
point function to `bounds-check-image-restrict.wgsl` and
`bounds-check-image-rzsw.wgsl`, including appropriate data in the
param.ron files.
* Apply comments
Snapshot test changes:
Co-authored-by: Jim Blandy <jimb@red-bean.com >
2022-05-30 12:13:58 -07:00
João Capucho
4cd997a3eb
glsl-out: Fix storage format for Rgba8Unorm
2022-05-28 14:30:12 -07:00
Ashley Ruglys
104f4dc7ec
Fix a broken clippy lint
2022-05-22 08:42:20 -07:00
Hasan Ali
571302e3ff
[hlsl-out] Fix countOneBits and reverseBits for signed integers
2022-05-17 00:12:18 +02:00
teoxoy
ab2806e05f
[hlsl-out] fix array constructor return type (for FXC)
2022-05-12 22:17:40 -07:00
teoxoy
5f47d6d31f
[msl-out] use matrix identity constructor
2022-05-12 22:15:45 -07:00
teoxoy
f48174a0b4
[spv-out] use OpCopyObject for matrix identity casts
2022-05-12 22:15:45 -07:00
teoxoy
b7ff50619c
[spv-out] use OpCopyObject for bool - bool conversion due to OpBitcast not being feasible for booleans
2022-05-12 22:15:45 -07:00
teoxoy
afb6504b8b
add support for identity matrix constructor
2022-05-12 22:15:45 -07:00
teoxoy
b688584d87
[msl-out] fix pointers to private or workgroup address spaces possibly being read only
2022-05-11 20:10:18 -07:00
Hasan Ali
205ea6cc5c
Fix hlsl output for writes to scalar/vector storage buffer
2022-05-10 22:46:47 +02:00
teoxoy
b3d5e6d807
[msl-out] zero init variables in function address space
2022-05-10 10:44:40 +02:00
teoxoy
239bbbbed4
[spv-out] zero init variables in function and private address spaces
2022-05-10 10:44:40 +02:00
teoxoy
ceb92921c2
remove named expression entry for phony assignment
2022-05-10 10:43:25 +02:00
teoxoy
66337af310
add TODOs for handling undefined behavior
2022-05-09 20:48:09 -07:00
teoxoy
7109cffb20
[spv-out] use SRem instead of SMod
2022-05-09 20:48:09 -07:00
teoxoy
c584331f39
[hlsl-out] use fmod instead of %
2022-05-09 20:48:09 -07:00
Teodor Tanasoaia
e312a7adeb
[hlsl-out] use wrapped constructors when loading from storage address space ( #1893 )
2022-05-09 20:40:42 -07:00
Hasan Ali
934fa16919
Implement reverseBits and countOneBits for SPIR-V ( #1897 )
...
* Implement reverseBits and countOneBits for spir-v
* Update tests
* Fix type error for glsl countOneBits implementation
2022-05-09 23:24:28 +02:00
João Capucho
cf32c2b7f3
glsl-out: Fix feature search in expressions
...
It was also searching in all entry points instead of only in the current
one.
All samples queries need the ARB_shader_texture_image_samples extension
so we need to check if any samples queries are made and if so request
the extension.
2022-05-05 19:06:33 +01:00
teoxoy
1869c6831e
[hlsl-out] zero init struct constructor
2022-05-03 19:51:51 +02:00
Noel Tautges
a99fc27dc1
Change !0 to <type>::MAX or -1, depending on signedness
2022-04-30 10:36:00 -07:00
Teodor Tanasoaia
f2e7818e71
[wgsl-in] implement firstTrailingBit/firstLeadingBit u32 overloads ( #1865 )
...
* [wgsl-in] implement firstTrailingBit/firstLeadingBit u32 overloads
* fix MSL type issue
reverts https://github.com/gfx-rs/naga/pull/1473/commits/b9162e443dd58cf95c2d7930e9c42b0e0e00ede7
2022-04-26 22:25:53 -07:00
Connor Fitzgerald
1aa9154964
Binding arrays play nice with bounds checks ( #1855 )
2022-04-25 04:17:51 +00:00
Connor Fitzgerald
ad28396851
Implement Binding Arrays ( #1845 )
2022-04-19 14:23:07 -04:00
Jim Blandy
0aa6b6902b
[hlsl-out] Flesh out matrix handling documentation.
2022-04-18 08:36:51 -07:00
Teodor Tanasoaia
7ce98dcc7d
Make use of new language features ( #1841 )
...
* use strip_prefix
* make fn const (resolving TODO)
* make use of nested OR patterns in match arms
* warn on clippy::missing_const_for_fn
* constify functions
* ignore clippy::missing_const_for_fn for into_inner functions
2022-04-17 03:39:54 -04:00
Jim Blandy
ef387f73a6
[hlsl-out] Emit row_major qualifier on matrix uniform globals.
...
Fixes #1836 .
2022-04-16 23:50:17 -07:00
Igor Shaposhnik
1720725014
[wgsl-out] Update entry point stage attributes
2022-04-15 18:02:48 +01:00
teoxoy
8584507fb6
[glsl-out] remove redundant space from unary ops
2022-04-15 11:21:51 +02:00
teoxoy
7f4e07e5cd
[glsl-out] add support for boolean vector ~, | and & ops
2022-04-15 11:21:51 +02:00
teoxoy
95b84c4403
[spv-out] add support for int vector scalar mult
2022-04-15 11:21:51 +02:00
teoxoy
6e6daad4d4
[hlsl-out] fix bool splat
2022-04-15 11:21:51 +02:00
teoxoy
4ea7dc3381
[spv-out] add support for matrix add and sub
2022-04-15 11:21:51 +02:00
teoxoy
4366e65609
add support for unary vector operators
2022-04-15 11:21:51 +02:00
teoxoy
dd75579d7c
fix typos
2022-04-14 13:47:18 -07:00
Jim Blandy
97fffccac7
[spv-out] Emit required decorations on wrapper struct types, too.
...
Fixes #1810 .
2022-04-14 11:54:47 -07:00
Jim Blandy
1a0a48fd69
[spv-out] Decorate array and struct type layouts unconditionally.
...
Remove the `decorate_layout` variable, which is unconditionally set to
`true` anyway.
2022-04-14 11:54:47 -07:00
Jim Blandy
27d0fee2e7
More tests for non-struct global types.
2022-04-14 11:45:42 -07:00
Jim Blandy
5d631d9e2d
[glsl-out] Generate GLSL for arbitrary global types, per Naga IR.
...
Delete `GlobalTypeKind`.
Break out `Writer::write_global`'s code into two new functions,
`write_simple_global` and `write_interface_block`. This introduces
some repeated code, but the way we need to produce interface blocks
and normal globals are sufficiently different that I think it's
clearer overall to just separate them entirely. Much of the details
are handled by their callees.
Loosen the interface block code to support arbitrary types.
2022-04-14 11:45:42 -07:00
Jim Blandy
cf1869016f
[glsl-out] Rename glsl_storage_class to glsl_storage_qualifier.
...
"Storage qualifier" is the term used in the GLSL ES specification.
2022-04-14 11:45:42 -07:00
Jim Blandy
896e884802
[glsl-out] Use exhaustive match in AddressSpace::initializable.
...
No change in behavior. Exhaustive matches aid error detection, and are
clearer when the number of match arms isn't excessive.
2022-04-14 11:45:42 -07:00
Jim Blandy
438a750967
Introduce TypeInner::is_dynamically_sized helper function.
...
Use it in HLSL and GLSL back ends.
2022-04-14 11:45:42 -07:00
Jim Blandy
170faab6db
Move invariant bit from Binding::Builtin to Builtin::Position. ( #1822 )
...
Use the type system to enforce the rule that the invariant attribute
may only appear on `Position` builtins.
2022-04-13 14:57:05 -07:00
Jim Blandy
78975f25da
[msl-out] Permit invariant qualifier on vertex shader outputs.
2022-04-12 22:22:20 +02:00
Jim Blandy
4e4d918d39
[msl-out] Introduce finer distinctions to LocationMode.
...
Distinguish between vertex shader outputs and fragment shader inputs.
This change should have no visible effect.
2022-04-12 22:22:20 +02:00
Jim Blandy
8afa5fe5e3
[glsl-out] Document and flatten back::glsl::Writer::write_varying.
2022-04-12 14:22:50 +01:00
Teodor Tanasoaia
bd62887a13
[hlsl-out] Add more padding when necessary ( #1814 )
...
* [hlsl-out] add padding at the end of structs and after struct members of type matrix and array (when necessary)
* use wrapped constructor fn for constants
* add array as fn arg test
* fix glsl array fn arg
* add wrapped constructor for arrays
* [glsl-out] support multidimensional arrays
* address comments
2022-04-11 20:34:06 -07:00