Dzmitry Malyshau
103e7763a3
Rename depth to depth_or_array_layers
2021-03-01 11:08:17 -05:00
bors[bot] and Dzmitry Malyshau
6442b947cb
Merge #1210
...
1210: Reset the bindings on the push constant change r=wumpf a=kvark
**Connections**
Fixes #1207
(unconfirmed!)
**Description**
I was able to replay the trace in #1207 without validation errors, so I looked deeper into what might have gone wrong.
The code isolated in #1194 looks great. However, the calling code's handling of push constants might have changed a bit.
And I see that the trace uses push constants, so here is what happened, I think:
- layout A was set, expecting bind group layouts X and Z
- bind groups X and Y where bound
- layout B was set, expecting bind group layout X and Y. We see that Y group can now be bound, so we do this. The old logic in this case wasn't considering the push constants in any way, it would only consider them if bind group layouts didn't change, erroneously.
- layout B has different push constant ranges...
So it's a one-line fix now, which I'm hoping is correct.
**Testing**
Not tested
@Wumpf would you be able to check this?
Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com >
2021-02-12 21:10:26 +00:00
Jakob Hellermann
b89cb21ce3
fix rustdoc warnings
2021-02-12 13:56:51 +01:00
Dzmitry Malyshau
692e82d521
Reset the bindings on the push constant change
2021-02-11 14:47:35 -05:00
Dzmitry Malyshau
d0dcb105f5
Don't check the index format for non-indexed calls
2021-02-06 10:58:46 -05:00
Dzmitry Malyshau
e357e3083a
Fix command allocator race condition with maintenance
2021-02-05 00:57:18 -05:00
Dzmitry Malyshau
262d0c6dfc
Isolate binding compatibility logic into a separate module
2021-02-04 01:16:40 -05:00
Andreas Reich
822424e519
Fix buffer init in bundle.rs with mem::size_of::<wgt::DrawIndirectArgs>
2021-01-31 22:01:52 +01:00
Andreas Reich
018ad05f56
memory init tracker check (previous is_initialized) clamps range now
...
and is O(log n)!
2021-01-31 21:56:31 +01:00
Andreas Reich
da86b3f401
Cleanup, better use of some rust std lib functions
2021-01-31 21:56:31 +01:00
Andreas Reich
492027fe6e
command buffer buffer memory init tracking is only filled if necessary now
2021-01-31 21:56:22 +01:00
Andreas Reich
1efdc2b229
Queue_submit zeros out uninitialized buffer regions now
...
again but with fine grained scheme now
2021-01-31 21:55:49 +01:00
Andreas Reich
9595b39bb3
Fine grained tracking of buffer init requirements
2021-01-31 21:55:49 +01:00
Andreas Reich
5133b0da94
Introduced separate MemoryInitTracker
2021-01-31 21:55:49 +01:00
Andreas Reich
a51b4f9232
buffer zero initialization prior to use in submit
2021-01-31 21:55:49 +01:00
Andreas Reich
6b51328b2e
Add public structs for indirect command buffers
...
and fix missing IndirectBufferOverrun error for IndirectDispatch
2021-01-31 21:32:33 +01:00
Dzmitry Malyshau
4764ff21e9
Update gfx with the new iterator API
2021-01-28 12:40:24 -05:00
Dzmitry Malyshau
0346b43982
Update the render pipeline API
2021-01-27 15:09:13 -05:00
Dzmitry Malyshau
c233a70afc
Handle zero-sized bindings as an error
2021-01-25 22:33:44 -05:00
Dzmitry Malyshau
7f8c776a85
Update gfx to unborrowed APIs
2021-01-19 00:33:45 -05:00
Vengarioth | Andreas Fischer
6adaef6512
fix the size checks in transfer buffer to image commands
2021-01-18 18:46:37 +01:00
Connor Fitzgerald
a22037ced0
Add pipeline statistics and timeline queries
2021-01-16 00:48:54 -05:00
Dzmitry Malyshau
a4f897b5d7
Include the extent into the framebuffer map key
2021-01-15 00:53:51 -05:00
Dzmitry Malyshau
012569845d
Update render pass and framebuffers logic to the latest gfx-hal
2021-01-15 00:53:28 -05:00
dasetwas
c01e2d10ce
Remove comment introduced in https://github.com/gfx-rs/wgpu/pull/1144
2021-01-13 23:28:44 +01:00
Mikko Lehtonen
6c56613045
Merge PassErrorScope::Draw* and Dispatch* variants
2021-01-12 22:23:17 +02:00
Mikko Lehtonen
0d60bd80c5
Include pipeline id in some pass error scopes
2021-01-12 17:58:44 +02:00
Dzmitry Malyshau
389a848dea
Support trailing render passes after the swapchain rendering
2021-01-11 21:40:41 -05:00
DasEtwas
93f68add27
Decrease error variant code verbosity, apply reviews
2021-01-11 23:46:26 +01:00
DasEtwas
151d521ad9
Fix and simplify attachment dimension mismatch check
...
This also improves error messages with detailed dimension and attachment type name info which should help developers can hopefully recognize.
2021-01-11 20:13:14 +01:00
Dzmitry Malyshau
d70148725b
Fix API traced dynamic offsets and object labels
2021-01-04 17:54:56 -05:00
Dzmitry Malyshau
f328995950
Fix UB in populating dynamic offsets
2021-01-04 14:46:04 -05:00
Dzmitry Malyshau
5953098461
Implement render bundle freeing
2021-01-04 09:30:10 -05:00
Dzmitry Malyshau
ab10d36ac0
Rename get_encoder to get_encoder_mut
2020-12-23 11:20:08 -05:00
Dzmitry Malyshau
a7587b41e6
Move the render pass setup logic into a separate method/struct
2020-12-22 22:30:27 -05:00
Dzmitry Malyshau
35b163ebc8
Encode render passes while command buffer is only read-locked
2020-12-22 13:48:18 -05:00
Connor Fitzgerald
1da153f3bd
Improve vertex state error messages
2020-12-21 23:13:34 -05:00
Connor Fitzgerald
94579d8125
Properly validate vertex buffer state
2020-12-21 23:10:53 -05:00
Dzmitry Malyshau
cb67ef6542
Clean up render pass labels
2020-12-15 17:28:24 -05:00
Dzmitry Malyshau
394135f725
Fix and improve object labels and command markers
2020-12-15 11:28:11 -05:00
bors[bot] and Noah Charlton
69196d85a3
Merge #1077
...
1077: Remove extern "C" from set_index_buffer r=kvark a=DevOrc
**Connections**
Fixes an issue that is blocking gfx-rs/wgpu-native#61
**Description**
Moves the ffi definition of wgpu_render_bundle_set_index_buffer / wgpu_render_pass_set_index_buffer to wgpu-native. This is needed because wgpu-native has its own version of IndexFormat that is different than the wgpu_types version.
**Testing**
My projects with wgpu-native work
Co-authored-by: Noah Charlton <ncharlton002@gmail.com >
2020-12-08 15:45:00 +00:00
Noah Charlton
b71c47a064
Remove extern "C" from set_index_buffer
2020-12-07 17:03:54 -05:00
Capucho
713c23bc42
Grow the VertexState inputs in SetPipeline
2020-12-07 15:45:20 +00:00
Connor Fitzgerald
19fb491262
Fix validation of compressed mipmaps
2020-12-05 19:30:26 -05:00
Connor Fitzgerald
8f430ab1ef
Implement ETC2 and ASTC textures
2020-12-05 19:30:26 -05:00
Dzmitry Malyshau
749f737c89
Add pervasive Naga support to shader module loading
...
The purpose of the PR is to support Naga modules everywhere.
As a requirement, it updates the gfx-rs version used.
Most of the logic is dedicated towards building a shader interface,
where previously we just used naga's IR. Now we have our own mini-IR.
2020-12-05 11:31:03 -05:00
kejor
4513fb2b83
Match upstream API changes for IndexFormat
2020-12-01 19:19:41 -05:00
Dzmitry Malyshau
9e2f6c2f01
Move to gfx master
2020-11-30 22:50:13 -05:00
Dzmitry Malyshau
c6bc37dbde
[error] render bundles
2020-11-23 12:00:47 -05:00
Mikko Lehtonen
459e835250
Add Ids to PassErrorScope
...
Also makes it pub, and the places it is used.
Tweak some error messages.
2020-11-21 23:39:05 +02:00