Jim Blandy
c9212c6d46
[core] Document command encoding and command buffers.
...
Flesh out the documentation for `wgpu_core`'s `CommandBuffer`,
`CommandEncoder`, and associated types.
Allow doc links to private items. `wgpu-core` isn't entirely
user-facing, so it's useful to document internal items.
2024-04-14 20:53:15 -07:00
dependabot[bot] and Andreas Reich
6756601089
build(deps): bump crate-ci/typos from 1.19.0 to 1.20.4 ( #5506 )
...
* build(deps): bump crate-ci/typos from 1.19.0 to 1.20.4
Bumps [crate-ci/typos](https://github.com/crate-ci/typos ) from 1.19.0 to 1.20.4.
- [Release notes](https://github.com/crate-ci/typos/releases )
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md )
- [Commits](https://github.com/crate-ci/typos/compare/v1.19.0...v1.20.4 )
---
updated-dependencies:
- dependency-name: crate-ci/typos
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* update to typoes 1.20.8 since it has a few important fixes
* typo fixes & exceptions
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andreas Reich <r_andreas2@web.de >
2024-04-14 09:28:36 +00:00
Jim Blandy
0b7f91c4a9
[core] Make wgpu_core::command::BakedCommands pub(crate), not pub. ( #5526 )
2024-04-14 09:40:50 +02:00
Jim Blandy
b7519bb73b
[core] Make Hub members and related types pub(crate), not pub. ( #5502 )
2024-04-10 19:52:16 -04:00
Jim Blandy
8289711b65
[core] Provide an explicit type for some CommandBuffer pointers. ( #5512 )
2024-04-10 19:51:56 -04:00
Jim Blandy
f8deb0317f
[core] Use expect instead of "if let else panic". ( #5513 )
...
Use `Option::expect` to check the result from `Arc::into_inner`,
rather than `if let Some ... else panic!`.
2024-04-10 03:53:10 -04:00
Andreas Reich
82dead09e4
Bump wgpu-core/hal/types & naga versions to match latest released patch versions ( #5404 )
2024-04-09 00:33:43 -04:00
Jim Blandy
03db77cb8c
[core] Replace id transmute method with explicit functions. ( #5509 )
...
Replace the `wgpu_core::id::Id::transmute` method, the `transmute`
private module, and the `Transmute` sealed trait with some associated
functions with obvious names.
2024-04-08 21:51:30 -04:00
lylythechosenone
d814851350
[wgpu-core] pass resources as Arcs when adding them to the registry ( #5499 )
...
* [wgpu-core] pass resources as Arcs when adding them to the registry (fix gfx-rs#5493)
* [wgpu-core] also add `Arc::new` to `#[cfg(dx12)]` blocks
* [wgpu-core] allow `clippy::arc_with_non_send_sync`
2024-04-06 09:10:24 +02:00
teoxoy
7ce422c57a
remove naga's clone feature
2024-04-05 18:07:41 +02:00
teoxoy
3bda381812
add pipeline constants plumbing
2024-04-05 18:07:41 +02:00
Erich Gubler
fb305b85f6
docs: add warning about stack size for WGSL compilation
2024-04-03 15:54:43 -04:00
Chase MacDonnell
3db0e46f7d
Implement Unorm10_10_10_2 VertexFormat ( #5477 )
2024-04-03 19:43:54 +00:00
JMS55
ed843f8029
Add more hal methods ( #5452 )
...
* Add return value to Texture::as_hal()
* Add TextureView::as_hal()
* Add CommandEncoder::as_hal_mut()
* Add changelog
* Add TextureView::raw_handle()
* Add CommandEncoder::raw_handle()
* Add additional docs for command_encoder_as_hal_mut
2024-04-03 00:37:18 +02:00
Erich Gubler
0c5bebca51
fix: unlock guard for release_gpu_resources call in Device::maintain
2024-04-02 16:12:28 -04:00
Andreas Reich
ed7d9de439
Fix indexed drawing with RenderBundle ( #5441 )
...
* enhance vertex_indices test to also run with render bundles
* fix render bundle index limit check
* changelog entry
2024-03-30 10:19:17 +01:00
Sludge
6b996dd9c7
Avoid recursive snatch lock acquisitions ( #5426 )
...
* Avoid recursive snatch lock acquisitions
* Always acquire the snatch lock before the fence lock
* Address review comments
* Add changelog entry
2024-03-23 21:29:00 +01:00
robtfm and Andreas Reich
ed95dfe9b4
Pool tracker vecs ( #5414 )
...
* pool tracker vecs
* pool
* ci
* move pool to device
* use pool ref, cleanup and comment
* suspect all the future suspects (#5413 )
* suspect all the future suspects
* changelog
* changelog
* review feedback
---------
Co-authored-by: Andreas Reich <r_andreas2@web.de >
2024-03-23 11:42:08 +00:00
Brad Werth and Erich Gubler
00e0e72596
Invoke a DeviceLostClosure immediately if set on an invalid device. ( #5358 )
...
Invoke a DeviceLostClosure immediately if set on an invalid device.
To make the device invalid, this defines an explicit, test-only method
make_invalid. It also modifies calls that expect to always retrieve a
valid device.
Co-authored-by: Erich Gubler <erichdongubler@gmail.com >
2024-03-21 13:33:25 -04:00
robtfm
152a94bc6c
suspect all the future suspects ( #5413 )
...
* suspect all the future suspects
* changelog
2024-03-18 10:53:41 -04:00
dependabot[bot]
e04a9f4c6f
build(deps): bump the patch-updates group with 29 updates ( #5376 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-14 13:00:43 -04:00
Erich Gubler
6040820099
refactor: extract Global::poll_single_device helper
2024-03-12 10:49:44 -04:00
Erich Gubler
9499e8c9df
refactor: rename Global::poll_device to poll_all_devices_of_api
2024-03-12 10:49:44 -04:00
Erich Gubler
c5ee3b6880
refactor: Global::device_poll: hoist submission_index extr.
2024-03-12 10:49:44 -04:00
Erich Gubler
fe28eda3e0
refactor: Global::poll_device: use &= for all_queue_empty
2024-03-12 10:49:44 -04:00
Erich Gubler
e3b23a6c62
fix: add missing deferred resource dtor. in Global::poll_all_devices
2024-03-12 10:49:44 -04:00
vero and Connor Fitzgerald
4e6f873da5
Add shader I64 and U64 support ( #5154 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2024-03-12 12:34:06 +01:00
Lucas Kent
cf4f8bc3a3
Minor rewording of ConfigureSurfaceError::TooLarge ( #5371 )
2024-03-10 20:48:30 +01:00
Erich Gubler
8f1981d5b1
fix: emit valid. err. on dev. mismatch in queue_write_buffer ( #5359 )
2024-03-07 11:20:42 +01:00
Connor Fitzgerald
330a8608e3
Fix Presentation ( #5312 )
2024-02-27 20:36:20 -05:00
dependabot[bot] and Connor Fitzgerald
744454b9e2
Bump Many Dependencies and MSRV ( #5241 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2024-02-27 14:43:05 -05:00
Erich Gubler
023b0e063f
feat!: make ProgrammableStage::entry_point optional in wgpu-core
2024-02-27 13:57:17 -05:00
Erich Gubler
2c66504a59
refactor(valid): factor out shader_stage_from_stage_bit helper
2024-02-27 13:57:17 -05:00
Erich Gubler
be384fc001
refactor: factor out stage_err helper in pipeline creation
2024-02-27 13:57:17 -05:00
Nicolas Silva
6f68d3dffa
Correctly set the tacker sizes before executing render bundles
2024-02-27 10:05:09 -05:00
Nicolas Silva
ed852c4774
Don't put the mapped-at-creation staging buffer in the registry
2024-02-27 10:05:09 -05:00
Nicolas Silva and Connor Fitzgerald
c77b4d3f56
Use a unique tracker index per resource instead of the ID in trackers ( #5244 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2024-02-26 20:25:12 +00:00
Erich Gubler
d6465702b6
fix: command_encoder_clear_buffer: err. on offset + size > u64::MAX
...
Rust would have made this operation either an overflow in release mode,
or a panic in debug mode. Neither seem appropriate for this context,
where I suspect an error should be returned instead. Web browsers, for
instance, shouldn't crash simply because of an issue of this nature.
Users may, quite reasonably, have bad arguments to this in early stages
of development!
2024-02-26 09:32:26 -05:00
Erich Gubler
9747a0ed23
fix: always check buffer clear offset for OOB
...
Fuzz testing in Firefox encountered crashes for calls of
`Global::command_encoder_clear_buffer` where:
* `offset` is greater than `buffer.size`, but…
* `size` is `None`.
Oops! We should _always_ check this (i.e., even when `size` is `None`),
because we have no guarantee that `offset` and the fallback value of
`size` is in bounds. 😅 So, we change validation here to unconditionally
compute `size` and run checks we previously gated behind `if let
Some(size) = size { … }`.
For convenience, the spec. link for this method:
<https://gpuweb.github.io/gpuweb/#dom-gpucommandencoder-clearbuffer >
2024-02-26 09:32:26 -05:00
Erich Gubler
751cddc510
refactor: command_encoder_clear_buffer: s/end/end_offset
2024-02-26 09:32:26 -05:00
Erich Gubler
7300b9f037
style: fix fmt. of assert!(…) in clear_texture_via_buffer_copies
2024-02-26 09:32:26 -05:00
Augusto Hack
a315925882
wgpu-core: Inform user about possible fix ( #5298 )
2024-02-25 14:30:55 -05:00
Nicolas Silva
75a98f2712
Validate that the view dimension of a multisampled texture binding is 2d ( #5274 )
...
* Validate that the view dimension of a multisampled texture binding is 2d
* typo
2024-02-21 08:56:28 +01:00
Nicolas Silva and Connor Fitzgerald
004e3efe84
Simplify the ID allocation in IdentityValues ( #5229 )
...
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com >
2024-02-15 20:55:55 +00:00
Nicolas Silva
66ba64b721
Store Arcs instead of IDs in render bundles ( #5242 )
2024-02-15 15:54:11 -05:00
Nicolas Silva
286306d7e8
Store the device's queue via a weak ref instead of an ID ( #5230 )
2024-02-15 15:42:28 -05:00
Erich Gubler
18b7904b8e
fix: discard cmd. enc. buf. on wgpu_core::Global::command_encoder_drop
2024-02-15 10:45:32 -05:00
andristarr
a7d76743a8
MissingBufferUsageError now has an id prop ( #5203 )
2024-02-14 13:27:58 +01:00
Andreas Reich
f350f28c35
Separate native-only feature for wgpu::CommandEncoder::write_timestamp ( #5188 )
...
* split out TIMESTAMP_QUERY_INSIDE_ENCODERS from TIMESTAMP_QUERY
* changelog entry
* update changelog change number
* fix web warnings
* single line changelog
* note on followup issue
2024-02-13 16:03:33 +00:00
Jim Blandy
59e79c0664
[wgpu-core] Document and improve naming in PendingWrites.
2024-02-09 11:33:52 -08:00