Commit Graph
3491 Commits
Author SHA1 Message Date
msiglreith b09027a74a export ndk toolchain path 2020-11-15 18:34:55 -05:00
Timo de Kort 25b7cea64c [rs] Remove implicit conversion hello-triangle shader.vert 2020-11-15 23:13:53 +01:00
Dzmitry Malyshau c7273b03d6 Don't install Android NDK 2020-11-14 20:07:50 -05:00
bors[bot]andDzmitry Malyshau af9713b249 Merge #1023
1023: Drop surfaces and adapters r=cwfitzgerald a=kvark

**Connections**
Not very connected

**Description**
Refactors our destruction paths a bit

**Testing**
tested on wgpu-rs

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-13 23:50:28 +00:00
bors[bot]andDzmitry Malyshau 82021b5e7c Merge #1024
1024: Update naga to 4d4e1cd4cb r=kvark a=kvark

**Connections**
Includes https://github.com/gfx-rs/naga/pull/273, https://github.com/gfx-rs/naga/pull/270, and others

**Description**
Better SPIR-V validation and introspection

**Testing**
Tested on Gecko (yo!)

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-13 23:43:33 +00:00
Dzmitry Malyshau ac89fbab8a Drop surfaces and adapters 2020-11-13 18:39:14 -05:00
Dzmitry Malyshau b0a98548d1 Update naga to 4d4e1cd4cb 2020-11-13 12:26:48 -05:00
bors[bot]andMarvin Löbel 57901a504c Merge #1021
1021: Normalize `Err(x)?` to `return Err(x.into())` r=kvark a=Kimundi

Just a tiny change based on some matrix discussion.

Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-11-12 23:14:14 +00:00
Marvin Löbel 3787d3bedb Change Err(x)? to return Err(x.into()) 2020-11-13 00:03:13 +01:00
bors[bot]andMarvin Löbel 022f19f94c Merge #1018
1018: Add context for errors originating from commads in a Pass r=kvark a=Kimundi

**Description**
This adds some error context information for some errors that can happen in a `{Render,Compute}Pass` to make error messages more clear.

Combined with https://github.com/gfx-rs/wgpu-rs/pull/613, errors in passes will look like this:
```
wgpu error: Validation error

Caused by:
    In a RenderPass
    In a draw command
    index 3600 extends beyond limit 38
```


Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-11-12 22:11:37 +00:00
Marvin Löbel 8723a8379a Annotate all commands of {Compute,Render}Passes with error context informations 2020-11-12 23:05:10 +01:00
bors[bot]andStygeon 92e75723d5 [rs] Merge #618
618: Removed unusued Uniform struct in texture-arrays example. r=cwfitzgerald a=Stygeon

The Uniform struct in the texture-arrays example is unused.

Co-authored-by: Stygeon <denrellum@gmail.com>
2020-11-12 01:30:35 +00:00
Stygeon 6fb829d4df [rs] Removed unusued Uniform struct in texture-arrays example. 2020-11-12 02:26:58 +01:00
bors[bot]andMarvin Löbel 033c896c4f [rs] Merge #613
613: Add more context to errors originating in Passes and Encoders r=kvark a=Kimundi

**Description**
This adds some top-level error context information to indicate wether an error originated in a `{Render,Compute}Pass` or `{Command,RenderBundle}Encoder` to make error messages more clear.

Combined with https://github.com/gfx-rs/wgpu/pull/1018, errors in passes will look like this:
```
wgpu error: Validation error

Caused by:
    In a RenderPass
    In a draw command
    index 3600 extends beyond limit 38
```


Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-11-11 04:56:44 +00:00
bors[bot]andDavid Shah 2226cc8d31 [rs] Merge #614
614: Bump winit version to 0.23.0 r=cwfitzgerald a=daveshah1

This fixes the following error trying to run the hello-triangle (and probably other) examples on GNOME/Wayland:

    [wayland-client error] Attempted to dispatch unknown opcode 0 for wl_shm, aborting.



Co-authored-by: David Shah <dave@ds0.me>
2020-11-10 20:57:19 +00:00
David Shah ac806458f9 [rs] Bump winit version to 0.23.0
This fixes the following error trying to run the hello-triangle (and
probably other) examples on GNOME/Wayland:

    [wayland-client error] Attempted to dispatch unknown opcode 0 for wl_shm, aborting.

Signed-off-by: David Shah <dave@ds0.me>
2020-11-10 20:28:41 +00:00
bors[bot]andAlan Kemp 315dd420f4 [rs] Merge #612
612: Update create_buffer_init_polyfill for wasm32 r=grovesNL a=alankemp

This removes create_buffer_mapped which has been removed in the latest chrome canary and firefox nightly and fixes #609 

Co-authored-by: Alan Kemp <alan@alankemp.com>
2020-11-10 02:59:00 +00:00
Marvin Löbel a74546f974 [rs] Add more context to errors originating in Passes and Encoders 2020-11-09 23:49:19 +01:00
Alan Kemp e1b05a583a [rs] Update create_buffer_init_polyfill for wasm32 2020-11-09 21:22:03 +00:00
bors[bot]andDzmitry Malyshau 2e88de3157 Merge #1015
1015: Replace gfx-memory by gpu-alloc r=cwfitzgerald a=kvark

**Connections**
Fixes #1011
Blocked on:
- https://github.com/zakarumych/gpu-alloc/issues/4
- https://github.com/zakarumych/gpu-alloc/pull/14
- https://github.com/zakarumych/gpu-alloc/issues/16

**Description**
Moves us to gpu-allocator, which should be simpler and better supported than gfx-memory.

**Testing**
Untested and unfinished (to be updated)

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-09 17:58:16 +00:00
Dzmitry Malyshau 22efbeae70 Replace gfx-memory by gpu-alloc 2020-11-09 12:16:34 -05:00
bors[bot]andDzmitry Malyshau ccc178a3d0 [rs] Merge #611
611: Match inputs/outputs in msaa-line shader r=kvark a=kvark

Note: this shouldn't be necessary, as the varyings are matched by location and not the name. However, spirv-cross doesn't try to fiddle with the varying names, so it fails if they are unmatched.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-09 14:31:28 +00:00
Dzmitry Malyshau b8f157f7df [rs] Match inputs/outputs in msaa-line shader 2020-11-09 09:27:51 -05:00
bors[bot]andZsolt Bölöny 8c386efb7c [rs] Merge #610
610: Rename TextureUsage::OUTPUT_ATTACHMENT to RENDER_ATTACHMENT r=kvark a=yzsolt

Depends on https://github.com/gfx-rs/wgpu/pull/1017 

Co-authored-by: Zsolt Bölöny <bolony.zsolt@gmail.com>
2020-11-09 14:03:43 +00:00
Zsolt Bölöny e6d7873844 [rs] Update dependencies 2020-11-09 13:50:06 +01:00
bors[bot]andZsolt Bölöny 789b09c7bd Merge #1017
1017: Rename output attachment usage r=grovesNL a=yzsolt

**Connections**
Implements #1001 

**Description**
Rename OUTPUT_ATTACHMENT texture usage to RENDER_ATTACHMENT to match the WebGPU spec

**Testing**
Ensure that `wgpu-rs` and `wgpu-native` build after the rename

**TODO**
- [ ] Update `wgpu-rs`
- [ ] Update `wgpu-native`

Co-authored-by: Zsolt Bölöny <bolony.zsolt@gmail.com>
2020-11-09 12:32:07 +00:00
Zsolt Bölöny 7c290fdd8d [rs] Rename TextureUsage::OUTPUT_ATTACHMENT to RENDER_ATTACHMENT 2020-11-09 10:35:55 +01:00
Zsolt Bölöny a493ed06d8 Rename OutputAttachment helper struct to RenderAttachment too to avoid confusion 2020-11-08 14:27:44 +01:00
Zsolt Bölöny 2151a252ad Rename TextureUsage::OUTPUT_ATTACHMENT to RENDER_ATTACHMENT 2020-11-08 14:24:39 +01:00
Dzmitry Malyshauandmonocodus[bot] 73d3f71caa Enable the non-fill polygon mode feature if requested (#1016)
* Enable the non-fill polygon mode feature if requested

* Update wgpu-core/src/instance.rs

Co-authored-by: monocodus[bot] <49363530+monocodus[bot]@users.noreply.github.com>

Co-authored-by: monocodus[bot] <49363530+monocodus[bot]@users.noreply.github.com>
2020-11-06 00:32:04 -05:00
Dzmitry Malyshau 6714c4fe7e Update players readme 2020-11-05 16:58:40 -05:00
bors[bot]andDzmitry Malyshau 6d8dfaca84 [rs] Merge #606
606: Enable GL backend r=kvark a=kvark

Replaces #182
Depends on https://github.com/gfx-rs/wgpu/pull/907

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-05 04:13:45 +00:00
bors[bot]andZicklag 4d378d6315 [rs] Merge #605
605: Enable X11 Support for the GL Backend r=kvark a=zicklag



Co-authored-by: Zicklag <zicklag@katharostech.com>
2020-11-05 04:05:27 +00:00
Dzmitry Malyshau 58d2b36d13 [rs] Enable GL backend 2020-11-04 23:02:01 -05:00
bors[bot]andZicklag 99ff41bb99 Merge #907
907: Implement OpenGL Backend For Unix Platforms r=kvark a=zicklag

**Connections**
Requires: https://github.com/gfx-rs/gfx/pull/3340 ( merged )
Should be merged first: https://github.com/gfx-rs/wgpu/pull/910
Works towards: https://github.com/gfx-rs/wgpu/issues/450

**Description**
Integrates the GFX GL backend for Unix platforms

**Testing**
Runs the basic cube and triangle examples  for wgpu-rs, but not without rendering artifacts on the cube.
<!--
Non-trivial functional changes would need to be tested through:
  - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples.
  - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity.

Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications.
See https://github.com/gfx-rs/wgpu/pull/666 for an example.
If you can add a unit/integration test here in `wgpu`, that would be best.
-->


Co-authored-by: Zicklag <zicklag@katharostech.com>
2020-11-05 02:54:37 +00:00
Zicklag f7f1ff699a Implement OpenGL Backend For Unix Platforms 2020-11-04 20:32:33 -06:00
Zicklag cd2e2cc61e [rs] Enable X11 Support for the GL Backend 2020-11-03 16:14:58 -06:00
Zicklag 7beb7c3411 Update For Latest GFX
Using a specific Git commit for now because it is unreleased.
2020-11-02 20:25:07 -06:00
Zicklag 165d7717b4 Add Error Message When Surface Creation Fails 2020-11-02 20:24:30 -06:00
7b9abf0fef Merge #1008
1008: Add helpers to convert passes to serialized forms r=grovesNL a=kvark

**Connections**
Stuff I needed to fix in the upcoming Gecko WebGPU update.

**Description**
It allows us to use the tracing `Command` more aggressively.

**Testing**
Tested in Gecko, doesn't need testing in wgpu

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
2020-11-02 23:15:03 +00:00
Dzmitry Malyshau 367735d085 Rename the lint to broken_intra_doc_links 2020-11-02 18:00:56 -05:00
bors[bot]andDzmitry Malyshau dd4a71d31d Merge #1012
1012: Check array layer counts r=cwfitzgerald a=kvark

**Connections**
Prevents https://github.com/gfx-rs/wgpu-rs/issues/601

**Description**
Follows the spec, yo!

**Testing**
Not tested, but not terribly complicated either.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-10-31 00:51:06 +00:00
Dzmitry Malyshau 5e1e3314cd Check array layer counts 2020-10-30 17:31:43 -04:00
Dzmitry Malyshau 6e3c7b359f Add missing license headers 2020-10-28 13:40:41 -04:00
Dzmitry Malyshau a168886497 Add helpers to convert passes to serialized forms 2020-10-27 13:19:05 -04:00
bors[bot]andConnor Fitzgerald c6c50e9670 Merge #1007
1007: Improve cubemap validation r=kvark a=cwfitzgerald

**Connections**

Closes #952.

**Description**

We were missing depth-size and texture dimension validation when creating Cubemap and CubemapArray views.

I split the depth-size errors so I can give a more helpful error message in both cases.

**Testing**

Tested on the skybox example when made intensionally incorrect.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-10-26 03:16:31 +00:00
Connor Fitzgerald dcc14fe645 Improve cubemap validation 2020-10-25 17:14:14 -04:00
bors[bot]andMarvin Löbel 6c519e0d92 Merge #1000
1000: Elide redundant set_pipeline calls. r=kvark a=Kimundi

**Description**
This adds an check in each `set_pipeline()` call for wether the same pipeline id has already been set previously. This should cause free performance wins for suboptimal usage of the wgpu API, while having neglible overhead otherwise.

An example scenario for where this would be useful is a game that just blindly sets all render state for each object, but has few actually different objects:

```rust
for game_obj in game_objs {
    rpass.set_pipeline(...);
    rpass.set_bind_group(...);
    rpass.set_vertex_buffer(...);
    rpass.draw(...);
}
```

**Testing**
Ideally we would have tests that check that pipeline changes have been ellided, but I'm not sure how to write them in the current codebase.

**Future work**
- We could extend this kind of redundant state change detection to most `.set_*` methods on `RenderPass`es.
- If we want to guarantee this behavior in the API, we should also document it.

Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-10-22 17:18:24 +00:00
bors[bot]andMarvin Löbel bcaae6a962 [rs] Merge #598
598: Clarify docs for Queue::write methods r=kvark a=Kimundi



Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-10-22 16:17:26 +00:00
Marvin Löbel 9073d18c70 [rs] Clarify docs for Queue::write methods 2020-10-22 17:40:23 +02:00