Commit Graph
9013 Commits
Author SHA1 Message Date
Dzmitry Malyshau 6c1832c8ee [spv-out] be smarter about deriving capabilities, auto derive them for tests 2021-05-19 02:01:25 -04:00
bors[bot]andDzmitry Malyshau 7ce535cc97 Merge #1402
1402: Check render target aspects r=kvark a=kvark

**Connections**
Reported on Matrix by "m4b"

**Description**
Passing a depth texture as a color attachment results in:
> Validation Error: [ VUID-vkCmdBeginRenderPass-initialLayout-00895 ] Object 0: handle = 0x280000000028, name = ShadowTexture, type = VK_OBJECT_TYPE_IMAGE; Object 1: handle = 0x3020000000302, type = VK_OBJECT_TYPE_RENDER_PASS; Object 2: handle = 0x3030000000303, type = VK_OBJECT_TYPE_FRAMEBUFFER; Object 3: handle = 0x2b000000002b, type = VK_OBJECT_TYPE_IMAGE_VIEW; | MessageID = 0x34f84ef4 | vkCmdBeginRenderPass(): Layout/usage mismatch for attachment 0 in VkRenderPass 0x3020000000302[] - the color attachment layout is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL but the image attached to VkFramebuffer 0x3030000000303[] via VkImageView 0x2b000000002b[] was not created with VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT The Vulkan spec states: If any of the initialLayout or finalLayout member of the VkAttachmentDescription structures or the layout member of the VkAttachmentReference structures specified when creating the render pass specified in the renderPass member of pRenderPassBegin is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL then the corresponding attachment image view of the framebuffer specified in the framebuffer member of pRenderPassBegin must have been created with a usage value including VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-vkCmdBeginRenderPass-initialLayout-00895)

**Testing**
Just ran wgpu-rs examples

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-19 04:53:42 +00:00
Dzmitry Malyshau ab78f3cf16 Check render target aspects 2021-05-19 00:42:20 -04:00
Gordon-F 6b3db1f487 [glsl-out] Write vector access as a swizzle 2021-05-19 00:09:12 -04:00
Jim Blandy 5753f6e107 [wgsl-in] Improve error message for UnknownIdent. 2021-05-19 00:07:39 -04:00
bors[bot]andDzmitry Malyshau 6ac8d8a728 Merge #1401
1401: Make player automatically start/stop the capture r=kvark a=kvark

**Connections**
Follow-up to #1301

**Description**
Replaying compute-based workloads, or Gecko-based API traces, always wants to auto-capture everything.
This PR makes it the default.

**Testing**
Tested on a real Gecko capture :)

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-18 21:43:23 +00:00
Dzmitry Malyshau 19dfcd93ca Make player automatically start/stop the capture 2021-05-18 17:42:49 -04:00
Jim Blandy 4e3dc41f3f [wgsl-in] Use Cow<str> in wgsl::ParseError. 2021-05-18 13:35:59 -04:00
Jim Blandy 8246287561 [dot-out] Take advantage of Cow's implementation of From<String>. 2021-05-18 13:35:59 -04:00
Gordon-F b4aa966575 [wgsl-out] Create baking expression for texture function 2021-05-18 13:33:25 -04:00
bors[bot]andIan Gowen 7a43516943 [rs] Merge #914
914:  Change the texture sample type for the cube example from Float to Uint r=kvark a=igowen

this is a rework of #764. i think wgpu supports everything we need for this now!



Co-authored-by: Ian Gowen <ian@gowen.cc>
2021-05-18 14:42:04 +00:00
Ian Gowen 29b1df51fc [rs] Change the texture sample type for the cube example from Float to Uint, and move the mandelbrot->color mapping functionality from the texel generation code to the fragment shader. 2021-05-18 10:33:15 -04:00
Dzmitry Malyshau 96ec0b61e7 Snapshot for built-ins 2021-05-18 10:01:14 -04:00
Dzmitry Malyshau 8b60171403 [glsl-out] emit sample variables extension 2021-05-18 10:01:14 -04:00
Dzmitry Malyshau 1f53ff1d1e [spv-in] fix emitted expressions for ImageStore 2021-05-18 10:01:14 -04:00
bors[bot]andConnor Fitzgerald 09f8f8dfb6 Merge #1399
1399: Fix segfault caused by improper drop order r=kvark a=cwfitzgerald

**Connections**

Closes #1398 

**Description**

The disabled dtor of the global hub was causing the incorrect drop order causing devices to be dropped before instances.

**Testing**

Tested against up and coming testing code.


Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-05-18 05:48:15 +00:00
Connor Fitzgerald be5adfa584 Fix segfault caused by improper drop order 2021-05-18 01:47:24 -04:00
bors[bot]andDzmitry Malyshau 1cd4ad7cfe Merge #1393
1393: Fix dynamic stencil reference for Replace ops r=cwfitzgerald a=kvark

**Connections**
Fixes an issue reported on Matrix, where we'd not set the stencil reference.

**Description**
Our conditions didn't check the Replace ops.

**Testing**
Untested, YOLO

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-05-18 00:30:51 +00:00
Jim Blandy 0985727710 [wgsl-in] Include span information in 'unknown identifier' errors. 2021-05-17 19:46:37 -04:00
Jim Blandy 0e3a7840ff [wgsl-in]: Report unknown identifiers as Error::UnknownIdent.
Move the parsing of type construction expressions into a function of its own,
which can return `None` when the identifier at hand is not the name of a type.
This means that `parse_primary_expression` doesn't have to commit to
interpreting the expression as a type construction too early, allowing it to
report unknown identifiers as Error::UnknownIdent.
2021-05-17 19:46:37 -04:00
Dzmitry Malyshau e24e8f643c Fix dynamic stencil reference for Replace ops 2021-05-17 18:42:42 -04:00
bors[bot]andDzmitry Malyshau 13f2ca571c Merge #1391
1391: Simplify features r=cwfitzgerald a=kvark

**Connections**
Fixes #1390
Makes vertex writable storage optional (native-only for now)
Fixes the follow-up to #891 

**Description**
Refactors the code so that adding new features and maintaining current ones is much easier.
Refactors the way missing features are checked and reported, DRY way.

**Testing**
Not really tested

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-17 19:03:59 +00:00
Dzmitry Malyshau 51c7963195 Use the same MissingFeatures error everywhere 2021-05-17 14:20:17 -04:00
Dzmitry Malyshau 163b11db42 Validate the writable storage feature 2021-05-17 14:19:49 -04:00
Dzmitry Malyshau a06d277d40 Simplify feature selection 2021-05-17 14:11:48 -04:00
Dzmitry Malyshau f0a145d0fa Add VERTEX_WRITABLE_STORAGE feature, refactor the sample border 2021-05-17 14:09:02 -04:00
Dzmitry Malyshau b191c982ec Remove alignment from struct IR 2021-05-17 09:32:52 -04:00
Gordon-F 6efe347e90 [wgsl-out] Implement all math functions. Rename entry point function based on stage. Rename entry point output struct. 2021-05-14 18:14:23 -04:00
Gordon-F 5958f98489 [wgsl-out] Enable snapshot testing for wgsl-in image test 2021-05-14 18:12:02 -04:00
Dzmitry Malyshau 77a20d0017 Update CHANGELOG for v0.4.1 2021-05-14 10:21:55 -04:00
Dzmitry Malyshau 418e71281e Derivative tests 2021-05-14 09:53:24 -04:00
bors[bot]andDzmitry Malyshau 2a7e07d94f [rs] Merge #909
909: Update naga to gfx-25 r=kvark a=kvark

Gets us arrayLength() in MSL

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-14 04:23:09 +00:00
Dzmitry Malyshau 2a0ea1d94b [rs] Update naga to gfx-25 2021-05-14 00:22:28 -04:00
bors[bot]andDzmitry Malyshau 53eab747a3 Merge #1381
1381: Update naga to gfx-25 r=kvark a=kvark

**Connections**
Fixes #1362
Picks up https://github.com/gfx-rs/gfx/pull/3752 and https://github.com/gfx-rs/gfx/pull/3758

**Description**
Updates gfx and Naga. Hooks up the new validation capabilities.

**Testing**
Self-testing.

Note: this PR doesn't currently work because Metal's backend is now required use a sizes buffer when dynamically sized arrays are present. One of the internal tests here uses them.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-14 03:57:13 +00:00
Dzmitry Malyshau e00251d3e3 Update naga to gfx-25 2021-05-13 23:56:26 -04:00
Jim Blandy 057d03ad86 [wgsl-in]: Add tests for array and struct validation. 2021-05-13 22:09:22 -04:00
Jim Blandy 9c5f324de2 TypeInner::span: Tolerate bad array length constants for now. 2021-05-13 22:09:22 -04:00
Jim Blandy f45d812266 [wgsl-in]: Move WGSL front end integration tests into a WGSL-specific file.
This lets us reduce noise by removing a bunch of `#[cfg]` attributes. In the
future, if we have tests for other front ends, we can create an `errors`
subdirectory, but for now, we only have the WGSL tests, so we should keep things
flat.
2021-05-13 22:09:22 -04:00
Matúš Talčík 5e5d64291d [spv-in] fix handling of break blocks (borrowed from Tint) 2021-05-13 22:08:06 -04:00
Dzmitry Malyshau a8df6a2b34 [msl] make sizes buffer local to each function 2021-05-13 22:02:37 -04:00
Dzmitry Malyshau 0250ffe2fb [msl] early out if the binding sizes are missing 2021-05-13 00:42:15 -04:00
Igor Shaposhnik 6a42e4a0f8 [wgsl-out] Enable snapshot testing for spv-in quad shader 2021-05-12 15:15:50 -04:00
bors[bot]andConner Bryan 6ffd4d94ab Merge #1385
1385: fix typo in PowerPreference::LowPower description r=cwfitzgerald a=cab

**Description**
Fixes a typo in the description of `PowerPreference::LowPower`.

**Testing**
None

Co-authored-by: Conner Bryan <conner@amps.io>
2021-05-11 23:22:19 +00:00
Conner Bryan eda7031f35 fix typo in PowerPreference::LowPower description 2021-05-11 19:10:06 -04:00
Dzmitry Malyshau 58b83f3ff6 Add extern-C on wgpu_render_pass_execute_bundles 2021-05-11 15:00:49 -04:00
Dzmitry Malyshau f861e83df1 Fix wgpu_render_bundle_draw_indexed_indirect 2021-05-11 15:00:49 -04:00
Dzmitry Malyshau 0135e02ff6 Re-enable bors 2021-05-11 15:00:41 -04:00
bors[bot]andConnor Fitzgerald 5b4623a112 [rs] Merge #907
907: Add feature request for wgpu-rs r=kvark a=cwfitzgerald

Thanks @JMS55 for bringing this to my attention in #906 

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-05-10 03:30:47 +00:00
Connor Fitzgerald 12f851c7b2 [rs] Add feature request for wgpu-rs 2021-05-09 17:57:43 -04:00
bors[bot]andConnor Fitzgerald b8c5b7ad97 [rs] Merge #905
905: Fill Out Issue Templates r=kvark a=cwfitzgerald

This adds issue templates, as well as links to the wgpu-core tracker and the discussion board. Hopefully this should reduce the amount of issues we have to transfer.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-05-09 04:10:49 +00:00