1402: Check render target aspects r=kvark a=kvark
**Connections**
Reported on Matrix by "m4b"
**Description**
Passing a depth texture as a color attachment results in:
> Validation Error: [ VUID-vkCmdBeginRenderPass-initialLayout-00895 ] Object 0: handle = 0x280000000028, name = ShadowTexture, type = VK_OBJECT_TYPE_IMAGE; Object 1: handle = 0x3020000000302, type = VK_OBJECT_TYPE_RENDER_PASS; Object 2: handle = 0x3030000000303, type = VK_OBJECT_TYPE_FRAMEBUFFER; Object 3: handle = 0x2b000000002b, type = VK_OBJECT_TYPE_IMAGE_VIEW; | MessageID = 0x34f84ef4 | vkCmdBeginRenderPass(): Layout/usage mismatch for attachment 0 in VkRenderPass 0x3020000000302[] - the color attachment layout is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL but the image attached to VkFramebuffer 0x3030000000303[] via VkImageView 0x2b000000002b[] was not created with VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT The Vulkan spec states: If any of the initialLayout or finalLayout member of the VkAttachmentDescription structures or the layout member of the VkAttachmentReference structures specified when creating the render pass specified in the renderPass member of pRenderPassBegin is VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL then the corresponding attachment image view of the framebuffer specified in the framebuffer member of pRenderPassBegin must have been created with a usage value including VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-vkCmdBeginRenderPass-initialLayout-00895)
**Testing**
Just ran wgpu-rs examples
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1401: Make player automatically start/stop the capture r=kvark a=kvark
**Connections**
Follow-up to #1301
**Description**
Replaying compute-based workloads, or Gecko-based API traces, always wants to auto-capture everything.
This PR makes it the default.
**Testing**
Tested on a real Gecko capture :)
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
914: Change the texture sample type for the cube example from Float to Uint r=kvark a=igowen
this is a rework of #764. i think wgpu supports everything we need for this now!
Co-authored-by: Ian Gowen <ian@gowen.cc>
1399: Fix segfault caused by improper drop order r=kvark a=cwfitzgerald
**Connections**
Closes#1398
**Description**
The disabled dtor of the global hub was causing the incorrect drop order causing devices to be dropped before instances.
**Testing**
Tested against up and coming testing code.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
1393: Fix dynamic stencil reference for Replace ops r=cwfitzgerald a=kvark
**Connections**
Fixes an issue reported on Matrix, where we'd not set the stencil reference.
**Description**
Our conditions didn't check the Replace ops.
**Testing**
Untested, YOLO
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Move the parsing of type construction expressions into a function of its own,
which can return `None` when the identifier at hand is not the name of a type.
This means that `parse_primary_expression` doesn't have to commit to
interpreting the expression as a type construction too early, allowing it to
report unknown identifiers as Error::UnknownIdent.
1391: Simplify features r=cwfitzgerald a=kvark
**Connections**
Fixes#1390
Makes vertex writable storage optional (native-only for now)
Fixes the follow-up to #891
**Description**
Refactors the code so that adding new features and maintaining current ones is much easier.
Refactors the way missing features are checked and reported, DRY way.
**Testing**
Not really tested
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1381: Update naga to gfx-25 r=kvark a=kvark
**Connections**
Fixes#1362
Picks up https://github.com/gfx-rs/gfx/pull/3752 and https://github.com/gfx-rs/gfx/pull/3758
**Description**
Updates gfx and Naga. Hooks up the new validation capabilities.
**Testing**
Self-testing.
Note: this PR doesn't currently work because Metal's backend is now required use a sizes buffer when dynamically sized arrays are present. One of the internal tests here uses them.
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This lets us reduce noise by removing a bunch of `#[cfg]` attributes. In the
future, if we have tests for other front ends, we can create an `errors`
subdirectory, but for now, we only have the WGSL tests, so we should keep things
flat.
1385: fix typo in PowerPreference::LowPower description r=cwfitzgerald a=cab
**Description**
Fixes a typo in the description of `PowerPreference::LowPower`.
**Testing**
None
Co-authored-by: Conner Bryan <conner@amps.io>
907: Add feature request for wgpu-rs r=kvark a=cwfitzgerald
Thanks @JMS55 for bringing this to my attention in #906
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
905: Fill Out Issue Templates r=kvark a=cwfitzgerald
This adds issue templates, as well as links to the wgpu-core tracker and the discussion board. Hopefully this should reduce the amount of issues we have to transfer.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>