Commit Graph
9013 Commits
Author SHA1 Message Date
Dzmitry Malyshau 77a64da189 [spv-out] support function arguments as pointers 2021-04-24 01:54:48 -04:00
Dzmitry Malyshau 34b830da17 [spv-in] work around sign differences in OpIAdd and OpISubtract 2021-04-24 01:00:33 -04:00
Dzmitry Malyshau 64856a808e [spv-in] refactor image coordinate extraction 2021-04-24 00:12:31 -04:00
João Capucho 7135c051b4 [glsl-in] Support for function parameters with In 2021-04-23 22:15:16 -04:00
João Capucho 2b8b5a271d [glsl-in] Implement textureLod 2021-04-23 22:15:16 -04:00
João Capucho 62e3ba4bcc [glsl-in] Fix type constructor of vec/matrix 2021-04-23 22:15:16 -04:00
João Capucho 6247f2c822 [glsl-in] Load local variables 2021-04-23 22:15:16 -04:00
João Capucho 076349ddf7 [glsl-in] Export types to allow for error handling 2021-04-23 22:15:16 -04:00
Dzmitry Malyshau 74f0a153cb Rename the binary to just naga 2021-04-23 20:14:16 -04:00
Gordon-F b6996dbd32 Return error exit code if validation fails 2021-04-23 16:36:49 -04:00
Gordon-F 3accf4dc15 Improve wgsl-out 2021-04-23 16:36:49 -04:00
bors[bot]anddzil123 cd7ba87a2c [rs] Merge #876
876: Derive Default for PipelineLayoutDescriptor r=kvark a=dzil123



Co-authored-by: dzil123 <5725958+dzil123@users.noreply.github.com>
2021-04-23 17:28:06 +00:00
Dzmitry Malyshau 02105db045 [spv-out] image queries (#749) 2021-04-23 12:31:33 -04:00
Ashley 36bace2b41 Set is_scoped to false when evaluating a swizzle subexpression (#761) 2021-04-23 11:53:07 -04:00
dzil123 360c3b3352 [rs] Derive Default for PipelineLayoutDescriptor 2021-04-23 03:49:36 -07:00
Dzmitry Malyshau 0725417193 Allow indexing value pointers (#758) 2021-04-23 01:19:48 -04:00
Dzmitry Malyshau 0917e3740b [msl] don't use sample level on 1D textures (#757) 2021-04-23 01:15:04 -04:00
Dzmitry Malyshau b15a23c61f [spv-in] fix integer constants parsing (#756) 2021-04-23 01:05:10 -04:00
bors[bot]andDzmitry Malyshau adfa1245d8 Merge #1351
1351: Hard error on SPIRV parsing failure when VALIDATION is requested r=cwfitzgerald a=kvark

**Connections**
Follow-up from https://github.com/gfx-rs/wgpu/issues/1350#issuecomment-825186159

**Description**
If the user provided SPIR-V, and they requested VALIDATION, and we fail to parse the file - there is no point to proceed.
VALIDATION flag should be a gaurantee of safe operation, so we can't just throw the same SPIR-V at SPIRV-Cross and pretend that it's ok.

**Testing**
Tested on noclip shaders

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-04-22 23:21:39 +00:00
Dzmitry Malyshau 525efda7b2 Hard error on SPIRV parsing failure when VALIDATION is requested 2021-04-22 17:18:16 -04:00
Dzmitry Malyshau f0cf6a6772 [spv-in] support OpModuleProcessed (#753) 2021-04-22 14:43:14 -04:00
Dzmitry Malyshau 24eaad10fc Follow up on the swizzle PR review notes (#750) 2021-04-22 11:17:44 -04:00
bors[bot]andDiggory Hardy 7058299954 [rs] Merge #873
873: Boids example: cleaner rand code r=kvark a=dhardy

... for a certain definition of cleaner. Is this clearer or just more confusing?

Co-authored-by: Diggory Hardy <git@dhardy.name>
2021-04-22 13:50:05 +00:00
Diggory Hardy 935b06f3dd [rs] Boids example: cleaner rand code 2021-04-22 10:31:10 +01:00
Dzmitry Malyshau a2e5284f82 WGSL trailing commas (#743)
* [wgsl-in] typedef Span

* [wgsl-in] trailing comma for case list

* [wgsl-in] trailing comma for constructors

* Review fixes
2021-04-21 22:38:26 -04:00
bors[bot]andgrovesNL 704d5d00b6 [rs] Merge #872
872: Remove zero padding from `create_buffer_init` r=kvark a=grovesNL

Follow-up to #870 (https://github.com/gfx-rs/wgpu-rs/pull/870#issuecomment-824333926)

Co-authored-by: grovesNL <josh@joshgroves.com>
2021-04-22 02:20:05 +00:00
grovesNL 73e7553df4 [rs] Remove zero padding from create_buffer_init
The buffer should already be zeroed so zeroing shouldn't be necessary
2021-04-21 23:03:40 -02:30
bors[bot]andDzmitry Malyshau fe07d272b1 Merge #1348
1348: Change error type for the backend shader r=kvark a=kvark

**Connections**
Fixes #1347

**Description**
Issues a better error for this case

**Testing**
Should work

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-21 21:07:49 +00:00
Dzmitry Malyshau bc4c5c8f03 Change error type for the backend shader 2021-04-21 17:06:58 -04:00
bors[bot]andDiggory Hardy 64ac552a9a [rs] Merge #870
870: Remove dead code r=kvark a=dhardy

Also, why bother setting the padding bytes to 0?

Co-authored-by: Diggory Hardy <git@dhardy.name>
2021-04-21 18:04:32 +00:00
Diggory Hardy d14d3b5cbd [rs] Remove dead code 2021-04-21 17:26:36 +01:00
Dzmitry Malyshau bc344579e8 [spv-in] fix signed/unsigned casting for builtins (#746) 2021-04-21 11:04:53 -04:00
Dzmitry Malyshau b86c2fbeeb Don't print the module in converter if no output is specified (#744) 2021-04-21 09:40:29 -04:00
Ashley 4664cd301a [Metal] Wrap a packed_float3 with float3 when loading from struct (#740)
* Implement the wrapping in Expression::Load instead

* Add changes to stack size

* stable and nightly can't seem to agree on a stack size

* Apply suggestions

* Add a comment about unexpected path

* Update skybox snapshot

* should_pack_struct_member returns an Option<ScalarKind>

* Remove accidental file
2021-04-21 09:16:11 -04:00
Dzmitry Malyshau 5d1746b0b4 Swizzle expression (#734) 2021-04-20 22:03:54 -04:00
bors[bot]andDzmitry Malyshau 43798a502f Merge #1346
1346: Make implicit ids actually errors to start with r=kvark a=kvark

**Connections**
Follow-up to #1341

**Description**
Turns out, leaving the indices `Vacant` is also not an option, since the `hub.rs` code considers this an internal error (unexpected), and panics.

**Testing**
Tested on Austin's examples in Gecko

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-04-20 21:35:12 +00:00
Dzmitry Malyshau 8505a39f6a Make implicit ids actually errors to start with 2021-04-20 17:32:40 -04:00
Ashley b08dfe5146 [Metal] Impl Expression::Splat (#738)
* [Metal] Impl `Expression::Splat`

* Add changes to the snapshots

* Apply suggestions
2021-04-20 11:41:13 -04:00
bors[bot]andDzmitry Malyshau 8704a6e3b5 Merge #1342
1342: Update gfx to the new image view API r=kvark a=kvark

**Connections**
Grabs https://github.com/gfx-rs/gfx/pull/3725 and https://github.com/gfx-rs/gfx/pull/3726
Addresses https://github.com/gfx-rs/wgpu-rs/discussions/868#discussioncomment-633648

**Description**
Updates gfx, also improves the error messages for pipeline creation a bit.

**Testing**
Not really, this is low-risk.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-20 15:11:07 +00:00
Ashley Ruglys a4ac7b38b2 Don't use an interpolation on fake bindings 2021-04-20 10:51:45 -04:00
Dzmitry Malyshau cc2e547d48 Update gfx to the new image view API 2021-04-20 10:16:30 -04:00
bors[bot]andDzmitry Malyshau 9c47ae6183 Merge #1332
1332: Validate min/max blending factors r=kvark a=kvark

**Connections**
Based on #1325 
Matches https://github.com/gpuweb/gpuweb/pull/1635

**Description**
This PR refactors the color state errors, giving them more detailed context, and having a dedicated enum for them.
It also adds the check for the blend factors to be (1, 1) for the min/max operations.

**Testing**
Untested

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-20 13:37:39 +00:00
Dzmitry Malyshau cac643507b Validate min/max blending factors 2021-04-20 09:37:07 -04:00
Gordon-F c37ae5e2a0 [glsl-out] Use fmt::Writer instead of io::Writer 2021-04-20 09:09:35 -04:00
Gordon-F 446f5dad6f [hlsl-out] Use fmt::Writer instead of io::Writer 2021-04-20 09:09:35 -04:00
bors[bot]andDzmitry Malyshau 8239307bcb Merge #1341
1341: Mark unused implicit BGL ids as vacant r=kvark a=kvark

**Connections**
Fixes https://github.com/gfx-rs/wgpu/issues/1340

**Description**
This is not an ideal solution. We aren't marking the IDs as errors. But it's an improvement, and it resolves the crash in FF, supposedly.

**Testing**
Tested on wgpu-rs examples with implicit layouts

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-20 03:42:28 +00:00
Dzmitry Malyshau de86f2a72f Mark unused implicit BGL ids as vacant 2021-04-19 23:35:33 -04:00
bors[bot]andDzmitry Malyshau 5d30d910a0 [rs] Merge #866
866: Update gfx and naga to gfx-22 r=kvark a=kvark

See https://github.com/gfx-rs/wgpu/pull/1339

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-19 22:15:51 +00:00
Dzmitry Malyshau 1ada1d8d24 [rs] Update gfx and naga to gfx-22 2021-04-19 18:15:14 -04:00
bors[bot]andDzmitry Malyshau 523ef2dfec Merge #1339
1339: Update naga to gfx-22, add interpolation sampling validation r=kvark a=kvark

**Connections**
Includes https://github.com/gfx-rs/gfx/pull/3729, https://github.com/gfx-rs/gfx/pull/3719, https://github.com/gfx-rs/naga/pull/689, https://github.com/gfx-rs/naga/pull/700, and other fixes

**Description**
Update gfx and naga to latest (gfx-22 tag).
The hope is for this to be the last tag release before 0.8

**Testing**
Tested on wgpu-rs examples

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-19 17:40:24 +00:00