1351: Hard error on SPIRV parsing failure when VALIDATION is requested r=cwfitzgerald a=kvark
**Connections**
Follow-up from https://github.com/gfx-rs/wgpu/issues/1350#issuecomment-825186159
**Description**
If the user provided SPIR-V, and they requested VALIDATION, and we fail to parse the file - there is no point to proceed.
VALIDATION flag should be a gaurantee of safe operation, so we can't just throw the same SPIR-V at SPIRV-Cross and pretend that it's ok.
**Testing**
Tested on noclip shaders
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
873: Boids example: cleaner rand code r=kvark a=dhardy
... for a certain definition of cleaner. Is this clearer or just more confusing?
Co-authored-by: Diggory Hardy <git@dhardy.name>
1348: Change error type for the backend shader r=kvark a=kvark
**Connections**
Fixes#1347
**Description**
Issues a better error for this case
**Testing**
Should work
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
* Implement the wrapping in Expression::Load instead
* Add changes to stack size
* stable and nightly can't seem to agree on a stack size
* Apply suggestions
* Add a comment about unexpected path
* Update skybox snapshot
* should_pack_struct_member returns an Option<ScalarKind>
* Remove accidental file
1346: Make implicit ids actually errors to start with r=kvark a=kvark
**Connections**
Follow-up to #1341
**Description**
Turns out, leaving the indices `Vacant` is also not an option, since the `hub.rs` code considers this an internal error (unexpected), and panics.
**Testing**
Tested on Austin's examples in Gecko
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
1332: Validate min/max blending factors r=kvark a=kvark
**Connections**
Based on #1325
Matches https://github.com/gpuweb/gpuweb/pull/1635
**Description**
This PR refactors the color state errors, giving them more detailed context, and having a dedicated enum for them.
It also adds the check for the blend factors to be (1, 1) for the min/max operations.
**Testing**
Untested
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1341: Mark unused implicit BGL ids as vacant r=kvark a=kvark
**Connections**
Fixes https://github.com/gfx-rs/wgpu/issues/1340
**Description**
This is not an ideal solution. We aren't marking the IDs as errors. But it's an improvement, and it resolves the crash in FF, supposedly.
**Testing**
Tested on wgpu-rs examples with implicit layouts
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>