Commit Graph
9013 Commits
Author SHA1 Message Date
João Capucho 54c3f5190c glsl-in: Fix panic when culling nested block (#1714)
Under certatin circumstances the parser would panic because of culling
using an index out of bound, for example take the following code:

```glsl
{
    x = 1; // Index 0 on nested block
    discard; // Index 1 on nested block
} // Index 0 on block
```

The parser seeing this would attempt to cull the block using the start
index of 1 which would be out of bound and panic. Now instead the nested
block properly does it's internal culling and the outer block culls
everything after the nested block only.
2022-02-04 14:21:16 -05:00
Robert Swain 5e2c2f8687 Fix M1 in macOS incorrectly reports supported compressed texture formats (#2453)
* Metal: Correctly identify ASTC and EAC/ETC2 support

* Metal: Correctly expose ASTC / BC / EAC/ETC2 compressed texture support

* Metal: Only call supports_family when supported, and use Apple6 for ASTC check
2022-02-04 14:11:08 -05:00
Leo Kettmeir e903a2b2dc full errors (#2454) 2022-02-04 14:09:25 -05:00
francesco-cattoglio b235973d2e Add support for vecN<i32> and vecN<u32> to dot() function (#1689)
* Allow vecN<i32> and vecN<u32> in `dot()`, first changes

* Added a test case

* Fix the test

* Changes to baking of expressions, incl args of integer dot product

* Implemented requested changes for glsl backend

* Added support for integer dot product on MSL backend

* Removed outdated code for hlsl and wgls writers

* Implement in spv backend

* Commit modified outputs from running the tests

* cargo fmt

* Applied requested changes for both MSL and GLSL back

* Changes to spv back

* Committed all test output changes

* Cargo fmt

* Added a comment w.r.t. VK_KHR_shader_integer_dot_product

* Implemented requested svp change

* Minor change to test case

This is because I wanted to highlight the fact that the correct
id is used in the last sum of the integer dot product expression

* Changed function signature

since it could not fail, changed it to simply return `void`
2022-02-03 14:03:43 -05:00
Noel Tautges 42bf3545c9 Standardize some docs (#1660)
* Rewrite front/back doc summaries

- Use line comments instead of block comments
- Standardize language for each front/backend
- Add reference link for each format
- Minor punctuation changes

* Add documentation for keywords module

* Clarify contents of keywords module in summary

* Refer to modules by their type name

* Add basic summary for valid module

* Adjust EarlyDepthTest and ConservativeDepth docs

* Remove "in" from list

* Adjust wording

* Standardize format of docstrings

* Adjust module links to be consistent with other links

* Add summary for reserved keywords list

* Remove extraneous doc spaces with `cargo fmt`

* Correct spelling of whether and rewrite some lines

* Fill out GLSL backend docs

* Remove unnecessary link targets

* Fill out DOT backend docs

* Change module line comments to block comments

* Remove unnecessary spaces

* Fix mistake during rebasing
2022-02-03 13:27:21 -05:00
Taylor Holliday f63003cd36 WGSL storage address space should always correspond to MSL device add… (#1711)
* WGSL storage address space should always correspond to MSL device address space.

See MSL spec section 4.2.

* Update baselines

* Add error for storage address space if MSL version < 2.

* Update default MSL version to 2.0.
2022-02-03 13:00:04 -05:00
Dzmitry Malyshau 9b89c5fa89 Improve error messages about address space 2022-02-02 12:42:29 -05:00
Dzmitry Malyshau 75692d3795 Allow non-structure buffer types 2022-02-02 10:08:20 -05:00
Leo Kettmeir e50b62fae4 dont panic when submitting same commandbuffer multiple times (#2449) 2022-02-02 08:52:08 -05:00
glalonde bb604fd6a3 Mitigation for MSL atomic bounds check. (#1703)
[msl-out] Correct output for bounds-checked atomic accesses.
2022-02-01 16:37:09 -08:00
Connor Fitzgerald 63dfd98d68 Improve some error messages (#2446)
* Fix render target mismatch error message

* Reword bind group layout mismatch error
2022-02-01 18:51:48 -05:00
Jinlei Li b10f7ed407 Make shadow example runnable on iOS Android devices (#2433) 2022-02-01 18:08:35 -05:00
Leo Kettmeir 23fab7ab0a clean up features in deno (#2445) 2022-02-01 18:06:07 -05:00
Dzmitry Malyshau 2ddc8d1929 Rename StorageClass to AddressSpace 2022-01-31 16:25:06 -05:00
rhysd d6f8958b34 wgsl: Do not make error output colorful when the terminal is dumb 2022-01-29 08:52:36 -05:00
rhysd f98053aa3c cli: Include file path in WGSL parse error 2022-01-29 08:52:15 -05:00
Robert Swain 766c6cda19 Identify Apple M1 GPU as integrated (#2429)
* Identify Apple M1 GPU as integrated

* metal: Call has_unified_memory conditional on OS version

Fall back to current low_power implies integrated GPU for older OSes.
2022-01-28 18:40:26 -05:00
rhysd 0afa8fcb4f cli: Add --version flag 2022-01-28 12:16:00 -05:00
Dzmitry Malyshau 9219489894 hal/gles: fix dirty vertex buffers that are unused 2022-01-28 01:07:56 -05:00
Jim Blandy 36ce638381 IdentityManager: from_index method is unneeded.
The `min_index` parameter has no useful effect. Because the range 0..n is pushed
on the free list, index values less than `min_index` do get allocated.

Document `IdentityManager` and `TypedId`.
2022-01-28 01:03:15 -05:00
Jinlei Li 9cff141d7f Add MULTISAMPLED_SHADING downlevel flag (#2425)
* Fix msaa-line example's unnecessary MSAA data store

* Add MULTISAMPLED_SHADING downlevel flag
2022-01-27 23:29:40 -05:00
Alexander Guryanov b19000367c feature: emscripten 2022-01-27 14:14:29 -05:00
rhysd 6842db4432 cli: Support reading input from stdin 2022-01-27 12:59:01 -05:00
Connor Fitzgerald f5d97cae84 Adjust MSL version invariant needs 2022-01-25 13:25:48 -05:00
Dzmitry Malyshau a782592af3 msl: emit point size even when there is no struct 2022-01-25 11:24:58 -05:00
Jinlei Li 77b2c25684 Fix msaa-line example's unnecessary MSAA data store 2022-01-25 09:09:06 -05:00
Dzmitry Malyshau 4c91abe5b3 wgsl: remove stride 2022-01-24 16:44:12 -05:00
Jim Blandy f61ac3e73e Document proc::layouter.
Rename `TypeLayoutError` to `LayoutErrorInner`, for consistency. It makes no
sense to have 'Type' in the name of one of the error types but not the other.
The 'Inner' convention is used by the module types.

Cite the layout rules in the WGSL spec, not a GitHub issue.
2022-01-24 16:43:54 -05:00
Connor Fitzgerald f36cfb93dc glsl: floatBitsToUint spelling 2022-01-24 10:36:26 -05:00
Dzmitry Malyshau aea427fa92 msl: add invariance if supported 2022-01-24 09:59:45 -05:00
Connor Fitzgerald 39a0256bcb Properly set msl version to 2.3 if supported 2022-01-24 09:41:53 -05:00
Lucas Kent effcf0874f Get cargo-run-wasm from crates.io (#2415) 2022-01-23 00:26:04 +00:00
João Capucho dcd07f0391 Update to upstream naga 2022-01-22 18:36:26 -05:00
João Capucho 83d0d16177 hal/gl: Allow push constants trough emulation
Uses freestanding uniforms for push constants
2022-01-22 18:36:26 -05:00
João Capucho 81dc67402a glsl-out: push constants use anonymous uniforms
Previously this was done with UBOs but this posed some problems when
integrating with wgpu (see https://github.com/gfx-rs/wgpu/pull/2400)
2022-01-21 21:13:12 -05:00
francesco-cattoglio 8647e06b72 glsl-out: Call proper memory barrier functions (#1680)
* glsl-out: Call proper memory barrier functions

* glsl-out: Change test for control flow

* Removed two unnecessary calls
2022-01-21 15:34:44 +00:00
Dzmitry Malyshau f3891fed33 hal/dx12: improve RowPitch computation (#2409) 2022-01-20 19:59:25 -05:00
Dzmitry Malyshau 4bd1efc34d wgsl: declare attribtues with @ 2022-01-20 19:44:05 -05:00
Shota Hamada 299e6f443b Make execute_bundles() receives IntoIterator (#2410) 2022-01-20 16:14:41 +00:00
Dávid Kocsis adc6821751 implement block comments (#1675) 2022-01-19 19:48:04 +00:00
Dzmitry Malyshau 76814a83a2 msl: inject point size if needed 2022-01-19 11:33:14 -05:00
Aaron O'Mullan cdd480a89c lint: deno_webgpu & wgpu-core (#2403) 2022-01-18 09:34:10 -05:00
Aaron O'Mullan 6b60037a6a chore(deno_webgpu): bump deno crates (#2405)
* chore(deno_webgpu): bump deno_core to 0.114.0

https://github.com/denoland/deno/commit/ca75752e5a9499a0a997809f02b18c2ba1ecd58d dates back to Aug 30 2021, so is nearly 5 months old.

There are no breaking changes updating `deno_core` to `0.114.0` (released 6 days ago)

Also by using the crate directly from cargo we avoid cloning https://github.com/denoland/deno and https://github.com/denoland/deno_third_party which can be quite large so crate DL/install is much faster

* bump cts_runner's deno crates

* minor cts_runner fixes
2022-01-18 09:30:41 -05:00
Aaron O'Mullan 5877117529 chore: bump naga to a1840be (#2401)
* chore: bump naga to a1840be

So tip no longer indirectly pins indexmap, etc...

* feedback

* TODO push_constant_binding
2022-01-17 19:17:31 -05:00
João Capucho a1840beb1a glsl-out: Add test for push constants 2022-01-16 19:32:51 -05:00
João Capucho 91ca923553 glsl-out: Add support for push constant emulation 2022-01-16 19:32:51 -05:00
João Capucho b42bf8768e glsl-out: Write correct argument name when skipping samplers 2022-01-16 00:47:35 -05:00
Ibiyemi Abiodun 0183e7d1e8 add AddressMode::ClampToZero (#2364)
* add AddressMode::ClampToZero

* add feature checks

* oops

* rustfmt

* fix dx12

* change to use SamplerBorderColor

* fix metal

* update to use new config

* update dx12 + docs

* address nits

* cargo fmt

* fix dx12
2022-01-15 05:16:35 +00:00
rustui 4612cdfba5 fix typo (#2393) 2022-01-15 05:09:06 +00:00
Noel Tautges 955e02eb17 Ignore .vscode 2022-01-14 21:47:14 -03:30