Commit Graph
9013 Commits
Author SHA1 Message Date
João Capucho 60bd9ec884 [glsl-in] Compile tests without codespan 2021-09-16 16:10:01 -04:00
Jim Blandy 8aae069f22 Document some Expression, EntryPoint, and Module rules. 2021-09-16 11:01:45 -04:00
Jim Blandy 636b8ed606 Document AtomicResult expressions. 2021-09-16 11:01:24 -04:00
Dzmitry Malyshau c8436de1ec Force point size output on Vulkan 2021-09-15 19:15:23 -04:00
Dzmitry Malyshau 52d74e91a4 spv-out: option to emit PointSize 2021-09-15 18:48:18 -04:00
Jim Blandy 5d3c93e8c7 [wgsl-out] Properly parenthesize address-of expressions.
Fixes #1352.
2021-09-15 18:46:55 -04:00
Jim Blandy 045ec6db32 [spv-out] Various doc fixes. 2021-09-15 18:41:07 -04:00
Jim Blandy 95d3a4e699 Enable span tracking by default in the Naga CLI. (#1364) 2021-09-15 15:32:19 -07:00
Connor Fitzgerald e0a6bffd5c Revamp the readme 2021-09-15 14:46:01 -04:00
Jamen Marz 5b133c34ec Add a note that copying within the same buffer panics 2021-09-15 11:01:37 -04:00
Jim Blandy e5ba11332f Correctly recognize defined spans.
Without this change, the `to_range` method method returns `None` even when spans
are enabled.
2021-09-15 10:53:46 -04:00
Jim Blandy d31121df77 [wgsl-in] Refuse to apply postfix expressions to WGSL pointers.
Fixes #1356.

Output for the test case in that issue is now:

    error: the value indexed by a `[]` subscripting expression must not be a pointer
      ┌─ wgsl:5:14
      │
    5 │     let a = *pv[3]; // Problematic line
      │              ^^ expression is a pointer

    Could not parse WGSL
2021-09-15 10:51:35 -04:00
Jim Blandy 08c1a1e9a3 [wgsl-in] Record identifier definitions as TypedExpression values.
Both a `var` binding and a `let` binding of a pointer to a variable create
entries in the `lookup_ident` tables whose expression is a `LocalVariable`.
However, the `let` should be a pointer, whereas the `var` should be a reference.
This patch changes the tables to hold `TypedExpression` values, thus preserving
the distinction.
2021-09-15 10:51:35 -04:00
Jim Blandy 4abf22c4d1 snapshot tests: Always write IR when requested, even if validation fails. 2021-09-15 10:37:12 -04:00
Connor Fitzgerald a5e6e8f9cc Split out CTS to its own workflow 2021-09-15 10:26:29 -04:00
João Capucho 36114d95b6 [spv-in] Move function data into BlockContext
This allows removing many arguments from functions dealing with
instruction parsing
2021-09-15 10:24:01 -04:00
Connor Fitzgerald 376ed9ea9c Merge pull request #1968 from mattlacey/master
Adds background to images used in README
2021-09-15 00:47:32 -04:00
Matt Lacey 92598e3875 Adds background to images used in README
Images weren't legible when using GitHub in dark mode as they became black on
dark grey, so added a white background to ensure legibility
2021-09-15 14:02:58 +10:00
Jim Blandy 933ecc4a44 [spv-out] Rename test snapshot files.
The old filenames were probably based on the shader stage, not the shader
function name, which the PR changed to do in response to a review suggestion.
2021-09-14 18:41:23 -04:00
Jim Blandy 0d3dbfe781 Clean up some old snapshot files.
`tests/out/glsl/operators.main.Fragment.glsl` is no longer generated because the
function in question changed to a Compute entry point.

`tests/out/wgsl/multiple_entry_points-glsl.wgsl` is no longer generated because
the input test was removed in 057dc310.
2021-09-14 18:38:49 -04:00
Jim Blandy 3fdd8592fc [wgsl-in] Rework Load Rule handling and indirection.
Make the parser code more closely follow the spec's grammar around
`unary_expression`, `postfix_expression`, and `singular_expression`.

Change the handling of postfix expressions (indexing, member/component access,
and swizzling) to apply the indirection at the appropriate time, resulting in
code improvements on all output formats. For example, where we used to generate
the following MSL:

    metal::float4 _e13 = bar.matrix[3];
    float b = _e13.x;

we now generate, simply:

    float b = bar.matrix[3].x;

Propagate WGSL reference types correctly, so that parenthesizing expressions no
longer causes the Load Rule to be applied.

Together with #1332 (already landed), this is a replacement for #1312, and
unblocks #1352.

Fixes #1351.
2021-09-14 16:17:57 -04:00
Connor Fitzgerald 4ce884b04b Remove monocodus config 2021-09-14 16:16:47 -04:00
Dzmitry Malyshau c4c359a43d Only run CTS check if 'needs testing' label is added 2021-09-14 14:41:47 -04:00
Connor Fitzgerald af960b91f4 Merge pull request #1956 from cwfitzgerald/ci-improvements
Improve CI testing code
2021-09-14 13:47:32 -04:00
Connor Fitzgerald 7766ed194b Improve CI testing code 2021-09-14 13:34:07 -04:00
Dzmitry Malyshau 300f7d2e8c Expose query resolve offset and respect it in the mipmap example 2021-09-14 09:47:15 -04:00
Dzmitry Malyshau db80ed4fa9 Fix warnings in snapshots and spv-in 2021-09-14 09:46:25 -04:00
Jim Blandy c03427b154 Document TypeResolution and TypeInner::ValuePointer. 2021-09-14 09:41:28 -04:00
Dzmitry Malyshau 392f904465 hal/metal: bump the maximum command buffer count 2021-09-14 09:12:00 -04:00
Dzmitry Malyshau bc91048216 Update cts to a44186d, enable blending tests 2021-09-14 09:11:29 -04:00
Dzmitry Malyshau a7c7c9f38e Move Deno out of the workspace 2021-09-13 23:57:33 -04:00
Dzmitry Malyshau 60142b56da List CTS tests to run 2021-09-13 19:44:38 -04:00
Dzmitry Malyshau 807accd7de wgsl-in: require storage class to be given 2021-09-13 15:44:05 -04:00
Dzmitry Malyshau 447d612f88 hal/metal: fix the back-face stencil state 2021-09-13 10:17:19 -04:00
Connor Fitzgerald e8c236cd71 Merge pull request #1945 from kvark/view-parent
Store a reference to the device in texture views
2021-09-12 20:22:51 -04:00
Dzmitry Malyshau 3afeb9a53f hal/metal: fix storage binding size units 2021-09-12 17:41:46 -04:00
Connor Fitzgerald ba2f4bb557 Merge pull request #1949 from UE2020/patch-1 2021-09-12 17:19:30 -04:00
Aspect 195cfa1b36 Fix typo in documentation for Rg8Sint texture format 2021-09-12 16:42:57 -04:00
xacrimon fc1cb5eb20 feedback 2021-09-12 11:03:05 -04:00
Dzmitry Malyshau abe41ccf9c Fix stencil ops 2021-09-12 10:37:17 -04:00
Dzmitry Malyshau 95f4122b22 Store a reference to the device in texture views 2021-09-12 10:20:16 -04:00
Jasper St. Pierre 0e66930aff [glsl-in] Fix sampling texture array types
Fixes #1349.
2021-09-12 09:44:14 -04:00
Jasper St. Pierre ba39fd47c3 Output parentheses around dereference (#1348)
Regression from ce676cf130.

We need to output (*d).mx rather than *d.mx, at least according to Tint.
wgsl-in seems to handle *d.mx just fine, which is likely a separate bug.
2021-09-11 23:32:10 -07:00
Mike Welsh 34c6d3a7f3 web: Fix spirv-web feature for latest naga 2021-09-12 00:06:58 -04:00
João Capucho bf29ceaf10 Update naga to latest 2021-09-11 11:44:27 -04:00
Connor Fitzgerald 69e86453d9 Merge pull request #1938 from xacrimon/acrimon/mtldrawable-error 2021-09-10 15:59:38 -04:00
João Capucho 130f802c89 Make span copyable (#1314)
* Make span copyable

* Use fixed size integers for span
2021-09-10 19:52:45 +00:00
xacrimon e013daadc8 please rustfmt 2021-09-10 21:46:21 +02:00
xacrimon a1bfbbbfab fix lint 2021-09-10 21:44:35 +02:00
xacrimon da849115b5 return appropriate error when failing to allocate drawable on metal 2021-09-10 21:30:30 +02:00