Commit Graph
2124 Commits
Author SHA1 Message Date
Wumpf 988716943f Zero init textures (#1688)
* Added tests for texture zero init
sadly, they are typically passing even if texture zero init isn't doing its job
However, they form nice isolated examples for testing out texture initialization
It could be possible to dirty texture memory prior to ensure zero init did the job

* texture init tracker

* tracking texture init requirements for bind group, transfer and rendertarget

* texture clears for texture init
* queue submit
* write_texture

* Enforce presence of either render target or copy_dst flag

* clear render targets also with using buffer copies
enforce COPY_DST usage now on all textures

* adjust ImageSubresourceRange.layer_range calculation for 3D textures

init_tracker has now a `discard` function to get single data points back to uninitialized

use new standardized partition_point function

* track init state for discarded textures from renderpasses

missing:
* init on the fly if discarded is found within command buffer
* handle discarding only stencil or only depth

* added tests for zero init after discard

* tracking discarded surfaces now in separate struct, piping all inits through utility function
allows to resolve discard/init_action interactions

* Move various memory init code to separate mod
CommandBufferTextureMemoryActions is now fully encapsulated

* implemented discard init fixups for everything but renderpass

* render passes also cause now discard fixups

* fixup_discarded_surfaces takes now an iterator instead of Drain

* Add memory init test for discarding depth targets

* handle divergently discarded depth/stencil target

* comment & clippy fixes

* fix collect_zero_buffer_copies_for_clear_texture yielding block breaking copies

* [pr feedback] minor cleanup in zero_init_texture_after_discard, `use` hygenie

* [pr feedback] fix bug in ImageSubresourceRange range utils

* [pr feedback] fix texture tracker check, bundle transition_texture on init, cleanups

* Implemented drop for InitTrackerDrain

* remove incorrect comment about extents in add_pass_texture_init_actions

* Fix unit test & clippy issues in init_tracker
2021-10-28 09:15:53 -04:00
Dzmitry Malyshau 3ec17cf9ed Fix smooth buffer barrier (#2104) 2021-10-21 22:11:41 -04:00
Wumpf 4af1c31edc init_tracker has now a discard function to get single data points back to uninitialized (#2081)
* init_tracker has now a `discard` function to get single data points back to uninitialized

use new standardized partition_point function

* allow unused InitTracker.discard function for time being
2021-10-16 18:09:04 +00:00
Dzmitry Malyshau 04b8ff2c9e Silence downlevel caps warning on secondary backends 2021-10-15 15:02:49 -04:00
Dzmitry Malyshau 41c595cfcf Hold BGL alive by BG (#2075) 2021-10-15 11:40:49 -04:00
Dzmitry Malyshau ec8413dfcb Build fixes after a bad merge (#2071) 2021-10-14 19:24:30 -04:00
Dzmitry Malyshau 47fb0efb2c ETC2 texture format refactor (#2064) 2021-10-13 13:42:44 -04:00
Wumpf a28c52873f Move clear_texture impl from wgpu-hal to wgpu-core (#2046)
* new test for clearing textures of all formats

* clear_texture is now always implemented in wgpu-core instead of wgpu-hal

* add 1D/array/volume texture to clear_texture test

* set mip_level_count to 1 for D1 textures in clear_texture test

* fix warning & clippy lints

* Fix web build

* [pr feedback] fix potentially skipped resource transition, fix wrong mip size for texture clear

* collect_zero_buffer_copies_for_clear_texture aligns rows now properly
2021-10-13 13:42:13 -04:00
Dzmitry Malyshau 016b319b38 Manifests update for 0.11 2021-10-07 19:15:49 -04:00
Zicklag 312828f12f Implement WebGL2 Backend (#1686)
* Implement WebGL Backend

* Add WebGL Fixes by @mrk-its

* Update Limits for WASM and Examples

* Address Review Points
2021-10-07 16:18:09 -04:00
Connor Fitzgerald 6df5f95b67 Update naga to 2e7d629 2021-10-07 16:09:13 -04:00
Dzmitry Malyshau dfa4948033 Update naga to 0e3fbc8 2021-10-07 08:32:01 -04:00
Dzmitry Malyshau 5092fb7ea5 Refactor presentation to be explicit 2021-10-06 17:02:10 -04:00
Connor Fitzgerald c3d906856f Add spans to provide more information profile gaps 2021-10-03 22:54:15 -04:00
Dzmitry Malyshau 1ee6036f44 Implement software adapter selection 2021-10-01 17:22:51 -04:00
Dzmitry Malyshau 97d6db4d18 Allow if/panic in wgpu-hal 2021-10-01 16:22:51 -04:00
memoryruins 13a0baaca5 Update mentions of gfx-hal to wgpu-hal 2021-10-01 13:50:19 -04:00
Connor Fitzgerald b679342d9e Support descriptor arrays shorter than binding length 2021-09-30 14:11:51 -04:00
João Capucho 9bc5908492 Add method to create shader modules without runtime checks (#1978)
* Add method to create shader modules without runtime checks

* Use opaque struct to represent shader bound checks
2021-09-27 19:51:44 +00:00
Dzmitry Malyshau a7aa72ba1c Check for color target count in bundle creation 2021-09-27 11:11:10 -04:00
Devin Brite dbfdbf4e32 Move validation from Device::create_texture_from_hal() to Device::create_texture() (#2001)
* Move validation from `Device::create_texture_from_hal()` to `Device::create_texture()`

---

Users encountered a segfault upon creating a texture when mip_level_count was set to 0 with (at least) Vulkan.
This is due to wgpu's validation taking place after the API's texture is created.

This change moves wgpu's validation to before the API's texture is created, introducing a friendly error instead of a segfault.

* Make `Device::create_texture_from_hal()` infallible

* run cargo fmt
2021-09-27 13:26:36 +00:00
Dzmitry Malyshau 089294fc51 Skip mismatched epochs in the remove_abandoned check 2021-09-25 15:40:21 -04:00
Dzmitry Malyshau 180e3e3576 Fix write_texture for array textures 2021-09-23 10:49:15 -04:00
Dzmitry Malyshau 08ff76f150 Align buffer usage end to 4 2021-09-20 15:22:18 -04:00
Dzmitry Malyshau be6898f166 Make "Unexpected varying type" a bit less annoying 2021-09-20 12:07:01 -04:00
Dzmitry Malyshau c8436de1ec Force point size output on Vulkan 2021-09-15 19:15:23 -04:00
Connor Fitzgerald 7766ed194b Improve CI testing code 2021-09-14 13:34:07 -04:00
Dzmitry Malyshau 95f4122b22 Store a reference to the device in texture views 2021-09-12 10:20:16 -04:00
João Capucho bf29ceaf10 Update naga to latest 2021-09-11 11:44:27 -04:00
Dzmitry Malyshau 37288a657f Avoid AtomicU64 for it not being portable 2021-09-10 10:34:07 -04:00
Dzmitry Malyshau ca6fd97c62 Codecoverage CI fix 2021-09-09 12:44:24 -04:00
Dzmitry Malyshau 83abe2a06d Still close the encoder on error 2021-09-09 09:43:38 -04:00
Dzmitry Malyshau 180dc27144 Work around Adreno's OpName bug 2021-09-08 22:24:27 -04:00
Connor Fitzgerald 809909137c Merge pull request #1919 from kvark/spv
vulkan: compile shader modules at pipeline creation time
2021-09-08 17:25:50 -04:00
Luke Street 76bcd9c494 Implement min_{uniform,storage}_buffer_offset_alignment limits (#1923)
* Implement min_{uniform,storage}_buffer_offset_alignment limits

* Add Limits::using_alignment

* Update docs & examples

* Create binding_model::buffer_binding_type_alignment fn
2021-09-08 13:53:02 -04:00
Dzmitry Malyshau e00bfac6cf vulkan: compile shader modules at pipeline creation time 2021-09-07 20:06:16 -04:00
Dzmitry Malyshau 076031c1ba hal: switch texture copies to expect physical sizes (#1908) 2021-09-07 13:13:11 +00:00
Wumpf df2a686c29 Reintroduce clear_texture Metal/Vulkan/DX12 (#1905)
* enable CLEAR_COMMANDS feature for all adapters

* replaced fill_buffer with clear_buffer (minus variable value)

* Improve clear buffer/texture test
and remove unused clear-buffer.ron test

* renamed clear_image to clear_texture

* skeleton for new wgpu-hal clear_texture

* clear_texture implementation for vulkan

* clear_texture now restricts usage

* clear_texture implementation for dx12

* Implemented clear_texture for Metal backend

* Clean up GLES clear_buffer and leave note on how to implement clear_texture in the future

* fix linux compilation & formatting issues

* comment & namespace fixes

* Extent3d has now a simple mipmap calculating function

Fix incorrect use of texture.size in clear_texture for metal/dx12
Fix incorrect mip/layer ranges in clear_texture for metal/dx12
2021-09-06 21:14:40 -04:00
Connor Fitzgerald 938c069608 Properly implement timestamp periods (#1907) 2021-09-04 22:24:15 -04:00
Luca Casonato d5ba0b439d WIP: add cts_runner and deno_webgpu crate (#1859)
* WIP: add cts_runner and deno_webgpu crate

* add test

* remove Cargo.lock

* review comment

* simplify

* fix bugs

* improve cts_runner to work with crowlKats/webgpu-examples

* fix

* remove build.rs

cts_runner binaries are now not portable anymore.

Also startup will now print a bunch of cargo:rerun-if-changed=. This
will be fixed in deno_core.

* remove d.ts

* add original deno license file
2021-09-03 13:23:35 -04:00
Dzmitry Malyshau 663f64c571 Fix read-write buffer barrier 2021-09-02 16:39:55 -04:00
Dzmitry Malyshau 53d262c8ee More validation of the surface texture lifetime 2021-09-01 16:19:32 -04:00
Christofer Nolander 06316c1bac hal/metal: support Features::NON_FILL_POLYGON_MODE (#1885)
* hal/metal: support Features::NON_FILL_POLYGON_MODE

* Document Metal support for NON_FILL_POLYGON_MODE

* Split Features::NON_FILL_POLYGON_MODE in two

Adds two new features: `LINE_POLYGON_MODE` and `POINT_POLYGON_MODE`.

Allows metal to support `PolygonMode::Line` while not being required to
support `PolygonMode::Point`.

* Formatting

* Rename {LINE,POINT}_POLYGON_MODE to POLYGON_MODE_{LINE,POINT}
2021-08-31 16:20:38 +00:00
Riccardo Zaglia 0a2be6099c Add Texture::as_hal() 2021-08-31 10:30:23 -04:00
Dzmitry Malyshau 42194168e0 Fix implicit storage texture access 2021-08-26 11:36:05 -04:00
Dzmitry Malyshau 590ef1d8cf Switch naga to latest on git (#1858) 2021-08-24 18:20:44 -04:00
Dzmitry Malyshau 43d44c89e1 Bump the vertex buffer sizes by 1 2021-08-24 13:39:57 -04:00
Dzmitry Malyshau c05b064bc8 Check for query resolve alignment (#1853) 2021-08-23 12:32:18 -04:00
Dávid Kocsis f34f88538b fixed mip level count check for storage textures 2021-08-23 17:49:20 +02:00
Dzmitry Malyshau f3c9f412f6 Validate against cube storage textures (#1846) 2021-08-23 02:17:28 -04:00