Commit Graph
8897 Commits
Author SHA1 Message Date
Connor Fitzgerald be5adfa584 Fix segfault caused by improper drop order 2021-05-18 01:47:24 -04:00
bors[bot]andDzmitry Malyshau 1cd4ad7cfe Merge #1393
1393: Fix dynamic stencil reference for Replace ops r=cwfitzgerald a=kvark

**Connections**
Fixes an issue reported on Matrix, where we'd not set the stencil reference.

**Description**
Our conditions didn't check the Replace ops.

**Testing**
Untested, YOLO

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-05-18 00:30:51 +00:00
Jim Blandy 0985727710 [wgsl-in] Include span information in 'unknown identifier' errors. 2021-05-17 19:46:37 -04:00
Jim Blandy 0e3a7840ff [wgsl-in]: Report unknown identifiers as Error::UnknownIdent.
Move the parsing of type construction expressions into a function of its own,
which can return `None` when the identifier at hand is not the name of a type.
This means that `parse_primary_expression` doesn't have to commit to
interpreting the expression as a type construction too early, allowing it to
report unknown identifiers as Error::UnknownIdent.
2021-05-17 19:46:37 -04:00
Dzmitry Malyshau e24e8f643c Fix dynamic stencil reference for Replace ops 2021-05-17 18:42:42 -04:00
bors[bot]andDzmitry Malyshau 13f2ca571c Merge #1391
1391: Simplify features r=cwfitzgerald a=kvark

**Connections**
Fixes #1390
Makes vertex writable storage optional (native-only for now)
Fixes the follow-up to #891 

**Description**
Refactors the code so that adding new features and maintaining current ones is much easier.
Refactors the way missing features are checked and reported, DRY way.

**Testing**
Not really tested

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-17 19:03:59 +00:00
Dzmitry Malyshau 51c7963195 Use the same MissingFeatures error everywhere 2021-05-17 14:20:17 -04:00
Dzmitry Malyshau 163b11db42 Validate the writable storage feature 2021-05-17 14:19:49 -04:00
Dzmitry Malyshau a06d277d40 Simplify feature selection 2021-05-17 14:11:48 -04:00
Dzmitry Malyshau f0a145d0fa Add VERTEX_WRITABLE_STORAGE feature, refactor the sample border 2021-05-17 14:09:02 -04:00
Dzmitry Malyshau b191c982ec Remove alignment from struct IR 2021-05-17 09:32:52 -04:00
Gordon-F 6efe347e90 [wgsl-out] Implement all math functions. Rename entry point function based on stage. Rename entry point output struct. 2021-05-14 18:14:23 -04:00
Gordon-F 5958f98489 [wgsl-out] Enable snapshot testing for wgsl-in image test 2021-05-14 18:12:02 -04:00
Dzmitry Malyshau 77a20d0017 Update CHANGELOG for v0.4.1 2021-05-14 10:21:55 -04:00
Dzmitry Malyshau 418e71281e Derivative tests 2021-05-14 09:53:24 -04:00
bors[bot]andDzmitry Malyshau 2a7e07d94f [rs] Merge #909
909: Update naga to gfx-25 r=kvark a=kvark

Gets us arrayLength() in MSL

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-14 04:23:09 +00:00
Dzmitry Malyshau 2a0ea1d94b [rs] Update naga to gfx-25 2021-05-14 00:22:28 -04:00
bors[bot]andDzmitry Malyshau 53eab747a3 Merge #1381
1381: Update naga to gfx-25 r=kvark a=kvark

**Connections**
Fixes #1362
Picks up https://github.com/gfx-rs/gfx/pull/3752 and https://github.com/gfx-rs/gfx/pull/3758

**Description**
Updates gfx and Naga. Hooks up the new validation capabilities.

**Testing**
Self-testing.

Note: this PR doesn't currently work because Metal's backend is now required use a sizes buffer when dynamically sized arrays are present. One of the internal tests here uses them.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-05-14 03:57:13 +00:00
Dzmitry Malyshau e00251d3e3 Update naga to gfx-25 2021-05-13 23:56:26 -04:00
Jim Blandy 057d03ad86 [wgsl-in]: Add tests for array and struct validation. 2021-05-13 22:09:22 -04:00
Jim Blandy 9c5f324de2 TypeInner::span: Tolerate bad array length constants for now. 2021-05-13 22:09:22 -04:00
Jim Blandy f45d812266 [wgsl-in]: Move WGSL front end integration tests into a WGSL-specific file.
This lets us reduce noise by removing a bunch of `#[cfg]` attributes. In the
future, if we have tests for other front ends, we can create an `errors`
subdirectory, but for now, we only have the WGSL tests, so we should keep things
flat.
2021-05-13 22:09:22 -04:00
Matúš Talčík 5e5d64291d [spv-in] fix handling of break blocks (borrowed from Tint) 2021-05-13 22:08:06 -04:00
Dzmitry Malyshau a8df6a2b34 [msl] make sizes buffer local to each function 2021-05-13 22:02:37 -04:00
Dzmitry Malyshau 0250ffe2fb [msl] early out if the binding sizes are missing 2021-05-13 00:42:15 -04:00
Igor Shaposhnik 6a42e4a0f8 [wgsl-out] Enable snapshot testing for spv-in quad shader 2021-05-12 15:15:50 -04:00
bors[bot]andConner Bryan 6ffd4d94ab Merge #1385
1385: fix typo in PowerPreference::LowPower description r=cwfitzgerald a=cab

**Description**
Fixes a typo in the description of `PowerPreference::LowPower`.

**Testing**
None

Co-authored-by: Conner Bryan <conner@amps.io>
2021-05-11 23:22:19 +00:00
Conner Bryan eda7031f35 fix typo in PowerPreference::LowPower description 2021-05-11 19:10:06 -04:00
Dzmitry Malyshau 58b83f3ff6 Add extern-C on wgpu_render_pass_execute_bundles 2021-05-11 15:00:49 -04:00
Dzmitry Malyshau f861e83df1 Fix wgpu_render_bundle_draw_indexed_indirect 2021-05-11 15:00:49 -04:00
Dzmitry Malyshau 0135e02ff6 Re-enable bors 2021-05-11 15:00:41 -04:00
bors[bot]andConnor Fitzgerald 5b4623a112 [rs] Merge #907
907: Add feature request for wgpu-rs r=kvark a=cwfitzgerald

Thanks @JMS55 for bringing this to my attention in #906 

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-05-10 03:30:47 +00:00
Connor Fitzgerald 12f851c7b2 [rs] Add feature request for wgpu-rs 2021-05-09 17:57:43 -04:00
bors[bot]andConnor Fitzgerald b8c5b7ad97 [rs] Merge #905
905: Fill Out Issue Templates r=kvark a=cwfitzgerald

This adds issue templates, as well as links to the wgpu-core tracker and the discussion board. Hopefully this should reduce the amount of issues we have to transfer.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-05-09 04:10:49 +00:00
Connor Fitzgerald 6485fc0ca2 Merge pull request #1380 from fintelia/patch-1
Include shader label in log message if shader parsing fails
2021-05-08 23:28:17 -04:00
Dzmitry Malyshau ba422f10f8 [msl] fix splat namespace 2021-05-08 22:07:13 -04:00
Connor Fitzgerald 9b57ce695f [rs] Fill out issue template 2021-05-08 21:29:41 -04:00
Dzmitry Malyshau 350ceb383d WGSL support for f64, snapshot test for it 2021-05-08 21:20:23 -04:00
Dzmitry Malyshau 59d1dcab5b Support width changes in As expression 2021-05-08 21:20:23 -04:00
Dzmitry Malyshau c25c06409c [spv-in] fix casting length expectations 2021-05-08 21:20:23 -04:00
Gordon-F 53fe7a329f [glsl-out] Handle uninitialized global variables 2021-05-08 21:09:11 -04:00
Dzmitry Malyshau 851f504e41 [spv-in] patch the SPIR-Vs wacky CFG cases by hand 2021-05-08 21:06:29 -04:00
Jonathan Behrens c64618abb8 Include shader label in log message if validation fails 2021-05-08 14:07:56 -04:00
Dzmitry Malyshau 1aa57b3f92 Support multiple output targets in the converter 2021-05-08 10:55:16 -04:00
Dzmitry Malyshau e173a514a0 [spv-in] respect per-member access decorations 2021-05-08 10:20:15 -04:00
Gordon-F 73b20ffa70 Add CullDistance BuiltIn 2021-05-08 09:51:14 -04:00
bors[bot]andPâris DOUADY 212f3bc050 [rs] Merge #900
900: Fix initializing buffer with unaligned data r=grovesNL a=Uriopass

In wgpu 0.7, this was a valid operation, the zero padding was done by hand. 
In #872 this logic was removed as an optimization since buffers are already zero initialized, however the slice end was taken from buffer.slice which has to be aligned when mapped.

This is causing issues when trying to update imgui-wgpu-rs (https://github.com/Yatekii/imgui-wgpu-rs/issues/54) to  wgpu 0.8 since they  use U16 index buffers with odd lengths.

Co-authored-by: Pâris DOUADY <paris.douady@hotmail.fr>
2021-05-07 12:04:32 +00:00
Pâris DOUADY 8b79b056fa [rs] Fix initializing buffer with unaligned data
In wgpu 0.7, this was a valid operation, the zero padding was done by hand. 
However in #872 this was removed as an optimization since buffers are zero padded, however the slice end was taken from buffer.slice which has to be aligned when mapped.
2021-05-07 13:50:49 +02:00
Dzmitry Malyshau bbb1b6b366 [msl] move Compose into a helper method 2021-05-07 01:21:55 -04:00
Dzmitry Malyshau 10c4c906da [msl] move ArrayLength logic out 2021-05-07 01:21:55 -04:00