1393: Fix dynamic stencil reference for Replace ops r=cwfitzgerald a=kvark
**Connections**
Fixes an issue reported on Matrix, where we'd not set the stencil reference.
**Description**
Our conditions didn't check the Replace ops.
**Testing**
Untested, YOLO
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Move the parsing of type construction expressions into a function of its own,
which can return `None` when the identifier at hand is not the name of a type.
This means that `parse_primary_expression` doesn't have to commit to
interpreting the expression as a type construction too early, allowing it to
report unknown identifiers as Error::UnknownIdent.
1391: Simplify features r=cwfitzgerald a=kvark
**Connections**
Fixes#1390
Makes vertex writable storage optional (native-only for now)
Fixes the follow-up to #891
**Description**
Refactors the code so that adding new features and maintaining current ones is much easier.
Refactors the way missing features are checked and reported, DRY way.
**Testing**
Not really tested
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1381: Update naga to gfx-25 r=kvark a=kvark
**Connections**
Fixes#1362
Picks up https://github.com/gfx-rs/gfx/pull/3752 and https://github.com/gfx-rs/gfx/pull/3758
**Description**
Updates gfx and Naga. Hooks up the new validation capabilities.
**Testing**
Self-testing.
Note: this PR doesn't currently work because Metal's backend is now required use a sizes buffer when dynamically sized arrays are present. One of the internal tests here uses them.
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This lets us reduce noise by removing a bunch of `#[cfg]` attributes. In the
future, if we have tests for other front ends, we can create an `errors`
subdirectory, but for now, we only have the WGSL tests, so we should keep things
flat.
1385: fix typo in PowerPreference::LowPower description r=cwfitzgerald a=cab
**Description**
Fixes a typo in the description of `PowerPreference::LowPower`.
**Testing**
None
Co-authored-by: Conner Bryan <conner@amps.io>
907: Add feature request for wgpu-rs r=kvark a=cwfitzgerald
Thanks @JMS55 for bringing this to my attention in #906
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
905: Fill Out Issue Templates r=kvark a=cwfitzgerald
This adds issue templates, as well as links to the wgpu-core tracker and the discussion board. Hopefully this should reduce the amount of issues we have to transfer.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
900: Fix initializing buffer with unaligned data r=grovesNL a=Uriopass
In wgpu 0.7, this was a valid operation, the zero padding was done by hand.
In #872 this logic was removed as an optimization since buffers are already zero initialized, however the slice end was taken from buffer.slice which has to be aligned when mapped.
This is causing issues when trying to update imgui-wgpu-rs (https://github.com/Yatekii/imgui-wgpu-rs/issues/54) to wgpu 0.8 since they use U16 index buffers with odd lengths.
Co-authored-by: Pâris DOUADY <paris.douady@hotmail.fr>
In wgpu 0.7, this was a valid operation, the zero padding was done by hand.
However in #872 this was removed as an optimization since buffers are zero padded, however the slice end was taken from buffer.slice which has to be aligned when mapped.