Commit Graph
8897 Commits
Author SHA1 Message Date
bors[bot]andConnor Fitzgerald 43aa8b11b2 Merge #840
840: Add builder for TextureDescriptor r=kvark a=cwfitzgerald

**Connections**

https://github.com/gfx-rs/wgpu-rs/issues/478 https://github.com/gfx-rs/wgpu-rs/issues/470

**Description**

Adds a mut based builder pattern to TextureDescriptor as a test.

**Testing**

Will test in wgpu-rs...


Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-07-29 18:28:46 +00:00
Connor Fitzgerald d5f23f9323 Add builder for TextureDescriptor 2020-07-29 14:28:03 -04:00
bors[bot]andGabriel Majeri f6ba5b8298 Merge #845
845: Finish error model refactor r=kvark a=GabrielMajeri

**Connections**
I think this is the last part of #638. I've reviewed all the remaining `unwrap`s and `assert`s in the code, and these should be the last ones left which ought to return errors (the remaining ones seem to uphold internal invariants).

**Description**
Implements error handling for various conditions, which are then returned to the caller. Including, but not limited to:
- running out of memory when creating a command pool
- running out of memory when creating a frame buffer for a render pass
- invalid dimensions when creating a texture

**Testing**
Tested with core and player.

Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
2020-07-29 18:10:33 +00:00
bors[bot]andKunal Mohan 75292f3f56 Merge #844
844: Add mip level count and array layer count validation to texture_create_view r=kvark a=kunalmohan

**Connections**
_Link to the issues addressed by this PR, or dependent PRs in other repositories_

**Description**
_Describe what problem this is solving, and how it's solved._
Catches the error when `mip_level_count = 0` and `base_mip_level > texture.mip_level_count` (same with `array_layer_count`)

**Testing**
_Explain how this change is tested._
Haven't been tested yet
<!--
Non-trivial functional changes would need to be tested through:
  - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples.
  - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity.

Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications.
See https://github.com/gfx-rs/wgpu/pull/666 for an example.
If you can add a unit/integration test here in `wgpu`, that would be best.
-->


Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
2020-07-29 17:35:40 +00:00
Gabriel Majeri a5f72d26d3 Handle DeviceLost in triage_submissions 2020-07-29 20:17:48 +03:00
Gabriel Majeri 62f1f9c438 Error types for conv module 2020-07-29 20:17:46 +03:00
bors[bot]andConnor Fitzgerald 378834336e [rs] Merge #484
484: Enable features in CI to prevent compiler errors r=kvark a=cwfitzgerald

Simple change, this also builds features in CI.

I added trace and replay features to wasm, even though wasm doesn't support tracing as is, because people may enable them to get serde support for wgpu-types stuff.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-07-29 16:59:20 +00:00
Connor Fitzgerald 3eda1c5990 [rs] Enable features in CI to prevent compiler errors 2020-07-29 12:58:08 -04:00
Kunal Mohan 0ef76a7643 Add mip level count and array layer count validation to texture_create_view 2020-07-29 21:47:28 +05:30
Gabriel Majeri 2f06d3e4f9 Return out of memory condition from render pass 2020-07-29 09:58:46 +03:00
Gabriel Majeri e860dd995f Handle command pool creation error 2020-07-29 09:56:42 +03:00
bors[bot]andDzmitry Malyshau db14d0f7ea [rs] Merge #488
488: Update wgpu with view descriptor changes r=kvark a=kvark

Includes https://github.com/gfx-rs/wgpu/pull/846

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-07-29 03:37:05 +00:00
Dzmitry Malyshau 8a32c7dbb8 [rs] Update wgpu with view descriptor changes 2020-07-28 23:35:59 -04:00
bors[bot]andDzmitry Malyshau 9929b8719f Merge #846
846: Make level and layer count for texture view optional r=cwfitzgerald a=kvark

**Connections**
implements https://github.com/gpuweb/gpuweb/pull/945

**Description**
`NonZeroU32` is more idiomatic here

**Testing**
untested, but should work

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-07-29 03:04:18 +00:00
Dzmitry Malyshau d2c1e725db Make level and layer count for texture view optional 2020-07-28 22:55:39 -04:00
Pelle Johnsen 1eb637038d [glsl-new] Add initial handling of stmts and exprs (#116)
* [glsl-new] Add initial handling of stmts and exprs

* [glsl-new] use &'static str for NotImplemented msg

* [glsl-new] Don't lazy create function context
2020-07-28 22:48:05 -04:00
bors[bot]andDzmitry Malyshau 0dcd1e1204 Merge #847
847: Gecko-requested refactor r=cwfitzgerald a=kvark



Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-07-28 21:01:27 +00:00
Dzmitry Malyshau bf862b7907 Clarity renames according to the Gecko review 2020-07-28 16:58:28 -04:00
bors[bot]andGabriel Majeri de36997986 [rs] Merge #487
487: Update to latest `wgpu-core` r=kvark a=GabrielMajeri

Pulls in the latest changes from `wgpu-core`, follow up for https://github.com/gfx-rs/wgpu/pull/841

Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
2020-07-28 19:58:28 +00:00
Gabriel Majeri 04c1ff27ea [rs] Update to latest wgpu-core 2020-07-28 21:32:39 +03:00
bors[bot]andDzmitry Malyshau 5bd24d5085 Merge #843
843: Reformat the alignment errors, add a stride check r=GabrielMajeri a=kvark

**Connections**
Addresses [one of the things](https://community-tc.services.mozilla.com/tasks/JQlmdXSiSK2ufM7mX8F1Tg/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FJQlmdXSiSK2ufM7mX8F1Tg%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log#L1999) Servo hit on the CTS

**Description**
This change affects the unaligned* error messages: instead of printing the exact value, they now refer to the constant in the code. On one hand, this involves an extra redirection for anyone who hits this. But on the other hand, it makes them aware of the actual constants they should be respecting. I think it's better in the long term, especially if we change any of these.

**Testing**
Not tested, but should work!

r? @GabrielMajeri 

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-07-28 17:56:05 +00:00
Dzmitry Malyshau b16640cdc4 Refactor pipeline creation to check the resource counts earlier 2020-07-28 13:55:07 -04:00
Dzmitry Malyshau 6e10518f12 Reformat the alignment errors, add a stride check 2020-07-28 11:48:49 -04:00
bors[bot]andGabriel Majeri c77f4de5a6 Merge #841
841: Safe error handling for queue module r=kvark a=GabrielMajeri

**Connections**
Part of #638 

**Description**
Adds error types for the `queue.rs` module. The out-of-memory conditions are reported upwards, other internal `gfx-hal` errors are unwrapped.

**Testing**
Tested with core and player.


Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
2020-07-27 16:34:32 +00:00
Gabriel Majeri 8316e9e678 Safe error handling for queue module 2020-07-26 17:49:53 +03:00
bors[bot]andConnor Fitzgerald 26eb6c0882 [rs] Merge #476
476: Convert to tracing for logging and add fmt logger r=kvark a=cwfitzgerald

wgpu-rs half of https://github.com/gfx-rs/wgpu/pull/835

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-07-26 04:46:37 +00:00
Connor Fitzgerald 927d80e0af [rs] Convert to tracing for logging and add fmt logger 2020-07-26 00:44:39 -04:00
bors[bot]andConnor Fitzgerald 11b3a95671 Merge #835
835: Convert all logging to tracing and add fmt logger r=kvark a=cwfitzgerald

**Connections**

#289 ish.

**Description**

This converts us fully to tracing, allowing traces to show up in logs.

https://github.com/gfx-rs/wgpu-rs/pull/476 should be considered at the same time as this PR.

**Testing**

Ran examples in wgpu-rs.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-07-26 04:00:54 +00:00
Connor Fitzgerald cb485f3798 Convert all logging to tracing and add fmt logger 2020-07-25 19:33:21 -04:00
bors[bot]andGabriel Majeri 67cab07e46 [rs] Merge #469
469: Update to latest `wgpu-core` device error handling r=kvark a=GabrielMajeri

Corresponding PR for https://github.com/gfx-rs/wgpu/pull/832

Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
2020-07-25 14:39:38 +00:00
Gabriel Majeri 3eec74cd9c [rs] Unwrap errors from device functions 2020-07-25 07:46:32 +03:00
bors[bot]andDzmitry Malyshau da863bd5f9 [rs] Merge #481
481: Remove screenshots from README r=grovesNL a=kvark

Screenshots cover a ton of space, and now we have a dedicated hosted gallery for them.
I'm open to the idea of having *some* smaller screenshots here. It's just difficult to draw the line. Maybe README should show a few screenshots of examples only, and the gallery would not have them?

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-07-25 03:52:41 +00:00
Dzmitry Malyshau 0ebc8adc58 [rs] Remove screenshots from README 2020-07-24 23:37:10 -04:00
Josh Groves 115c29c022 [msl] Cast single-component scalars (#115)
* [msl] Cast single-component scalars

* [msl] Allow `BinaryOperator::And`
2020-07-24 22:48:14 -04:00
bors[bot]andmemoryruins be70c758bb [rs] Merge #480
480: Fix the link to friend applications in the readme r=kvark a=memoryruins

The current link <sup> [1] </sup> brings one to a "Create new page" form for the wiki instead of the intended page <sup> [2] </sup>.
[1] https://github.com/gfx-rs/wgpu-rs/wiki/Applications
[2] https://github.com/gfx-rs/wgpu-rs/wiki/Applications-and-Libraries

Co-authored-by: memoryruins <memoryruinsmusic@gmail.com>
2020-07-25 00:42:55 +00:00
bors[bot]andDzmitry Malyshau 6182495102 Merge #838
838: wait for buffer to be done in the player r=cwfitzgerald a=kvark

**Connections**
Fixes our code enough to replay #834 without issues. Doesn't help to solve the original problem though.

**Description**
There are two things in here:
  1. don't deduplicate the BGLs if we are not generating new IDs at this layer. This helps Servo/Gecko/player. cc @kunalmohan 
  2. have an option in `buffer_destroy` to *actually* kill it, at the cost of blocking on GPU sometimes. This is required for the player, since the very next command may try to reuse the ID.

**Testing**
Tested on the trace in #834 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-07-24 22:57:04 +00:00
memoryruins 6dbbc0bd7a [rs] Fix the link to friend apllications in the readme
The current link brings one to a "Create new page" form for the wiki instead of the intended page.
2020-07-24 18:45:05 -04:00
bors[bot]andConnor Fitzgerald 645b43b0c7 Merge #839
839: Fix push constant pipeline invalidation r=kvark a=cwfitzgerald

**Connections**

Fixes #821

**Description**

We need to invalidate everything if push constants change. This code is kinda ugly but this is try three and it's the least terrible I got.

**Testing**

Pinging @Wumpf :)

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-07-24 22:26:30 +00:00
Connor Fitzgerald b9498952a1 Fix push constant pipeline invalidation 2020-07-24 18:19:36 -04:00
bors[bot]andConnor Fitzgerald 2c62e86792 [rs] Merge #479
479: Split framework limit situation into requested/required r=kvark a=cwfitzgerald

Requiring individual examples be responsible for panicing if their features aren't supported is a bit bug-prone, so this encodes requirements in the framework and enforces it in the framework.

Additionally made the verbs consistent.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-07-24 21:39:46 +00:00
Connor Fitzgerald 41cadccf3a [rs] Split framework limit situation into requested/required, enforcing correctness in the framework 2020-07-24 17:37:04 -04:00
bors[bot]andGabriel Majeri 102d69eb58 Merge #832
832: Return errors from device functions r=kvark a=GabrielMajeri

**Connections**
Part of #638 

**Description**
Lots of changes, but they should be easily reviewable commit-by-commit.

- Error types for most of the fallible resource creation errors in `device/mod.rs`

- Removed assertions and replaced them with error types

- All of the `BufferMap`, `BufferNotMapped` etc. errors were united in a single `BufferAccessError`, since it was pretty weird to have so many overlapping error types.

- Removed all `unwrap`s of `gfx-hal` errors - they are now returned to the caller.

**Testing**
Checked with core and tested with `wgpu-rs` (see https://github.com/gfx-rs/wgpu-rs/pull/469)

Co-authored-by: Gabriel Majeri <gabriel.majeri6@gmail.com>
2020-07-24 20:43:56 +00:00
Gabriel Majeri 7cf9970121 Error handling for device functions 2020-07-24 22:56:51 +03:00
bors[bot]andAndrea Nardi 53fa5104f7 [rs] Merge #475
475: Made RenderBundleEncoder derive Debug r=kvark a=Andful

This is a continuation of the pull request #466 and should resolve the issue #458.

Co-authored-by: Andrea Nardi <buongiorno19972@gmail.com>
2020-07-24 19:11:05 +00:00
Dzmitry Malyshau 7e4ce4a4fe wait for buffer to be done in the player 2020-07-24 14:34:18 -04:00
bors[bot]andMarvin Löbel b98bf6da98 [rs] Merge #477
477: Add more cows r=cwfitzgerald,kvark a=Kimundi



Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-07-24 15:57:02 +00:00
Marvin Löbel 340f45200c [rs] Fix missing cows in some places 2020-07-24 17:24:30 +02:00
Andrea Nardi 9abd9f9449 [rs] Made RenderBundleEncoder derive Debug
Signed-off-by: Andrea Nardi <buongiorno19972@gmail.com>
2020-07-24 14:59:40 +02:00
bors[bot]andDzmitry Malyshau 04248d07a2 [rs] Merge #473
473: Update wgpu, use defaults for rasterizer states, use depth-clamping r=straightforward a=kvark

Includes https://github.com/gfx-rs/wgpu/pull/833 last

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-07-24 02:36:24 +00:00
Dzmitry Malyshau e97bda20b2 [rs] Update wgpu, use defaults for rasterizer states, use depth-clamping 2020-07-23 22:35:13 -04:00