Commit Graph
8897 Commits
Author SHA1 Message Date
bors[bot]andDzmitry Malyshau a96b2d6b1e [rs] Merge #174
174: Update wgpu and disable no_redirection_bitmap r=kvark a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-02-10 00:28:37 +00:00
Dzmitry Malyshau be4e88cafd [rs] Update wgpu revision 2020-02-09 19:25:41 -05:00
Dzmitry Malyshau ebb7366f3d [rs] Disable no_redirection_bitmap on Windows 2020-02-09 19:25:34 -05:00
bors[bot]andDzmitry Malyshau 24710207cb [rs] Merge #169
169: Disable window bitmap redirection r=kvark a=kvark

That sets `WS_EX_NOREDIRECTIONBITMAP`. According to @raphlinus, makes our resize better :)
There are still strange pauses I see on resizing with DX12 (with and without the change), to be followed-up.

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-02-02 05:27:45 +00:00
Dzmitry Malyshau 6e9145b71f [rs] Disable window bitmap redirection 2020-02-02 00:21:51 -05:00
bors[bot]andDzmitry Malyshau 0ecc0f307e [rs] Merge #168
168: Enforce life times of render pass attachments r=kvark a=kvark

Fixes #167

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-01-31 20:30:58 +00:00
Dzmitry Malyshau 109d5e184d [rs] Enforce life times of render pass attachments 2020-01-31 13:18:46 +01:00
bors[bot]andIstvan Miklos d4a46cb60e Merge #479
479: Serialize BindGroupBinding r=kvark a=imiklos



Co-authored-by: Istvan Miklos <istvan.miklos@h-lab.eu>
2020-01-28 12:41:08 +00:00
Istvan Miklos 38ba0e625a Serialize BindGroupBinding 2020-01-28 12:47:23 +01:00
bors[bot]anddaxpedda 9d12a30918 Merge #475
475: Return custom `AdapterInfo` that contains backend. r=kvark a=daxpedda

When requesting an `Adapter` in combination with `BackendBit::all()`, there was no way to determine what backend was ultimately chosen.

This change implements a custom `AdapterInfo` that contains a field with `Backend`, it does otherwise not differ from `gfx_hal::adapter::AdapterInfo`.

The only question I have is about `serde` implementation, currently I can't derive de/serialization from it because of `DeviceType`. This could be fixed by activating the `serde` feature in `gfx-hal`, which isn't possible (as far as i know) without renaming our current `serde` feature.

Co-authored-by: daxpedda <daxpedda@gmail.com>
2020-01-28 11:00:11 +00:00
Dzmitry Malyshau 43f48c85db Readme update with a new logo 2020-01-27 17:05:26 -05:00
daxpedda cd8e2a30b2 Duplicate DeviceType from gfx-hal. 2020-01-26 23:09:58 +01:00
daxpedda 8c80557dd6 Return custom AdapterInfo that contains backend. 2020-01-25 18:22:34 +01:00
bors[bot]andDzmitry Malyshau 31edc4209f [rs] Merge #166
166: Reduce Rust requirements for Pin usage r=auto a=kvark

That lowers Rust requirement from 1.39 to 1.33
Important, since Ubuntu packages are still on 1.37

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-01-24 01:02:23 +00:00
Dzmitry Malyshau 37a8217163 [rs] Reduce Rust requirements for Pin usage 2020-01-23 20:01:01 -05:00
bors[bot]andDzmitry Malyshau 851542a26f [rs] Merge #165
165: Update wgpu-core r=trivial a=kvark



Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-01-24 00:14:55 +00:00
Dzmitry Malyshau ae66c0d9f4 [rs] Update wgpu-core 2020-01-23 19:14:16 -05:00
bors[bot]andAlmar Klein 009bde0f90 Merge #468
468: Switch value of BufferUsage's INDIRECT and STORAGE_READ fields r=kvark a=almarklein

Closes #467. This makes the value of `INDIRECT` equal to it's value in the IDL spec. (`STORAGE_READ` is not present in the IDL spec.)

I changed the value in `resource.rs` and then ran `make ffi/wgpu.h`.


Co-authored-by: Almar Klein <almar.klein@gmail.com>
2020-01-23 16:26:53 +00:00
bors[bot]andyanchith b7cdf90cbe Merge #471
471: Run clippy only when not on nightly r=kvark a=yanchith

... otherwise run `check`

https://github.com/gfx-rs/wgpu/pull/468#issuecomment-577451412

Co-authored-by: yanchith <yanchi.toth@gmail.com>
2020-01-23 15:54:16 +00:00
yanchith dca7d54fd3 Run clippy only when not on nightly 2020-01-23 16:05:44 +01:00
bors[bot]andDzmitry Malyshau 61d9e87c6b Merge #470
470: Fix building on Rust 1.37 r=kvark a=kvark

It doesn't like by-move pattern with an `if`

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-01-23 05:52:38 +00:00
Dzmitry Malyshau b9e7449b43 Fix building on Rust 1.37
It doesn't like by-move pattern with an `if`
2020-01-23 00:52:04 -05:00
Almar Klein 299a051db1 Switch value of BufferUsage's INDIRECT and STORAGE_READ fields
This makes the value of INDIRECT equal to it's value in the IDL spec.
(STORAGE_READ is not present in the IDL spec).
2020-01-22 08:07:07 +01:00
bors[bot]andDzmitry Malyshau c59e35e9cb Merge #466
466: Refactored swapchain tracking r=sibling a=kvark

This is a sibling of #465 for master.
Fixes #227

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-01-21 19:27:06 +00:00
Dzmitry Malyshau 8a5de68aab Refactor the swap chain frame tracking 2020-01-21 14:24:45 -05:00
Dzmitry Malyshau ec54038e7c Improve STORAGE_READ support for buffers 2020-01-21 14:13:27 -05:00
Dzmitry Malyshau ad7045455c Optionally request vertex shader stores and atomics 2020-01-21 14:12:08 -05:00
bors[bot]andLogan McGrath 5e6eba05bb Merge #462
462: Using default nsview if not provided by raw-window-handle r=kvark a=lmcgrath

Per #453 I've added some native code to get the default `NSView` if it's not provided by `RawWindowHandle`. This is to support libraries like SDL2 which expose an `NSWindow` but no `NSView`. I'm using the [`[NSWindow contentView]`](https://developer.apple.com/documentation/appkit/nswindow/1419160-contentview) property to get the `NSView`.

Co-authored-by: Logan McGrath <1755866+lmcgrath@users.noreply.github.com>
2020-01-18 18:17:23 +00:00
Logan McGrath 7927f4cb2b Using default nsview if not provided by raw-window-handle 2020-01-18 10:06:10 -08:00
bors[bot]andyanchith 7387bd1a4d Merge #461
461: Add Clippy to CI, fix errors and most warnings r=kvark a=yanchith

A quick rundown of changes:

- Fixed instances of clippy error [not_unsafe_ptr_arg_deref](https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref): Some extern functions in wgpu-remote are now marked unsafe, as they accessed data behind raw pointer via `Box::from_raw` and `slice::from_raw_parts` (commit https://github.com/gfx-rs/wgpu/commit/741844cc2b3a2944a31455974bcd1df76a115380)

- Fixed clippy warning [or_fun_call](https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call) by changing `unwrap_or` to `unwrap_or_else`

- Added `#[allow(clippy::range_plus_one)]` in places where ranges are constructed along with TODOs to fix upstream in gfx. The rule [range_plus_one](https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one) is great if you have everything in one crate, but the gfx hal structs expect `Range` instead of the more generic `RangeBounds` trait.

- Fixed quite a few clippy warnings [missing_safety_doc](https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc) in the trivial cases (`Box::from_raw` and `slice::from_raw_parts`).

There's still a few `missing_safety_doc` warnings left. They all have in common the usage of the unsafe functions `RawPass::encode` and `RawPass::encode_slice`. I think these could potentially be made safe - it seems like `RawPass` manages its invariants internally, but I might be missing something.

I didn't add CI code that posts the warnings to github PR comments, but if anyone is willing to pick that up, this could help: https://github.com/dpobel/damien.pobel.fr/pull/62/files

Fixes: #422

Co-authored-by: yanchith <yanchi.toth@gmail.com>
2020-01-18 16:08:33 +00:00
yanchith cd114e780a Don't forget to install clippy 2020-01-17 17:58:42 +01:00
yanchith b6215db57d Modify CI script to run clippy instead of check 2020-01-17 16:30:12 +01:00
yanchith ab205b042c Add # Safery docs to wgpu-core 2020-01-17 16:15:05 +01:00
yanchith d24d7157cf Add # Safety docs to wgpu-native 2020-01-17 15:18:35 +01:00
yanchith 8414b01403 Add # Safety docs to wgpu-remote
Only two unsafe functions were used internally:

- `slice::from_raw_parts`
- `Box::from_raw`

The safety messages are adapted from the safety messages of these functions.
2020-01-17 15:04:57 +01:00
yanchith 0d9ad70468 Add TODOs for range_plus_one clippy warnings 2020-01-17 14:44:17 +01:00
yanchith 53b9a01b2f Resolve trivial clippy warning 2020-01-17 14:44:02 +01:00
yanchith 741844cc2b Fix clippy errors
In wgpu-remote, some functions are now marked `unsafe` on the outside,
because they dereferenced a raw pointer they couldn't have checked
themselves.
mozilla-bb908b9156834ac2f3b297ebac9bde2e0ed3fc2e
2020-01-17 14:20:20 +01:00
cf049fbc18 [rs] Merge #155
155: Update wgpu dependency r=grovesNL a=kvark

(needs an actual bump)

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-01-16 06:28:21 +00:00
Dzmitry Malyshau b7c4ae78f9 [rs] wgpu commit update 2020-01-15 11:06:49 -05:00
Dzmitry Malyshau 32ea1638fc [rs] Enforce lifetimes of resource dependencies of passes 2020-01-15 11:06:19 -05:00
Dzmitry Malyshau 89dbdc8130 [rs] Update to wgpu version with raw passes 2020-01-15 11:06:19 -05:00
bors[bot]andLayl 3a41272cba Merge #448
448: Fix framebuffers not always being cleaned up if invalid r=kvark a=LaylConway

This changes framebuffers to be cleaned up if only one view is cleaned up, instead of if all views are cleaned up. This is necessary because currently, at least for me, swapchain images will have a different view every frame. This means that if other views continue to exist between frames, the resulting framebuffers will never be cleaned up.

Fixes #447

Co-authored-by: Layl <2385329-layl@users.noreply.gitlab.com>
2020-01-15 14:24:19 +00:00
Layl 6202d5ddad Fix framebuffers not always being cleaned up if invalid 2020-01-15 15:11:16 +01:00
bors[bot]andIstvan Miklos 881222a947 Merge #451
451: Make BindGroupLayoutBinding Serializable r=kvark a=imiklos

cc @kvark @zakorgy

Co-authored-by: Istvan Miklos <istvan.miklos@h-lab.eu>
2020-01-14 20:04:21 +00:00
bors[bot]andDzmitry Malyshau a72574ae0f Merge #440
440: Stand-alone passes r=me,grovesNL a=kvark

Fixes #438 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-01-14 15:20:16 +00:00
Istvan Miklos 0fdf77feb5 Make BindGroupLayoutBinding Serializable 2020-01-14 12:43:58 +01:00
Dzmitry Malyshau a51019795e Switch to a custom fork of peek-poke 2020-01-13 16:52:59 -05:00
Dzmitry Malyshau 92441c38a2 Fix missing transitions before the render pass 2020-01-13 16:52:58 -05:00
Dzmitry Malyshau f798f7c631 Add missing render pass methods 2020-01-13 16:52:58 -05:00