Commit Graph
8897 Commits
Author SHA1 Message Date
Jim Blandy a818b2e089 Document Loop, Break, and Continue statements. 2021-07-06 13:55:09 -04:00
João Capucho e8bb7f2503 [glsl-in] Parse array initializers 2021-07-06 11:24:05 -04:00
João Capucho ee1004d443 [glsl-in] Use cast for implicit conversion
Previously this was a bitcast
2021-07-06 11:24:05 -04:00
João Capucho ee343b3017 [glsl-in] Implicit splat max builtin 2021-07-06 11:24:05 -04:00
João Capucho 7bced3f4e8 [glsl-in] Add support for all texture types 2021-07-06 11:24:05 -04:00
João Capucho 2b475ecc96 [spv-out] Support object-wise select 2021-07-06 10:12:24 -04:00
Dzmitry Malyshau 9473340c16 wgsl-in: fix auto array stride 2021-07-06 02:20:26 -04:00
bors[bot]andBenoît du Garreau d2a27e0c4e Merge #1604
1604: Upgrade `arrayvec` to 0.7 r=kvark a=a1phyr

Upgrade `arrayvec` to version 0.7 (using const generics).

Co-authored-by: Benoît du Garreau <bdgdlm@outlook.com>
2021-07-06 05:31:22 +00:00
Dzmitry Malyshau c69736210a Snapshot test local variable inference 2021-07-06 01:26:03 -04:00
Dzmitry Malyshau beabd62d96 wgsl: type inference for local variables 2021-07-06 01:26:03 -04:00
Dzmitry Malyshau 2efccb2bf8 hal/vk: fix indirect stage flag 2021-07-06 00:56:43 -04:00
bors[bot]andMikko Lehtonen 782a5bc831 Merge #1606
1606: Fix macos build r=cwfitzgerald a=scoopr

Building on macos failed with
```
   Compiling wgpu-hal v0.9.0 (/Users/scoopr/Code/ext/wgpu/wgpu-hal)
error[E0609]: no field `entry` on type `&vulkan::Instance`
   --> /Users/scoopr/Code/ext/wgpu/wgpu-hal/src/vulkan/instance.rs:267:61
    |
267 |             let metal_loader = ext::MetalSurface::new(&self.entry, &self.shared.raw);
    |                                                             ^^^^^ unknown field
    |
    = note: available fields are: `shared`, `extensions`

error: aborting due to previous error
```

The PR fixes the issue.

Co-authored-by: Mikko Lehtonen <scoopr@iki.fi>
2021-07-06 00:25:08 +00:00
Mikko Lehtonen 7e277c2ed9 Fix macos build 2021-07-06 02:08:19 +03:00
Gordon-F 65fbbf1101 [hlsl-out] Return only real names on entry point in ReflectionInfo 2021-07-05 18:54:42 -04:00
Gordon-F d5776879de [hlsl-out] Enable interface snapshot testing 2021-07-05 18:54:42 -04:00
Gordon-F 2812acf8cd [hlsl-out] Handle output semantic for shader stage 2021-07-05 18:54:42 -04:00
Gordon-F 988fc90b83 [Makefile] Fix dxc params in validate-hlsl 2021-07-05 18:54:42 -04:00
Benoît du Garreau e7269e72f3 Upgrade arrayvec to 0.7 2021-07-06 00:45:24 +02:00
Joshua Groves 9192f7b882 wgsl-in: add more error tests 2021-07-05 02:24:18 -04:00
João Capucho 2f002a0594 [spv-out] Load texture arguments ahead of time 2021-07-05 02:23:00 -04:00
João Capucho c7b98f5ab9 [spv-out] accept texture trough function argument 2021-07-05 02:23:00 -04:00
bors[bot]andConnor Fitzgerald 118cf2cdba Merge #1599
1599: Fix Limits for lava/llvmpipe and re-enable and re-work CI r=kvark,groves,wumpf a=cwfitzgerald

**Connections**

No longer fixes #1551.

**Description**

This PR has a couple things going on at once.

- Fixes limits for llvmpipe, lavapipe, and rpi4.
- Added a downlevel limit to express that RPI4 does not allow storage buffers in vertex shaders on GL.
- Added a `Limits::downlevel_default()` that takes minimum limits from GLES and adds some more documentation on how to choose limits.
- Moved all examples to the new downlevel limits
- Reworks CI to re-enable software testing and unify instructions.

**Testing**

It is

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-07-04 19:23:23 +00:00
Connor Fitzgerald 130ddcf561 Unify CI and testing 2021-07-04 15:22:51 -04:00
Joshua Groves c5805a9e10 wgsl-in: add more error tests 2021-07-04 01:00:21 -04:00
bors[bot]andDzmitry Malyshau b5a73b6a80 Merge #1600
1600: Vulkan Timeline Semaphores r=kvark a=kvark

**Connections**
None

**Description**
One of the non-straightforward design decisions in wgpu-hal was to expose the fences with `D3D12Fence` semantics. Now that we got Vulkan, Metal, and GLES3, it became a bit concerning that all of these backends implemented this new fence API in the same convoluted way: via managing a pool of binary fences internally, which requires maintenance (done on submit() only). If that's the expected implementation, then the abstraction is wrong.

For this reason, it was important for me to try implementing this new semantics in a modern Vulkan way - via timeline semaphores. With this, we have 1:1 relation between `Api::Fence` and a Vulkan object. I believe the experiment is a success: Vulkan is now very efficient at fences!

**Testing**
Works on the examples!


Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-07-04 04:57:40 +00:00
Dzmitry Malyshau 3de1681eb0 hal/vk: enable timeline semaphores 2021-07-04 00:50:05 -04:00
Dzmitry Malyshau 8ae7d51c82 hal/vk: request timeline semaphores if available 2021-07-04 00:50:05 -04:00
bors[bot]andDzmitry Malyshau 93eb33cf3b Merge #1598
1598: Fix memory leak in acquiring encoders r=kvark a=kvark

**Connections**
Fixes #1501 
Fixes #1531

**Description**
It was ... interesting. We were creating new command encoders all the time, but still trying to add them to the pool to re-use later. So we were constantly allocating and never freeing them, up until the end. Therefore, program as a whole was valid and non-leaking, if analyzed after termination.

**Testing**
Observed memory manually


Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-07-04 02:34:10 +00:00
Dzmitry Malyshau b704a0542f Fix memory leak in acquiring encoders 2021-07-03 22:25:59 -04:00
Connor Fitzgerald e2bcb72bf4 Please clippy 2021-07-03 22:15:34 -04:00
Connor Fitzgerald 861e84b178 Start adjusting CI 2021-07-03 22:15:16 -04:00
Connor Fitzgerald 26f3c03150 Add downlevel limit for vertex shader access to SSBO 2021-07-03 22:15:16 -04:00
Connor Fitzgerald 93cca6d182 Fix limits for rpi on vk 2021-07-03 22:15:16 -04:00
Connor Fitzgerald a13b54ced8 Fix limits for llvmpipe 2021-07-03 22:15:16 -04:00
bors[bot]andGordon-F 762cdb3953 Merge #1589
1589: [GL] Fix min_storage_buffer_offset_alignment param r=kvark a=Gordon-F

**Connections**
Android Emulator (11) error:
```
2021-07-02 14:49:12.500 8292-8317/rust.example.cube E/emuglGLESv2_enc: device/generic/goldfish-opengl/system/GLESv2_enc/GL2Encoder.cpp:s_glGetIntegerv:876 GL error 0x500
```

**Description**
As a workaround set this parameter to default value.


Co-authored-by: Gordon-F <ishaposhnik@icloud.com>
2021-07-04 00:33:32 +00:00
bors[bot]andDzmitry Malyshau fcba9325f8 Merge #1597
1597: hal/metal: bump storage limits r=kvark a=kvark

**Connections**
Fixes #1596

**Description**
The limits where just copied from the defaults. Then we updated the defaults...

**Testing**
Just ran locally


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-07-04 00:27:35 +00:00
Dzmitry Malyshau a4a4d541b8 hal/metal: bump storage limits 2021-07-03 20:26:15 -04:00
bors[bot]andDzmitry Malyshau fd183a99ba Merge #1594
1594: Generation of memory reports for Hubs r=cwfitzgerald a=kvark

**Connections**
Part of #1501 

**Description**
Tried to see if we aren't accidentally growing the hubs.

**Testing**
Examples...


Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
2021-07-03 21:45:57 +00:00
Gordon-F a077102457 [GL] Fix min_storage_buffer_offset_alignment param 2021-07-03 22:45:45 +03:00
Dzmitry Malyshau d2a4af35af Generation of memory reports for Hubs 2021-07-03 01:51:04 -04:00
bors[bot]andDzmitry Malyshau edbe3b33fa Merge #1593
1593: Fix VVL on halmark example r=kvark a=kvark

**Connections**
We have a bunch of VVL related to resource destruction on the halmark example.
It also seems to leak memory quite a ton and eventually hang the system.

**Description**
This PR fixes the logic of changing the command pools in halmark, its initialization sequence, and its destruction.

**Testing**
Tested on halmark and others


Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
2021-07-03 05:13:18 +00:00
Dzmitry Malyshau e2f97ea659 hal/gles: detect llvmpipe instead of lavapipe 2021-07-03 01:09:39 -04:00
Dzmitry Malyshau 497c6647ee hal/vulkan: fix instance destruction logic 2021-07-03 01:07:21 -04:00
Dzmitry Malyshau b15f1ebfb7 halmark: fix the command pool recycling policy 2021-07-03 00:23:11 -04:00
bors[bot]andDzmitry Malyshau 7ab950e465 Merge #1592
1592: Detailed limits check and error r=cwfitzgerald a=kvark

**Connections**
Related to #1590

**Description**
The old comparison "A < B" was simply wrong, because it would do every field in order and could bail out mid-way without reaching for all limits.

**Testing**
Untested


Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-07-03 01:12:43 +00:00
Dzmitry Malyshau 81b382f5cd Readme and clippy fixes 2021-07-02 20:43:01 -04:00
bors[bot]andClayton Walker 62972c6c5f Merge #1591
1591: Expose calayer r=kvark a=Sineaggi

**Description**

This pr restores the ability to create a surface from a pre-existing CAMetalLayer. This is required for wgpu-native.

Co-authored-by: Clayton Walker <cwalker@sofi.org>
2021-07-03 00:23:25 +00:00
Dzmitry Malyshau 23b587246a Detailed limits check and error 2021-07-02 20:17:12 -04:00
Jasper St. Pierre 7a9fb864ad [glsl-in] Add support for gl_FragCoord / gl_FragDepth
And remove the ability to read gl_Position in fragment.
2021-07-03 00:29:44 +01:00
Clayton Walker 25c452cbdd Add metal layer back in 2021-07-02 15:51:11 -06:00