high bitrate seedance 2.5

This commit is contained in:
Brandon Thomas committed 2026-09-12 13:22:42 -04:00
1 parent 32a6e6470f
commit 9c1633bd9c
6 files changed
+98 -5

No files matched your search

+1
View File
@@ -39,6 +39,7 @@ venv/
# LLM Testing
/external/
/prompts/
/untracked/
/reports/
/requests/
@@ -1,9 +1,11 @@
use kinovi_web_client::generate::video::generate_seedance_2p5::{
KinoviSeedance2p5AspectRatio as KinoviAspectRatio,
KinoviSeedance2p5Bitrate,
KinoviSeedance2p5OutputResolution as KinoviOutputResolution,
};
use crate::api::router_aspect_ratio::RouterAspectRatio;
use crate::api::router_bitrate::RouterBitrate;
use crate::api::router_resolution::RouterResolution;
use crate::client::request_mismatch_mitigation_strategy::RequestMismatchMitigationStrategy;
use crate::errors::artcraft_router_error::ArtcraftRouterError;
@@ -64,8 +66,10 @@ fn do_build_kinovi_seedance_2p5(mut builder: GenerateVideoRequestBuilder) -> Res
let total_input_seconds = builder.total_reference_video_input_seconds
.map(|seconds| u8::try_from(seconds).unwrap_or(u8::MAX));
// NB: `builder.bitrate` is intentionally ignored — 2.5 has no bitrate
// option (and bitrate never affects cost).
let maybe_bitrate = match builder.bitrate.take() {
Some(RouterBitrate::High) => Some(KinoviSeedance2p5Bitrate::High),
Some(RouterBitrate::Normal) | None => None,
};
let unhandled_request_state = KinoviSeedance2p5RemainingItems {
start_frame: builder.start_frame.take(),
@@ -81,6 +85,7 @@ fn do_build_kinovi_seedance_2p5(mut builder: GenerateVideoRequestBuilder) -> Res
duration_seconds,
prompt,
total_input_seconds,
maybe_bitrate,
unhandled_request_state: Some(unhandled_request_state),
})
}
@@ -246,6 +251,7 @@ fn plan_duration(
#[cfg(test)]
mod tests {
use kinovi_web_client::creds::kinovi_web_session::KinoviWebSession;
use kinovi_web_client::generate::video::generate_seedance_2p5::{
KinoviSeedance2p5AspectRatio as KinoviAspectRatio,
KinoviSeedance2p5OutputResolution as KinoviOutputResolution,
@@ -261,13 +267,50 @@ mod tests {
use crate::api::router_video_model::RouterVideoModel;
use crate::api::video_list_ref::VideoListRef;
use crate::client::request_mismatch_mitigation_strategy::RequestMismatchMitigationStrategy;
use crate::client::router_client::RouterClient;
use crate::client::router_kinovi_web_client::RouterKinoviWebClient;
use crate::generate::generate_video::generate_video_request_builder::GenerateVideoRequestBuilder;
use crate::generate::generate_video::providers::kinovi::seedance_2p5::cost::KinoviSeedance2p5CostState;
use crate::generate::generate_video::providers::kinovi::seedance_2p5::draft::KinoviSeedance2p5DraftState;
use crate::generate::generate_video::video_generation_draft::VideoGenerationDraftRequest;
use crate::generate::generate_video::video_generation_draft_context::VideoGenerationDraftContext;
use crate::generate::generate_video::video_generation_draft_or_request::VideoGenerationDraftOrRequest;
use super::*;
#[tokio::test]
async fn bitrate_survives_finalization_without_changing_cost() {
let client = RouterClient::KinoviWeb(RouterKinoviWebClient::new(
KinoviWebSession::from_cookies_string(String::new()),
));
let context = VideoGenerationDraftContext {
client: Some(&client),
..Default::default()
};
let baseline = unwrap_draft(build_kinovi_seedance_2p5(base_builder()));
let baseline_cost = KinoviSeedance2p5CostState::from_draft(&baseline).estimate_cost();
for bitrate in [None, Some(RouterBitrate::Normal), Some(RouterBitrate::High)] {
let mut draft = unwrap_draft(build_kinovi_seedance_2p5(GenerateVideoRequestBuilder {
bitrate,
..base_builder()
}));
let draft_cost = KinoviSeedance2p5CostState::from_draft(&draft).estimate_cost();
// No media inputs: finalization needs no network calls or credentials.
let finalized = draft.to_request(&context).await.expect("finalize should succeed");
assert_eq!(
matches!(finalized.request.maybe_bitrate, Some(KinoviSeedance2p5Bitrate::High)),
matches!(bitrate, Some(RouterBitrate::High)),
);
let final_cost = KinoviSeedance2p5CostState::from_request(&finalized).estimate_cost();
for cost in [draft_cost, final_cost] {
assert_eq!(cost.cost_in_credits, baseline_cost.cost_in_credits);
assert_eq!(cost.cost_in_usd_cents, baseline_cost.cost_in_usd_cents);
}
}
}
mod materialized_field_conversions {
use super::*;
@@ -91,6 +91,7 @@ impl KinoviSeedance2p5CostState {
duration_seconds: self.duration_seconds,
total_input_seconds,
use_face_blur_hack: None,
maybe_bitrate: None,
};
// Enterprise tier: what generations actually cost us (our discounted
@@ -1,5 +1,5 @@
use kinovi_web_client::generate::video::generate_seedance_2p5::{
GenerateSeedance2p5Request, KinoviSeedance2p5AspectRatio, KinoviSeedance2p5Modality,
GenerateSeedance2p5Request, KinoviSeedance2p5AspectRatio, KinoviSeedance2p5Bitrate, KinoviSeedance2p5Modality,
KinoviSeedance2p5OutputResolution,
};
@@ -32,6 +32,8 @@ pub struct KinoviSeedance2p5DraftState {
/// all reference videos (each rounded up to a whole second).
pub total_input_seconds: Option<u8>,
pub maybe_bitrate: Option<KinoviSeedance2p5Bitrate>,
pub unhandled_request_state: Option<KinoviSeedance2p5RemainingItems>,
}
@@ -111,6 +113,7 @@ impl KinoviSeedance2p5DraftState {
duration_seconds: self.duration_seconds,
total_input_seconds: self.total_input_seconds,
use_face_blur_hack: None,
maybe_bitrate: self.maybe_bitrate,
};
Ok(KinoviSeedance2p5RequestState { request })
@@ -6,7 +6,7 @@ use crate::pricing::kinovi_pricing_rate::KinoviPricingRate;
use crate::pricing::kinovi_pricing_tier::KinoviPricingTier;
use crate::requests::kinovi_host::KinoviHost;
use crate::requests::workflow_run_task::workflow_run_task::{
workflow_run_task, KinoviAspectRatioRaw, KinoviBatchCountRaw, KinoviModelTypeRaw,
workflow_run_task, KinoviAspectRatioRaw, KinoviBatchCountRaw, KinoviBitrateRaw, KinoviModelTypeRaw,
KinoviOutputResolutionRaw, WorkflowRunTaskArgs, WorkflowRunTaskRequest,
};
@@ -60,6 +60,10 @@ pub struct GenerateSeedance2p5Request {
/// Controls `faceBlurMode`: true sends "on"; false or None sends "off"
/// (the model always sends the field, like 2.5 Preview).
pub use_face_blur_hack: Option<bool>,
/// Output video bitrate. None keeps the standard bitrate; `High` requests
/// a higher bitrate. This does not select a container or lossless codec.
pub maybe_bitrate: Option<KinoviSeedance2p5Bitrate>,
}
// ── Modality ──
@@ -115,6 +119,11 @@ pub enum KinoviSeedance2p5OutputResolution {
TenEightyP,
}
#[derive(Debug, Clone, Copy)]
pub enum KinoviSeedance2p5Bitrate {
High,
}
// ── Pricing ──
//
// Seedance 2.5 credit pricing (credits per billed second). Without video
@@ -295,7 +304,14 @@ fn to_raw_request(req: GenerateSeedance2p5Request) -> WorkflowRunTaskRequest {
reference_audio_urls,
character_ids: None,
use_face_blur_hack: req.use_face_blur_hack,
bitrate: None,
bitrate: map_bitrate(req.maybe_bitrate),
}
}
fn map_bitrate(maybe_bitrate: Option<KinoviSeedance2p5Bitrate>) -> Option<KinoviBitrateRaw> {
match maybe_bitrate {
Some(KinoviSeedance2p5Bitrate::High) => Some(KinoviBitrateRaw::High),
None => None,
}
}
@@ -748,6 +764,7 @@ mod tests {
duration_seconds,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
}
}
@@ -774,6 +791,7 @@ mod tests {
duration_seconds: duration,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
}
}
@@ -833,9 +851,11 @@ mod tests {
duration_seconds: 8,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
});
assert!(matches!(raw.model_type, KinoviModelTypeRaw::Seedance2p5));
assert!(raw.bitrate.is_none());
assert_eq!(raw.start_frame_url.as_deref(), Some("https://example.com/start.png"));
assert_eq!(raw.end_frame_url.as_deref(), Some("https://example.com/end.png"));
assert!(raw.reference_image_urls.is_none());
@@ -857,9 +877,11 @@ mod tests {
duration_seconds: 8,
total_input_seconds: Some(7),
use_face_blur_hack: None,
maybe_bitrate: Some(KinoviSeedance2p5Bitrate::High),
});
assert!(matches!(raw.aspect_ratio, KinoviAspectRatioRaw::UltraWide21x9));
assert!(matches!(raw.bitrate, Some(KinoviBitrateRaw::High)));
assert!(raw.start_frame_url.is_none());
assert!(raw.end_frame_url.is_none());
assert_eq!(raw.reference_image_urls.as_deref().map(|urls| urls.len()), Some(1));
@@ -881,6 +903,7 @@ mod tests {
duration_seconds: 4,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
});
assert!(matches!(raw.output_resolution, Some(KinoviOutputResolutionRaw::TenEightyP)));
@@ -900,6 +923,7 @@ mod tests {
duration_seconds: 5,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
});
assert!(matches!(raw.aspect_ratio, KinoviAspectRatioRaw::Landscape16x9));
@@ -929,6 +953,7 @@ mod tests {
duration_seconds: 5,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
},
}).await?;
println!("t2v 480p — task_id={}, order_id={}", result.task_id, result.order_id);
@@ -960,6 +985,7 @@ mod tests {
duration_seconds: 4,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
},
}).await?;
println!("t2v 1080p — task_id={}, order_id={}", result.task_id, result.order_id);
@@ -987,6 +1013,7 @@ mod tests {
duration_seconds: 4,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
},
}).await?;
println!("keyframe 1080p — task_id={}, order_id={}", result.task_id, result.order_id);
@@ -1014,6 +1041,7 @@ mod tests {
duration_seconds: 8,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
},
}).await?;
println!("keyframe 480p — task_id={}, order_id={}", result.task_id, result.order_id);
@@ -1046,6 +1074,7 @@ mod tests {
duration_seconds: 8,
total_input_seconds: None,
use_face_blur_hack: None,
maybe_bitrate: None,
},
}).await?;
println!("reference 480p — task_id={}, order_id={}", result.task_id, result.order_id);
@@ -1,5 +1,6 @@
use artcraft_api_defs::omni_gen::models::omni_gen_video_models::OmniGenVideoModelDetails;
use enums::common::generation::common_aspect_ratio::CommonAspectRatio;
use enums::common::generation::common_bitrate::CommonBitrate;
use enums::common::generation::common_resolution::CommonResolution;
use enums::common::generation::common_video_model::CommonVideoModel;
use enums::common::generation::model_creator::ModelCreator;
@@ -42,6 +43,11 @@ pub fn seedance_2p5_video_models() -> Vec<OmniGenVideoModelDetails> {
CommonResolution::TenEightyP,
]),
resolution_default: Some(CommonResolution::SevenTwentyP),
bitrate_options: Some(vec![
CommonBitrate::Normal,
CommonBitrate::High,
]),
bitrate_default: Some(CommonBitrate::Normal),
batch_size_options: Some(vec![1]),
batch_size_default: Some(1),
duration_seconds_min: Some(4),
@@ -84,6 +90,11 @@ pub fn seedance_2p5_video_models() -> Vec<OmniGenVideoModelDetails> {
CommonResolution::TenEightyP,
]),
resolution_default: Some(CommonResolution::SevenTwentyP),
bitrate_options: Some(vec![
CommonBitrate::Normal,
CommonBitrate::High,
]),
bitrate_default: Some(CommonBitrate::Normal),
batch_size_options: Some(vec![1]),
batch_size_default: Some(1),
duration_seconds_min: Some(4),
@@ -125,6 +136,11 @@ pub fn seedance_2p5_video_models() -> Vec<OmniGenVideoModelDetails> {
CommonResolution::SevenTwentyP,
]),
resolution_default: Some(CommonResolution::SevenTwentyP),
bitrate_options: Some(vec![
CommonBitrate::Normal,
CommonBitrate::High,
]),
bitrate_default: Some(CommonBitrate::Normal),
batch_size_options: Some(vec![1]),
batch_size_default: Some(1),
duration_seconds_min: Some(4),