Commit Graph
922 Commits
Author SHA1 Message Date
Alex Joaquim Pereira e09888e146 Sweep leftover agent sessions when the desktop app starts (R2.2) (#1422)
A coding agent's turn killed mid-turn leaves a record of its session, which was removed only at the next agent turn or on uninstall; meanwhile the agent's own background service could carry on a session nobody was watching. The desktop app now sweeps those records when it starts, on a background thread, with the same rules as any sweep: a record a running turn holds is left alone, and a delete that fails is kept for the next sweep.
2026-11-10 02:06:22 +07:00
dbzx6r 133e29d619 Find bundled Codex on macOS and check an agent's sign-in (R2.2) (#1414)
Started from the Dock, the app has a short PATH, so a Codex installed inside the ChatGPT or Codex app wasn't found. It's now looked for in those apps' known bundle locations (never the app's own executable), after an explicit program and PATH. Testing a local coding agent in Settings → AI (or `ai test`) now also asks its adapter whether it's signed in, without sending a prompt, and Codex only gives sign-in advice for real authentication failures.
2026-11-10 01:28:29 +07:00
Alex Joaquim Pereira cf2a8ad0b0 Study again when a build's kept conversation is from the other mode (R2.9) (#1418)
A coding agent's saved session counted as the project's history whatever mode it ran in, so after switching between Clean room and Deep a run could skip its study and build from the other mode's capture. A saved session or transcript now counts only in its own mode (one saved before the mode was kept counts as Deep); one from the other mode makes the run study again and replace the capture before the builder is briefed, including an API follow-up whose transcript was rejected for its mode.
2026-11-10 01:28:05 +07:00
Louis Cerclé-Cheminel eb03911dbb Tell a builder's check that is still going from no build running, and wait past the run's own limit (R2.9) (#1417)
rebuild_check said "no build is running" when the run had taken the check and one of its steps hadn't finished, and the builder gave up after its default 20 minutes, below the run's own 30-minute limit on a check. The run now marks a check request it takes, the tool says "still going" apart from "no run took it", and its default wait (35 minutes) outlasts the run's limit, so the run reports a stuck check itself.
2026-11-10 01:17:07 +07:00
Louis Cerclé-Cheminel 1b4352cb0c Remember a Deep-mode decompile across requests, so the builder isn't told it hasn't decompiled after each one (R2.9) (#1403)
In Deep mode, a builder that hadn't decompiled anything was reminded to, but whether it had was kept only for one run, and each request from the person starts a new run. So a builder that had read the original's functions earlier was told "You haven't decompiled anything yet" after every request. It's now kept in the project's craft.json, so a decompile in any run counts.
2026-11-10 00:36:19 +07:00
Alex Joaquim Pereira d52d1a0531 Count a Claude Code question's own cost (R2.9) (#1404)
A question answered from a fork of the builder's Claude Code session reported the whole session's running total, so its cost was hidden. It's now what the total added since the builder's last turn, read before the question starts, and unknown when there's no kept total, never the session's total. The question's cost is added to the project's usage, and a build turn and a question saving their costs at the same time no longer overwrite each other.
2026-11-10 00:32:59 +07:00
Afloat 2174cac80b Reject GNU tar long-name records that end before their padding (#1402)
A GNU long-name or long-link record whose text was complete but whose 512-byte padding was cut off, or whose padded size overflowed, stopped the listing without saying why, so the engine installer could still write the files listed before it and report success. Both cases now count as a cut-short GNU record, and the installer refuses the archive before writing anything.
2026-11-10 00:27:22 +07:00
Afloat a80cc82539 Reject ASAR manifest nodes with invalid file metadata (#1364)
An ASAR manifest whose nodes aren't objects, are both a folder and a link, have a link that isn't text, have no size, a non-boolean `unpacked` flag, or a packed file with no offset is now reported as damaged instead of being listed with made-up values.
2026-11-10 00:25:55 +07:00
Afloat 69e7f5773d Refuse incomplete tar engine installs after GNU metadata stops (#1394)
When a tar listing stopped at a GNU long name or link it refused (too long, or cut short), the engine installer still wrote the files listed before it and reported success, which could replace a working engine with part of one. The listing now says why it stopped, and the installer refuses such an archive before writing anything, with a plain-English error. An archive missing only its end marker still installs.
2026-11-09 23:34:38 +07:00
Afloat 092aef2474 Extract ZIP LZMA members with checked framing and output limits (#1375)
ZIP entries compressed with LZMA (method 14) were listed and not read. They're now extracted with the same output limit, size and CRC checks as other methods, whether the stream gives its size or ends with a marker; the dictionary is held to the output limit, and properties of another size are reported as unsupported.
2026-11-09 23:31:28 +07:00
Afloat aa8bba98e2 Keep GNU sparse tar payloads out of regular-file extraction (#1382)
A GNU sparse member stores only some extents of its file, and was extracted as if those were the whole file. It's now listed as another kind of member with a warning, under the name GNU.sparse.name gives when there is one.
2026-11-09 23:31:22 +07:00
Afloat 4a0c164da8 Preserve unambiguous ELF import slots across version-library metadata (R3.12) (#1393)
A versioned ELF import names its library while its relocation slot doesn't, so since slots were matched by name and library, such imports lost their slot address. An import now takes a slot of its own library first, then a slot with no library only when the name belongs to one library and has one address.
2026-11-09 23:29:56 +07:00
Afloat cdc8a880f1 Enforce standalone LZMA budgets before large dictionary growth (#1381)
A standalone LZMA stream's declared size is now checked against the output limit before decoding, and its dictionary is held to the limit, so a damaged stream can't grow a large window before failing.
2026-11-09 23:11:29 +07:00
Afloat f2392fe9c7 Extract ZIP entries compressed with bzip2 or XZ (#1374)
ZIP entries compressed with bzip2 (method 12) or XZ (method 95) were reported and not read. They're now extracted with the same output limit, size and CRC checks as deflated entries.
2026-11-09 23:11:22 +07:00
Afloat a9f7cf1fa5 Read complete gzip packed members and verify their trailers (#1372)
A gzip member in a packed bundle was inflated without its trailer being checked, and only its first gzip member was read. Every member is now read, within the size limit, and each trailer's checksum and length must match.
2026-11-09 23:11:16 +07:00
Afloat a1c93f15b7 Validate gzip header checksums without rejecting informational fields (#1371)
A gzip header with the optional header checksum (FHCRC) is now checked against it. The extra-flags and operating-system bytes, which are only informational, no longer make a valid header be refused, while reserved flags still do.
2026-11-09 23:09:07 +07:00
Afloat f19f304482 Keep PyInstaller CArchive members inside the payload (#1363)
A member whose stored bytes reach past the start of the archive's table, into the table, cookie or a signature after it, could be read as that member. Such members are now unreadable, with a note counting them, and a PYZ there supplies no nested members.
2026-11-09 23:09:00 +07:00
Afloat f7b985cd3f Reject Objective-C method records shorter than their declared layout (R3.12) (#1387)
A method list whose record size was smaller than a method record, or whose last record was only partly in the file, was still read, so methods came from whatever bytes followed. A list now needs records of at least 24 bytes (12 for relative ones), each wholly in the file, and longer extended records still read.
2026-11-09 23:05:42 +07:00
Afloat 4824e31d5f Keep embedded Godot pack reads before the trailer (R3.12) (#1379)
A Godot pack embedded in an executable ends before its trailer, and a member's data could run into the trailer. The file table and members are now read only before it, and a member that would reach past it isn't readable.
2026-11-09 22:55:43 +07:00
Afloat 1c4f233f08 Reject Java constants that exceed the constant-pool slots (R3.12) (#1373)
A `long` or `double` constant takes two constant-pool slots, and one in the last slot was read past the pool's declared count. Such a constant is now refused as a damaged class, with no overflow at the largest pool size.
2026-11-09 22:54:35 +07:00
Afloat 7073462fcc Decode Unreal floating-point texture formats (R3.9) (#1392)
Cooked Unreal textures in half- and full-precision float formats (R16F, G16R16F, FloatRGBA, R32_FLOAT, G32R32F, A32B32G32R32F and the filtered half aliases) were reported as unsupported. They're now decoded with the shared float reader: colour becomes 8-bit sRGB, alpha stays linear, and values outside the range are clipped.
2026-11-09 22:51:55 +07:00
Afloat 9d7217e437 Validate Unity serialized metadata ranges before reading (R3.12) (#1391)
The metadata reader took a header offset past the end of a short input and read past the declared metadata into object bytes. The offset and size are now checked against the object data, the declared file length and the bytes supplied, and only that range is parsed.
2026-11-09 22:51:49 +07:00
Afloat 37ec5557f0 Bound WebAssembly metadata across repeated custom sections (R3.12) (#1390)
Each repeated name or producers section got its own allowance, so together they could keep more than the item limit, and the cutoffs left metadata out without saying so. The function-name and producer limits now apply to the whole module, names already kept can still be updated at the limit, and the report says when anything was left out.
2026-11-09 22:51:41 +07:00
Afloat 98c8a0ceae Keep Android resource children inside their parent chunks (R3.12) (#1389)
A resource chunk could fit in the file while reaching past the size its table or package declares, so string pools, library records and short headers could read unrelated bytes. Each chunk is now read only within its parent, package and known child headers must be complete, package string pools stay inside the package, and only complete library records are kept.
2026-11-09 22:51:34 +07:00
Afloat 34d9450b75 Preserve DEX boundaries when member or handler lists are capped (R3.12) (#1388)
A class-data group cut at the member limit left its unread records where the next group would be read, so they were taken as that group's members, and a typed-handler list that stopped early could turn its remaining bytes into a catch-all address. The class data now ends as incomplete before an unread group, and a catch-all is read only after every typed handler.
2026-11-09 22:51:28 +07:00
Justin John c7606c4551 Stop a private browser and delete its profile when the app ends without closing it (R2.9, #810) (#1376)
A private browser or driven Electron app was stopped only when its process handle was dropped, which a crash, a kill, a force quit or an MCP server stopped by its client never does, so the browser was left running and its profile stayed in the temp folder. On Unix a small watcher now stops the browser's process group and deletes its `craft-*` profile once the app is gone, and ends by itself as soon as the browser does. Windows children are held by a Job Object; whether one outlives an abrupt exit is left as a roadmap line.

Refs #810
2026-11-09 22:51:21 +07:00
Afloat efddbdeb68 Bound Mach-O indirect import slots across all sections (R3.12) (#1386)
The indirect symbol limit applied to each section on its own, so many sections could still read an unbounded number of slots. It now applies across all sections, with a warning when slots are left out.
2026-11-09 22:41:42 +07:00
Afloat fbdc3049db Read Mach-O thread entry points from the matching complete CPU state (R3.12) (#1385)
An `LC_UNIXTHREAD` entry point was read from the first state record whatever its CPU or length. It's now read from the record whose flavour matches the file's CPU (x86_64, arm64 or i386) and that holds a complete state, so a short or foreign record no longer gives a made-up entry point.
2026-11-09 22:41:35 +07:00
Afloat 25f4db213e Apply PE export limits to aliases and empty function slots (R3.12) (#1384)
The export limit counted listed exports but not the function slots examined or the extra names of one function, so a crafted table could still make the reader do unbounded work. Both now count against the limit, and the table says when it was cut.
2026-11-09 22:41:29 +07:00
Afloat 131cac4f56 Respect the UTF-8 output budget for IL2CPP literals (R3.12) (#1380)
A string literal cut at the display limit could grow past it once invalid bytes became replacement characters, or end in the middle of a character. The text shown now stays within the limit, on a character boundary, and an incomplete final character isn't shown as a replacement.
2026-11-09 22:40:03 +07:00
Afloat a5ea19cf10 Recover dynamic symbols when retained ELF sections omit the symbol table (R3.12) (#1367)
Dynamic symbols were recovered from the dynamic segment only when a file had no section headers at all. They're now recovered whenever the sections give none, and symbols, exports and imports already listed aren't added twice.
2026-11-09 22:35:00 +07:00
Afloat 7779fc2449 Advance ELF core mapping paths by their original bytes (R3.12) (#1366)
A core dump's file mapping paths are read one after another, and the reader moved on by the length of the decoded path, which differs from the stored bytes when a path isn't valid UTF-8, so the paths after it went wrong. It now moves on by the bytes it read.
2026-11-09 22:34:53 +07:00
Afloat 78af11ce4d Keep same-named imports attached to their own library slots (R3.12) (#1365)
Two imports with the same name from different libraries shared the first one's slot address. Slots are now matched by name and library, and an import that already knows its slot keeps it.
2026-11-09 22:34:46 +07:00
Afloat 2474de39fe Decode Unity R16 and RG16 textures (R3.9) (#1378)
Unity textures in the R16 (format 9) and RG16 (format 62) layouts are now decoded: R16 as greyscale, and RG16's two channels as red and green.
2026-11-09 22:34:33 +07:00
Afloat ee73141313 Bound retained metadata when listing Node SEA programs (R3.12) (#1377)
The code path, asset names and exec arguments kept from a Node single-executable program now share an 8 MiB limit on decoded text, and the listing says when metadata was left out instead of keeping all of it.
2026-11-09 22:34:26 +07:00
Afloat 5b1bf92ba3 Reject PE virtual addresses that wrap past the address space (R3.12) (#1370)
A PE entry point or import slot was computed with wrapping arithmetic, so an address past the end of a 32-bit image's address space wrapped round to a small one. Such addresses are now refused: the entry point is left unknown with a warning, and an import slot without a valid address isn't listed as one.
2026-11-09 22:31:20 +07:00
Afloat 0cb327f9c9 Keep ELF symbol versions inside their declared sections (R3.12) (#1368)
Symbol version definitions, requirements and the version index were read from their section's offset onwards with nothing to stop them at the section's end, so a damaged table could take versions from whatever followed. They're now read only within their sections' bytes.
2026-11-09 22:31:13 +07:00
Afloat 87d9ec0e5f Preserve GNU tar member identities at the long-name limit (#1362)
A GNU long name or link longer than the name limit was cut to the limit, so two members could end up with the same name. Such a name now stops the listing with a warning, a long name whose data ends early is reported, and names up to the limit, terminated or not, keep their full text.
2026-11-09 22:26:54 +07:00
Cr a561c0d371 Decode Swift enum case symbols (R3.12) (#1359)
A symbol ending `WC` is the function that builds an enum case, and the demangler read the `W` but not the `C`, so every one was reported invalid. It now reads `enum case for` and the case's function, payload and generic parameters included, as `swift-demangle` prints them, and refuses a `WC` after another global.
2026-11-09 21:53:21 +07:00
Cr 13916403c4 Keep parentheses around Swift optional function types (R3.12) (#1357)
An optional function type or protocol composition was written without parentheses, so `((Data) async throws -> Data?)?` read as a function returning an optional. The wrapped type is now put in parentheses before `?` or `!`, as `swift-demangle` writes it.
2026-11-09 21:31:09 +07:00
Cr 8fb279e499 Name Swift allocating initialisers init outside classes (R3.12) (#1356)
An allocating initialiser read `__allocating_init` everywhere. As `swift-demangle` prints them, only a class's own initialisers keep that name; in a struct, an enum, a protocol or any extension, even of a class, it reads `init`.
2026-11-09 21:31:02 +07:00
Cr ee1dbf4d3a Name the right generic parameter in Swift associated types (R3.12) (#1355)
A `Qy` associated type names its generic parameter with the same numbering as `q`, where `Qy_` is the second parameter, and the demangler counted from the first, so `B.Iterator` read as `A.Iterator`. It now names the parameter `swift-demangle` names.
2026-11-09 21:30:56 +07:00
Cr ef9f33f990 Read the kind letter of Swift addressors (R3.12) (#1354)
An addressor's mangling is `a` (mutable) or `l` followed by a letter for its kind, and the demangler read the kind letter as the next operator, so every addressor was reported invalid. The kind letter is now read (unsafe, owning, native owning and native pinning, mutable and not), and an unknown kind is an error instead of being taken for an unsafe addressor.
2026-11-09 21:04:20 +07:00
Cr d9c069a8bd Decode Swift protocols named in a protocol list (R3.12) (#1353)
A Swift existential type (`any Error`, `A & B`) is mangled as a protocol list where each protocol is a context and a name with no kind letter, and the demangler expected a type there, so every such symbol was reported invalid. Each protocol in a list is now read as a context and a name, taking no substitution slot of its own.
2026-11-09 21:04:14 +07:00
Justin John 1c0e49f284 Let a Deep build through Claude Code start subagents again (R2.2, #1105) (#1351)
Claude Code builders got a fixed tool list without `Agent`, and since that list limits the whole session, every subagent call failed with "No such tool available: Agent". A Deep build now includes `Agent`: a subagent gets only the builder's tools and the session's permissions, and starting one goes to the approval tool like other actions. Clean room still leaves it out, since all of its reads must reach the approval tool.

Fixes #1105
2026-11-09 21:00:00 +07:00
Cr 3f4c54bdd4 Read the Swift standard type SQ as Equatable (R3.12) (#1350)
The two-letter standard type `SQ` in a Swift mangling is the protocol `Swift.Equatable`, and the demangler read it as the enum `ImplicitlyUnwrappedOptional`, so generic constraints named the wrong type and conformances to Equatable were reported invalid. It now reads `SQ` as `Swift.Equatable` in all three manglings.
2026-11-09 20:38:15 +07:00
Afloat 1b5f516b07 Verify Cargo package versions before reporting Rust dependencies (R3.12) (#1329)
A path like `vendor/notes-1.2.draft/` was taken for a crate and its version. A Cargo package folder is now split into name and version only where the rest is a complete semantic version and the name is a valid crate name, so hyphens in names and prerelease or build versions (`helper-2-1.2.3-rc.1+build.7`) read correctly and other folders aren't reported.
2026-11-09 19:46:34 +07:00
Afloat 0c4cdd63cc Read decimal digit separators when filling added SQLite columns (R3.12) (#1318)
A row stored before ALTER TABLE ADD COLUMN reads the default as SQLite's default expression gives it, not as a later insert would store it. In a TEXT column a separated literal keeps its spelling without the underscores or a leading plus (`1_000.` reads '1000.', `12_34.5_0` reads '1234.50'), and an integer that fits in 64 bits is written plainly (`0_07` reads '7'), as SQLite 3.50 reads them.
2026-11-09 19:44:26 +07:00
Afloat b6a50815a7 Keep Mach-O zero-fill sections out of file-backed section data (R3.12) (#1348)
A zero-fill Mach-O section (`S_ZEROFILL`, `S_GB_ZEROFILL`, `S_THREAD_LOCAL_ZEROFILL`) takes memory but has no bytes in the file, so looking one up by name could return unrelated bytes from the start of the file. Each section now keeps its type, and a zero-fill one has no file range.
2026-11-09 19:39:28 +07:00
Afloat 41c3bdd9f8 Keep Dart snapshot metadata inside its declared extent (R3.12) (#1343)
A Dart snapshot's hash and feature string are now read only within the length the snapshot declares, so they can't come from bytes after it.
2026-11-09 19:18:12 +07:00