mirror of
https://github.com/storytold/craft-common-actions.git
synced 2026-11-19 09:01:25 +01:00
This reverts commit b86cdd3. Wayland drag-and-drop waits for winit 0.31,
and Flatpak portal drops will be resolved with zbus (already in every
app via rfd) rather than libdbus. Records the decision as ADR 0001;
tracking in #64.
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
b86cdd3d0e
commit
ffe9bd01ad
4 files changed
+50
-12
No files matched your search
@@ -409,13 +409,3 @@ The tests execute the FreeBSD run template under the host's POSIX shell with
|
||||
fixture build/test commands and real tar archives. They cover failures in each
|
||||
custom test group, default build/test failures, missing/corrupt packages and font
|
||||
environment propagation. They do not replace native FreeBSD caller runs.
|
||||
|
||||
|
||||
## Linux portal build prerequisite
|
||||
|
||||
The native and RISC-V cross-compilation dependency actions install libdbus
|
||||
headers for the target architecture. Applications that opt into native Wayland
|
||||
file-portal support through libdbus can then build on clean runners. This only
|
||||
adds build dependencies; it does not enable a feature, change app permissions or
|
||||
alter the release dependency graph. Native apt installation and RISC-V linking
|
||||
still need validation on the corresponding CI runners.
|
||||
@@ -20,7 +20,7 @@ runs:
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y --no-install-recommends \
|
||||
libxkbcommon-dev libwayland-dev libx11-dev libxrandr-dev libxi-dev libgl1-mesa-dev \
|
||||
libasound2-dev libdbus-1-dev pkg-config \
|
||||
libasound2-dev pkg-config \
|
||||
desktop-file-utils appstream python3-yaml zsync
|
||||
|
||||
- uses: storytold/craft-common-actions/actions/install-nfpm@main
|
||||
|
||||
@@ -30,5 +30,5 @@ runs:
|
||||
sudo apt-get install -y --no-install-recommends \
|
||||
gcc-riscv64-linux-gnu binutils-riscv64-linux-gnu libc6-dev-riscv64-cross libc6-dev:riscv64 qemu-user \
|
||||
libxkbcommon-dev:riscv64 libwayland-dev:riscv64 libx11-dev:riscv64 libxrandr-dev:riscv64 \
|
||||
libxi-dev:riscv64 libgl1-mesa-dev:riscv64 libasound2-dev:riscv64 libdbus-1-dev:riscv64 pkg-config \
|
||||
libxi-dev:riscv64 libgl1-mesa-dev:riscv64 libasound2-dev:riscv64 pkg-config \
|
||||
desktop-file-utils appstream
|
||||
@@ -0,0 +1,48 @@
|
||||
# 1. Wayland drag-and-drop without libdbus
|
||||
|
||||
- Status: accepted
|
||||
- Date: 2026-10-22
|
||||
- Tracking: #64
|
||||
|
||||
## Context
|
||||
|
||||
On native Wayland, dropping a file from a file manager onto a craft app does nothing. The cause is winit 0.30, which egui pins (`winit = "0.30.13"`): it never emits `DroppedFile` on Wayland. X11 and XWayland work.
|
||||
|
||||
#57 added `libdbus-1-dev` (and `libdbus-1-dev:riscv64` for the cross build) to the shared Linux build dependencies. That was groundwork for a winit prototype (rust-windowing/winit#4790, branch `mockydevs/winit:prototype/native-wayland-031`) that resolves Flatpak portal drops through libdbus.
|
||||
|
||||
Where the upstream pieces stand:
|
||||
|
||||
- **Plain Wayland drops** are in winit 0.31: rust-windowing/winit#1881 closed as completed 2026-08-03. 0.31 is in beta (beta.3 on 2026-09-04). The 0.31.0 milestone has no due date.
|
||||
- **egui** is still on 0.30. Ports to 0.31 are in progress (emilk/egui#7731, emilk/egui#8767).
|
||||
- **The 0.30 backport** (rust-windowing/winit#4787) was closed upstream without merging. It used zbus 5, not libdbus.
|
||||
- **Flatpak drops** deliver an `application/vnd.portal.filetransfer` token instead of paths. The token must be exchanged through `org.freedesktop.portal.FileTransfer.RetrieveFiles` over D-Bus. 0.31 doesn't do this. #4790 proposes it, but its author says the dependency choice and the API are "proposals, not settled designs", and it notes that "an application-side resolver is another possible design".
|
||||
|
||||
What the craft apps already have:
|
||||
|
||||
- Every craft app on these shared workflows already depends on **zbus**, which is pure Rust and comes in through `rfd`.
|
||||
- None of them link `libdbus-sys`.
|
||||
- vectorcraft's D-Bus single-instance handoff (storytold/vectorcraft#3423) also uses zbus.
|
||||
|
||||
## Decision
|
||||
|
||||
1. **Revert #57.** No libdbus headers in `install-linux-deps` or `install-riscv64-cross`.
|
||||
2. **Native drops come from upgrading to winit 0.31**, through the egui release that adopts it. We don't patch or fork winit.
|
||||
3. **Flatpak drops use zbus.** Either winit resolves the portal token with zbus, or winit passes the raw token through and a shared resolver in craft-libs calls `RetrieveFiles` with zbus. We've said so on #4790.
|
||||
4. **Until then, drag-and-drop on Wayland is a documented gap.** Users open files with File › Open.
|
||||
|
||||
## Consequences
|
||||
|
||||
- No C D-Bus library anywhere in the build or runtime.
|
||||
- libdbus would have had to be added to every build path: native, riscv64 cross, Nix and FreeBSD.
|
||||
- It would also have become a runtime dependency of every package: the nfpm deb and rpm, the Arch `depends=`, the AppImage and the Flatpak.
|
||||
- zbus needs none of that, and it parses data from outside the sandbox in memory-safe code.
|
||||
- Wayland users can't drag files in for months. The chain is: winit 0.31 final, then an egui release, then an upgrade in each app.
|
||||
- The 0.31 upgrade alone doesn't fix Flatpak. Flatpak needs the zbus resolver too, and #64 tracks both.
|
||||
- If winit settles on libdbus for portal drops anyway, we revisit this decision. We'd prefer to raw-pass the token and resolve it in the app, so the dependency stays out.
|
||||
|
||||
## Alternatives considered
|
||||
|
||||
- **Keep #57 and adopt libdbus.** Rejected: adds a C dependency to every build and package, when zbus is already in the tree.
|
||||
- **Patch or fork winit 0.30 with the #4787 backport.** Rejected: upstream closed it, and we'd carry a fork of the windowing stack.
|
||||
- **Give the Flatpak the `--filesystem=host` permission so drops arrive as paths.** Rejected: it gives up the sandbox to work around a UI gap.
|
||||
- **Force XWayland by unsetting `WAYLAND_DISPLAY`.** Possible stopgap, untested. It isn't a fix, because it loses native Wayland scaling and input.
|
||||
Reference in new issue
Block a user