5575 Commits
Author SHA1 Message Date
Dylan M. Taylor 88f5a00e38 test(images): fit 1-component progressive JPEG test under 512 MiB decoder budget (#2998)
* test(images): fit 1-component progressive JPEG test under 512 MiB decoder budget

* test(render): update reduced JPEG peak estimate to 16 B/px for craft_jpeg
2026-11-18 23:20:04 -05:00
c0721c08b4 fix(canvas): restart the text caret blink on typing, caret moves and clicks (#1953)
* fix(canvas): restart the text caret blink on typing, caret moves and clicks

* fix(canvas): stop caret blink repaints in an unfocused window

* Update crates/ui-egui/src/canvas/tests.rs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Apply review fixes

- crates/ui-egui/src/canvas/input.rs
- crates/ui-egui/src/canvas/text_overlay.rs

* Apply review fixes

- crates/ui-egui/src/canvas/input.rs
- crates/ui-egui/src/canvas/text_overlay.rs

* Fix failing CI check

- crates/ui-egui/src/canvas/input.rs

* remove focus guard and respective test

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: aiongg <67543387+aiongg@users.noreply.github.com>
2026-11-19 08:37:12 +07:00
Dylan M. Taylor a8f6be842e cutover: use craft_jpeg::decode_reduced (#2991) 2026-11-18 19:08:41 -05:00
Dylan M. Taylor a73e3def53 Merge pull request #2550 from pepen11/up/psd-resolution
Place: a Photoshop file comes in at its own resolution
2026-11-18 18:02:40 -05:00
Dylan M. Taylor 12fe81ca01 images: cut over EPS bounding_box and is_eps to craft-ps (#2972) 2026-11-18 16:30:59 -05:00
Dylan M. Taylor 77de9c4f5f Place: reconcile PSD resolution with shared parser
Preserve Josef Mlčůch’s PSD placement work and tests while adapting resource lookup to the current shared zero-copy HeadView and ResolutionInfo. Keep current main decoding and sanity limits.
2026-11-18 15:27:36 -05:00
autocraft-bot[bot] 5ce12193af Merge pull request #2954 from makesomethingshit/fix/2694-idml-data-merge-counts
Data Merge: count fields after reopening IDML (#2694)
2026-11-18 15:00:20 +00:00
autocraft-bot[bot] 05f08db538 Apply review fixes
- crates/engine/src/cmd/datamerge.rs
- crates/engine/src/cmd/datamerge/tests.rs
2026-11-18 14:22:41 +00:00
autocraft-bot[bot] f5a94959f9 Merge pull request #2946 from Hamza0101/fix/separations-say-when-dpi-is-lowered
Separations: say when the resolution was lowered to fit the plate size
2026-11-18 13:36:30 +00:00
.CooCoo 14fb342b26 Story Editor: View › Story Editor › Show/Hide Style Name Column, and a draggable column width (#1797)
View › Story Editor › Show/Hide Style Name Column shows or hides the
column of paragraph style names. The column width can be dragged
between 40 and 400 points, and the bar follows the pointer back from
those limits. The setting is remembered.
2026-11-18 20:00:41 +07:00
autocraft-bot[bot] 53b80e7196 Apply review fixes
- crates/engine/src/separations.rs
2026-11-18 13:00:36 +00:00
Hamza Naveed 0c90568d97 Hyphenation: a Korean word or an address is not broken by English rules (#1754)
A whitespace-delimited token that carries Hangul, kana or Han, or that
reads as an address, is not hyphenated by English rules. Breaking at a
hyphen the author typed is still allowed. The ligature / visible-source
follow-up is in #2196 and #2197.

Fixes #1688.
2026-11-18 19:35:21 +07:00
autocraft-bot[bot] 294cef70d6 Apply review fixes
- crates/engine/src/separations.rs
2026-11-18 12:24:49 +00:00
Hamza Naveed 1d547b307f A cross-reference's PDF link covers the text it generated (#1495)
A cross-reference's PDF link annotation covers the text it generated,
not only the first letter of the marker. List labels and decorative
zero-length glyphs are left out of the rectangle, and clickable spans
are split around unselected visual text.

Related to #1446.
2026-11-18 19:04:59 +07:00
makesomethingshit 9c9641c848 #2694: count data merge markers after IDML reopening 2026-11-18 20:59:05 +09:00
Hamza 15ec895e4f Separations: the params text says A5 at 300 dpi is already lowered 2026-11-18 16:39:41 +05:00
Hamza 0ff88f981d Separations: say when the resolution was lowered to fit the plate size (#2945)
ink.separations accepts 9-300 dpi, but craft-prepress renders each plate within 4 megapixels, so a page larger than A5 at 300 dpi was separated at less with an empty warnings list. separate() now adds a warning naming the resolution used and the one asked for, and the command's params text says the resolution is lowered to fit 4 megapixels per plate.
2026-11-18 16:39:17 +05:00
Weyert de Boer 57890e43c2 Scroll overflowing document tabs (#2357)
Document tabs that overflow the bar scroll (trackpad, wheel, or arrows), keep the active tab in view, and list every open document in a menu.

Fixes #2358.
2026-11-18 18:08:50 +07:00
Hamza Naveed b12196eaf0 Fonts: the PostScript name of a variable font's named instance (#1864)
`name` ID 6 names a variable font's default instance, so every instance
was previously embedded under that same name. A named instance's
PostScript name is now built as Adobe TN #5902 prescribes.

Related to #1690.
2026-11-18 17:06:16 +07:00
Adithya Shankaran 697279c56f Automation roots: refuse a network, device or non-disk verbatim path before the file system is asked about it (#2799)
Refuse UNC, device and non-disk verbatim paths in automation roots by their form, before any file-system lookup, and judge each symlink from its own text. This closes the NTLM/WebDAV leak where canonicalize was asked about a path first.
2026-11-18 16:31:52 +07:00
.CooCoo 13bd801db2 Tables: Cell Options › Diagonal Lines draws diagonal lines across cells (#1793)
Adds Cell Options › Diagonal Lines so cells can be drawn with diagonal lines. The dialog applies only to the cells and document it opened for, and PowerPoint export writes the diagonals as cell borders. Includes Swedish catalog rows for the new strings.
2026-11-18 16:31:13 +07:00
makesomethingshit b1bf440cbb fix(fonts): discover named instances before listing paragraph styles (#1246)
For a catalog-only variable family, named instances are discovered before the Font Style combo and the Family menu list their styles, so the first opening is complete. Styles are cached once per popup opening. Synthetic fvar regressions run by default.

Related to #1210.
2026-11-18 16:30:06 +07:00
autocraft-bot[bot] 3930cff80d Merge pull request #2904 from Hamza0101/fix/create-outlines-vertical-upright
Create Outlines: vertical text keeps its upright glyphs and its columns
2026-11-17 13:55:25 +00:00
autocraft-bot[bot] a7f341fa3a Apply review fixes
- crates/ui-egui/src/canvas/text_overlay.rs
2026-11-17 13:17:34 +00:00
Hamza c4478f92c3 Create Outlines: vertical text keeps its upright glyphs and its columns
Create Outlines built each glyph's outline as horizontal text does. In a
vertical frame the canvas and the PDF export also turn each upright glyph
(PlacedGlyph::vertical_xf), and a frame of several columns put each line in a
group whose children had no transform, losing the frame's quarter turn. CJK
glyphs lay on their sides and the columns became rows.

Each upright glyph now takes its turn, as the renderer applies it, and each
line in the group takes the frame's text turn (Document::text_local).

Fixes #2895
2026-11-17 17:23:10 +05:00
autocraft-bot[bot] 47ef1ec411 Merge pull request #2844 from gmrmad1/fix/2601-rtl-spread-label
Pages panel: a right-to-left spread label reads left page first (#2601)
2026-11-16 16:00:05 +00:00
Madhav Agarwal 105a080c03 review: the spread test expects the labels in the order they are drawn (CodeRabbit/a spread with a section inside lists its names apart)
Moving page 4 into spread 1 does not move the section that starts at page 3, so the label takes the comma-separated branch: pages 2, 3 and 4 are numbered 2, 1 and 2, and the assertion now expects exactly that. The test failed before this change (left: "2, 1, 2", right: "2-4").
2026-11-16 21:09:45 +05:30
gmrmad1andMadhav Agarwal a84fa41eba Contributors: gmrmad1's name for the About window (#2876)
Co-authored-by: Madhav Agarwal <gmrmad1@users.noreply.github.com>
2026-11-16 14:51:02 +00:00
FredApps a73f46df33 Merge pull request #2866 from storytold/docs/shared-library-guidance
docs: prefer shared Craft libraries for reusable features
2026-11-16 13:51:57 +01:00
Dylan M. Taylor 424b54dc0b docs: prefer shared Craft libraries for reusable features 2026-11-16 06:28:38 -05:00
Dylan M. Taylor 11ad84fd69 Merge pull request #2857 from storytold/fix/epub-layer-guide-default
fix(ci): initialize guide lock in EPUB layer fixture
2026-11-15 19:40:07 -05:00
Dylan M. Taylor 0d742e07d6 test(epub): initialize guide lock in hidden layer fixture 2026-11-15 19:09:44 -05:00
Dylan M. Taylor 278aba4a14 Merge pull request #1482 from Hamza0101/test/cli-argument-surface
cli: pin the argument surface, and fix the argument bugs pinning it found (photocraft#7071)
2026-11-15 18:49:03 -05:00
Dylan M. Taylor b949f0fd2b Merge pull request #1502 from midasdf/jp/kinsoku-push-pull
Compose: apply 禁則 push-in/push-out priorities (JIS X 4051)
2026-11-15 18:47:30 -05:00
Dylan M. Taylor 4828d96ba2 Merge pull request #1516 from moppeeer/layer-lock-guides
Layer Options: Lock Guides, as InDesign's (and IDML's LockGuides)
2026-11-15 18:22:18 -05:00
FredAppsandDylan M. Taylor f405f89da4 Formats: port the craft-libs cutover follow-ups from #2734 to main (#2838)
* Formats: port the craft-libs cutover follow-ups from #2734 to main (craft-libs#778)

Brings #2734's changes (made against the release branch) to main:
IDML CDATA on write and table span parsing, DOCX plain-text accepted
changes, XLSX invalid number cells shown as written, shared CMYK JPEG
polarity, exact PPTX opacity, PDF CMYK fallback wording, and the
craft-libs re-pins. Imported DOCX built-in headings keep main's and
v0.21.0's spelling ("Heading 1"), with a test. craft-pdf, craft-prepress,
craft-cms, the krilla/hayro patches and craft-xml-dtd move to the #1322
squash merge on craft-libs main (a5ac3aa0).

Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>

* Point the PDF dependency check at the craft-libs main pin

Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>

* Formats: address review on the cutover follow-ups

- PDF: keep main's CMYK fallback warning. The shared decoder reads planar
  CMYK TIFFs and makes associated alpha straight, so neither falls back;
  a test now checks both keep their inks.
- DOCX plain-text import uses craft-wordmodel's Paragraph::final_text,
  which already drops tracked deletions and expands inline objects.
- IDML: a test pins numeric table spans (fractions round down, spans past
  the table or past 32 bits reach its edge, anything under 1 or not a
  number spans one cell).
- Cargo.lock: craft-rtf takes craft-codepage at bfea7d98 after the merge
  with main.

* PDF test: expect the CMYK fallback warning's main wording

---------

Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
2026-11-15 22:45:42 +01:00
FredApps b3e6e31317 Merge pull request #2850 from MMexicann/patch-9
docs: describe existing pull-request CI quality gate
2026-11-15 22:03:56 +01:00
Mex 7e01d9b1ed Merge branch 'main' into patch-9 2026-11-15 21:30:36 +01:00
FredApps 6dadc22329 Merge pull request #2851 from MMexicann/patch-10
fix: preserve selections when resolving tracked changes
2026-11-15 21:24:05 +01:00
Dylan M. Taylor 497b541b11 Merge pull request #2840 from storytold/extract/shared-base64-encode
Reuse shared Base64 encoding for HTML and serialization
2026-11-15 15:20:45 -05:00
Mex 6fa5f6672b docs: record completed CI documentation review 2026-11-15 21:16:40 +01:00
Mex d59a441dbf docs: remove completed CI gate from current focus 2026-11-15 21:16:26 +01:00
Mex bbb7fa31ee docs: align parity notes with existing CI gate 2026-11-15 21:15:59 +01:00
gmrmad1 8ad537632e Justification: keep the spacing table out of the wide-control grid (#2525) (#2848) 2026-11-15 19:45:19 +00:00
autocraft-bot[bot] 963baa1bba Merge pull request #2845 from gmrmad1/fix/2812-fitting-crop-units
Frame Fitting Options: crop amounts follow the document's ruler unit (#2812)
2026-11-15 19:19:58 +00:00
Mex cf43ba518b docs: record tracked-change selection preservation 2026-11-15 20:03:12 +01:00
Mex d22b67d418 fix: follow selections when resolving tracked changes 2026-11-15 20:02:25 +01:00
Mex 9a46810963 docs: describe shared PR and main quality gate 2026-11-15 19:57:05 +01:00
Mex cd2a098dfc docs: remove completed PR CI work from Upcoming 2026-11-15 19:56:24 +01:00
Mex 2bf5ac3319 docs: record existing PR quality gate 2026-11-15 19:44:23 +01:00