4182 Commits
Author SHA1 Message Date
Dylan M. Taylor f67d38b35c chore(interchange): bump craft-aaf and craft-timeline to craft-libs main (#5054)
* chore(interchange): bump craft-aaf and craft-timeline to craft-libs main

* fix(captions): convert between filmcraft_time::Tick and craft_captions::Tick

* fix(captions): use filmcraft_captions::Tick in ttml_language test

* fix(engine): adapt caption Tick/FrameRate to craft_captions types

* style: rustfmt
2026-11-18 21:59:34 -05:00
Dylan M. Taylor 3d37c0f1f1 chore(dng): bump craft-raw and craft-tiff to craft-libs main (#5051) 2026-11-18 19:04:22 -05:00
Dylan M. Taylor 6aa6768494 Merge pull request #4924 from storytold/dot/shared-hdr-20261117
Stills: replace local Radiance HDR decoder with craft-hdr
2026-11-18 09:13:51 -05:00
FredApps 688444e75d Merge pull request #5029 from storytold/fix/fcpxml-unusable-lane-warning
fix(interchange): report unusable FCPXML lanes on the live import path
2026-11-18 19:52:04 +07:00
FredApps 6df14ec66f fix(interchange): apply FCPXML adjust-conform on the live import path
#2300's tests call import()/export(), which go through craft-timeline
(pin 57288eda). That pin still ignores adjust-conform, so a missing
element left scale-to-frame off, fill was silent, and export wrote no
type="none". The legacy #[cfg(test)] parser already had the intended
rules.

After a successful live import, the wrapper now applies those rules to
the clips craft-timeline built, and after export it writes
adjust-conform type="none" for clips that keep their native pixels.
roxmltree moves to a lib dependency so the document's DOCTYPE can be
parsed.

Tests: fcpxml_conform::* and the existing interchange fcpxml suite.
Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-18 18:30:20 +07:00
FredApps 81c351f826 fix(interchange): report unusable FCPXML lanes on the live import path
#2255 added a warning to the legacy FCPXML parser when a connected clip's
lane is not an i32, plus a test that calls import(). Import already goes
through craft-timeline, which still skips those attributes silently, so
the new test failed on main as soon as the PR merged.

Warn from the craft-timeline wrapper instead of bumping the craft-libs
pin (main is hundreds of commits ahead of the pin).

Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-18 17:04:20 +07:00
NetterSilver 176d072983 Read a hyphen as minus only at the start of a number
A hyphen before digits is read as "minus" only when it starts the text
or follows a non-alphanumeric character. Names and model numbers such as
COVID-19 and F-16 keep a plain hyphen. Negative numbers after whitespace,
brackets, or other punctuation still read as minus.
2026-11-18 16:49:31 +07:00
Will Bunker 9ad3e41397 fix(fcpxml): import and export adjust-conform (fit by default) (#2218)
A clip with no adjust-conform means "fit" in FCPXML: the picture is
scaled into the sequence frame before its adjust-transform. The importer
ignored the element, so a 4K clip in a 1080p sequence landed at scale
100 and was cropped.

Import now sets the clip's scale-to-frame-size flag for fit (and a
missing element) and clears it for none. fill has no equivalent in the
model: it is reported and imported as fit. Export writes
adjust-conform type="none" for a clip without the flag, so FilmCraft
clips keep their native size on a round trip.

An adjust-conform on the <video> inside a <clip> is read first; the
clip's own element overrides it. An inner fill is reported when the
clip does not override it.

Fixes #2218.
2026-11-18 16:37:49 +07:00
FredApps 427992f178 Merge pull request #4741 from ivanao92/export-reuse-renderers
export: parts of a job reuse the frame renderers of the previous part
2026-11-18 16:30:26 +07:00
FredApps f937482d8f Merge pull request #3834 from Zaxaerith/fix/3820-active-dock-tab-highlight
fix(ui): make active panel tabs visually distinct (#3820)
2026-11-18 16:28:48 +07:00
FredApps 1c3e01b8ac Merge pull request #2954 from earlvanze/codex/security-project-media-dimensions
fix(format): reject oversized persisted media dimensions
2026-11-18 16:27:14 +07:00
FredApps 796eec1133 Merge pull request #2708 from kk376/fix/2474-animated-cache
fix(media): bound decoded animated GIF and APNG frames in shared cache (#2474)
2026-11-18 16:25:49 +07:00
FredApps 92551059da Merge pull request #2425 from 00xJS/fix/2421
#2421: the layout in use when the app closes comes back at the next launch, saved workspace or not
2026-11-18 16:24:45 +07:00
FredApps 18c73aed84 Merge pull request #2255 from Wbunker/fix/fcpxml-unbounded-lanes
fix(interchange): FCPXML connected clip with an unusable lane is reported, not silently dropped
2026-11-18 16:23:41 +07:00
FredApps 5491c734ed Merge pull request #1854 from 00xJS/fix/1540-control-no-dialogs
#1540: engine.execute over the control channel never opens a parameter dialog
2026-11-18 16:21:49 +07:00
0b3f30edaa Add a hex field to colour parameters in Effect Controls (#2359)
* Add a hex field to colour parameters in Effect Controls (#1561)

Ultra Key and Color Key could only be given a colour by swatch, by
eyedropper, or by the picker's R/G/B fields in 8-bit or float. None of
those takes `#00ff00`, which is how colours are actually exchanged: a
green screen's published value, a brand colour, one read off a style
guide.

A `#rrggbb` field now sits beside every colour parameter, next to the
swatch and the eyedropper. The typing behaviour matches the hex field in
Settings - Appearance (#722): while the field has focus it shows what is
typed, each valid colour is applied as it completes, and leaving shows
the kept one again, so a half-typed value never sticks. Six digits say
nothing about alpha, and the swatch is Alpha::Opaque, so the parameter
keeps the alpha it had.

Parsing and formatting reuse filmcraft_color::{parse_hex, to_hex}.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Read colour parameters as sRGB, not linear

Review on #2359 pointed out that the swatch used egui's linear `Rgba`
while the new hex field reads the parameter directly. Checking the
renderer settled which is right: `ultra_key` runs each pixel through
`effects::enc` (linear to sRGB) before comparing it with the key colour,
which it takes exactly as stored, so the stored components are sRGB.

The swatch was therefore showing the wrong colour. Ultra Key's default
`[0.0, 0.8, 0.2]` is `#00cc33`, but the picker opened on `#00e77c`.
Reading and writing it as `Color32` through `color_edit_button_srgba`
puts the swatch, the picker and the hex field on the same value, and on
the one the keyer actually uses. Alpha is untouched, as before.

Adds a test pinning the convention, so a later change back to linear
fails instead of silently shifting every colour parameter.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Cover the picker itself, and fix Lumetri's tints too

Review asked for a test that goes through the picker: the previous one
read the stored parameter, so a return to the linear widget would have
left it passing. The swatch now carries an automation id, and the new
test opens the picker and reads what it shows. Turning the widget back
to `color_edit_button_rgba` makes it fail with
`R 0 | G 231 | B 124`, which is the linear misreading.

Looking for other callers turned up the same pattern in the Lumetri
Color panel, where Shadow Tint and Highlight Tint went through
`Rgba` as well. Same parameters, same encoding, so they get the same
treatment; their alpha handling is unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* #1561: the eyedropper and the transition colour picker use sRGB like the colour field

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
2026-11-17 22:20:17 -06:00
MarekSpodBiedryandskylar taylor-barrick b6a37d19db Fix clippy expect_used under --all-features and the no-threads build (#2813) (#2838)
* Fix clippy expect_used under --all-features and the no-threads build (#2813)

* xtask: root() falls back to the manifest dir instead of expect, so the whole-workspace expect_used gate passes (#2813)

---------

Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
2026-11-17 22:11:29 -06:00
Dylan M. Taylor 1b0f9f8e7b Merge pull request #5006 from storytold/dot/mjpeg-export-shared-20261117
Export: software MJPEG through shared JPEG encoder
2026-11-17 19:40:28 -05:00
Dylan M. Taylor 894a773207 Use merged tokenless JPEG encoder for bounded MJPEG scratch 2026-11-17 17:45:44 -05:00
Dylan M. Taylor 9e15e2a8e2 M2: encode software MJPEG through shared craft-jpeg 2026-11-17 15:46:35 -05:00
Dylan M. Taylor 73ae4dfac0 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/media/Cargo.toml
2026-11-17 08:23:01 -05:00
Dylan M. Taylor 93a88a839a Merge pull request #4926 from storytold/dot/film-shared-psd-packbits-20261117
Stills: share strict PSD PackBits rows without allocation overhead
2026-11-17 00:05:26 -05:00
Dylan M. Taylor f5cff8c85e media: pin PackBits decoder to merged shared prerequisite 2026-11-16 23:11:10 -05:00
Dylan M. Taylor a04c021988 Merge pull request #4927 from storytold/fix/ycbcr-metadata-budget
Stills: bound YCbCr TIFF metadata before typed array allocation
2026-11-16 23:09:17 -05:00
Dylan M. Taylor 17beb2d574 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/media/Cargo.toml
2026-11-16 23:05:26 -05:00
Dylan M. Taylor 4da80fa02d Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/media/Cargo.toml
2026-11-16 23:03:59 -05:00
Dylan M. Taylor 39c075a96a media: bound decoded YCbCr metadata before allocation 2026-11-16 22:35:43 -05:00
Dylan M. Taylor 737060c0b4 media: pin shared HDR decoder to merged craft-libs main 2026-11-16 21:59:50 -05:00
Dylan M. Taylor d896af61ce Stills: integrate shared YCbCr TIFF decoder and contributor orientation work (#4925) 2026-11-16 21:58:27 -05:00
00xJ0 04b2b6540c #1540: engine.execute of voiceover.settingsDialog answers the settings, not the window
From the menu, Voice-Over Record Settings… still opens its dialog. Over
engine.execute it now answers the voice-over settings (as
audio.voiceover.settings does) instead of opening a window nobody can see.
The every-dialog-route test checks the window's automation elements, since
the dialog's draft lives in egui memory outside the inspected UI state.
2026-11-16 19:19:58 -07:00
Dylan M. Taylor 1a4e060cdb media: reuse shared PSD PackBits decoder without row allocations 2026-11-16 21:05:11 -05:00
Dylan M. Taylor 2aae01f68c Merge pull request #4083 from vangel76/fix/platform-nvenc-tests-serial
platform tests: take NVENC_SERIAL in every NVENC test, fixes hangs under plain cargo test (#4075)
2026-11-16 20:31:35 -05:00
Dylan M. Taylor 544723c75b Stills: use shared bounded Radiance HDR decoder 2026-11-16 19:17:12 -05:00
FredApps 3f137a7ed4 Merge pull request #4900 from storytold/codex/otio-marker-color-parity
Preserve tolerant optional OTIO marker color imports
2026-11-16 18:11:31 +01:00
FredApps d6e78890f1 Merge pull request #4906 from storytold/codex/filmcraft-dng-lossy-tile-bound
dng: pin craft-raw to the bounded lossy-tile allocation (craft-libs #1884)
2026-11-16 17:44:16 +01:00
Zaxaerith bb7a19fc4e fix(ui): underline the active dock tab (#3820) 2026-11-16 23:35:21 +08:00
FredApps a497b938f3 dng: pin craft-tiff and craft-raw to craft-libs main bea91b18 (#1884: bounded lossy tile allocation) 2026-11-16 16:06:12 +01:00
FredApps 1bfa4800d4 Merge pull request #4871 from storytold/codex/dng-opcode-interpreter
Use shared typed DNG opcode parameters
2026-11-16 15:59:23 +01:00
FredApps 92c4c623e3 Merge pull request #4870 from storytold/codex/dng-capture-info
Use shared CinemaDNG capture metadata
2026-11-16 15:51:40 +01:00
FredApps 159bd74cb7 Merge pull request #4869 from storytold/codex/dng-metadata
Use shared DNG processing and camera metadata
2026-11-16 15:40:56 +01:00
FredApps 606a52faf0 Merge pull request #4868 from storytold/codex/filmcraft-shared-dng-opcodes
dng: use shared bounded opcode envelopes
2026-11-16 15:28:47 +01:00
FredApps 6e561687f0 Merge pull request #4858 from storytold/codex/filmcraft-shared-aaf
interchange: use shared AAF schema reader and writer
2026-11-16 15:23:02 +01:00
FredApps d4d786e63c Merge branch 'codex/dng-capture-info' into codex/dng-opcode-interpreter 2026-11-16 15:04:42 +01:00
FredApps 33098a9c77 Merge branch 'codex/dng-metadata' into codex/dng-capture-info 2026-11-16 15:04:25 +01:00
FredApps da1fa1fb8c Merge branch 'codex/filmcraft-shared-dng-opcodes' into codex/dng-metadata 2026-11-16 15:04:08 +01:00
FredApps 1ccd567a59 dng: stage opcode encoding with fallible allocations; make the parity GainMap fixture valid 2026-11-16 15:04:04 +01:00
FredApps 04689784a8 Merge pull request #4867 from storytold/codex/filmcraft-shared-dng-raw
dng: use shared bounded raw strip and tile decoder
2026-11-16 14:45:45 +01:00
Dylan M. Taylor efb61a88a4 Merge branch 'main' into codex/filmcraft-shared-aaf 2026-11-16 08:13:18 -05:00
FredApps a509410b90 Merge branch 'codex/dng-capture-info' into codex/dng-opcode-interpreter 2026-11-16 14:09:37 +01:00
FredApps a99d28ee3d Merge branch 'codex/dng-metadata' into codex/dng-capture-info 2026-11-16 14:09:23 +01:00