* chore(interchange): bump craft-aaf and craft-timeline to craft-libs main
* fix(captions): convert between filmcraft_time::Tick and craft_captions::Tick
* fix(captions): use filmcraft_captions::Tick in ttml_language test
* fix(engine): adapt caption Tick/FrameRate to craft_captions types
* style: rustfmt
#2300's tests call import()/export(), which go through craft-timeline
(pin 57288eda). That pin still ignores adjust-conform, so a missing
element left scale-to-frame off, fill was silent, and export wrote no
type="none". The legacy #[cfg(test)] parser already had the intended
rules.
After a successful live import, the wrapper now applies those rules to
the clips craft-timeline built, and after export it writes
adjust-conform type="none" for clips that keep their native pixels.
roxmltree moves to a lib dependency so the document's DOCTYPE can be
parsed.
Tests: fcpxml_conform::* and the existing interchange fcpxml suite.
Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
#2255 added a warning to the legacy FCPXML parser when a connected clip's
lane is not an i32, plus a test that calls import(). Import already goes
through craft-timeline, which still skips those attributes silently, so
the new test failed on main as soon as the PR merged.
Warn from the craft-timeline wrapper instead of bumping the craft-libs
pin (main is hundreds of commits ahead of the pin).
Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
A hyphen before digits is read as "minus" only when it starts the text
or follows a non-alphanumeric character. Names and model numbers such as
COVID-19 and F-16 keep a plain hyphen. Negative numbers after whitespace,
brackets, or other punctuation still read as minus.
A clip with no adjust-conform means "fit" in FCPXML: the picture is
scaled into the sequence frame before its adjust-transform. The importer
ignored the element, so a 4K clip in a 1080p sequence landed at scale
100 and was cropped.
Import now sets the clip's scale-to-frame-size flag for fit (and a
missing element) and clears it for none. fill has no equivalent in the
model: it is reported and imported as fit. Export writes
adjust-conform type="none" for a clip without the flag, so FilmCraft
clips keep their native size on a round trip.
An adjust-conform on the <video> inside a <clip> is read first; the
clip's own element overrides it. An inner fill is reported when the
clip does not override it.
Fixes#2218.
* Add a hex field to colour parameters in Effect Controls (#1561)
Ultra Key and Color Key could only be given a colour by swatch, by
eyedropper, or by the picker's R/G/B fields in 8-bit or float. None of
those takes `#00ff00`, which is how colours are actually exchanged: a
green screen's published value, a brand colour, one read off a style
guide.
A `#rrggbb` field now sits beside every colour parameter, next to the
swatch and the eyedropper. The typing behaviour matches the hex field in
Settings - Appearance (#722): while the field has focus it shows what is
typed, each valid colour is applied as it completes, and leaving shows
the kept one again, so a half-typed value never sticks. Six digits say
nothing about alpha, and the swatch is Alpha::Opaque, so the parameter
keeps the alpha it had.
Parsing and formatting reuse filmcraft_color::{parse_hex, to_hex}.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* Read colour parameters as sRGB, not linear
Review on #2359 pointed out that the swatch used egui's linear `Rgba`
while the new hex field reads the parameter directly. Checking the
renderer settled which is right: `ultra_key` runs each pixel through
`effects::enc` (linear to sRGB) before comparing it with the key colour,
which it takes exactly as stored, so the stored components are sRGB.
The swatch was therefore showing the wrong colour. Ultra Key's default
`[0.0, 0.8, 0.2]` is `#00cc33`, but the picker opened on `#00e77c`.
Reading and writing it as `Color32` through `color_edit_button_srgba`
puts the swatch, the picker and the hex field on the same value, and on
the one the keyer actually uses. Alpha is untouched, as before.
Adds a test pinning the convention, so a later change back to linear
fails instead of silently shifting every colour parameter.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* Cover the picker itself, and fix Lumetri's tints too
Review asked for a test that goes through the picker: the previous one
read the stored parameter, so a return to the linear widget would have
left it passing. The swatch now carries an automation id, and the new
test opens the picker and reads what it shows. Turning the widget back
to `color_edit_button_rgba` makes it fail with
`R 0 | G 231 | B 124`, which is the linear misreading.
Looking for other callers turned up the same pattern in the Lumetri
Color panel, where Shadow Tint and Highlight Tint went through
`Rgba` as well. Same parameters, same encoding, so they get the same
treatment; their alpha handling is unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* #1561: the eyedropper and the transition colour picker use sRGB like the colour field
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
* Fix clippy expect_used under --all-features and the no-threads build (#2813)
* xtask: root() falls back to the manifest dir instead of expect, so the whole-workspace expect_used gate passes (#2813)
---------
Co-authored-by: skylar taylor-barrick <hi@skylar.cc>
From the menu, Voice-Over Record Settings… still opens its dialog. Over
engine.execute it now answers the voice-over settings (as
audio.voiceover.settings does) instead of opening a window nobody can see.
The every-dialog-route test checks the window's automation elements, since
the dialog's draft lives in egui memory outside the inspected UI state.