Commit Graph
19792 Commits
Author SHA1 Message Date
Behdad Esfahbod 7f7671f761 [sanitize] Update comments 2025-11-10 02:55:44 -07:00
Behdad Esfahbod 665afc08f6 [sanitize] Remove table-altering code parts
Part of fixing https://github.com/harfbuzz/harfbuzz/issues/5535

This makes two changes to previous behavior:
- If a FontFeatureSetting offset was wrong as per old Adobe
  behavior, we used to recover from. With this change (and immutable
  tables), we don't do that anymore,
- Similarly, if a cmap subtable has too-large of a length pointing
  outside of the cmap table, we used to recover from this, but
  don't anymore.
2025-11-09 15:28:19 -07:00
Behdad Esfahbod 83dc4d1d35 [sanitize] Don't do edit-sanitize cycle
Part of fixing https://github.com/harfbuzz/harfbuzz/issues/5535
2025-11-09 15:13:52 -07:00
Behdad Esfahbod 31cdb587f2 [draw] Always slant around horizontal origin (#5638)
Fixes https://github.com/harfbuzz/harfbuzz/issues/5632
2025-11-05 15:47:01 -07:00
Khaled Hosny e8c839425b [ci] Use GITHUB_TOKEN instead of a custom one 2025-11-05 07:59:27 +02:00
Khaled Hosny 0426759f2b 12.2.0 12.2.0 2025-11-05 07:18:46 +02:00
Khaled Hosny 76c490aee2 [cmake] Re-word the warning message to be more up-to-date [ci skip] 2025-11-05 07:16:23 +02:00
Khaled Hosny 281325fc95 Add .wraplock to subprojects/.gitignore [ci skip] 2025-11-05 06:59:00 +02:00
Behdad Esfahbod b11c14227f Match backtrack/lookahead per syllable (#5635)
* [match-backtrack] Fix syllable-setting logic

If accidentally backtrack_len() was equal idx, we were setting
syllable, even though we want to match backtrack, which shouldn't
match syllable.

I'm surprised how this was not exposed before.

Fixes https://github.com/harfbuzz/harfbuzz/issues/5597

* Always match backtrack per syllable

* Always match lookahead per syllable as well

* Add Indic test for per-syllable backtrack/lookahead matching
2025-11-04 13:49:52 -07:00
Behdad Esfahbod 844f2fea06 [GPOS] Handle attach_chain() overflow (#5636)
Fixes https://oss-fuzz.com/testcase-detail/5461871294742528
2025-11-03 20:28:54 -07:00
dependabot[bot] 8f2ecfb103 Bump github/codeql-action from 4.31.0 to 4.31.2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.0 to 4.31.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/4e94bd11f71e507f7f87df81788dff88d1dacbfb...0499de31b99561a6d14a36a5f662c2a54f91beee)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-11-03 12:26:41 +02:00
Qunxin Liu cb6e12bf3e [repacker] remap 24 bits links cause they could be roots (#5631) 2025-11-01 16:39:29 -06:00
Brenton Bostick f6054b6ccc fix CMake message warning (#5633) 2025-10-31 13:50:46 -06:00
Behdad Esfahbod 54bcb3793a [font] Don't apply slant to singular glyph origin functions either (#5630)
Followup to 6105bad187
2025-10-29 16:42:33 -06:00
Khaled Hosny 6105bad187 Fix applying synthetic slight to glyph origins (#5629)
* Fix applying synthetic slight to glyph origins

The hb_font_t::get_glyph_[h/v]_origins() methods were applying all the
transformations to the first glyph in the buffer. This shows up for
vertical text only because h_origin callback is usually unset.

Fixes https://github.com/harfbuzz/harfbuzz/issues/5628

* Don’t apply slant to glyph origin

Per discussion in https://github.com/harfbuzz/harfbuzz/issues/5628#issuecomment-3459345504

* Disable only font functions that fail
2025-10-29 13:59:51 -06:00
dependabot[bot] 4d1ce4a655 Bump actions/upload-artifact from 4 to 5
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-27 15:37:31 +03:00
dependabot[bot] b54c6cd9b1 Bump github/codeql-action from 4.30.9 to 4.31.0
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.9 to 4.31.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/16140ae1a102900babc80a33c44059580f687047...4e94bd11f71e507f7f87df81788dff88d1dacbfb)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-27 15:36:59 +03:00
dependabot[bot] 4f733aaf77 Bump actions/download-artifact from 5 to 6
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v5...v6)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-27 15:36:40 +03:00
Behdad Esfahbod 41c8b99bee Remove unused var 2025-10-22 18:47:07 -06:00
Khaled Hosny 46e3882f85 [subset] Don’t collect name IDs from STAT table if it is dropped (#5623) 2025-10-22 17:11:13 -06:00
Garret Rieger 07ee609f5a Fix invalid pointer conversions in graph Coverage. (#5622)
For #5604.
2025-10-20 20:06:43 -06:00
dependabot[bot] d9844278e6 Bump github/codeql-action from 4.30.8 to 4.30.9
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.8 to 4.30.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f443b600d91635bebf5b0d9ebc620189c0d6fba5...16140ae1a102900babc80a33c44059580f687047)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-20 15:17:47 +03:00
Behdad Esfahbod 73f98256c6 Revert "[match-backtrack] Fix syllable-setting logic (#5617)" (#5620)
This reverts commit 2c934a6b39.

Revert until implications are sorted out:
https://github.com/harfbuzz/harfbuzz/issues/5618
2025-10-19 20:16:35 -06:00
Behdad Esfahbod 2c934a6b39 [match-backtrack] Fix syllable-setting logic (#5617)
If accidentally backtrack_len() was equal idx, we were setting
syllable, even though we want to match backtrack, which shouldn't
match syllable.

I'm surprised how this was not exposed before.

Fixes https://github.com/harfbuzz/harfbuzz/issues/5597
2025-10-18 22:31:31 -06:00
Behdad Esfahbod b98ec96008 [cache] Fix get() check for item_t=int16_t
Fixes https://github.com/harfbuzz/harfbuzz/issues/5616
2025-10-18 15:00:45 -06:00
Behdad Esfahbod f159600ccb Fix a draw fuzzer uninitialized-memory issue (#5615)
Fixes https://oss-fuzz.com/testcase-detail/5714890590584832
2025-10-17 19:49:40 -06:00
Behdad Esfahbod 61126e4b63 Merge pull request #5614 from harfbuzz/no-fallback-kern
[shape] Don't do font-funcs-based kerning for most shapers
2025-10-17 18:42:33 -04:00
Harry Dalton 780b986659 [shape] Test fallback to kern table under different shapers
More specifically, this asserts that the `kern` table is avoided for
certain shapers, and that we avoid double-spacing in the presence of
`dist` for the same.
2025-10-17 16:26:21 -06:00
Behdad Esfahbod 5973479e4b [shape] Don't do font-funcs-based kerning for most shapers 2025-10-17 16:21:51 -06:00
Behdad Esfahbod 07f0cba388 [alloc-pool] Fix MSVC warning
Fixes https://github.com/harfbuzz/harfbuzz/issues/5613
2025-10-17 15:23:05 -06:00
Behdad Esfahbod 9cfb0e6786 Merge pull request #5609 from harfbuzz/most-shapers-disable-kern-table
[shape] Disable `kern` table in most shapers
2025-10-15 15:08:33 -04:00
Behdad Esfahbod 63e8c13e16 [hangul] Enable fallback position / kern table
https://github.com/harfbuzz/harfbuzz/pull/5609#issuecomment-3400878406
2025-10-15 12:41:50 -06:00
Khaled Hosny 189358e3d0 [test] Add test for harfrust#278 (#5610)
Add test case for https://github.com/harfbuzz/harfrust/pull/278
2025-10-14 20:06:26 -06:00
Behdad Esfahbod 3b58ce4518 [shape] Disable kern table in most shapers
Only default, Arabic, and Hebrew keep it.

Fixes https://github.com/harfbuzz/harfbuzz/issues/5607

Needs documentation update.
2025-10-13 13:26:23 -06:00
higher-performance 2ce548a7f3 Clean up std::forward to match spelling of argument type (#5608)
This helps readability and also avoids false positives during static analysis.
2025-10-13 13:11:15 -06:00
Harry Dalton 059fc205d9 Fix documentation of offsets in text glyph serialization format (#5606)
Offsets are serialized when only one of `x` and `y` is non-zero too:

https://github.com/harfbuzz/harfbuzz/blob/7c2105a52e6b50e448064e82c760dad0b5f4bdb9/src/hb-buffer-serialize.cc#L302-L303
2025-10-13 10:58:13 -06:00
dependabot[bot] 7c2105a52e Bump github/codeql-action from 3.30.6 to 4.30.8
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.6 to 4.30.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/64d10c13136e1c5bce3e5fbde8d4906eeaafc885...f443b600d91635bebf5b0d9ebc620189c0d6fba5)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-13 13:57:50 +03:00
dependabot[bot] 3f70b69878 Bump fonttools from 4.60.0 to 4.60.1 in /.ci
Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.60.0 to 4.60.1.
- [Release notes](https://github.com/fonttools/fonttools/releases)
- [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst)
- [Commits](https://github.com/fonttools/fonttools/compare/4.60.0...4.60.1)

---
updated-dependencies:
- dependency-name: fonttools
  dependency-version: 4.60.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-06 16:00:25 +03:00
dependabot[bot] 7051186d22 Bump github/codeql-action from 3.30.5 to 3.30.6
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.5 to 3.30.6.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/3599b3baa15b485a2e49ef411a7a4bb2452e7f93...64d10c13136e1c5bce3e5fbde8d4906eeaafc885)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-06 16:00:12 +03:00
dependabot[bot] 61dc19735b Bump ossf/scorecard-action from 2.4.2 to 2.4.3
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.2 to 2.4.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](https://github.com/ossf/scorecard-action/compare/05b42c624433fc40578a4040d5cf5e36ddca8cde...4eaacf0543bb3f2c246792bd56e8cdeffafb205a)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-version: 2.4.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-06 16:00:03 +03:00
Behdad Esfahbod d1a3e40365 [util] Fix compiler warning 2025-10-02 18:58:40 -07:00
Khaled Hosny a790c38b78 [docs] Fix build 12.1.0 2025-10-01 08:26:58 +03:00
Khaled Hosny cb59b347ca 12.1.0 2025-10-01 08:24:34 +03:00
Behdad Esfahbod 4a26e289f7 Add hb_ot_layout_lookup_collect_glyph_alternates() (#5367)
* [map] Massage operator << overloads

* [ot-layout] Add +hb_ot_layout_lookup_collect_glyph_alternates

To collect all glyph mapping from SingleSubst or AlternateSubst
lookups in one call.  Needed by FreeType autohinter for performance.

New API:
+hb_ot_layout_lookup_collect_glyph_alternates()

* [layout] Change hb_ot_layout_lookup_collect_glyph_alternates() API

https://github.com/harfbuzz/harfbuzz/pull/5367#discussion_r2149019638
2025-09-30 13:31:04 -06:00
Behdad Esfahbod 61b6a262cc [pragmas] Disable -Wuninitialized and -Wmaybe-uninitialized on gcc
Fixes https://github.com/harfbuzz/harfbuzz/issues/5589
CC https://github.com/harfbuzz/harfbuzz/pull/5367
2025-09-30 13:18:46 -06:00
Behdad Esfahbod af286b8f71 [Coverage] Simplify initialization 2025-09-30 13:00:36 -06:00
Behdad Esfahbod 164303139b [pragmas] Demote -Wuninitialized from error to warning (#5593)
I suspect a gcc false positive.

"Fixes" https://github.com/harfbuzz/harfbuzz/issues/5589
2025-09-29 21:00:28 -06:00
Behdad Esfahbod 37fd8c0b15 [alloc-pool] Fix alignment (#5592)
We were aligning on the bytes remaining. Align on actual
pointer.

Probably fixes https://github.com/harfbuzz/harfbuzz/issues/5591
2025-09-29 21:00:21 -06:00
dependabot[bot] 051a885c00 Bump github/codeql-action from 3.30.3 to 3.30.5 (#5590)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.3 to 3.30.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/192325c86100d080feab897ff886c34abd4c83a3...3599b3baa15b485a2e49ef411a7a4bb2452e7f93)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-29 13:20:00 -06:00
Khaled Hosny 720f1a3b66 12.0.0 12.0.0 2025-09-28 00:55:46 +03:00