nussaibah shaikh
47b18b6ebd
[font] Don't read stale design coords in hb_font_set_variation() ( #6402 )
...
hb_font_set_variation() seeds its new design coords from the font's
existing ones for every axis of the current face, trusting an assert
that their lengths match. hb_font_set_face() keeps the font's
variation coords, which stay sized for the old face, so switching to
a face with more axes and then calling hb_font_set_variation() reads
past the old array: a heap-buffer-overflow read with NDEBUG, an
assertion failure otherwise.
Only reuse the existing design coords when their length matches the
current face; otherwise start from the defaults, as when none are set.
Reproduced the overflow under ASan with NDEBUG and the assertion
failure in the default build. Added a regression test in test-font.c
that fails without the fix. The full ASan+UBSan Meson suite passes.
Assisted-by: Claude
2026-10-16 12:18:00 -06:00
..
2025-02-26 14:41:04 -07:00
2026-10-15 11:16:49 -06:00
2026-07-12 22:20:21 +03:00
2026-10-15 11:16:49 -06:00
2026-10-14 10:51:09 -06:00
2026-10-10 04:04:32 -06:00
2025-04-06 03:49:15 -06:00
2025-07-02 20:14:51 +03:00
2026-10-11 00:41:07 -06:00
2025-04-06 03:49:15 -06:00
2025-04-06 03:49:15 -06:00
2026-10-01 12:59:54 -06:00
2026-10-02 11:22:24 -06:00
2026-10-02 04:31:02 -06:00
2026-10-01 16:51:20 -06:00
2025-04-06 18:08:50 -06:00
2026-10-10 16:58:18 -06:00
2025-04-06 03:49:15 -06:00
2026-08-26 18:34:02 -06:00
2026-06-24 03:00:52 -06:00
2026-06-02 02:33:52 -06:00
2025-04-25 19:04:37 -06:00
2026-01-10 07:42:07 -07:00
2025-03-23 15:40:41 +02:00
2026-10-02 18:01:26 -06:00
2026-08-26 17:54:45 -06:00
2026-07-30 19:02:25 -06:00
2025-04-06 03:49:15 -06:00
2021-11-01 17:59:48 -07:00
2026-10-16 12:18:00 -06:00
2026-10-01 13:33:09 -06:00
2026-09-10 14:54:07 -06:00
2026-04-18 19:54:54 -06:00
2026-08-26 18:34:31 -06:00
2026-08-22 12:48:13 -06:00
2026-10-15 11:16:49 -06:00
2026-05-06 17:27:10 -06:00
2025-04-06 03:49:15 -06:00
2025-04-06 19:16:43 -06:00
2020-06-18 22:56:07 +04:30
2025-04-06 03:49:15 -06:00
2026-03-10 00:19:39 -06:00
2026-08-25 14:47:33 -06:00
2025-04-06 03:49:15 -06:00
2026-09-04 14:14:49 -06:00
2026-07-31 04:31:26 +03:00
2025-04-06 03:49:15 -06:00
2026-10-01 20:40:06 -06:00
2025-04-05 22:37:10 -06:00
2025-04-06 03:49:15 -06:00
2019-08-13 21:02:47 -07:00
2026-10-14 10:51:09 -06:00
2025-04-06 03:49:15 -06:00
2025-04-05 22:37:10 -06:00
2026-07-08 00:53:56 -06:00
2026-07-21 18:47:36 -06:00
2026-08-26 17:11:21 -06:00
2026-10-10 18:32:30 -06:00
2026-10-07 12:19:48 -06:00
2026-10-16 11:01:47 -06:00
2026-08-12 17:17:00 -06:00
2024-02-10 07:08:18 -07:00
2026-08-15 11:43:02 -06:00
2020-01-31 16:37:30 -05:00
2026-07-27 22:12:16 +03:00
2023-11-06 16:49:09 -07:00
2026-10-02 21:33:22 -06:00
2026-10-12 17:50:56 -06:00
2025-04-06 03:49:15 -06:00
2026-10-11 00:38:02 -06:00
2026-10-05 18:04:26 -06:00
2026-10-01 14:47:15 -06:00
2025-04-06 03:49:15 -06:00
2026-06-05 13:35:05 +02:00
2021-07-29 18:30:27 -07:00
2026-10-11 00:41:07 -06:00
2025-04-06 02:34:48 -06:00
2018-10-21 11:27:05 +03:30
2018-10-21 11:27:05 +03:30
2026-07-14 12:01:38 -06:00
2020-01-15 13:36:01 -08:00
2026-10-11 00:38:36 -06:00
2018-10-21 11:27:05 +03:30
2021-07-29 18:30:27 -07:00
2026-10-05 18:11:53 -06:00
2026-09-17 00:37:58 +03:00
2025-06-08 13:43:27 +03:00
2025-04-06 03:49:15 -06:00