nussaibah shaikh
fe407340d5
Clamp transformed CFF2 blend deltas before int conversion ( #6397 )
...
When partially instancing a CFF2 font, the blend rewriters in
hb-subset-cff2.cc pass each old delta row through the region transform
and store the result with (int) round (transform_delta (...)).
transform_delta accumulates in double with no bound. Private DICT
operands can be BCD reals of any magnitude, so a StdVW blend delta of
1e12 yields about 3.7e11 at wght=300:600, and the double-to-int
conversion is undefined behavior (UBSan float-cast-overflow in
cff2_private_dict_blend_opset_t::rewrite_blends).
Saturate with hb_clamp_to<int>, as number_t::to_int already does.
The charstring blend rewriter uses the same expression and gets the
same clamp. Charstring operands are bounded by the 16.16 range, so
that site is not known to overflow in practice. Results that fit in
int are unchanged.
Add a regression test to test-instance-cff2 with a fixture generated
from AdobeVFPrototype.abc.otf. Under UBSAN_OPTIONS=halt_on_error=1 it
fails before the fix and passes after. The full Meson suite passes
under ASan+UBSan (290 ok).
Assisted-by: Claude
2026-10-15 11:16:49 -06:00
..
2018-11-25 01:16:01 -05:00
2018-12-03 22:27:26 +03:30
2018-12-03 22:27:26 +03:30
2018-10-10 18:35:12 -07:00
2020-01-26 23:58:34 +03:30
2026-10-15 11:16:49 -06:00
2023-11-06 16:49:09 -07:00
2025-09-02 15:40:51 -06:00
2024-05-12 09:04:02 -07:00
2023-11-06 16:49:09 -07:00
2021-06-30 14:05:48 -07:00
2023-11-06 16:49:09 -07:00
2025-09-02 15:40:51 -06:00
2025-09-02 15:40:51 -06:00
2021-04-30 14:46:57 -06:00
2020-01-23 10:50:52 -08:00
2023-01-24 18:08:22 -07:00
2022-12-26 17:00:20 -07:00
2022-02-16 17:37:33 -06:00
2023-05-19 16:10:21 -06:00
2018-11-03 22:28:30 +03:30
2021-11-01 17:59:48 -07:00
2023-11-06 16:49:09 -07:00
2018-11-16 12:28:24 -08:00
2023-11-06 16:49:09 -07:00
2018-10-13 17:25:09 -07:00
2018-10-18 13:04:41 -07:00
2023-11-06 16:49:09 -07:00
2018-11-14 13:38:03 -08:00
2018-10-22 22:07:59 +03:30
2018-10-22 22:07:59 +03:30
2018-10-22 22:07:59 +03:30
2018-10-22 22:07:59 +03:30
2020-09-21 11:39:38 +03:30
2019-10-29 02:09:13 +02:00
2026-10-11 14:41:09 -06:00
2026-10-11 14:32:47 -06:00
2026-10-12 17:50:56 -06:00
2026-10-11 14:37:21 -06:00
2026-10-11 14:37:21 -06:00
2026-10-12 17:50:56 -06:00
2026-10-11 00:37:22 -06:00
2024-10-07 13:24:14 -06:00
2026-06-05 15:09:11 -07:00
2018-10-22 10:17:31 +02:00
2018-10-22 10:17:31 +02:00
2018-10-12 16:06:39 -04:00
2026-10-05 18:04:26 -06:00
2026-10-05 18:04:26 -06:00
2026-10-11 00:38:02 -06:00
2020-02-29 16:04:03 +03:30
2026-10-02 04:49:46 -06:00
2026-10-05 18:04:51 -06:00
2026-10-05 18:11:53 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-05 18:04:51 -06:00
2026-10-05 18:11:53 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-05 18:04:51 -06:00
2026-10-05 18:11:53 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-05 18:04:51 -06:00
2026-10-05 18:11:53 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 14:14:29 -06:00
2026-10-02 06:20:51 -06:00
2026-10-02 06:20:51 -06:00
2026-10-11 14:41:09 -06:00
2026-10-11 14:32:47 -06:00
2026-10-11 14:37:21 -06:00
2026-10-12 17:50:56 -06:00
2026-10-11 00:37:22 -06:00
2026-10-05 18:04:26 -06:00
2026-10-11 00:38:02 -06:00
2026-10-05 18:11:53 -06:00
2026-10-11 00:41:07 -06:00
2026-10-02 17:17:10 -06:00
2026-10-02 18:01:26 -06:00
2025-03-23 01:28:41 +02:00
2026-10-14 10:51:09 -06:00
2018-02-14 14:53:10 -08:00
2018-02-14 14:53:10 -08:00
2018-02-14 14:53:10 -08:00
2018-02-14 14:53:10 -08:00
2018-02-14 14:53:10 -08:00
2020-01-26 23:58:34 +03:30
2026-10-11 00:41:07 -06:00
2016-09-26 10:27:33 +01:00
2016-09-26 10:49:09 +01:00
2016-09-26 10:27:33 +01:00
2016-09-26 11:32:25 +01:00
2016-09-26 11:32:25 +01:00
2016-09-26 11:32:25 +01:00
2016-09-26 15:18:16 +01:00
2025-04-06 02:48:49 +02:00
2019-07-25 17:49:51 -07:00
2020-01-09 10:00:32 -08:00
2018-03-07 11:36:54 -08:00
2018-03-07 10:08:47 -08:00
2020-01-09 10:00:32 -08:00
2019-04-26 15:24:47 -07:00
2019-04-26 15:24:47 -07:00
2019-05-07 10:59:03 -07:00
2019-04-26 15:24:47 -07:00
2022-12-02 18:05:53 -07:00
2022-12-23 13:37:59 -07:00
2020-02-05 16:13:10 +03:30
2020-02-05 16:13:10 +03:30
2020-01-31 16:37:30 -05:00
2020-01-31 16:37:30 -05:00
2020-01-31 16:37:30 -05:00
2020-01-31 16:37:30 -05:00
2026-10-11 00:36:18 -06:00
2020-01-31 16:37:30 -05:00
2020-01-31 16:37:30 -05:00
2020-05-21 00:05:54 +04:30
2024-02-10 07:08:18 -07:00
2020-01-26 23:58:34 +03:30
2022-02-18 18:27:02 -06:00
2020-01-26 23:58:34 +03:30
2021-08-03 10:06:27 -06:00
2020-01-24 20:42:12 +03:30
2020-02-29 16:04:03 +03:30
2022-06-16 15:17:58 -06:00
2020-01-21 16:53:19 -08:00
2021-04-30 14:46:57 -06:00
2019-05-16 10:34:53 -07:00
2018-02-12 16:01:15 -08:00
2018-04-16 16:29:26 -06:00
2018-04-17 15:00:23 +02:00
2021-08-04 17:36:24 -06:00
2021-05-26 16:04:56 -06:00
2018-02-12 16:01:15 -08:00
2018-02-23 13:05:58 -08:00
2019-01-29 13:19:21 -08:00
2021-08-04 17:36:24 -06:00
2018-02-14 10:19:50 -08:00
2021-05-26 16:04:56 -06:00
2018-02-27 20:17:04 -08:00
2018-02-16 18:29:29 -08:00
2018-02-16 18:29:29 -08:00
2021-08-04 17:36:24 -06:00
2020-01-23 17:23:55 -08:00
2018-06-08 12:09:34 -06:00
2018-06-08 12:09:34 -06:00
2018-09-05 19:31:55 -07:00
2018-09-05 19:31:55 -07:00
2018-06-08 12:09:34 -06:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2022-12-23 13:37:59 -07:00
2020-01-15 13:36:01 -08:00
2020-01-15 13:36:01 -08:00
2026-07-27 22:12:16 +03:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2018-11-02 16:40:20 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2023-11-06 16:49:09 -07:00
2020-01-26 23:58:34 +03:30
2021-06-30 14:05:48 -07:00
2021-06-30 14:05:48 -07:00
2019-10-06 08:58:40 +03:30
2025-09-02 15:40:51 -06:00
2025-09-02 15:40:51 -06:00
2025-09-02 15:40:51 -06:00
2019-10-06 08:58:40 +03:30
2019-10-06 08:58:40 +03:30
2021-06-30 14:05:48 -07:00
2021-06-30 14:05:48 -07:00
2021-06-30 14:05:48 -07:00
2020-02-23 23:23:50 +03:30
2020-02-06 11:35:48 +03:30
2025-03-07 10:48:46 -07:00
2025-03-07 10:48:46 -07:00
2026-07-03 18:57:00 -06:00
2019-07-25 23:22:00 +04:30
2023-01-25 09:27:49 -07:00
2020-01-26 23:58:34 +03:30
2020-01-26 23:58:34 +03:30
2020-01-26 23:58:34 +03:30
2020-01-26 23:58:34 +03:30
2021-10-23 11:22:39 -07:00
2021-10-23 11:22:39 -07:00
2021-10-23 11:22:39 -07:00
2021-10-23 11:22:39 -07:00
2026-10-02 12:58:52 -06:00
2026-10-02 12:58:52 -06:00
2026-10-02 12:58:52 -06:00
2026-10-02 12:58:52 -06:00
2026-10-02 12:58:52 -06:00
2026-10-02 17:17:10 -06:00
2026-10-02 12:58:52 -06:00
2026-10-02 12:58:52 -06:00
2026-10-02 06:43:14 -06:00
2026-10-02 18:01:26 -06:00
2026-09-14 15:30:54 -06:00
2026-10-10 04:04:32 -06:00
2026-10-10 04:04:32 -06:00
2019-03-29 18:15:00 -07:00