5557 Commits
Author SHA1 Message Date
Dylan M. Taylor 5a24289898 raw: consume merged DJI DNG and Sony ZV-E10 fixes (#4532)
* raw: consume merged DJI DNG and Sony ZV-E10 fixes (#587)

Pin craft-raw to merged f589ff48, carrying craft-libs #2042 and #2039. Preserve the Fuji Kelvin adapter and other application codec pins. Bridge the RAW writer TIFF identity explicitly and regenerate Flatpak sources.

* raw: align engine preview fallback test TIFF error identity
2026-11-18 23:27:04 -05:00
Dylan M. Taylor f52841444e chore(codecs): bump craft-psd to storytold/craft-libs main (#4529) 2026-11-18 18:57:40 -05:00
eliets2andeliets2 2e49c4561e Match bundled camera profiles to Nikon model spellings (#3861)
* Match bundled camera profiles to Nikon model spellings

NEF files without colour matrices depend on the bundled camera profile for colour; missing it leaves the image flat and desaturated.

Normalize the model name (case, spacing and separators) when looking up bundled profiles so variant EXIF spellings find the same profile.

Test: bundled_profile_matches_nikon_model_spelling_variants failed before the change and passes after.

* Find the bundled Nikon Z 8 profile under the Z8 spelling and rebuild older previews

Add an explicit alias for the Exif spelling "NIKON Z8", which the case and spacing fold does not cover.
Advance the camera look version so previews made without the bundled profile are rebuilt.
Test: bundled_profile_matches_nikon_model_spelling_variants and a_proxy_from_the_previous_look_version_is_stale pass.

* Address review for pull request 3861

* Address remaining review requests

* Address review for pull request 3861

* Format the files this pull request changes

* Repair review branch integration

* Address remaining review requests

* Address review for pull request 3861

* Format the files this pull request changes

* Repair review branch integration

---------

Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
2026-11-18 14:49:56 -06:00
Chad ElliottandClaude Opus 5.5 6c3083ebbd fix(raw): Fujifilm RAFs keep their Kelvin white-balance scale (#4492)
craft-raw gives a RAF's white-balance presets as the camera's neutral
multipliers for Illuminant A and D65 (`neutral_pair()`) with no points:
placing points between them is left to the developer. The adapter in
convert.rs rebuilt LightCraft's scale from `points()` alone, so every RAF
lost its Kelvin scale when RAF decoding moved to craft-raw (#4234).

Bodies that rely on it showed a different As Shot Temp / Tint. On the
corpus, seven of the 70 RAFs changed, all to a tint near +110: X-H1
4960 K / +7 became 6384 K / +110, and the X-T2, X-T20 (both files), X-E3,
X-Pro2 and X100F moved the same way. A neutral pair now goes through
`KelvinPresets::from_neutral_pair`, as the RAF decoder did before the
move, and all seven read the same Temp / Tint as before it.

Fixes #4491

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-18 15:15:06 -05:00
.CooCoo 7db608d694 Dependencies: take craft-libs main at 23acc70493 (#4127)
* Updates: take craft-update from craft-libs main at 6e03f65bf

craft-update moves from storytold/craft-libs at 1b34eba41 to 6e03f65bf,
craft-libs main with the update fixes from #763 and #803. Cargo.lock
records the new revision. The other craft-libs pins are unchanged.

* Updates: take craft-update from craft-libs main at e98299546

craft-libs e98299546 includes #923: the check of whether the copy can install itself now runs on the update-check thread instead of in Updater::tick on the UI thread.

* Dependencies: take craft-libs main at 3af2280ee3

Every craft-libs crate in the workspace moves to craft-libs main at
3af2280ee3, so the app builds against one craft-libs commit.

- crates/codecs: the separate craft-avif-encode alias of
  craft-image-codecs is removed. With both on one commit, cargo refuses
  the same package under two names. On native targets the avif feature
  now enables craft-image-codecs' avif and threads features, so a build
  without avif, and the wasm32 build, still leave the AV1 encoder out.
- crates/ui-egui: GroupLocation has two new fields, flyout_width and
  flyout_offset (storytold/craft-libs#627); the default dock location
  sets both to None, as craft-ui does for a new group.

* Dependencies: take craft-libs main at 3af718585c

Every craft-libs crate moves from 3af2280ee3 to craft-libs main at
3af718585c. craft-image-codecs now depends on the new craft-dds crate.

* Flatpak: regenerate cargo sources for craft-libs at 3af718585c

cargo-sources.json now lists the craft-libs git sources that Cargo.lock locks: one
commit, 3af718585c, for every craft-libs crate, and the new craft-dds crate. It
was generated with ./packaging/linux/flatpak/generate-cargo-sources.py.

* Dependencies: take craft-libs main at 453b0da782

Every craft-libs crate moves from 3af718585c to craft-libs main at
453b0da782. Cargo.lock changes only the craft-libs source lines, and
packaging/linux/flatpak/cargo-sources.json is regenerated with
generate-cargo-sources.py for the new commit.

craft-update now reads the installed files for a release the app offers
on a thread of its own, and the prompt opens at a later tick
(storytold/craft-libs#1149). startup_prompt_shows_and_closes offered a
release and checked the prompt after one frame, so it failed when that
thread had not answered yet. The test now waits for the thread's repaint
request and ticks until the prompt opens.

* Updates: startup prompt test fails instead of waiting forever

The offer's thread sends its answer before it asks for a repaint, so the
tick after that repaint reads the answer. The helper now ticks once after
the repaint and asserts that the prompt is open, instead of waiting for
another repaint that never comes when the answer opens no prompt.

The test also gives its updater a pins file that does not exist, so a
launcher choice on the machine running the tests does not stop the offer.
2026-11-18 11:43:24 -06:00
eliets2andeliets2 51bb1950a3 Name where to set the SAM 3 download mirror instead of a built-in default (#3851)
* Add a default SAM 3 download mirror

Users who have not configured a mirror themselves currently reach a dead end with only Close, so Object and Describe masks cannot be set up through the app.

Populate DEFAULT_MIRRORS with LightCraft's HTTPS CDN base URL for the SAM 3 files so the in-app download can start without manual mirror configuration.

Test: default_mirrors_offer_a_download_location failed before the change and passes after.

* Leave the SAM 3 default download location unset until one is verified

No download location is built in for the SAM 3 files yet. The download uses only the location the user sets in LIGHTCRAFT_SAM3_MIRRORS or the mirrors file, and the message when none is set names where to set one.
Test: sam3_mirrors_come_from_the_environment_the_file_and_the_defaults and without_a_configured_mirror_the_message_names_where_to_set_one pass.

* Tighten the change after a final review

---------

Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
2026-11-18 10:56:10 -06:00
Dylan M. Taylor b5400289a9 Merge pull request #4518 from storytold/fix/repin-metadata-psd
Pin craft-metadata and the TIFF cluster to the rev with the shared helpers
2026-11-18 10:25:59 -05:00
Dylan M. Taylor 8e26d2b7fb Pin craft-metadata and the TIFF cluster to the rev that has the shared helpers 2026-11-18 10:25:40 -05:00
Dylan M. Taylor 61b604aed6 Merge pull request #4314 from storytold/codex/exif-ifd0-consumer
Delegate first IFD orientation to shared metadata
2026-11-18 10:08:34 -05:00
Dylan M. Taylor 50b2b32c08 Merge branch 'main' into codex/exif-ifd0-consumer 2026-11-18 10:08:13 -05:00
Dylan M. Taylor 515c8bf2ee Merge pull request #4309 from storytold/codex/shared-raw-exif-consumer
Use shared verbatim image metadata helpers
2026-11-18 10:07:04 -05:00
Dylan M. Taylor e49049cdfd Merge branch 'codex/shared-raw-exif-consumer' of github.com:storytold/lightcraft into pr-4309
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 10:06:35 -05:00
Dylan M. Taylor ef8be0af03 Merge remote-tracking branch 'base-src/main' into pr-4309
# Conflicts:
#	Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 10:05:56 -05:00
Dylan M. Taylor 18fa1bebce Merge branch 'codex/shared-jpeg-sef-consumer' into codex/shared-raw-exif-consumer 2026-11-18 10:04:03 -05:00
Dylan M. Taylor f9cbdb6407 Merge pull request #4308 from storytold/codex/shared-jpeg-sef-consumer
Use shared JPEG EOI and Samsung SEF repair
2026-11-18 10:03:25 -05:00
Dylan M. Taylor b800c6e573 Merge remote-tracking branch 'base-src/main' into tmp4308
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	crates/codecs/Cargo.toml
#	crates/raw/tests/it/dng.rs
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 10:02:00 -05:00
Dylan M. Taylor 8d8e5b89d2 Restore merged DNG dependency pins after metadata stack integration
Keep the RAW, TIFF and metadata public types at the merged writer revision. Drop only the unused egui patches already removed on main, and regenerate Flatpak sources. Preserve the existing metadata and JPEG cutovers and contributor history.
2026-11-18 10:00:31 -05:00
Dylan M. Taylor 1218db1952 Merge pull request #4426 from storytold/dot/shared-bmp-header-sniff
Use shared BMP header recognition for format routing
2026-11-18 09:58:11 -05:00
Dylan M. Taylor 19bfe49c2a Merge remote-tracking branch 'base-src/main' into pr-4426
# Conflicts:
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:57:56 -05:00
Dylan M. Taylor e0fdd6ec46 Merge pull request #4317 from storytold/codex/shared-psd-metadata
Delegate PSD metadata resource selection
2026-11-18 09:57:07 -05:00
Dylan M. Taylor 6cf00875c2 Merge remote-tracking branch 'base-src/main' into pr-4317
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:56:05 -05:00
Dylan M. Taylor 288924e674 Merge pull request #4304 from storytold/codex/shared-psd-merged-consumer
Use shared merged PSD plane reader
2026-11-18 09:54:08 -05:00
Dylan M. Taylor 635b542e0b Merge remote-tracking branch 'base-src/main' into pr-4426
# Conflicts:
#	Cargo.lock
#	crates/codecs/Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:53:00 -05:00
Dylan M. Taylor 31aabff0f2 Merge remote-tracking branch 'base-src/main' into pr-4317
# Conflicts:
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:52:08 -05:00
Dylan M. Taylor 44add76111 Merge remote-tracking branch 'base-src/main' into pr-4304
# Conflicts:
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:51:18 -05:00
Dylan M. Taylor 7ff6c8e1f5 Merge pull request #4307 from storytold/codex/shared-jpeg-inspection-consumer
Use shared JPEG marker and MPF handling
2026-11-18 09:47:27 -05:00
Dylan M. Taylor 8a302d398c Merge pull request #4300 from storytold/codex/shared-webp-consumer
Use shared WebP header inspection
2026-11-18 09:47:19 -05:00
Dylan M. Taylor 4472b3a72d Merge branch 'codex/shared-jpeg-sef-consumer' into codex/shared-raw-exif-consumer 2026-11-18 09:24:32 -05:00
Dylan M. Taylor 0354bb81f9 Merge remote-tracking branch 'origin/main' into pr-4309 2026-11-18 09:21:36 -05:00
Dylan M. Taylor 2a07c3398e Merge remote-tracking branch 'origin/main' into pr-4426 2026-11-18 09:19:02 -05:00
Dylan M. Taylor a638cb7625 Merge remote-tracking branch 'origin/main' into pr-4317 2026-11-18 09:16:30 -05:00
Dylan M. Taylor 2abd2881b9 Merge remote-tracking branch 'origin/main' into pr-4304 2026-11-18 09:15:54 -05:00
Dylan M. Taylor 6e6b9d62ce Merge remote-tracking branch 'origin/main' into codex/shared-webp-consumer 2026-11-18 09:11:44 -05:00
Dylan M. Taylor c3c8e93b20 fix(codecs): gate the legacy EXIF walker to tests
Merging main left the app-owned TIFF walker without non-test callers, so
clippy's dead_code lint failed the gate. The walker is still the oracle for
the shared-summary compatibility test.
2026-11-18 09:10:59 -05:00
Dylan M. Taylor d5382f20b4 Merge pull request #4340 from storytold/refactor/shared-dng-writer
raw: cut DNG wire writing over to craft-raw
2026-11-18 08:33:34 -05:00
Dylan M. Taylor 5606bccb4f Merge remote-tracking branch 'origin/main' into codex/shared-webp-consumer 2026-11-18 07:50:02 -05:00
Dylan M. Taylor 7609d6e60c Merge remote-tracking branch 'origin/main' into codex/shared-jpeg-inspection-consumer 2026-11-18 07:49:50 -05:00
FredApps 6f5027f7ca Merge pull request #3414 from finaler1x/issue-3404-unused-egui-patches
Issue #3404: drop the unused egui patches that break offline builds
2026-11-18 19:40:41 +07:00
FredApps 2359954d9a Merge branch 'main' into issue-3404-unused-egui-patches 2026-11-18 18:19:20 +07:00
FredApps fb1d24a472 Merge pull request #3801 from lostwald/fix/legacy-render-dither-golden
LR-BEHAV-RENDER-FIDELITY: refresh legacy goldens after dithering (#3788)
2026-11-18 18:18:18 +07:00
Dylan M. Taylor 216739da8c test: await GPU warm-up after failed similar-photo search 2026-11-18 06:09:14 -05:00
FredApps 5b81b550db Merge branch 'main' into fix/legacy-render-dither-golden 2026-11-18 17:12:22 +07:00
FredApps 250f8e2274 Merge pull request #3201 from nledford/mac-menu-layout-language
LR-BEHAV-LOCALE: the Edit menu drops its 18-row Language submenu; Settings has the choice
2026-11-18 17:11:36 +07:00
FredApps b49622bdb6 Merge branch 'main' into issue-3404-unused-egui-patches 2026-11-18 16:30:12 +07:00
FredApps d89322240d Merge branch 'main' into mac-menu-layout-language 2026-11-18 16:22:23 +07:00
FredApps 1dcc28d246 Merge branch 'main' into fix/legacy-render-dither-golden 2026-11-18 16:22:07 +07:00
Dylan M. Taylor 12070a58e5 raw: pin the merged borrowed DNG writer and refresh package sources 2026-11-18 02:15:38 -05:00
Dylan M. Taylor f1829845a5 Merge remote-tracking branch 'origin/main' into integration/dng-final-pin-20261118 2026-11-18 02:05:52 -05:00
cf3d0205ef Decode AVIF through shared image codecs (#4312)
* Decode AVIF through shared image codecs

* Include JPEG encoder distribution notices

* Exercise AVIF HDR decoding through public API

* Preserve AVIF source bit depth

* Test AVIF alpha through public entrypoints

* Update AVIF round trip for supported decode

* Document native AVIF decode support

* Clarify import feature gates

* Keep RAW fixtures valid under shared container and strip bounds

* Include sample-to-chunk mappings in CR3 fixtures

* Find Similar test: a photo read from memory isn't a missing read (#3823)

The second search after a stop plans its reads after frames in which the
loupe and filmstrip decoded photos; those are measured from memory
(source_ref takes the cached source), so the drive sees fewer than 12 reads
on a loaded machine. Check instead that no file is read twice, the searched
photo above all; the answer still needs every photo's signature.

* Find Similar test: every photo is measured after the resumed search

* Bound AVIF padded picture storage and preserve integer source flag

* Size the AVIF picture-store budget for the stored canvas, not the clap-cropped size

* Attribute the AVIF lossless decode fixture

* Keep the AVIF clap test helpers free of unwrap for the codecs lint gate

* lightcraft: keep the newer craft-cms pin after merging main

---------

Co-authored-by: Bruno-Alumn <171815746+Bruno-Alumn@users.noreply.github.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
2026-11-18 01:58:41 -05:00
Dylan M. Taylor 2037556929 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	crates/raw/tests/it/dng.rs
2026-11-17 08:23:27 -05:00