A photosite brighter than its same-colour neighbours was tested against K σ at the median of those neighbours,
which sorts them. σ rises with level and the median is at least the dimmest neighbour, so σ at that neighbour
bounds the threshold from below: a photosite that fails it fails the full test too, and nearly all of them do.
Same candidates, so the same output; the pass takes 125 ms instead of 200 ms on a 45 MP NIKON D850 NEF.
* codecs: use shared container muxing for slideshow video
* codecs: format shared mux adapter and return invalid writer state
* codecs: box active WebM mux state to keep writer variants compact
* test(slideshow): ignore craft-media Mp4Writer placeholder free box
* fix(codecs): include av01 ftyp brand and real WebM ReferenceBlock delta
* Adopt the shared AGENTS.md (RFC-0072) and test rules (RFC-0071)
* Point docs to the shared rules; drop local rules
* AGENTS.md: correct the repository facts
Give the full layer list (there is no tiff crate), the it/ path of the MCP e2e sweep and when the Windows CI leg runs; README: replace the removed AGENTS.md anchor and name the two unsafe crates.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: aiongg <aiongg@users.noreply.github.com>
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(engine): reject duplicate .lrcat central directory records in Lightroom backups
* fix(engine): use craft_zip::lenient::file::directory_record_names path
* build: enable lenient feature on craft-zip for directory_record_names
* fix(engine): decode DirectoryRecordName::name lossily as UTF-8
* fix(engine): use SeekableArchive::has_duplicate_names for strict directory parity
* T006: read GeoNames ZIPs with craft-zip
* geocode: take craft-zip at the workspace's craft-libs rev; build the fixture with its writer
craft-zip at 23acc704, the rev every other craft-libs crate here uses, has
the same Archive and Writer code as 5c496f6e (that rev only adds the
seekable reader), so the workspace stays on one craft-libs rev.
unzip::make now builds its one-file fixture with craft_zip::Writer instead
of hand-written headers, so geocode no longer needs crc32fast or
miniz_oxide.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* geocode: retain the selected ZIP entry index
---------
Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* engine: read Lightroom backup zip via craft-zip
* engine: pin Lightroom ZIP reader to merged shared revision
* engine: add mid-stream cancellation test for Lightroom backup extraction
* raw: consume merged DJI DNG and Sony ZV-E10 fixes (#587)
Pin craft-raw to merged f589ff48, carrying craft-libs #2042 and #2039. Preserve the Fuji Kelvin adapter and other application codec pins. Bridge the RAW writer TIFF identity explicitly and regenerate Flatpak sources.
* raw: align engine preview fallback test TIFF error identity
* Match bundled camera profiles to Nikon model spellings
NEF files without colour matrices depend on the bundled camera profile for colour; missing it leaves the image flat and desaturated.
Normalize the model name (case, spacing and separators) when looking up bundled profiles so variant EXIF spellings find the same profile.
Test: bundled_profile_matches_nikon_model_spelling_variants failed before the change and passes after.
* Find the bundled Nikon Z 8 profile under the Z8 spelling and rebuild older previews
Add an explicit alias for the Exif spelling "NIKON Z8", which the case and spacing fold does not cover.
Advance the camera look version so previews made without the bundled profile are rebuilt.
Test: bundled_profile_matches_nikon_model_spelling_variants and a_proxy_from_the_previous_look_version_is_stale pass.
* Address review for pull request 3861
* Address remaining review requests
* Address review for pull request 3861
* Format the files this pull request changes
* Repair review branch integration
* Address remaining review requests
* Address review for pull request 3861
* Format the files this pull request changes
* Repair review branch integration
---------
Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
craft-raw gives a RAF's white-balance presets as the camera's neutral
multipliers for Illuminant A and D65 (`neutral_pair()`) with no points:
placing points between them is left to the developer. The adapter in
convert.rs rebuilt LightCraft's scale from `points()` alone, so every RAF
lost its Kelvin scale when RAF decoding moved to craft-raw (#4234).
Bodies that rely on it showed a different As Shot Temp / Tint. On the
corpus, seven of the 70 RAFs changed, all to a tint near +110: X-H1
4960 K / +7 became 6384 K / +110, and the X-T2, X-T20 (both files), X-E3,
X-Pro2 and X100F moved the same way. A neutral pair now goes through
`KelvinPresets::from_neutral_pair`, as the RAF decoder did before the
move, and all seven read the same Temp / Tint as before it.
Fixes#4491
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Updates: take craft-update from craft-libs main at 6e03f65bf
craft-update moves from storytold/craft-libs at 1b34eba41 to 6e03f65bf,
craft-libs main with the update fixes from #763 and #803. Cargo.lock
records the new revision. The other craft-libs pins are unchanged.
* Updates: take craft-update from craft-libs main at e98299546
craft-libs e98299546 includes #923: the check of whether the copy can install itself now runs on the update-check thread instead of in Updater::tick on the UI thread.
* Dependencies: take craft-libs main at 3af2280ee3
Every craft-libs crate in the workspace moves to craft-libs main at
3af2280ee3, so the app builds against one craft-libs commit.
- crates/codecs: the separate craft-avif-encode alias of
craft-image-codecs is removed. With both on one commit, cargo refuses
the same package under two names. On native targets the avif feature
now enables craft-image-codecs' avif and threads features, so a build
without avif, and the wasm32 build, still leave the AV1 encoder out.
- crates/ui-egui: GroupLocation has two new fields, flyout_width and
flyout_offset (storytold/craft-libs#627); the default dock location
sets both to None, as craft-ui does for a new group.
* Dependencies: take craft-libs main at 3af718585c
Every craft-libs crate moves from 3af2280ee3 to craft-libs main at
3af718585c. craft-image-codecs now depends on the new craft-dds crate.
* Flatpak: regenerate cargo sources for craft-libs at 3af718585c
cargo-sources.json now lists the craft-libs git sources that Cargo.lock locks: one
commit, 3af718585c, for every craft-libs crate, and the new craft-dds crate. It
was generated with ./packaging/linux/flatpak/generate-cargo-sources.py.
* Dependencies: take craft-libs main at 453b0da782
Every craft-libs crate moves from 3af718585c to craft-libs main at
453b0da782. Cargo.lock changes only the craft-libs source lines, and
packaging/linux/flatpak/cargo-sources.json is regenerated with
generate-cargo-sources.py for the new commit.
craft-update now reads the installed files for a release the app offers
on a thread of its own, and the prompt opens at a later tick
(storytold/craft-libs#1149). startup_prompt_shows_and_closes offered a
release and checked the prompt after one frame, so it failed when that
thread had not answered yet. The test now waits for the thread's repaint
request and ticks until the prompt opens.
* Updates: startup prompt test fails instead of waiting forever
The offer's thread sends its answer before it asks for a repaint, so the
tick after that repaint reads the answer. The helper now ticks once after
the repaint and asserts that the prompt is open, instead of waiting for
another repaint that never comes when the answer opens no prompt.
The test also gives its updater a pins file that does not exist, so a
launcher choice on the machine running the tests does not stop the offer.
* Add a default SAM 3 download mirror
Users who have not configured a mirror themselves currently reach a dead end with only Close, so Object and Describe masks cannot be set up through the app.
Populate DEFAULT_MIRRORS with LightCraft's HTTPS CDN base URL for the SAM 3 files so the in-app download can start without manual mirror configuration.
Test: default_mirrors_offer_a_download_location failed before the change and passes after.
* Leave the SAM 3 default download location unset until one is verified
No download location is built in for the SAM 3 files yet. The download uses only the location the user sets in LIGHTCRAFT_SAM3_MIRRORS or the mirrors file, and the message when none is set names where to set one.
Test: sam3_mirrors_come_from_the_environment_the_file_and_the_defaults and without_a_configured_mirror_the_message_names_where_to_set_one pass.
* Tighten the change after a final review
---------
Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
Keep the RAW, TIFF and metadata public types at the merged writer revision. Drop only the unused egui patches already removed on main, and regenerate Flatpak sources. Preserve the existing metadata and JPEG cutovers and contributor history.