Commit Graph
4678 Commits
Author SHA1 Message Date
Bruno cb91d69eec perf(raw): hot-pixel candidates skip the neighbour sort when they can't pass (#4592)
A photosite brighter than its same-colour neighbours was tested against K σ at the median of those neighbours,
which sorts them. σ rises with level and the median is at least the dimmest neighbour, so σ at that neighbour
bounds the threshold from below: a photosite that fails it fails the full test too, and nearly all of them do.
Same candidates, so the same output; the pass takes 125 ms instead of 200 ms on a 45 MP NIKON D850 NEF.
2026-11-20 14:33:53 -05:00
Dylan M. Taylor c17badc68a test(codecs): add JPEG/WebP metadata framing and MP4/WebM writer parity tests (#4591)
* test(codecs): add JPEG/WebP metadata framing and MP4/WebM writer parity tests

* test(codecs): fix MP4 MAX_PERIODS overflow test case
2026-11-20 13:40:44 -05:00
Dylan M. Taylor 968b0428fc test(engine): add committed-WAL multi-commit growth and shrink parity tests (#4588)
* test(engine): add committed-WAL multi-commit growth and shrink parity tests

* test(engine): cover shrink after growth in one SQLite WAL
2026-11-20 13:18:56 -05:00
FredApps 041c8db2f7 Merge pull request #3482 from dotCooCoo/fix/keyword-names-no-trailing-asterisk
LRC-LIB-KEYWORDS: a new keyword name cannot end in an asterisk
2026-11-20 21:04:02 +07:00
FredApps d501e3c5d4 Merge pull request #3469 from dotCooCoo/feat/keywording-enter-keywords
LRC-LIB-KEYWORDS: the Keywording panel's Enter Keywords view edits keywords as text
2026-11-20 21:03:57 +07:00
FredApps 9b6a264304 Merge pull request #2110 from helgehelge123/hebrew-glyph-fallback
LR-BEHAV-LOCALIZE: Hebrew file and folder names get glyphs (part of #1915)
2026-11-20 21:03:47 +07:00
FredApps fd93a14654 Merge pull request #2020 from nledford/album-counts-background
LR-LIB-SMARTALBUM: creating or giving a keyword no longer freezes the window while albums are counted
2026-11-20 21:03:42 +07:00
Terra854 55644724be Restore JPEG format detection precedence (#778) (#4583) 2026-11-20 21:00:00 +07:00
Dylan M. Taylor 368855cd1e codecs: use shared container muxing for slideshow video (#4557)
* codecs: use shared container muxing for slideshow video

* codecs: format shared mux adapter and return invalid writer state

* codecs: box active WebM mux state to keep writer variants compact

* test(slideshow): ignore craft-media Mp4Writer placeholder free box

* fix(codecs): include av01 ftyp brand and real WebM ReferenceBlock delta
2026-11-20 06:21:27 -05:00
Dylan M. Taylor 5eca431541 engine: use craft-sqlite for varint and serial-type decoding (#4576) 2026-11-20 03:54:34 -05:00
Dylan M. Taylor 89d11ab116 fix(engine): allow duplicate non-catalog entries in Lightroom backup ZIPs (#4581) 2026-11-20 03:01:52 -05:00
Dylan M. Taylor 2d905e0ab3 fix(engine): reject duplicate .lrcat central directory records in Lightroom backups (#4574)
* fix(engine): reject duplicate .lrcat central directory records in Lightroom backups

* fix(engine): use craft_zip::lenient::file::directory_record_names path

* build: enable lenient feature on craft-zip for directory_record_names

* fix(engine): decode DirectoryRecordName::name lossily as UTF-8

* fix(engine): use SeekableArchive::has_duplicate_names for strict directory parity
2026-11-19 23:32:35 -05:00
976f52ab69 geocode: use craft-zip for GeoNames downloads (#4566)
* T006: read GeoNames ZIPs with craft-zip

* geocode: take craft-zip at the workspace's craft-libs rev; build the fixture with its writer

craft-zip at 23acc704, the rev every other craft-libs crate here uses, has
the same Archive and Writer code as 5c496f6e (that rev only adds the
seekable reader), so the workspace stays on one craft-libs rev.

unzip::make now builds its one-file fixture with craft_zip::Writer instead
of hand-written headers, so geocode no longer needs crc32fast or
miniz_oxide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* geocode: retain the selected ZIP entry index

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-19 21:31:08 -05:00
Dylan M. Taylor a3f65b67b8 fetch: use shared craft_http_url::parse_content_range (#4546)
* fetch: use shared craft_http_url::parse_content_range

* chore: repin craft-http-url to craft-libs main
2026-11-19 20:41:29 -05:00
Dylan M. Taylor 8539efc832 codecs: share image metadata framing and sniffing (#4556)
* codecs: share image metadata framing and sniffing

* codecs: cover BigTIFF and JPEG-LS shared routing parity

* codecs: add unit tests for BMFF probe precedence and sniff fallback
2026-11-19 20:36:49 -05:00
Dylan M. Taylor 7c7965989b codecs(psd): share PSD recovery framing with craft_psd::HeadView (#4562) 2026-11-19 19:53:31 -05:00
Dylan M. Taylor 1901762de2 engine: read Lightroom backup zip via craft-zip (#4555)
* engine: read Lightroom backup zip via craft-zip

* engine: pin Lightroom ZIP reader to merged shared revision

* engine: add mid-stream cancellation test for Lightroom backup extraction
2026-11-19 18:49:30 -05:00
Dylan M. Taylor 78b575658a fetch: delegate HTTP URL and redirect syntax to craft-http-url (#4337) 2026-11-19 09:14:32 -05:00
Dylan M. Taylor 5a24289898 raw: consume merged DJI DNG and Sony ZV-E10 fixes (#4532)
* raw: consume merged DJI DNG and Sony ZV-E10 fixes (#587)

Pin craft-raw to merged f589ff48, carrying craft-libs #2042 and #2039. Preserve the Fuji Kelvin adapter and other application codec pins. Bridge the RAW writer TIFF identity explicitly and regenerate Flatpak sources.

* raw: align engine preview fallback test TIFF error identity
2026-11-18 23:27:04 -05:00
eliets2andeliets2 2e49c4561e Match bundled camera profiles to Nikon model spellings (#3861)
* Match bundled camera profiles to Nikon model spellings

NEF files without colour matrices depend on the bundled camera profile for colour; missing it leaves the image flat and desaturated.

Normalize the model name (case, spacing and separators) when looking up bundled profiles so variant EXIF spellings find the same profile.

Test: bundled_profile_matches_nikon_model_spelling_variants failed before the change and passes after.

* Find the bundled Nikon Z 8 profile under the Z8 spelling and rebuild older previews

Add an explicit alias for the Exif spelling "NIKON Z8", which the case and spacing fold does not cover.
Advance the camera look version so previews made without the bundled profile are rebuilt.
Test: bundled_profile_matches_nikon_model_spelling_variants and a_proxy_from_the_previous_look_version_is_stale pass.

* Address review for pull request 3861

* Address remaining review requests

* Address review for pull request 3861

* Format the files this pull request changes

* Repair review branch integration

* Address remaining review requests

* Address review for pull request 3861

* Format the files this pull request changes

* Repair review branch integration

---------

Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
2026-11-18 14:49:56 -06:00
Chad ElliottandClaude Opus 5.5 6c3083ebbd fix(raw): Fujifilm RAFs keep their Kelvin white-balance scale (#4492)
craft-raw gives a RAF's white-balance presets as the camera's neutral
multipliers for Illuminant A and D65 (`neutral_pair()`) with no points:
placing points between them is left to the developer. The adapter in
convert.rs rebuilt LightCraft's scale from `points()` alone, so every RAF
lost its Kelvin scale when RAF decoding moved to craft-raw (#4234).

Bodies that rely on it showed a different As Shot Temp / Tint. On the
corpus, seven of the 70 RAFs changed, all to a tint near +110: X-H1
4960 K / +7 became 6384 K / +110, and the X-T2, X-T20 (both files), X-E3,
X-Pro2 and X100F moved the same way. A neutral pair now goes through
`KelvinPresets::from_neutral_pair`, as the RAF decoder did before the
move, and all seven read the same Temp / Tint as before it.

Fixes #4491

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-18 15:15:06 -05:00
.CooCoo 7db608d694 Dependencies: take craft-libs main at 23acc70493 (#4127)
* Updates: take craft-update from craft-libs main at 6e03f65bf

craft-update moves from storytold/craft-libs at 1b34eba41 to 6e03f65bf,
craft-libs main with the update fixes from #763 and #803. Cargo.lock
records the new revision. The other craft-libs pins are unchanged.

* Updates: take craft-update from craft-libs main at e98299546

craft-libs e98299546 includes #923: the check of whether the copy can install itself now runs on the update-check thread instead of in Updater::tick on the UI thread.

* Dependencies: take craft-libs main at 3af2280ee3

Every craft-libs crate in the workspace moves to craft-libs main at
3af2280ee3, so the app builds against one craft-libs commit.

- crates/codecs: the separate craft-avif-encode alias of
  craft-image-codecs is removed. With both on one commit, cargo refuses
  the same package under two names. On native targets the avif feature
  now enables craft-image-codecs' avif and threads features, so a build
  without avif, and the wasm32 build, still leave the AV1 encoder out.
- crates/ui-egui: GroupLocation has two new fields, flyout_width and
  flyout_offset (storytold/craft-libs#627); the default dock location
  sets both to None, as craft-ui does for a new group.

* Dependencies: take craft-libs main at 3af718585c

Every craft-libs crate moves from 3af2280ee3 to craft-libs main at
3af718585c. craft-image-codecs now depends on the new craft-dds crate.

* Flatpak: regenerate cargo sources for craft-libs at 3af718585c

cargo-sources.json now lists the craft-libs git sources that Cargo.lock locks: one
commit, 3af718585c, for every craft-libs crate, and the new craft-dds crate. It
was generated with ./packaging/linux/flatpak/generate-cargo-sources.py.

* Dependencies: take craft-libs main at 453b0da782

Every craft-libs crate moves from 3af718585c to craft-libs main at
453b0da782. Cargo.lock changes only the craft-libs source lines, and
packaging/linux/flatpak/cargo-sources.json is regenerated with
generate-cargo-sources.py for the new commit.

craft-update now reads the installed files for a release the app offers
on a thread of its own, and the prompt opens at a later tick
(storytold/craft-libs#1149). startup_prompt_shows_and_closes offered a
release and checked the prompt after one frame, so it failed when that
thread had not answered yet. The test now waits for the thread's repaint
request and ticks until the prompt opens.

* Updates: startup prompt test fails instead of waiting forever

The offer's thread sends its answer before it asks for a repaint, so the
tick after that repaint reads the answer. The helper now ticks once after
the repaint and asserts that the prompt is open, instead of waiting for
another repaint that never comes when the answer opens no prompt.

The test also gives its updater a pins file that does not exist, so a
launcher choice on the machine running the tests does not stop the offer.
2026-11-18 11:43:24 -06:00
eliets2andeliets2 51bb1950a3 Name where to set the SAM 3 download mirror instead of a built-in default (#3851)
* Add a default SAM 3 download mirror

Users who have not configured a mirror themselves currently reach a dead end with only Close, so Object and Describe masks cannot be set up through the app.

Populate DEFAULT_MIRRORS with LightCraft's HTTPS CDN base URL for the SAM 3 files so the in-app download can start without manual mirror configuration.

Test: default_mirrors_offer_a_download_location failed before the change and passes after.

* Leave the SAM 3 default download location unset until one is verified

No download location is built in for the SAM 3 files yet. The download uses only the location the user sets in LIGHTCRAFT_SAM3_MIRRORS or the mirrors file, and the message when none is set names where to set one.
Test: sam3_mirrors_come_from_the_environment_the_file_and_the_defaults and without_a_configured_mirror_the_message_names_where_to_set_one pass.

* Tighten the change after a final review

---------

Co-authored-by: eliets2 <287273517+eliets2@users.noreply.github.com>
2026-11-18 10:56:10 -06:00
FredApps abfc8c55ec Merge branch 'main' into fix/keyword-names-no-trailing-asterisk 2026-11-18 22:12:43 +07:00
Dylan M. Taylor 50b2b32c08 Merge branch 'main' into codex/exif-ifd0-consumer 2026-11-18 10:08:13 -05:00
Dylan M. Taylor ef8be0af03 Merge remote-tracking branch 'base-src/main' into pr-4309
# Conflicts:
#	Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 10:05:56 -05:00
Dylan M. Taylor 18fa1bebce Merge branch 'codex/shared-jpeg-sef-consumer' into codex/shared-raw-exif-consumer 2026-11-18 10:04:03 -05:00
Dylan M. Taylor b800c6e573 Merge remote-tracking branch 'base-src/main' into tmp4308
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	crates/codecs/Cargo.toml
#	crates/raw/tests/it/dng.rs
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 10:02:00 -05:00
Dylan M. Taylor 19bfe49c2a Merge remote-tracking branch 'base-src/main' into pr-4426
# Conflicts:
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:57:56 -05:00
FredApps 10d24033f5 Merge branch 'main' into fix/keyword-names-no-trailing-asterisk 2026-11-18 21:57:40 +07:00
Dylan M. Taylor 6cf00875c2 Merge remote-tracking branch 'base-src/main' into pr-4317
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:56:05 -05:00
Dylan M. Taylor 635b542e0b Merge remote-tracking branch 'base-src/main' into pr-4426
# Conflicts:
#	Cargo.lock
#	crates/codecs/Cargo.toml
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:53:00 -05:00
Dylan M. Taylor 31aabff0f2 Merge remote-tracking branch 'base-src/main' into pr-4317
# Conflicts:
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:52:08 -05:00
Dylan M. Taylor 44add76111 Merge remote-tracking branch 'base-src/main' into pr-4304
# Conflicts:
#	packaging/linux/flatpak/cargo-sources.json
2026-11-18 09:51:18 -05:00
FredApps 3d58dda66e Merge branch 'main' into fix/keyword-names-no-trailing-asterisk 2026-11-18 21:48:24 +07:00
Dylan M. Taylor 7ff6c8e1f5 Merge pull request #4307 from storytold/codex/shared-jpeg-inspection-consumer
Use shared JPEG marker and MPF handling
2026-11-18 09:47:27 -05:00
Dylan M. Taylor 0354bb81f9 Merge remote-tracking branch 'origin/main' into pr-4309 2026-11-18 09:21:36 -05:00
Dylan M. Taylor 2a07c3398e Merge remote-tracking branch 'origin/main' into pr-4426 2026-11-18 09:19:02 -05:00
Dylan M. Taylor a638cb7625 Merge remote-tracking branch 'origin/main' into pr-4317 2026-11-18 09:16:30 -05:00
Dylan M. Taylor 2abd2881b9 Merge remote-tracking branch 'origin/main' into pr-4304 2026-11-18 09:15:54 -05:00
Dylan M. Taylor 6e6b9d62ce Merge remote-tracking branch 'origin/main' into codex/shared-webp-consumer 2026-11-18 09:11:44 -05:00
Dylan M. Taylor c3c8e93b20 fix(codecs): gate the legacy EXIF walker to tests
Merging main left the app-owned TIFF walker without non-test callers, so
clippy's dead_code lint failed the gate. The walker is still the oracle for
the shared-summary compatibility test.
2026-11-18 09:10:59 -05:00
FredApps b971b3bfe5 Merge branch 'main' into fix/keyword-names-no-trailing-asterisk 2026-11-18 21:07:51 +07:00
Dylan M. Taylor d5382f20b4 Merge pull request #4340 from storytold/refactor/shared-dng-writer
raw: cut DNG wire writing over to craft-raw
2026-11-18 08:33:34 -05:00
Dylan M. Taylor 5606bccb4f Merge remote-tracking branch 'origin/main' into codex/shared-webp-consumer 2026-11-18 07:50:02 -05:00
Dylan M. Taylor 7609d6e60c Merge remote-tracking branch 'origin/main' into codex/shared-jpeg-inspection-consumer 2026-11-18 07:49:50 -05:00
FredApps 5dde053259 Merge branch 'main' into fix/keyword-names-no-trailing-asterisk 2026-11-18 19:41:17 +07:00
Dylan M. Taylor 216739da8c test: await GPU warm-up after failed similar-photo search 2026-11-18 06:09:14 -05:00
FredApps 5b81b550db Merge branch 'main' into fix/legacy-render-dither-golden 2026-11-18 17:12:22 +07:00
FredApps 664974a820 Merge branch 'main' into hebrew-glyph-fallback 2026-11-18 16:22:39 +07:00