Hebrew folder and file names drew as boxes: no face in the UI fallback
chain (Inter, egui's default faces, the craft-fonts faces) has Hebrew
letters. theme::font_definitions already falls back on every craft-fonts
face of a non-CJK script, so the glyphs come from Noto Sans Hebrew, added
to craft-fonts in storytold/craft-fonts#12:
- Pin craft-fonts to 1466a88, the head of that PR (release and FreeBSD
workflows, flake.nix/flake.lock, local packaging scripts). Re-pin to its
merge commit once it lands.
- CRAFT_FONTS_REQUIRED rejects a font input without Noto Sans Hebrew
Regular, so a release can't ship boxes with an older pin.
- The web build embeds Noto Sans Hebrew Regular (~65 KiB) next to Noto
Sans Thai, for Hebrew file and folder names in every UI language.
- The Thai folder-name test becomes a helper; a Hebrew test (letters,
final forms, maqaf, geresh, gershayim, niqqud) runs it through every UI
family, and the engine checks that the shipped face draws Hebrew and the
shekel sign. They fail with a craft-fonts input without Hebrew and skip
without CRAFT_FONTS_DIR. The egui check leaves out the shekel sign: Inter
and Hack draw it before the Hebrew face, and in monospace Hack also holds
the replacement glyph, where egui 0.36's has_glyph answers false
(resolve_face(c) == replacement face) although the sign draws.
Reading direction, measured on the laid-out galley: egui 0.36 shapes
each run of one face with harfrust, which orders a Hebrew run right to
left, so each word reads correctly. Nothing reorders the runs, and the
space between words comes from Inter, so a multi-word name shows its
words in logical order, left to right (documented in
docs/localization-parity.md and docs/web.md).
Part of #1915.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Native already appends every non-CJK craft face via ui_fallback; the wasm build
only embedded BIZ UDPGothic and Noto Sans Thai, so add Noto Sans Georgian to
that filter. Check its glyphs next to Thai and Arabic, and bump craft-fonts-ref
to a71c20e (storytold/craft-fonts#27).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
Retain the complete reviewed change, including prior integration resolutions,
on current upstream.
#736: deliver Thai UI fonts in desktop and web releases
Use the merged craft-fonts input containing Noto Sans Thai across release,
FreeBSD and Nix builds. Retain the small Thai face in the wasm subset and
reject required release inputs that lack it. Exercise the reported Thai
folder name through all UI families and include original font licence texts
in Windows installers as well as portable packages.
Refs #736; completes delivery of the fallback added in #750.
Validation: UI tests, UI-only strict Clippy, 28 wasm checks, HEIF checks,
assets, layers, parity and formatting pass. All 21 unrelated workspace
failures reproduce with upstream Rust sources and the old font input;
existing Rust 1.95 metadata/engine Clippy findings remain unchanged.
1.Added Simplified Chinese font support for web and desktop builds.
2.Kept Inter as the default font, with Chinese used only as a fallback.
3.Verified Chinese glyph tests and a macOS universal build.
Signed-off-by: supper_yijie <syj794844854@163.com>
A build script's cwd is its package root, so CRAFT_FONTS_DIR=../craft-fonts —
the spelling the README and craft-fonts' integration docs both use, written
relative to the workspace root — resolved to crates/craft-fonts and failed.
The failure is silent from the user's side: the app runs, the language menu
lists every language, and selecting Chinese or Japanese paints boxes. Warn
when no font ends up embedded, not only when the variable is set but wrong.
The Japanese fonts (BIZ UDPGothic Regular/Bold for the UI, BIZ UDMincho for text
watermarks; #110, #114) now come from storytold/craft-fonts instead of assets/fonts/.
- crates/engine/build.rs: the craft-fonts recipe. With CRAFT_FONTS_DIR set it embeds
the manifest's fonts as lightcraft_engine::CRAFT_FONTS (wasm32: BIZ UDPGothic Regular
only, for the web size budget); unset, CRAFT_FONTS is empty. Local files only, no
network; craft-fonts is not in any Cargo.toml.
- UI: theme::font_definitions adds the Japanese faces after Inter and egui's defaults
in every family (BIZ UDPGothic first, Bold first for semibold). About box lists the
embedded families.
- Watermarks: Inter, then the craft-fonts Japanese faces (Mincho first).
- Removed BIZUDPGothic-Regular/Bold.ttf, BIZUDMincho-Regular.ttf and their OFL files,
and their ATTRIBUTION rows; added an attribution row for craft-fonts as an optional
build input; NOTICE updated.
- Tests: Japanese glyph tests use CRAFT_FONTS and skip without it; new tests for
Japanese in the UI with craft-fonts and for the UI and watermarks without it.
- CI: the FreeBSD job builds/tests with craft-fonts. Releases check out craft-fonts at
a pinned commit, build with CRAFT_FONTS_DIR + CRAFT_FONTS_REQUIRED=1, and ship the
fonts' OFL licences (plus NOTICE) in every package.
- Docs: AGENTS.md, CLAUDE.md, README, docs/web.md, docs/localization-ja.md, ROADMAP,
parity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>