Ignore repeated FBX geometry connections

This commit is contained in:
FredApps committed 2026-11-13 11:22:29 +01:00
1 parent b982d66008
commit 1e72ed79c3
2 files changed
+21

No files matched your search

+3
View File
@@ -542,6 +542,9 @@ fn read_inner(bytes: &[u8], files: &mut Files) -> Result<RawMesh> {
attribute_of.insert(parent, *a);
}
}
// Repeated connections describe the same instance; keep distinct model placements in order.
let mut seen_instances = HashSet::new();
instances.retain(|instance| seen_instances.insert(instance.clone()));
let placed: HashSet<&String> = instances.iter().map(|(g, _)| g).collect();
let mut unplaced: Vec<String> = geometries.keys().filter(|g| !placed.contains(g)).cloned().collect();
unplaced.sort_unstable();
@@ -415,6 +415,24 @@ fn fbx_ascii_and_z_up() {
check_fbx_scene(&import_mesh_bytes("z.fbx", &binary_fbx(&scene(true), 7700, true)).unwrap().mesh, true);
}
#[test]
fn fbx_duplicate_geometry_connections_do_not_duplicate_instances() {
let mut nodes = scene(false);
let connections = nodes.iter_mut().find(|node| node.name == "Connections").unwrap();
for _ in 0..50 {
connections.children.push(n("C", vec![P::S("OO"), P::L(10), P::L(21)], vec![]));
}
let imported = import_mesh_bytes("scene.fbx", ascii_fbx(&nodes).as_bytes()).unwrap();
assert_eq!(imported.report.triangles, 3);
let objects = nodes.iter_mut().find(|node| node.name == "Objects").unwrap();
objects.children.push(n("Model", vec![P::L(22), P::S("Other\u{0}\u{1}Model"), P::S("Mesh")], vec![]));
let connections = nodes.iter_mut().find(|node| node.name == "Connections").unwrap();
connections.children.push(n("C", vec![P::S("OO"), P::L(10), P::L(22)], vec![]));
let imported = import_mesh_bytes("scene.fbx", ascii_fbx(&nodes).as_bytes()).unwrap();
assert_eq!(imported.report.triangles, 6, "a different model must remain a distinct instance");
}
/// The scene of [`scene`] (Y up) as FBX 6.1 writes it: geometry inside the Model, objects named
/// `Class::Name`, `Properties60`, `Connect` records, GlobalSettings inside Objects.
const FBX61: &str = r#"; FBX 6.1.0 project file