This moves existing validation from binding creation to BGL
creation. Binding creation already had a check that returns
`CreateBindGroupError::InvalidStorageTextureFormat` if the format
does not match the layout, so it is not necessary to revalidate
the format support at that point.
Two-row matrices in uniform buffers in Vulkan/SPIR-V's default
"extended" (std140) layout do not adhere to WGSL/Naga IR's layout
rules - each column is aligned to a minimum of 16 bytes rather than
just the vector size.
To work around this, we emit additional std140 compatible type
declarations for each type used in a uniform buffer that requires
one. Any two-row matrix struct member is decomposed into the
containing struct as separate vectors for each column. Two-row
matrices used directly as uniform buffers are wrapped in a struct with
a vector member for each column, and arrays (of arrays, etc) of
two-row matrices are declared as arrays (of arrays) of structs
containing a vector member for each column.
When loading such a value from a uniform buffer, we convert from the
std140 compatible type to the regular type immediately after loading.
Accesses of a uniform two-row matrix's columns using constant indices
are rewritten to access the containing struct's vector members
directly. Accesses using dynamic indices are implemented by loading
and converting the matrix, extracting each column then `switch`ing on
the index to select the correct column.
We can now remove the expected failure annotation for the Vulkan
backend on the uniform_input struct_layout test, as it now passes.
Notable public API additions:
- New `StageError` variants:
- `VertexOutputLocationTooLarge`
- `TooManyVertexOutputs`
- Add new `shader_io_deductions` submodule of `wgpu_core::validation` with:
- A `ShaderIoDeduction` trait
- `enum MaxVertexShaderOutputDeduction`
- `MaxInterStageShaderVariablesDeductions` for them.
In order to prepare for spec.-compliant validation of shader I/O, we
need to create a new `enum` that will have the same set of _variants_ as
`naga::ShaderStage`, but will carry additional information relevant to
validation. As a preparatory step, create the new `enum` (called
`ShaderStageForValidation`), and use it as the source of truth for
details of the stage being validated. This yields several immediate
benefits, even before making adjustments for the new validation:
- Stage-specific stage is now properly encapsulated. `compare_function`,
which was previously passed as a `Option`al sibling argument, is now
properly associated with only the vertex shader stage.
- This led to an odd discovery that `compare_function` was being
provided to `check_stages` with other stages, but not actually
actually checked. This seems like a rightfully squashed bug.
- Instead of passing a `wgpu_types::ShaderStages` (with a single bit)
and `naga::ShaderStage` side-by-side, encapsulate both into conversion
methods for an instance of `ShaderStageForValidation`, so errors are
impossible to make.
This is intended to provide all the information necessary to make use of
occlusion and timestamp queries, without needing to read example code or
the WebGPU spec.