Notable public API additions:
- New `StageError` variants:
- `VertexOutputLocationTooLarge`
- `TooManyVertexOutputs`
- Add new `shader_io_deductions` submodule of `wgpu_core::validation` with:
- A `ShaderIoDeduction` trait
- `enum MaxVertexShaderOutputDeduction`
- `MaxInterStageShaderVariablesDeductions` for them.
In order to prepare for spec.-compliant validation of shader I/O, we
need to create a new `enum` that will have the same set of _variants_ as
`naga::ShaderStage`, but will carry additional information relevant to
validation. As a preparatory step, create the new `enum` (called
`ShaderStageForValidation`), and use it as the source of truth for
details of the stage being validated. This yields several immediate
benefits, even before making adjustments for the new validation:
- Stage-specific stage is now properly encapsulated. `compare_function`,
which was previously passed as a `Option`al sibling argument, is now
properly associated with only the vertex shader stage.
- This led to an odd discovery that `compare_function` was being
provided to `check_stages` with other stages, but not actually
actually checked. This seems like a rightfully squashed bug.
- Instead of passing a `wgpu_types::ShaderStages` (with a single bit)
and `naga::ShaderStage` side-by-side, encapsulate both into conversion
methods for an instance of `ShaderStageForValidation`, so errors are
impossible to make.
This is intended to provide all the information necessary to make use of
occlusion and timestamp queries, without needing to read example code or
the WebGPU spec.
* Initial commit
* Other initial changes
* Updated shader snapshots
* Added new HLSL limitation
* Moved error to global variable error
* Added docs to per_primitive
* Added a little bit more docs here and there in IR
* Adding validation to ensure that task shaders have a task payload
* Updated spec to reflect the change to payload variables
* Updated the mesh shading spec because it was goofy
* some doc tweaks
* Tried to clarify docs a little
* Tried to update spec
* Removed a warning
* Addressed comment about docs mistake
* Review in progress
- Extensive revisions to `docs/api-specs/mesh_shading.md`.
- Doc comments.
- Ensure `Module` stays at the bottom of `ir/mod.rs`.
- Avoid a clone.
- Rename some arguments to be more specific.
- Minor readability tweaks.
* mesh_shading.md: more tweaks
* Ran cargo fmt
* Small tweaks
* [naga] Move definition of `ShaderStage::compute_like` to `proc`.
Move the definition of `naga::ShaderStage::compute_like` from
`naga::ir` into `naga::proc`. We generally want ot keep methods out of
`naga::ir`, since the IR itself is complicated enough already.
* Replace TODO comment with followup issue.
* Update analyzer.rs
Co-authored-by: Jim Blandy <jimb@red-bean.com>
* Removed stuff in accordance with Jim's recommendation
* minor changes for readability
* Pull mesh shader output type validation out into its own function.
* doc fixes
* remove duplicated task payload validation
* Quick little changes
* Another quick fix
* Quick fix
* Removed unnecessary TODO statement
* A
* Tried to be more expressive
* Made functions only work in mesh shader entry points
* Various validation fix attempts
* Undid capabilities resize
* WGSL PR is up :)
* Update naga/src/ir/mod.rs
Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
* Update naga/src/front/wgsl/error.rs
Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
* Update naga/src/ir/mod.rs
Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
* Other Erich suggestion
* Updated docs & validation for some builtins
* Added some docs & removed contentious "// TODO"
* Fixed bad validation, formatted mesh shader wgsl
* Rewrote the IR and parser significantly
* Improved validation slightly, remvoed obselete crap, fixed bug in compaction, made clippy happy
* Added changelog entry
* Made parser respect enable extension
* Updated mesh shader spec
* Cleaned up the mesh shader analyzer function
* Updated changelog
* Updated validation from spv-write
* Slight tweaks
* Added capabilitiy thing blah blah blah
* Fixed compaction & clean stuff up
* Fixed compaction and such pt 2
* Paved the way for primitive-index stuff
* Little bit of cleanup
* Added new features/capabilities for point primitives and added snapshots for stuff
* Updated spec to rename something
* Updated some limits stuff
* Made some improvements
* Fixed doctests & webgpu stuff
* Fixed experimental features stuff
* A little more scaffolding
* Added some initial validation
* Added per primitive validation
* Improved per primitive validation
* Added some more validation
* Fixed primitive index validation
* Updated the spec
* Updated comments on some limits
* Made some fixes
* Fixed new validation rule for task payload size
* Update wgpu-core/src/validation.rs
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
* Update wgpu-core/src/validation.rs
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
* A small tweak to mesh shader recommended minimums
* Addressed 2 comments
* A few more comments addressed with limits
* Addressed more comments
* Update wgpu-core/src/validation.rs
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
* Split up error
* Addressed another comment by changing workgroup size validation
* Final comment addressed
* Update wgpu-info/src/human.rs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update wgpu-core/src/validation.rs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update wgpu-info/src/human.rs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixed compilation and added some new test functions
---------
Co-authored-by: SupaMaggie70Incorporated <85136135+SupaMaggie70Incorporated@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>