Commit Graph
315 Commits
Author SHA1 Message Date
Keeley Hoek 469b416632 [rs] Don't busy-redraw in examples 2020-05-12 03:20:19 +10:00
bors[bot]andPaul Kernfeld 1de6a6c084 [rs] Merge #302
302: Add BufferRange struct for #199 r=kvark a=paulkernfeld

- Use in set_index_buffer
- Use in set_vertex_buffer
- Use in BindingResource

Co-authored-by: Paul Kernfeld <paulkernfeld@gmail.com>
2020-05-10 21:50:06 +00:00
Paul Kernfeld 445786d474 [rs] Add Buffer.slice fn for #199
This fn is used for set_index_buffer, set_vertex_buffer, and
BindingResource
2020-05-10 17:37:19 -04:00
bors[bot]andkyren c985df9fc8 [rs] Merge #272
272: Force the wasm32 types to match Send / Sync with the native types r=kvark a=kyren

This is potentially a controversial change so this is just a draft to discuss it.

Currently, when building wgpu on wasm32, none of the interface types are Send or Sync, whereas on any other platform they are generally Send and Sync and this can cause a lot of pain, especially in the presence of async.

This PR is the nuclear option: lie and forcibly declare nearly all interface types to be Send or Send + Sync.

I think I understand the situation with proposed wasm32 threading a bit better now, and as of right now at least with my current understanding, it seems to me unlikely that javascript values held by rust could *ever* be sent transparently to another worker.  The mechanism that rust apparently will use to implement transparent threading will be to use `SharedArrayBuffer` to share memory between multiple workers.  Javascript provides a way for certain (serializable) objects to be shared with with other workers through `worker.postMessage()`, so Javascript has *some* story for sending javascript values to other threads, but only plain rust values that exist solely in the `SharedArrayBuffer` memory are send-able under this scheme.  I've looked briefly through some of the wasm proposals like the interface types proposal, but I don't have a good sense if there's any proposed mechanism at all for interface types and threads to interact at all.

If that's true that's really unfortunate because it seems like any thread safe API shared by native and web is doomed to mismatch.  This is even more unfortunate because many of the webgpu types in the draft standard are marked as 'Serializable', meaning that they *are* actually safe to send to another worker via `postMessage`, but there does not appear to be a planned way for rust to do this transparently.

I definitely could be misunderstanding the situation though and even if I am understanding it, the situation may have since changed.  I also don't know the timing here, I don't know what the eventual timing of wasm32 threading support will be vs webgpu support and interface types support.  *Right now* this PR is almost certainly sound, but there's definitely a possible future where it becomes unsound, and even maybe a possible future where it becomes unsound but then could later be made sound again.

Co-authored-by: kyren <kerriganw@gmail.com>
2020-05-07 04:09:14 +00:00
kyren a3e6e1024f [rs] Force the wasm32 types to match Send / Sync with the native types
There are several things in this commit:

1) Add `Send` or `Send + Sync` bounds to most of the associated types in `Context`.
2) Force most of the handle types and future types returned by the web backend to be Send / Sync
3) Make `BufferReadMapping` and `BufferWriteMapping` `Send` again on native by
   making the associated detail types implement `Send`.
2020-05-06 23:02:27 -04:00
bors[bot]andDzmitry Malyshau 8e2486f172 [rs] Merge #300
300: Properly free pass contents r=kvark a=kvark

Fixes #299

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-05-06 01:56:54 +00:00
Dzmitry Malyshau 55b727e0c5 [rs] Rustfmt pass on examples 2020-05-05 21:55:42 -04:00
Dzmitry Malyshau 4b7f26b8a2 [rs] Free pass contents 2020-05-05 21:55:25 -04:00
bors[bot]andJohn Mitchell ae58ac8447 [rs] Merge #298
298: Added a screenshot for harmony. r=kvark a=StarArawn



Co-authored-by: John Mitchell <john.mitchell@mangolanguages.com>
2020-05-05 16:05:05 +00:00
John Mitchell cbbc067ef7 [rs] Added a screenshot for harmony. 2020-05-05 11:59:56 -04:00
Dzmitry Malyshau 2c3d278ee3 [rs] Add wgpu-pbr to README 2020-05-05 11:20:15 -04:00
bors[bot]andDzmitry Malyshau c2b5719029 [rs] Merge #297
297: Update wgpu with the BGL fix r=kvark a=kvark



Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
2020-05-05 04:05:22 +00:00
Dzmitry Malyshau b1f0961713 [rs] Update wgpu with the BGL fix 2020-05-05 00:04:24 -04:00
bors[bot]andRukai 81a725c561 [rs] Merge #295
295: Remove wasm-bindgen patches r=grovesNL a=rukai

A new release occurred with the required fixes, so we no longer need to patch it.

Co-authored-by: Rukai <rubickent@gmail.com>
2020-05-02 12:44:45 +00:00
Rukai 881071a21a [rs] Remove wasm-bindgen patches 2020-05-02 22:41:15 +10:00
bors[bot]andDzmitry Malyshau 3586f123c9 [rs] Merge #291
291: Update for wgpu-core r=grovesNL a=kvark

Depends on https://github.com/gfx-rs/wgpu/pull/619
Closes #285

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-05-02 03:59:45 +00:00
Dzmitry Malyshau 26b424e35b [rs] Update for wgpu-core 2020-04-30 15:52:16 -04:00
bors[bot]andDzmitry Malyshau a60fc025aa [rs] Merge #281
281: The Context trait r=grovesNL a=kvark

The main motivation here is to avoid blocking the wgpu-core updates by `wgpu-native`. Instead, `wgpu-native` becomes a branch, and the dependency of `wgpu-rs` -> `wgpu-native` starts adhering to the contract/API of the standard webgpu-native headers.

The biggest change is the introduction of the Context trait. I recall us discussing 2 downsides to having this trait:
  1. inconvenient for the users to include. This is a non-issue here, since it's private.
  2. more code to maintain. This is less of an issue if we aim to have 3 backends.

What this gives in return is a well established contract with the backends. Unlike gfx-rs, the backend code is right here, a part of the crate, so the contract is only for internal use.

Fixes #156 : the "direct" implementation of it goes straight to wgpu-core. What this gives us is less overhead for command recording, since there is no longer an extra indirection on every command, and no heap allocation at the end of a render pass.

The downside of this PR is one extra `Arc` (with addref) per object.

This commit also has small improvements:
- consuming command buffers on submit (Fixes #267)
- Instance type
- proper call to destructors
- fallible `request_device`

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-27 04:12:38 +00:00
Dzmitry Malyshau 196e0dba7e [rs] Small comment on WebGPU backend bit, readme update 2020-04-27 00:11:22 -04:00
Dzmitry Malyshau 7633f48617 [rs] Port the Web backend to the Context trait 2020-04-26 19:18:24 -04:00
Dzmitry Malyshau 03258c2171 [rs] Move everything into Context trait, remove async 2020-04-26 19:18:24 -04:00
Dzmitry Malyshau 1fb8e7bb5e [rs] Rewire the backend system to remove wgpu-native step
Main change here is the introduction of the Context trait.
The "direct" implementation of it goes straight to wgpu-core.

This commit also has small improvements:
- consuming command buffers on submit
- Instance type
- proper call to destructors
2020-04-26 19:18:24 -04:00
Chinedu Francis Nwafili 35e07f4172 [rs] Add screenshots of examples
When looking into wgpu-rs as a replacement for WebGL I went to the
examples directory on GitHub to browse for a bit.

I wanted to see some of the examples at a glance without needing to
clone the repository.

This commit enables that by adding a README to each example with a
description of the example and screenshots / example output.

In a few cases the description is a bit redundant - but my hope is that
in the future we can improve all the READMEs.

Being a web API and thus very accessible, WebGPU could end up being many
people's first introduction to graphics programming so the lower we make
the barrier the better.
2020-04-26 18:59:48 -02:30
bors[bot]andRukai 455f5cb224 [rs] Merge #280
280: Add required wasm-bindgen patches to readme r=grovesNL a=rukai

Fixes https://github.com/gfx-rs/wgpu-rs/issues/279

Co-authored-by: Rukai <rubickent@gmail.com>
2020-04-25 03:03:56 +00:00
Rukai 1e8cc73e66 [rs] Add required wasm-bindgen patches to readme 2020-04-25 12:09:13 +10:00
Gabriel Majeri 31726862c9 [rs] Build and deploy examples in CI 2020-04-24 22:32:26 -02:30
Igor Shaposhnik 94c06b0c9b [rs] Disable fail fast on CI 2020-04-24 22:31:21 -02:30
Christophe Massolin e8244ae5e3 [rs] Update README.md for running examples on the web (#275)
* [readme] add details for running on wasm32 target

* [readme] update

* [readme] [web] Running instruction on webgpu.io
2020-04-24 09:42:15 -04:00
bors[bot]andAron Granberg e0ec201ee5 [rs] Merge #271
271: Improve docs for BindingType r=kvark a=HalfVoxel

I think everything should be correct.

The readonly flags seem obvious at face value, but I couldn't find anything in the specifications about them (other than some unrelated validation), so I didn't add any documentation for those fields.

Co-authored-by: Aron Granberg <aron.granberg@gmail.com>
2020-04-22 13:08:31 +00:00
Aron Granberg 8219a64ecb [rs] Improve docs for BindingType 2020-04-22 15:07:11 +02:00
bors[bot]andDzmitry Malyshau 4f1dbaf9ef [rs] Merge #268
268: Fix hello-triangle example format and bind group r=kvark a=kvark



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-21 23:10:18 +00:00
Dzmitry Malyshau 628af82d4c [rs] Fix hello-triangle example format and bind group 2020-04-21 19:08:42 -04:00
bors[bot]andJoshua Groves 0f8c0947d9 [rs] Merge #262
262: Reverse srgb in hello-triangle r=kvark a=grovesNL

Reverse srgb support in hello-triangle (these were backwards by mistake)

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2020-04-20 02:18:30 +00:00
bors[bot]andJoshua Groves ec8b028326 [rs] Merge #264
264: Use opaque texels in mipmap example r=kvark a=grovesNL

This fixes rendering for the mipmap example in Nightly

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2020-04-20 02:13:07 +00:00
Joshua Groves 3a121231b7 [rs] Use opaque texels in mipmap example 2020-04-19 23:38:58 -02:30
Joshua Groves 8f7d7ce028 [rs] Reverse srgb support in hello-triangle 2020-04-19 16:32:50 -02:30
Dzmitry Malyshau 0b20277396 [rs] Add harmony to README 2020-04-18 11:21:08 -04:00
Joshua Groves 930d2cd791 [rs] Use srgb for swapchain when possible 2020-04-18 01:04:28 -02:30
Joshua Groves f35c3fb3cd [rs] Add wasm to CI 2020-04-18 01:04:28 -02:30
Joshua Groves 1d72176b1d [rs] Add labels to mapped descriptors where possible 2020-04-18 01:04:28 -02:30
Joshua Groves 6aa83a526b [rs] Fix some remaining TODOs in the web backend 2020-04-18 01:04:28 -02:30
Joshua Groves 0fbb75ea95 [rs] Expose more functions on the web backend 2020-04-18 01:04:28 -02:30
Joshua Groves 1f4b8801f5 [rs] Combine wasm_main/main and add console_log 2020-04-18 01:04:28 -02:30
Joshua Groves c3c5d3927a [rs] Switch event loop back to ControlFlow::Poll 2020-04-18 01:04:28 -02:30
Joshua Groves c4be28fcd9 [rs] Allow describe example to run on the web 2020-04-18 01:04:28 -02:30
Joshua Groves 095d682a5b [rs] Get shadow mostly working
Some of the implementation is still missing in Canary
2020-04-18 01:04:28 -02:30
Joshua Groves 3b8e0db62a [rs] Update to latest winit and wasm-bindgen 2020-04-18 01:04:28 -02:30
Joshua Groves 44083411d9 [rs] Only expose adapter info on native 2020-04-18 01:04:28 -02:30
Joshua Groves 654833ea56 [rs] Get capture mostly working
`File::create` isn't available on wasm, so we can't actually write the
output image anywhere unless we target something else as the file
system (e.g. local storage)
2020-04-18 01:04:28 -02:30
Joshua Groves 8f7d8cf27e [rs] Get mipmap mostly working
Subresource tracking for mip levels isn't available in Canary yet, so
we can't verify that the web example output matches native
2020-04-18 01:04:28 -02:30