Commit Graph
653 Commits
Author SHA1 Message Date
Greg V 6b00ebf94d [rs] Staging belt: do not panic by unwrapping send result in recall (fixes #634) 2020-11-24 19:46:32 +03:00
Dzmitry Malyshau 0735ba6d28 [rs] Update wgpu with gpu-alloc fixes 2020-11-24 09:56:09 -05:00
bors[bot]andJoshua Groves e578fce5cd [rs] Merge #615
615: Update web bindings r=kvark a=grovesNL

- Use newer buffer mapping API everywhere and remove polyfill.
  - There's a weird thing here where we hand out `&[u8]`/`&mut [u8]`s for users to write into, but later have to copy back into the browser-provided `ArrayBuffer`. It's done during `Drop` here but open to some other ideas.
- Add in `web_sys::GpuTextureComponentType::DepthComparison` though it looks like we don't have it in Gecko yet:
  > GPUDevice.createBindGroupLayout: 'depth-comparison' (value of 'textureComponentType' member of GPUBindGroupLayoutEntry) is not a valid value for enumeration GPUTextureComponentType.
- `mipmap` fails because `layout` is still required in Gecko:
  > GPUDevice.createRenderPipeline: Missing required 'layout' member of GPUPipelineDescriptorBase.
- Add in some parts that we can implement now, including labels, debug markers, render bundles, and `get_bind_group_layout`

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2020-11-24 04:25:00 +00:00
Joshua Groves 6a6f4c139a [rs] Add get_bind_group_layout to web backend 2020-11-24 00:11:26 -03:30
Joshua Groves 92b52a4610 [rs] Add more labels and debug markers to web backend 2020-11-24 00:11:26 -03:30
Joshua Groves ff1a348862 [rs] Add render bundles to web backend 2020-11-24 00:11:26 -03:30
Joshua Groves f79845e777 [rs] Update web bindings 2020-11-24 00:11:16 -03:30
bors[bot]andDzmitry Malyshau 6f712d59bd [rs] Merge #633
633: Port to the updated wgpu error model r=scoopr a=kvark

Depends on https://github.com/gfx-rs/wgpu/pull/1034

I removed most of the helping sugar we had before, in exchange for simple `match` and a `handle_error` function.
I believe this way it's easier to maintain and debug (stepping through closures is a pain today).

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-23 23:04:54 +00:00
Dzmitry Malyshau 0adcfdd3ad [rs] Port to the updated wgpu error model 2020-11-23 17:59:21 -05:00
bors[bot]andMikko Lehtonen f22356329c [rs] Merge #632
632: Improve error messages r=kvark a=scoopr

Improve error messages
depends on gfx-rs/wgpu#1037


Co-authored-by: Mikko Lehtonen <scoopr@iki.fi>
2020-11-23 15:50:23 +00:00
Mikko Lehtonen add09fb33c [rs] Handle PassErrorScope Ids 2020-11-23 08:23:43 +02:00
Mikko Lehtonen dc61d7fb22 [rs] Add label for render pass context error
Also made the label key settable
2020-11-21 23:47:07 +02:00
bors[bot]andJoshua Groves db82edb31e [rs] Merge #631
631: Temporarily use `BackendBit::PRIMARY` in examples r=kvark a=grovesNL

`BackendBit::all()` allows GL/surfman to be used on macOS which appears to prevent rendering with Metal (e.g. hello-triangle displays an empty window).

surfman will be removed in later versions of gfx, which will allow us to switch back to `BackendBit::all()` in the examples.

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2020-11-21 03:54:15 +00:00
Joshua Groves de83824617 [rs] Fix typo 2020-11-21 00:07:57 -03:30
Joshua Groves dc9a3096f5 [rs] Temporarily use BackendBit::PRIMARY in examples
`BackendBit::all()` allows GL/surfman to be used on macOS which appears
to prevent rendering with Metal (e.g. hello-triangle displays an empty
window).

surfman will be removed in later versions of gfx, which will allow us
to switch back to `BackendBit::all()` in the examples.
2020-11-20 23:33:10 -03:30
bors[bot]andMikko Lehtonen 9e1a62112a [rs] Merge #617
617: Add labels for some error messages r=kvark a=scoopr

This places some pieces on how to transform the ids in the errors to a label, and adds them to the validation message.

This changes the formatting of the validation error to happen when constructing the error, rather than in the unhandled error handler.
It also requires some code for all the error variants for extracting the ids.

Co-authored-by: Mikko Lehtonen <scoopr@iki.fi>
2020-11-19 22:42:41 +00:00
Mikko Lehtonen daa15a853f [rs] Add labels for some error messages
This adds transforms for the ids in the errors to a label,
and adds them to the validation error message.

This changes the formatting of the validation error to happen when
constructing the error, rather than in the unhandled error handler.
It also requires some code for all the error variants for extracting the ids.
2020-11-20 00:36:29 +02:00
Mikko Lehtonen 581674efb3 [rs] Update wgpu-core 2020-11-20 00:36:29 +02:00
bors[bot]andMikko Lehtonen 98bd3033f6 [rs] Merge #630
630: Update wgpu-core r=kvark a=scoopr

Pass label to error id creation methods.

Co-authored-by: Mikko Lehtonen <scoopr@iki.fi>
2020-11-19 15:10:37 +00:00
Mikko Lehtonen dd7f1735f3 [rs] Update wgpu-core
Pass label to error id creation methods.
2020-11-19 01:21:09 +02:00
bors[bot]andDzmitry Malyshau ed96a4218f [rs] Merge #629
629: Update wgpu, work around surface validation r=straightforward a=kvark

Works around https://github.com/gfx-rs/wgpu/issues/1030
Includes https://github.com/zakarumych/gpu-alloc/pull/24

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-18 15:07:30 +00:00
Dzmitry Malyshau a14c253e6a [rs] Update wgpu, work around surface validation 2020-11-18 10:05:20 -05:00
bors[bot]andinfinitesnow c56340fb62 [rs] Merge #627
627: Fixed size in "boids" example r=kvark a=infinitesnow

Buffer size is specified in number of items instead of bytes and fails validation against compiled SPIR-V

Co-authored-by: infinitesnow <3xplosive.g@gmail.com>
2020-11-17 22:15:54 +00:00
infinitesnow ca15e7c1a3 [rs] Fixed size in "boids" example 2020-11-17 21:26:35 +01:00
bors[bot]andDzmitry Malyshau 8675a0cf5e [rs] Merge #621
621: Drop for surfaces and adapters r=grovesNL a=kvark

Based on https://github.com/gfx-rs/wgpu/pull/1023

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-16 21:48:14 +00:00
Dzmitry Malyshau edbe112d23 [rs] Drop for surfaces and adapters 2020-11-16 16:47:21 -05:00
bors[bot]andTimo de Kort dff98ac2a8 [rs] Merge #624
624: Remove implicit conversion hello-triangle shader.vert r=kvark a=Napokue

Remove implicit conversion to float, and change it to explicit conversion. Reason for this change is to prepare the hello-triangle example for Naga glsl-spirv path.

Co-authored-by: Timo de Kort <dekort.timo@gmail.com>
2020-11-15 23:36:30 +00:00
Timo de Kort 25b7cea64c [rs] Remove implicit conversion hello-triangle shader.vert 2020-11-15 23:13:53 +01:00
bors[bot]andStygeon 92e75723d5 [rs] Merge #618
618: Removed unusued Uniform struct in texture-arrays example. r=cwfitzgerald a=Stygeon

The Uniform struct in the texture-arrays example is unused.

Co-authored-by: Stygeon <denrellum@gmail.com>
2020-11-12 01:30:35 +00:00
Stygeon 6fb829d4df [rs] Removed unusued Uniform struct in texture-arrays example. 2020-11-12 02:26:58 +01:00
bors[bot]andMarvin Löbel 033c896c4f [rs] Merge #613
613: Add more context to errors originating in Passes and Encoders r=kvark a=Kimundi

**Description**
This adds some top-level error context information to indicate wether an error originated in a `{Render,Compute}Pass` or `{Command,RenderBundle}Encoder` to make error messages more clear.

Combined with https://github.com/gfx-rs/wgpu/pull/1018, errors in passes will look like this:
```
wgpu error: Validation error

Caused by:
    In a RenderPass
    In a draw command
    index 3600 extends beyond limit 38
```


Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-11-11 04:56:44 +00:00
bors[bot]andDavid Shah 2226cc8d31 [rs] Merge #614
614: Bump winit version to 0.23.0 r=cwfitzgerald a=daveshah1

This fixes the following error trying to run the hello-triangle (and probably other) examples on GNOME/Wayland:

    [wayland-client error] Attempted to dispatch unknown opcode 0 for wl_shm, aborting.



Co-authored-by: David Shah <dave@ds0.me>
2020-11-10 20:57:19 +00:00
David Shah ac806458f9 [rs] Bump winit version to 0.23.0
This fixes the following error trying to run the hello-triangle (and
probably other) examples on GNOME/Wayland:

    [wayland-client error] Attempted to dispatch unknown opcode 0 for wl_shm, aborting.

Signed-off-by: David Shah <dave@ds0.me>
2020-11-10 20:28:41 +00:00
bors[bot]andAlan Kemp 315dd420f4 [rs] Merge #612
612: Update create_buffer_init_polyfill for wasm32 r=grovesNL a=alankemp

This removes create_buffer_mapped which has been removed in the latest chrome canary and firefox nightly and fixes #609 

Co-authored-by: Alan Kemp <alan@alankemp.com>
2020-11-10 02:59:00 +00:00
Marvin Löbel a74546f974 [rs] Add more context to errors originating in Passes and Encoders 2020-11-09 23:49:19 +01:00
Alan Kemp e1b05a583a [rs] Update create_buffer_init_polyfill for wasm32 2020-11-09 21:22:03 +00:00
bors[bot]andDzmitry Malyshau ccc178a3d0 [rs] Merge #611
611: Match inputs/outputs in msaa-line shader r=kvark a=kvark

Note: this shouldn't be necessary, as the varyings are matched by location and not the name. However, spirv-cross doesn't try to fiddle with the varying names, so it fails if they are unmatched.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-09 14:31:28 +00:00
Dzmitry Malyshau b8f157f7df [rs] Match inputs/outputs in msaa-line shader 2020-11-09 09:27:51 -05:00
bors[bot]andZsolt Bölöny 8c386efb7c [rs] Merge #610
610: Rename TextureUsage::OUTPUT_ATTACHMENT to RENDER_ATTACHMENT r=kvark a=yzsolt

Depends on https://github.com/gfx-rs/wgpu/pull/1017 

Co-authored-by: Zsolt Bölöny <bolony.zsolt@gmail.com>
2020-11-09 14:03:43 +00:00
Zsolt Bölöny e6d7873844 [rs] Update dependencies 2020-11-09 13:50:06 +01:00
Zsolt Bölöny 7c290fdd8d [rs] Rename TextureUsage::OUTPUT_ATTACHMENT to RENDER_ATTACHMENT 2020-11-09 10:35:55 +01:00
bors[bot]andDzmitry Malyshau 6d8dfaca84 [rs] Merge #606
606: Enable GL backend r=kvark a=kvark

Replaces #182
Depends on https://github.com/gfx-rs/wgpu/pull/907

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-11-05 04:13:45 +00:00
bors[bot]andZicklag 4d378d6315 [rs] Merge #605
605: Enable X11 Support for the GL Backend r=kvark a=zicklag



Co-authored-by: Zicklag <zicklag@katharostech.com>
2020-11-05 04:05:27 +00:00
Dzmitry Malyshau 58d2b36d13 [rs] Enable GL backend 2020-11-04 23:02:01 -05:00
Zicklag cd2e2cc61e [rs] Enable X11 Support for the GL Backend 2020-11-03 16:14:58 -06:00
bors[bot]andMarvin Löbel bcaae6a962 [rs] Merge #598
598: Clarify docs for Queue::write methods r=kvark a=Kimundi



Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
2020-10-22 16:17:26 +00:00
Marvin Löbel 9073d18c70 [rs] Clarify docs for Queue::write methods 2020-10-22 17:40:23 +02:00
bors[bot]andDzmitry Malyshau 1a556facab [rs] Merge #596
596: Update wgpu with another bind group fix, updated power preference r=kvark a=kvark

Includes https://github.com/gfx-rs/wgpu/pull/973 and https://github.com/gfx-rs/wgpu/pull/980

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2020-10-13 20:58:27 +00:00
Dzmitry Malyshau c115aed4cc [rs] Update wgpu with another bind group fix, updated power preference 2020-10-13 16:57:52 -04:00
bors[bot]andParis DOUADY 42bb7ca65f [rs] Merge #594
594: Fix mipmap example which was y-flipped r=kvark a=Uriopass

Mipmap rendering was y-flipped, hence making one out of every two mipmaps wrong. See:

![image](https://user-images.githubusercontent.com/5420739/95760589-7eba1f80-0cab-11eb-8a5f-bfe9e228b480.png)

(look at the black dots)

Co-authored-by: Paris DOUADY <paris.douady@hotmail.fr>
2020-10-12 14:56:08 +00:00