Commit Graph
878 Commits
Author SHA1 Message Date
Dzmitry Malyshau b71bcc5349 Add is_power_of_two function (#603) 2020-04-25 00:17:50 -04:00
Aron Granberg 11a321131f Improve error messages for mismatched binding types (#593) 2020-04-25 00:17:50 -04:00
d937742da7 Merge #599
599: [0.5] texture storage read fix r=kvark a=kvark

This is blocked on @cwfitzgerald confirming/denying if this is a proper fix for https://github.com/gfx-rs/wgpu-rs/issues/253

Co-authored-by: Almar Klein <almar.klein@gmail.com>
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
wgpu-core-v0.5.3
2020-04-19 02:32:12 +00:00
Dzmitry Malyshau 47336441e5 Version bump to 0.5.3 and changelog update 2020-04-18 17:02:54 -04:00
Dzmitry Malyshau 8dcaf05649 Fix host mapping buffer barriers 2020-04-18 17:02:54 -04:00
Dzmitry Malyshau 5235547a3a Enable READ access for texture storage 2020-04-18 14:19:53 -04:00
Dzmitry Malyshau acfa8ecb35 Derive swapchain layout off the load operation 2020-04-18 14:19:43 -04:00
Almar Klein 754b465818 Warn when binding a buffer that is still mapped 2020-04-18 14:19:33 -04:00
88710e899d Merge #590
590: [0.5] Various correctness fixes r=kvark a=kvark

Includes the pipeline layout fix, read-only usage fix, and the improved error messages.
Everything is backwards-compatible.

Co-authored-by: Aron Granberg <aron.granberg@gmail.com>
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-15 23:02:32 +00:00
Dzmitry Malyshau 3cd7376abe Version bump to 0.5.2 and CHANGELOG update wgpu-core-v0.5.2 2020-04-15 18:59:18 -04:00
Aron Granberg 78b4ccfb97 Improve drawing error messages 2020-04-15 18:56:25 -04:00
Aron Granberg b51162c2c6 Improve error messages when passing buffers with the wrong usage flags 2020-04-15 18:55:59 -04:00
Dzmitry Malyshau fe92b3fec9 Track pipeline layout lifetime 2020-04-15 18:54:50 -04:00
Dzmitry Malyshau 2a535d24c3 Fix buffer unmap warning 2020-04-15 18:54:29 -04:00
Dzmitry Malyshau be49ffae9c Comment fixes, header update 2020-04-15 18:54:14 -04:00
Dzmitry Malyshau 9c49a8c3d5 Fix read-only flags 2020-04-15 18:53:33 -04:00
Aron Granberg e0485b49ac Improve error message when bind group and bind group layout have different number of entries 2020-04-15 18:53:19 -04:00
bors[bot]andDzmitry Malyshau 83d49815ed Merge #566
566: [0.5] tracking improvements r=kvark a=kvark

Sibling of #565
The code is mostly new tests :)

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-10 05:48:26 +00:00
Dzmitry Malyshau 1303d4907c Version bump to 0.5.1 wgpu-core-v0.5.1 2020-04-10 00:43:21 -04:00
Dzmitry Malyshau ee6ef901e5 Fix tracking of the initial state during replacement.
When multiple "replace" style transitions are happening,
we weren't properly retaining the "first" state, which
is required for proper stitching of command buffers.

This logic is fixed and fortified with a new set of
"change" and "merge" tests in the track module.
2020-04-10 00:40:49 -04:00
Dzmitry Malyshau 3e7682757d Refactor tracking of swapchain images as attachments
We were improperly detecting if a swapchain image has already
been used by a command buffer. In this case, we need to assume
that it's already in the PRESENT state.
2020-04-10 00:40:42 -04:00
bors[bot]andDzmitry Malyshau 77d95f5ecd Merge #556
556: Preparations for wgpu-0.5 release r=grovesNL a=kvark

Based on #555 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-06 12:57:11 +00:00
Dzmitry Malyshau 7dba052900 Version bump and CHANGELOG update wgpu-types-v0.5.0 wgpu-core-v0.5.0 2020-04-06 08:55:39 -04:00
Dzmitry Malyshau a3aefe2535 Rustfmt stable pass 2020-04-06 08:55:39 -04:00
bors[bot]andRukai 384606f2e2 Merge #555
555: Use crates.io release of peek-poke r=kvark a=kvark

Closes #549 

Co-authored-by: Rukai <rubickent@gmail.com>
2020-04-06 03:09:12 +00:00
Rukai 99161cbeb5 Use crates.io release of peek-poke 2020-04-05 23:06:02 -04:00
bors[bot]andDzmitry Malyshau d6d31695d3 Merge #553
553: Fix order of maintenace between submission tracking and buffer mapping. r=kvark a=kvark

Fixes https://github.com/gfx-rs/wgpu-rs/issues/237

Logic needs to have the following order:
  1. we first wait for the device to finish
  2. then we move some tracked resources from per-submission lists into the "ready to destroy" or "ready to map" lists.
  3. then we handle mapping, which goes through "ready to map" lists
  4. then we destroy everything for realz that needs to be

That order got broken with #547

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-05 21:54:16 +00:00
bors[bot]andKunal Mohan 8f9f13fc8c Merge #550
550: Add check for bound pipeline r=kvark a=kunalmohan

fix #456
Validate that a pipeline is bound before issuing any draw/dispatch call.

Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
2020-04-05 19:58:26 +00:00
Dzmitry Malyshau 00c98e7d5a Fix order of maintenace between submission tracking and buffer mapping. 2020-04-05 14:39:10 -04:00
Kunal Mohan aef0c7c2c4 Add check for bound pipeline
fix #456
Validate that a pipeline is bound before issuing
draw/dispatch call.
2020-04-05 11:16:50 +05:30
bors[bot]andDzmitry Malyshau 902a0ebca3 Merge #546
546: NonZero internal Id representation r=grovesNL a=kvark

Fixes  #544
Based on #545 
Blocked by https://github.com/eqrion/cbindgen/issues/500

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-04-04 23:43:53 +00:00
Dzmitry Malyshau f07943f2d8 Use NonZeroU64 for Id 2020-04-04 19:43:16 -04:00
bors[bot]andKunal Mohan 09beda1942 Merge #547
547: Add BufferMapState r=kvark a=kunalmohan

WIP for issue #395 

Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
2020-04-03 03:50:22 +00:00
Kunal Mohan fb1c448aa9 Add BufferMapState enum
fix #395
Add BufferMapState enum to track the state of buffer
mapping and store any mapping details in case one is
pending.
2020-04-03 07:55:23 +05:30
bors[bot]andDzmitry Malyshau 05ba7a50b4 Merge #545
545: Check surface compatibility r=grovesNL a=kvark

Addresses https://github.com/gfx-rs/wgpu-rs/issues/224
Follows the proposal of https://github.com/webgpu-native/webgpu-headers/pull/39

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-03-31 04:02:24 +00:00
Dzmitry Malyshau f3eee020e6 Check surface compatibility 2020-03-30 23:31:24 -04:00
bors[bot]andHeroesGrave 306554600a Merge #540
540: Add serialization to more types r=kvark a=HeroesGrave

With these changes, pretty much everything in wgpu-types can be serialized with the exception of BufferDescriptor, CommandEncoderDescriptor, and TextureDescriptor which contain a `*const c_char`.

Options for dealing with those:
- Leave these types as not de/serializable
- Skip when serializing, deserialize as nullptr
- Serialize as a string, deserialize as nullptr

AFAICT there's not really a way to allow a full roundtrip for these fields because nul-terminated strings don't play nicely with serde. Maybe it could serialize as a byte array?

Co-authored-by: HeroesGrave <heroesgrave@gmail.com>
2020-03-28 14:44:08 +00:00
HeroesGrave 1702a54c5c Add Undefined variant to CompareFunction 2020-03-28 16:20:47 +13:00
bors[bot]andJoshua Groves fcd8bce6f7 Merge #541
541: Move more types to wgpu-types r=kvark a=grovesNL



Co-authored-by: Joshua Groves <josh@joshgroves.com>
2020-03-28 02:14:06 +00:00
Joshua Groves f3bb6eb230 Move more types to wgpu-types 2020-03-27 23:26:17 -02:30
HeroesGrave 98e18c5ac8 Add serialization to more types 2020-03-28 13:49:09 +13:00
bors[bot]andDzmitry Malyshau 6d7eca94be Merge #539
539: Parking lot update to 0.10 r=kvark a=kvark

That allows us to remove some of the duplicated dependencies.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-03-27 14:43:21 +00:00
Dzmitry Malyshau 4b69b4257f Parking lot update to 0.10 2020-03-27 10:42:18 -04:00
bors[bot]andConnor Fitzgerald caf7be0d73 Merge #536
536: Update Support Platforms Table to Have a Key r=kvark a=cwfitzgerald

Closes #531 

I have added wording that I believe is accurate, but if there is better wording, feel free to propose it.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2020-03-27 13:43:26 +00:00
Connor Fitzgerald 43618e4101 Update Support Platforms table to have a key 2020-03-27 02:59:39 -04:00
bors[bot]andDzmitry Malyshau 2f00710832 Merge #537
537: Port to gfx-extras and gfx-hal-0.5 r=kvark a=kvark

blocked on publishing gfx-extras

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2020-03-27 04:54:40 +00:00
Dzmitry Malyshau 2e9610e8c9 Request NDC_Y_FLIP feature 2020-03-27 00:54:01 -04:00
Dzmitry Malyshau 8aeeb8e318 Port to gfx-extras and gfx-hal-0.5 2020-03-27 00:54:01 -04:00
bors[bot]andLachlan Sneff 8d8f68418b Merge #538
538: Unbox unnecessarily boxed function r=kvark a=lachlansneff

Internally, the async buffer mapping callbacks were unnecessarily boxed. This was pretty easy to fix.

Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
2020-03-27 03:07:34 +00:00
Lachlan Sneff bcd7744c5b Unbox unnecessarily boxed function 2020-03-26 22:38:50 -04:00