Commit Graph
496 Commits
Author SHA1 Message Date
sagudev bf063c0a4a [core] Make more stuff public for #5121
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-30 04:54:40 -04:00
Luo Zhihao 0ae95c7365 Fix flush_immediates out of range (#9906) 2026-07-20 19:38:08 +00:00
Andy Leiserson bfdd45b6b8 fix(core): Add missing indirect draw validation for render bundles (#9871) 2026-07-15 08:55:22 -07:00
Luo Zhihao 2b92ae160d Defer set_immediates to draw/dispatch call time (#9597) 2026-07-10 15:52:20 -07:00
Luo ZhihaoandJim Blandy 7fe459a58b Lower clippy large-error-threshold (#9612)
Co-authored-by: Jim Blandy <jimb@red-bean.com>
2026-07-07 13:42:21 -04:00
sagudev 49e9f14fd0 thin Global in RenderPass
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-07 10:38:22 +02:00
sagudev 91818a4368 Generalize BindGroupStateChange
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-07 10:38:22 +02:00
sagudev 2a8304eef3 [core] Move validity into Arc<BindGroup>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-06 15:06:57 +02:00
Sam 52a280d631 [core] Move validity into Arc<Buffer> (#9803)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-06 13:51:11 +02:00
Sam 18714da8da [core] Move validity into Arc<RenderBundle> (#9797)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-03 10:21:56 +02:00
Sam 99f8284e42 [core] Move validity into Arc<QuerySet> (#9795)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-02 17:05:08 +02:00
Sam b65c47ad60 [core] Move validity into Arc<TextureView> (#9787)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-02 09:13:30 +02:00
Sam 979ab2bca6 [core] IDed encoders needs to be dropped (#9782)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-01 14:02:32 +02:00
Sam 7877b766c8 [core] Move begin_*_pass to CommandEncoder and do only ID resolve in global (#9781)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-07-01 11:22:32 +02:00
Sam 5e139ccbeb [core] Add support IDed RenderPasses in Global (#9740)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-06-30 15:30:02 +02:00
Sam 5a5caa01ad [core] Move validity into Arc<RenderPipeline> (#9752)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-06-29 11:10:45 +02:00
Erich Gubler fc60449802 refactor: rename WorkgroupSizeCheck::sizes to dimensions 2026-06-25 11:55:58 -07:00
Erich Gubler 127a367497 refactor: reimpl. check_workgroup_sizes w/ new struct WorkgroupSizeCheck 2026-06-25 11:55:58 -07:00
Luo Zhihao c841633bb3 Bring transient attachment in line with webgpu spec (#9568) 2026-06-18 18:28:52 -07:00
Luo Zhihao 49102603b5 Add immediates to deno_webgpu (#9569) 2026-06-18 14:50:14 -07:00
Teoxoy ab33a724dc [wgpu-core] add query set initialization tracking
Vulkan, D3D12 and Metal require slots of query sets to
have been written prior to resolving them into a buffer.
2026-06-17 11:53:01 -07:00
Sam 019bce9139 Implement QuerySet::destroy (#9671)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-06-16 12:37:11 +02:00
Sam f308f06443 [core] Make ComputePassDescriptor and RenderPassDescriptor ser/de (#9666)
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
2026-06-15 15:08:13 +02:00
teoxoy 45f820a4ad disallow LoadOp::DontCare under STRICT_WEBGPU_COMPLIANCE 2026-06-03 23:36:32 +02:00
Teoxoy 31d22915be [indirect-draw-validation] don't attempt indirect draw validation for mesh shaders since it's not supported 2026-06-03 22:43:37 +02:00
Luo Zhihao 8b7e9edcdb Mask stencil clear value and reference value with 255 (#9607) 2026-06-02 17:09:58 +00:00
Luo ZhihaoandErich Gubler a7e0298dc5 Validate LoadOp and StoreOp are None for attachments without corresponding depth or stencil aspect (#9567)
Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
2026-05-29 11:28:50 -04:00
Andy Leiserson 61e76ee746 fix(core): Use more checked arithmetic, part 2b (#9425) 2026-04-16 14:27:01 +02:00
teoxoy c9c7359f5b deduplicate vertex buffer validation in is_ready 2026-04-14 17:20:15 -07:00
teoxoy a1b646243d converge on a single VertexState impl for both render passes and
render bundles

- render passes now defer setting vertex buffers to the start of a draw
  command (same as bundles)
- render bundles now cache vertex/instance limit calculations when
  setting the pipeline or when setting a vertex buffer (same as passes)
2026-04-14 17:20:15 -07:00
teoxoy 4bbed4074c add max_bind_groups_plus_vertex_buffers limit 2026-04-14 17:20:15 -07:00
teoxoy 2060683c29 make vertex buffer slots optional 2026-04-14 17:20:15 -07:00
atlv e6e5f5288c Bring immediate in line with webgpu spec (#9280) 2026-04-09 22:36:02 +00:00
Andy Leiserson acc5855e1f fix(core): Use more checked arithmetic, part 2 (#9363) 2026-04-09 15:21:20 -06:00
Inner DaemonsandAndreas Reich b5bd5aed7d Mesh shaders MSL writer (#8739)
* Single squashed commit

* Updated changelog

* Fixed stupid changelog thing

* If I have to do this one more fucking time I'm gonna lose it

* Removed some pub(super)'s

* Thing

---------

Co-authored-by: Andreas Reich <r_andreas2@web.de>
2026-04-07 17:26:22 +00:00
Elabajaba e8afd9a906 fix debug assertion not covering both parts of the debug statement (#9352) 2026-04-01 19:56:14 -06:00
Andy Leiserson 11db97cf1b fix(core): Use more checked arithmetic (#9357) 2026-04-01 15:23:21 -07:00
Kristoffer Søholm fd04edc0ac Fix bad debug_assert in dx12 indirect multi draw (#9332) 2026-03-31 13:46:25 -04:00
Andy Leiserson e14050d7db fix(core): Fix resource usage for R/O depth w/o TEXTURE_BINDING (#9346)
* fix(core): Fix resource usage for R/O depth w/o TEXTURE_BINDING

Fixes #9343

* Update test and waive failure

Related to #5231

* changelog
2026-03-31 17:02:11 +02:00
Andy Leiserson d152e7369b Reduce binary bloat from error vtables (#9149) 2026-03-04 08:52:24 -08:00
Andy Leiserson 3676e0e247 fix(core): Validate occlusion query set type in begin_render_pass (#9086) 2026-02-23 14:38:46 -08:00
Luo Zhihao c0f04c801c Validate strip_index_format equals index buffer format for indexed drawing with strip topology 2026-02-01 23:14:52 -08:00
Erich Gubler 9bc127f128 chore: update CORE_MSRV to 1.90 (#8943)
New cases for some Clippy lints pop up as part of this upgrade that
cannot be done before, listed below. Yuck!

- `clippy::manual_is_multiple_of`
- `clippy::missing_const_for_fn`
- `clippy::useless_nonzero_new_unchecked`
2026-01-27 19:37:10 -05:00
Andy Leiserson 1481b23e55 Clean up imports/exports in wgpu_core::command (#8836) 2026-01-09 12:23:34 -08:00
952d653835 New mesh shader limits (#8507)
* Initial commit

* Other initial changes

* Updated shader snapshots

* Added new HLSL limitation

* Moved error to global variable error

* Added docs to per_primitive

* Added a little bit more docs here and there in IR

* Adding validation to ensure that task shaders have a task payload

* Updated spec to reflect the change to payload variables

* Updated the mesh shading spec because it was goofy

* some doc tweaks

* Tried to clarify docs a little

* Tried to update spec

* Removed a warning

* Addressed comment about docs mistake

* Review in progress

- Extensive revisions to `docs/api-specs/mesh_shading.md`.

- Doc comments.

- Ensure `Module` stays at the bottom of `ir/mod.rs`.

- Avoid a clone.

- Rename some arguments to be more specific.

- Minor readability tweaks.

* mesh_shading.md: more tweaks

* Ran cargo fmt

* Small tweaks

* [naga] Move definition of `ShaderStage::compute_like` to `proc`.

Move the definition of `naga::ShaderStage::compute_like` from
`naga::ir` into `naga::proc`. We generally want ot keep methods out of
`naga::ir`, since the IR itself is complicated enough already.

* Replace TODO comment with followup issue.

* Update analyzer.rs

Co-authored-by: Jim Blandy <jimb@red-bean.com>

* Removed stuff in accordance with Jim's recommendation

* minor changes for readability

* Pull mesh shader output type validation out into its own function.

* doc fixes

* remove duplicated task payload validation

* Quick little changes

* Another quick fix

* Quick fix

* Removed unnecessary TODO statement

* A

* Tried to be more expressive

* Made functions only work in mesh shader entry points

* Various validation fix attempts

* Undid capabilities resize

* WGSL PR is up :)

* Update naga/src/ir/mod.rs

Co-authored-by: Erich Gubler <erichdongubler@gmail.com>

* Update naga/src/front/wgsl/error.rs

Co-authored-by: Erich Gubler <erichdongubler@gmail.com>

* Update naga/src/ir/mod.rs

Co-authored-by: Erich Gubler <erichdongubler@gmail.com>

* Other Erich suggestion

* Updated docs & validation for some builtins

* Added some docs & removed contentious "// TODO"

* Fixed bad validation, formatted mesh shader wgsl

* Rewrote the IR and parser significantly

* Improved validation slightly, remvoed obselete crap, fixed bug in compaction, made clippy happy

* Added changelog entry

* Made parser respect enable extension

* Updated mesh shader spec

* Cleaned up the mesh shader analyzer function

* Updated changelog

* Updated validation from spv-write

* Slight tweaks

* Added capabilitiy thing blah blah blah

* Fixed compaction & clean stuff up

* Fixed compaction and such pt 2

* Paved the way for primitive-index stuff

* Little bit of cleanup

* Added new features/capabilities for point primitives and added snapshots for stuff

* Updated spec to rename something

* Updated some limits stuff

* Made some improvements

* Fixed doctests & webgpu stuff

* Fixed experimental features stuff

* A little more scaffolding

* Added some initial validation

* Added per primitive validation

* Improved per primitive validation

* Added some more validation

* Fixed primitive index validation

* Updated the spec

* Updated comments on some limits

* Made some fixes

* Fixed new validation rule for task payload size

* Update wgpu-core/src/validation.rs

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

* Update wgpu-core/src/validation.rs

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

* A small tweak to mesh shader recommended minimums

* Addressed 2 comments

* A few more comments addressed with limits

* Addressed more comments

* Update wgpu-core/src/validation.rs

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>

* Split up error

* Addressed another comment by changing workgroup size validation

* Final comment addressed

* Update wgpu-info/src/human.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update wgpu-core/src/validation.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update wgpu-info/src/human.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fixed compilation and added some new test functions

---------

Co-authored-by: SupaMaggie70Incorporated <85136135+SupaMaggie70Incorporated@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Co-authored-by: Erich Gubler <erichdongubler@gmail.com>
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-12-17 05:13:27 +00:00
Connor Fitzgerald e52e8336b0 Bring immediate api in line with spec (#8724) 2025-12-16 13:13:09 +01:00
Andy Leiserson 422d539731 Add missing maxColorAttachmentBytesPerSample validation for render passes (#8697) 2025-12-09 13:32:57 -08:00
Teodor Tanasoaia d41e43bc60 [wgpu-core] validate occlusion and pipeline statistics queries end (#8684) 2025-12-08 18:42:26 +01:00
Connor Fitzgerald e3149bac9e LoadOp::DontCare (#8549) 2025-12-08 03:41:38 +00:00
Connor Fitzgerald a356cb2026 Update Repo MSRV to 1.91 (#8678) 2025-12-07 21:52:35 -05:00