[core] Make more stuff public for #5121

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
sagudev authored and Erich Gubler committed 2026-07-30 04:54:40 -04:00
1 parent fb1c777b2f
commit bf063c0a4a
3 files changed
+14 -10

No files matched your search

+2 -2
View File
@@ -466,7 +466,7 @@ fn transition_resources(
}
impl CommandEncoder {
fn begin_compute_pass(
pub fn begin_compute_pass(
self: &Arc<Self>,
desc: &ComputePassDescriptor<'_, PassTimestampWrites<Arc<QuerySet>>>,
) -> (ComputePass, Option<CommandEncoderError>) {
@@ -557,7 +557,7 @@ impl CommandEncoder {
// Running the compute pass.
impl ComputePass {
fn end(&mut self) -> Result<(), EncoderStateError> {
pub fn end(&mut self) -> Result<(), EncoderStateError> {
profiling::scope!(
"CommandEncoder::run_compute_pass {}",
self.base.label.as_deref().unwrap_or("")
+1 -1
View File
@@ -61,7 +61,7 @@ pub use self::{
ColorAttachmentError, ColorAttachments, LoadOp, PassChannel, RenderBasePass, RenderPass,
RenderPassColorAttachment, RenderPassDepthStencilAttachment, RenderPassDescriptor,
RenderPassError, RenderPassErrorInner, ResolvedPassChannel,
ResolvedRenderPassDepthStencilAttachment, StoreOp,
ResolvedRenderPassDepthStencilAttachment, ResolvedRenderPassDescriptor, StoreOp,
},
render_command::ArcRenderCommand,
transfer::{CopySide, TransferError},
+11 -7
View File
@@ -1826,8 +1826,8 @@ fn check_transient_attachment_ops<V>(load_op: LoadOp<V>, store_op: StoreOp) -> b
}
impl CommandEncoder {
fn begin_render_pass(
self: Arc<Self>,
pub fn begin_render_pass(
self: &Arc<Self>,
desc: ResolvedRenderPassDescriptor<'_>,
) -> (RenderPass, Option<CommandEncoderError>) {
use EncoderStateError as SErr;
@@ -2095,9 +2095,9 @@ impl CommandEncoder {
multiview_mask: None,
};
match fill_arc_desc(desc, &mut arc_desc, &self.device) {
Ok(()) => (RenderPass::new(self, arc_desc), None),
Ok(()) => (RenderPass::new(self.clone(), arc_desc), None),
Err(err) => (
RenderPass::new_invalid(self, &label, err.map_pass_err(scope)),
RenderPass::new_invalid(self.clone(), &label, err.map_pass_err(scope)),
None,
),
}
@@ -2109,7 +2109,7 @@ impl CommandEncoder {
cmd_buf_data.invalidate(err.clone());
drop(cmd_buf_data);
(
RenderPass::new_invalid(self, &desc.label, err.map_pass_err(scope)),
RenderPass::new_invalid(self.clone(), &desc.label, err.map_pass_err(scope)),
None,
)
}
@@ -2118,7 +2118,11 @@ impl CommandEncoder {
// generates an immediate validation error.
drop(cmd_buf_data);
(
RenderPass::new_invalid(self, &desc.label, err.clone().map_pass_err(scope)),
RenderPass::new_invalid(
self.clone(),
&desc.label,
err.clone().map_pass_err(scope),
),
Some(err.into()),
)
}
@@ -2130,7 +2134,7 @@ impl CommandEncoder {
// invalid pass to save that work.
drop(cmd_buf_data);
(
RenderPass::new_invalid(self, &desc.label, err.map_pass_err(scope)),
RenderPass::new_invalid(self.clone(), &desc.label, err.map_pass_err(scope)),
None,
)
}